Completed
Pull Request — developer (#8612)
by Sławomir
96:08 queued 81:00
created
modules/Settings/Workflows/models/RecordStructure.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 	/**
51 51
 	 * Get instance for workflow module.
52 52
 	 *
53
-	 * @param object $workFlowModel
53
+	 * @param Settings_Workflows_Record_Model $workFlowModel
54 54
 	 * @param string $mode
55 55
 	 *
56 56
 	 * @return object
Please login to merge, or discard this patch.
modules/Settings/Workflows/models/TaskRecord.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	/**
140 140
 	 * Set workflow from instance.
141 141
 	 *
142
-	 * @param object $workflowModel
142
+	 * @param Workflow $workflowModel
143 143
 	 *
144 144
 	 * @return $this
145 145
 	 */
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 	 * @param int      $taskId
197 197
 	 * @param Workflow $workflowModel
198 198
 	 *
199
-	 * @return VTTask
199
+	 * @return Settings_Workflows_TaskRecord_Model
200 200
 	 */
201 201
 	public static function getInstance($taskId, $workflowModel = null)
202 202
 	{
@@ -212,10 +212,10 @@  discard block
 block discarded – undo
212 212
 	/**
213 213
 	 * Return clean instance.
214 214
 	 *
215
-	 * @param object $workflowModel
215
+	 * @param Settings_Workflows_Record_Model $workflowModel
216 216
 	 * @param string $taskName
217 217
 	 *
218
-	 * @return VTTask
218
+	 * @return Settings_Workflows_TaskRecord_Model
219 219
 	 */
220 220
 	public static function getCleanInstance($workflowModel, $taskName)
221 221
 	{
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	 * @param Workflow      $workflowModel
231 231
 	 * @param VTTaskManager $tm
232 232
 	 *
233
-	 * @return VTTask
233
+	 * @return Settings_Workflows_TaskRecord_Model
234 234
 	 */
235 235
 	public static function getInstanceFromTaskObject($task, $workflowModel, $tm)
236 236
 	{
Please login to merge, or discard this patch.
modules/Settings/Workflows/models/TaskType.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	/**
85 85
 	 * Get all tasks for module.
86 86
 	 *
87
-	 * @param object $moduleModel
87
+	 * @param vtlib\ModuleBasic $moduleModel
88 88
 	 *
89 89
 	 * @return array
90 90
 	 */
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 	 *
105 105
 	 * @param string $taskType
106 106
 	 *
107
-	 * @return object
107
+	 * @return Settings_Workflows_TaskType_Model
108 108
 	 */
109 109
 	public static function getInstance($taskType)
110 110
 	{
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
116 116
 	/**
117 117
 	 * Get instance from task type object.
118 118
 	 *
119
-	 * @param object $taskTypeObject
119
+	 * @param VTTaskType $taskTypeObject
120 120
 	 *
121
-	 * @return \self
121
+	 * @return Settings_Workflows_TaskType_Model
122 122
 	 */
123 123
 	public static function getInstanceFromTaskTypeObject($taskTypeObject)
124 124
 	{
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	/**
129 129
 	 * Get task base module object.
130 130
 	 *
131
-	 * @return object
131
+	 * @return Vtiger_Module_Model|null
132 132
 	 */
133 133
 	public function getTaskBaseModule()
134 134
 	{
Please login to merge, or discard this patch.
modules/SMSNotifier/providers/Basic.php 1 patch
Doc Comments   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * @param string $key
67 67
 	 * @param mixed  $value
68 68
 	 *
69
-	 * @return \self
69
+	 * @return SMSNotifier_Basic_Provider
70 70
 	 */
71 71
 	public function set($key, $value)
72 72
 	{
@@ -142,8 +142,6 @@  discard block
 block discarded – undo
142 142
 	/**
143 143
 	 * Function to handle SMS Send operation.
144 144
 	 *
145
-	 * @param string          $message
146
-	 * @param string|string[] $toNumbers
147 145
 	 */
148 146
 	public function send()
149 147
 	{
Please login to merge, or discard this patch.
modules/SSalesProcesses/dashboards/ActualSalesOfTeam.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,9 +15,8 @@
 block discarded – undo
15 15
 	/**
16 16
 	 * Function to get search params in address listview.
17 17
 	 *
18
-	 * @param int    $owner  number id of user
19
-	 * @param string $status
20 18
 	 *
19
+	 * @param string $time
21 20
 	 * @return string
22 21
 	 */
23 22
 	public function getSearchParams($row, $time)
Please login to merge, or discard this patch.
modules/SSalesProcesses/SSalesProcesses.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -195,6 +195,7 @@
 block discarded – undo
195 195
 	 * @param int   $id                    - ssalesprocessesid
196 196
 	 * @param array $parentSSalesProcesses - Array of all the parent sales
197 197
 	 *                                     returns All the parent Sales of the given ssalesprocessesid in array format
198
+	 * @param integer[] $encounteredSalesProcesses
198 199
 	 */
199 200
 	public function getParentSales($id, &$parentSSalesProcesses, &$encounteredSalesProcesses, $depthBase = 0)
200 201
 	{
Please login to merge, or discard this patch.
modules/Users/models/Module.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * Check mail exist.
135 135
 	 *
136 136
 	 * @param string    $email
137
-	 * @param int|false $userId
137
+	 * @param integer $userId
138 138
 	 *
139 139
 	 * @return bool
140 140
 	 */
@@ -152,9 +152,9 @@  discard block
 block discarded – undo
152 152
 	 * Validation of user name.
153 153
 	 *
154 154
 	 * @param string    $userName
155
-	 * @param int|false $userId
155
+	 * @param integer $userId
156 156
 	 *
157
-	 * @return bool
157
+	 * @return string|false
158 158
 	 */
159 159
 	public static function checkUserName($userName, $userId = false)
160 160
 	{
Please login to merge, or discard this patch.
modules/Users/models/Privileges.php 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -106,7 +106,6 @@  discard block
 block discarded – undo
106 106
 	/**
107 107
 	 * Function to check whether the user has access to the specified action/operation on a given module by tabid.
108 108
 	 *
109
-	 * @param <Number>        $tabId
110 109
 	 * @param <String/Number> $action
111 110
 	 *
112 111
 	 * @return bool true/false
@@ -128,7 +127,7 @@  discard block
 block discarded – undo
128 127
 	 *
129 128
 	 * @param <Array> $valueMap
130 129
 	 *
131
-	 * @return Users_Privilege_Model object
130
+	 * @return Users_Privileges_Model object
132 131
 	 */
133 132
 	public static function getInstance($valueMap)
134 133
 	{
@@ -181,6 +180,9 @@  discard block
 block discarded – undo
181 180
 
182 181
 	protected static $lockEditCache = [];
183 182
 
183
+	/**
184
+	 * @param string $moduleName
185
+	 */
184 186
 	public static function checkLockEdit($moduleName, Vtiger_Record_Model $recordModel)
185 187
 	{
186 188
 		$recordId = $recordModel->getId();
@@ -220,7 +222,7 @@  discard block
 block discarded – undo
220 222
 	/**
221 223
 	 * Clear user cache.
222 224
 	 *
223
-	 * @param int|bool $userId
225
+	 * @param integer $userId
224 226
 	 */
225 227
 	public static function clearCache($userId = false)
226 228
 	{
@@ -270,6 +272,8 @@  discard block
 block discarded – undo
270 272
 
271 273
 	/**
272 274
 	 * Function to get set Shared Owner Recursively.
275
+	 * @param integer $recordId
276
+	 * @param string $moduleName
273 277
 	 */
274 278
 	public static function getSharedRecordsRecursively($recordId, $moduleName)
275 279
 	{
Please login to merge, or discard this patch.
modules/Users/models/Record.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -834,6 +834,10 @@  discard block
 block discarded – undo
834 834
 	 * to whom records should be assigned
835 835
 	 */
836 836
 
837
+	/**
838
+	 * @param integer $userId
839
+	 * @param integer $newOwnerId
840
+	 */
837 841
 	public static function deleteUserPermanently($userId, $newOwnerId)
838 842
 	{
839 843
 		$db = App\Db::getInstance();
@@ -1025,7 +1029,7 @@  discard block
 block discarded – undo
1025 1029
 	/**
1026 1030
 	 * Get authorization detail.
1027 1031
 	 *
1028
-	 * @return array
1032
+	 * @return string
1029 1033
 	 */
1030 1034
 	protected function getAuthDetail()
1031 1035
 	{
Please login to merge, or discard this patch.