YetiForceCompany /
YetiForceCRM
| Conditions | 35 |
| Paths | 273 |
| Total Lines | 91 |
| Code Lines | 71 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 1260 |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function doTask($recordModel) |
||
| 28 | { |
||
| 29 | $moduleName = $recordModel->getModuleName(); |
||
| 30 | $recordId = $recordModel->getId(); |
||
| 31 | $entityType = $this->entity_type; |
||
|
Bug
Best Practice
introduced
by
|
|||
| 32 | if (!\App\Module::isModuleActive($entityType)) { |
||
| 33 | return; |
||
| 34 | } |
||
| 35 | $fieldValueMapping = []; |
||
| 36 | if (!empty($this->field_value_mapping)) { |
||
| 37 | $fieldValueMapping = \App\Json::decode($this->field_value_mapping); |
||
| 38 | } |
||
| 39 | if (!$this->mappingPanel && !empty($entityType) && !empty($fieldValueMapping) && \count($fieldValueMapping) > 0) { |
||
| 40 | $newRecordModel = Vtiger_Record_Model::getCleanInstance($entityType); |
||
| 41 | $ownerFields = array_keys($newRecordModel->getModule()->getFieldsByType('owner')); |
||
| 42 | foreach ($fieldValueMapping as $fieldInfo) { |
||
| 43 | $fieldName = $fieldInfo['fieldname']; |
||
| 44 | $destinyModuleName = $this->getDestinyModuleName($fieldInfo['modulename']); |
||
| 45 | $sourceModuleName = $destinyModuleName ?? $fieldInfo['modulename']; |
||
| 46 | $fieldValueType = $fieldInfo['valuetype']; |
||
| 47 | $fieldValue = trim($fieldInfo['value']); |
||
| 48 | if ('fieldname' === $fieldValueType) { |
||
| 49 | if ($this->relationId) { |
||
| 50 | $fieldValue = $destinyModuleName ? $newRecordModel->get($fieldValue) : $recordModel->get($fieldValue); |
||
| 51 | } else { |
||
| 52 | $fieldValue = $sourceModuleName === $entityType ? $newRecordModel->get($fieldValue) : $fieldValue = $recordModel->get($fieldValue); |
||
| 53 | } |
||
| 54 | } elseif ('expression' === $fieldValueType) { |
||
| 55 | require_once 'modules/com_vtiger_workflow/expression_engine/include.php'; |
||
| 56 | |||
| 57 | $parser = new VTExpressionParser(new VTExpressionSpaceFilter(new VTExpressionTokenizer($fieldValue))); |
||
| 58 | $expression = $parser->expression(); |
||
| 59 | $exprEvaluater = new VTFieldExpressionEvaluater($expression); |
||
| 60 | if ($sourceModuleName === $entityType) { |
||
| 61 | $fieldValue = $exprEvaluater->evaluate($newRecordModel); |
||
| 62 | } else { |
||
| 63 | $fieldValue = $exprEvaluater->evaluate($recordModel); |
||
| 64 | } |
||
| 65 | } elseif (preg_match('/([^:]+):boolean$/', $fieldValue, $match)) { |
||
| 66 | $fieldValue = $match[1]; |
||
| 67 | if ('true' == $fieldValue) { |
||
| 68 | $fieldValue = '1'; |
||
| 69 | } else { |
||
| 70 | $fieldValue = '0'; |
||
| 71 | } |
||
| 72 | } elseif (!\in_array($fieldName, $ownerFields)) { |
||
| 73 | $fieldValue = $newRecordModel->getField($fieldName)->getUITypeModel()->getDBValue($fieldValue); |
||
| 74 | } |
||
| 75 | if (\in_array($fieldName, $ownerFields)) { |
||
| 76 | if ('triggerUser' === $fieldValue) { |
||
| 77 | $fieldValue = $recordModel->executeUser; |
||
| 78 | } elseif (!is_numeric($fieldValue)) { |
||
| 79 | $userId = App\User::getUserIdByName($fieldValue); |
||
| 80 | $groupId = \App\Fields\Owner::getGroupId($fieldValue); |
||
| 81 | if (!$userId && !$groupId) { |
||
| 82 | $fieldValue = $recordModel->get($fieldName); |
||
| 83 | } else { |
||
| 84 | $fieldValue = (!$userId) ? $groupId : $userId; |
||
| 85 | } |
||
| 86 | } |
||
| 87 | } |
||
| 88 | $newRecordModel->set($fieldName, $fieldValue); |
||
| 89 | } |
||
| 90 | $newRecordModel->set($this->reference_field, $recordId); |
||
| 91 | // To handle cyclic process |
||
| 92 | $newRecordModel->setHandlerExceptions(['disableHandlerClasses' => ['Vtiger_Workflow_Handler']]); |
||
| 93 | $newRecordModel->save(); |
||
| 94 | |||
| 95 | $relationModel = \Vtiger_Relation_Model::getInstance($recordModel->getModule(), $newRecordModel->getModule(), $this->relationId); |
||
| 96 | if ($relationModel) { |
||
| 97 | $relationModel->addRelation($recordModel->getId(), $newRecordModel->getId()); |
||
| 98 | } |
||
| 99 | } elseif ($this->mappingPanel && $entityType) { |
||
| 100 | if (!empty($this->verifyIfExists) && ($relationListView = Vtiger_RelationListView_Model::getInstance($recordModel, $entityType, false)) && (int) $relationListView->getRelatedEntriesCount() > 0) { |
||
| 101 | return true; |
||
| 102 | } |
||
| 103 | $saveContinue = true; |
||
| 104 | $newRecordModel = Vtiger_Record_Model::getCleanInstance($entityType); |
||
| 105 | $parentRecordModel = Vtiger_Record_Model::getInstanceById($recordId, $moduleName); |
||
| 106 | $newRecordModel->setRecordFieldValues($parentRecordModel); |
||
| 107 | $mandatoryFields = $newRecordModel->getModule()->getMandatoryFieldModels(); |
||
| 108 | if (!empty($fieldValueMapping) && \is_array($fieldValueMapping)) { |
||
| 109 | $newRecordModel = $this->setFieldMapping($fieldValueMapping, $newRecordModel, $parentRecordModel); |
||
| 110 | } |
||
| 111 | foreach ($mandatoryFields as $field) { |
||
| 112 | if ('' === $newRecordModel->get($field->getName()) || null === $newRecordModel->get($field->getName())) { |
||
| 113 | $saveContinue = false; |
||
| 114 | } |
||
| 115 | } |
||
| 116 | if ($saveContinue) { |
||
| 117 | $newRecordModel->save(); |
||
| 118 | } |
||
| 194 |
Loading history...
