YetiForceCompany /
YetiForceCRM
| Conditions | 18 |
| Paths | 273 |
| Total Lines | 100 |
| Code Lines | 75 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 342 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function getWidgetTimeControl($user, $time) |
||
| 28 | { |
||
| 29 | if (!$time) { |
||
| 30 | return ['show_chart' => false]; |
||
| 31 | } |
||
| 32 | $currentUser = Users_Record_Model::getCurrentUserModel(); |
||
| 33 | if ('all' == $user) { |
||
| 34 | $user = array_keys(\App\Fields\Owner::getInstance(false, $currentUser)->getAccessibleUsers()); |
||
|
Bug
introduced
by
|
|||
| 35 | } |
||
| 36 | if (!\is_array($user)) { |
||
| 37 | $user = [$user]; |
||
| 38 | } |
||
| 39 | $colors = \App\Fields\Picklist::getColors('timecontrol_type'); |
||
| 40 | $moduleName = 'OSSTimeControl'; |
||
| 41 | $query = (new App\Db\Query())->select(['sum_time', 'due_date', 'vtiger_osstimecontrol.timecontrol_type', 'vtiger_crmentity.smownerid', 'timecontrol_typeid']) |
||
| 42 | ->from('vtiger_osstimecontrol') |
||
| 43 | ->innerJoin('vtiger_crmentity', 'vtiger_osstimecontrol.osstimecontrolid = vtiger_crmentity.crmid') |
||
| 44 | ->innerJoin('vtiger_timecontrol_type', 'vtiger_osstimecontrol.timecontrol_type = vtiger_timecontrol_type.timecontrol_type') |
||
| 45 | ->where(['vtiger_crmentity.setype' => $moduleName, 'vtiger_crmentity.smownerid' => $user]); |
||
| 46 | \App\PrivilegeQuery::getConditions($query, $moduleName); |
||
| 47 | $query->andWhere([ |
||
| 48 | 'and', |
||
| 49 | ['>=', 'vtiger_osstimecontrol.due_date', $time[0]], |
||
| 50 | ['<=', 'vtiger_osstimecontrol.due_date', $time[1]], |
||
| 51 | ['vtiger_osstimecontrol.deleted' => 0], |
||
| 52 | ]); |
||
| 53 | $timeTypes = []; |
||
| 54 | $smOwners = []; |
||
| 55 | $dataReader = $query->createCommand()->query(); |
||
| 56 | $chartData = [ |
||
| 57 | 'labels' => [], |
||
| 58 | 'fullLabels' => [], |
||
| 59 | 'datasets' => [], |
||
| 60 | 'show_chart' => false, |
||
| 61 | ]; |
||
| 62 | $time = \App\Fields\Date::formatRangeToDisplay($time); |
||
| 63 | $workingTimeByType = $workingTime = []; |
||
| 64 | while ($row = $dataReader->read()) { |
||
| 65 | $label = \App\Language::translate($row['timecontrol_type'], 'OSSTimeControl'); |
||
| 66 | if (isset($workingTimeByType[$label])) { |
||
| 67 | $workingTimeByType[$label] += (float) $row['sum_time']; |
||
| 68 | } else { |
||
| 69 | $workingTimeByType[$label] = (float) $row['sum_time']; |
||
| 70 | } |
||
| 71 | if (isset($workingTime[$row['smownerid']][$row['timecontrol_type']])) { |
||
| 72 | $workingTime[$row['smownerid']][$row['timecontrol_type']] += (float) $row['sum_time']; |
||
| 73 | } else { |
||
| 74 | $workingTime[$row['smownerid']][$row['timecontrol_type']] = (float) $row['sum_time']; |
||
| 75 | } |
||
| 76 | if (!\in_array($row['timecontrol_type'], $timeTypes)) { |
||
| 77 | $timeTypes[$row['timecontrol_typeid']] = $row['timecontrol_type']; |
||
| 78 | // one dataset per type |
||
| 79 | $chartData['datasets'][] = [ |
||
| 80 | 'label' => $label, |
||
| 81 | 'original_label' => $label, |
||
| 82 | '_type' => $row['timecontrol_type'], |
||
| 83 | 'data' => [], |
||
| 84 | 'dataFormatted' => [], |
||
| 85 | 'backgroundColor' => [], |
||
| 86 | 'links' => [], |
||
| 87 | ]; |
||
| 88 | } |
||
| 89 | if (!\in_array($row['smownerid'], $smOwners)) { |
||
| 90 | $smOwners[] = $row['smownerid']; |
||
| 91 | $ownerName = \App\Fields\Owner::getUserLabel($row['smownerid']); |
||
| 92 | $chartData['labels'][] = \App\Utils::getInitials($ownerName); |
||
| 93 | $chartData['fullLabels'][] = $ownerName; |
||
| 94 | } |
||
| 95 | } |
||
| 96 | foreach ($chartData['datasets'] as &$dataset) { |
||
| 97 | $dataset['label'] .= ': ' . \App\Fields\RangeTime::displayElapseTime($workingTimeByType[$dataset['label']]); |
||
| 98 | } |
||
| 99 | if ($dataReader->count() > 0) { |
||
| 100 | $chartData['show_chart'] = true; |
||
| 101 | foreach ($workingTime as $ownerId => $timeValue) { |
||
| 102 | foreach ($timeTypes as $timeTypeId => $timeType) { |
||
| 103 | // if owner has this kind of type |
||
| 104 | if (!empty($timeValue[$timeType])) { |
||
| 105 | $userTime = $timeValue[$timeType]; |
||
| 106 | } else { |
||
| 107 | $userTime = 0; |
||
| 108 | } |
||
| 109 | foreach ($chartData['datasets'] as &$dataset) { |
||
| 110 | if ($dataset['_type'] === $timeType) { |
||
| 111 | // each data item is an different owner time in this dataset/time type |
||
| 112 | $dataset['data'][] = round($userTime / 60, 2); |
||
| 113 | $dataset['backgroundColor'][] = $colors[$timeTypeId]; |
||
| 114 | $dataset['dataFormatted'][] = \App\Fields\RangeTime::displayElapseTime($userTime); |
||
| 115 | } |
||
| 116 | } |
||
| 117 | } |
||
| 118 | } |
||
| 119 | foreach ($smOwners as $ownerId) { |
||
| 120 | foreach ($chartData['datasets'] as &$dataset) { |
||
| 121 | $dataset['links'][] = 'index.php?module=OSSTimeControl&view=List&viewname=All&entityState=Active' . $this->getSearchParams($ownerId, $time); |
||
| 122 | } |
||
| 123 | } |
||
| 124 | } |
||
| 125 | $dataReader->close(); |
||
| 126 | return $chartData; |
||
| 127 | } |
||
| 159 |
Loading history...