OSSMailView_Graf_Dashboard::process()

Complexity

Conditions	17
Paths	217

Size

Total Lines	104
Code Lines	89

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	306

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function process(App\Request $request)
	{
		$userId = \App\User::getCurrentUserId();
		$viewer = $this->getViewer($request);
		$moduleName = $request->getModule();
		$linkId = $request->getInteger('linkid');
		$owner = $request->getByType('owner', 'Alnum');
		$dates = $request->getByType('dateFilter', 'Text');
		$userList = \App\Fields\Owner::getInstance($moduleName, $userId)->getAccessibleUsersForModule();
		$groupList = \App\Fields\Owner::getInstance($moduleName, $userId)->getAccessibleGroupForModule();
		if (!$owner) {
			$owner = $userId;
		} elseif (is_numeric($owner) && !isset($userList[$owner]) && !isset($groupList[$owner])) {
			throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);
		}

		$today = date('Y-m-d');
		if ('Yesterday' === $dates) {
			$data = strtotime('-1 day', strtotime($today));
			$dateFilter['start'] = date('Y-m-d', $data);

$dateFilter was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dateFilter = array(); before regardless.

			$dateFilter['end'] = date('Y-m-d', $data);
		} elseif ('Current week' === $dates) {
			if ('Mon' == date('D')) {
				$dateFilter['start'] = date('Y-m-d');
			} else {
				$data = strtotime('last Monday', strtotime($today));
				$dateFilter['start'] = date('Y-m-d', $data);
			}
			$dateFilter['end'] = date('Y-m-d');
		} elseif ('Previous week' === $dates) {
			$data = strtotime('last Monday', strtotime($today));
			if ('Mon' != date('D')) {
				$data = strtotime('last Monday', strtotime(date('Y-m-d', $data)));
			}
			$dateFilter['start'] = date('Y-m-d', $data);
			$data = strtotime('last Sunday', strtotime($today));
			$dateFilter['end'] = date('Y-m-d', $data);
		} elseif ('Current month' === $dates) {
			$dateFilter['start'] = date('Y-m-d', mktime(0, 0, 0, date('m'), 1, date('Y')));

date('Y') of type string is incompatible with the type integer expected by parameter $year of mktime().

date('m') of type string is incompatible with the type integer expected by parameter $month of mktime().

			$dateFilter['end'] = $today;
		} elseif ('Previous month' === $dates) {
			$dateFilter['start'] = date('Y-m-d', mktime(0, 0, 0, date('m') - 1, 1, date('Y')));
			$dateFilter['end'] = date('Y-m-d', mktime(23, 59, 59, date('m'), 0, date('Y')));
		} elseif ('All' === $dates) {
			$dateFilter = '';
		} else {
			$dateFilter['start'] = $today;
			$dateFilter['end'] = $today;
		}
		$dateFilter['start'] .= ' 00:00:00';
		$dateFilter['end'] .= ' 23:59:59';

		$dataSets = [[
			'data' => [],
			'backgroundColor' => [],
			'borderColor' => [],
			'tooltips' => [],
			'names' => [],
			'links' => []
		]];
		$data = [
			'labels' => [],
			'datasets' => &$dataSets,
			'show_chart' => false,
		];

		$fieldName = 'ossmailview_sendtype';
		$colors = \App\Fields\Picklist::getValues($fieldName);
		$colors = array_column($colors, 'color', $fieldName);
		$listViewUrl = Vtiger_Module_Model::getInstance($moduleName)->getListViewUrl();

		$queryGenerator = (new \App\QueryGenerator($moduleName))
			->setFields([$fieldName])
			->setCustomColumn(['count' => new \yii\db\Expression('COUNT(*)')])
			->setGroup($fieldName)
			->addCondition($fieldName, '', 'ny')
			->addCondition('createdtime', $dateFilter['start'] . ',' . $dateFilter['end'], 'bw');
		if ('all' !== $owner) {
			$queryGenerator->addCondition('assigned_user_id', $owner, 'e');
		}
		$i = 0;
		$dataReader = $queryGenerator->createQuery()->createCommand()->query();
		while ($row = $dataReader->read()) {
			$color = !empty($colors[$row[$fieldName]]) ? '#' . $colors[$row[$fieldName]] : \App\Colors::getRandomColor($i);
			$data['labels'][$i] = \App\Language::translate($row[$fieldName], $moduleName);
			$dataSets[0]['data'][$i] = $row['count'];
			$dataSets[0]['names'][$i] = $row[$fieldName];
			$dataSets[0]['backgroundColor'][$i] = $color;
			$dataSets[0]['borderColor'][$i] = $color;
			$dataSets[0]['links'][$i] = $listViewUrl . $this->getSearchParams($row[$fieldName], $owner, $dateFilter);

Are you sure the usage of $this->getSearchParams($row[$fieldName], $owner, $dateFilter) targeting OSSMailView_Graf_Dashboard::getSearchParams() seems to always return null.

Are you sure $this->getSearchParams($row[$fieldName], $owner, $dateFilter) of type void can be used in concatenation?

			$data['show_chart'] = true;
			++$i;
		}
		$dataReader->close();

		$viewer->assign('MODULE_NAME', $moduleName);
		$viewer->assign('WIDGET', Vtiger_Widget_Model::getInstance($linkId, $userId));
		$viewer->assign('ACCESSIBLE_USERS', $userList);
		$viewer->assign('ACCESSIBLE_GROUPS', $groupList);
		$viewer->assign('DATA', $data);
		if ($request->has('content')) {
			$viewer->view('dashboards/DashBoardWidgetContents.tpl', $moduleName);
		} else {
			$viewer->view('dashboards/Graf.tpl', $moduleName);
		}