YetiForceCompany /
YetiForceCRM
| Total Complexity | 44 |
| Total Lines | 178 |
| Duplicated Lines | 0 % |
| Coverage | 67.68% |
| Changes | 0 | ||
Complex classes like Settings_CurrencyUpdate_NBP_BankModel often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Settings_CurrencyUpdate_NBP_BankModel, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 11 | class Settings_CurrencyUpdate_NBP_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model |
||
| 12 | { |
||
| 13 | // Returns bank name |
||
| 14 | |||
| 15 | 1 | public function getName() |
|
| 18 | } |
||
| 19 | |||
| 20 | // Returns url sources from where exchange rates are taken from |
||
| 21 | |||
| 22 | 1 | public function getSource() |
|
| 23 | { |
||
| 24 | 1 | return ['http://nbp.pl/kursy/xml/LastA.xml']; |
|
| 25 | } |
||
| 26 | |||
| 27 | // Returns list of currencies supported by this bank |
||
| 28 | |||
| 29 | 2 | public function getSupportedCurrencies() |
|
| 30 | { |
||
| 31 | 2 | $supportedCurrencies = []; |
|
| 32 | 2 | $supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode(); |
|
| 33 | 2 | $dateCur = date('Y-m-d', strtotime('last monday')); |
|
| 34 | 2 | $tableUrl = 'http://api.nbp.pl/api/exchangerates/tables/a/'; |
|
| 35 | |||
| 36 | 2 | $numberOfDays = 1; |
|
| 37 | 2 | $iterationsLimit = 60; |
|
| 38 | 2 | $stateA = false; |
|
| 39 | 2 | while (!$stateA) { |
|
| 40 | 2 | $url = $tableUrl . $dateCur . '/?format=json'; |
|
| 41 | try { |
||
| 42 | 2 | \App\Log::beginProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate'); |
|
| 43 | 2 | $tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]); |
|
| 44 | 2 | \App\Log::endProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate'); |
|
| 45 | 2 | if (200 == $tryTable->getStatusCode()) { |
|
| 46 | $stateA = true; |
||
| 47 | $tableBody = $tryTable->getBody(); |
||
| 48 | } |
||
| 49 | } catch (\Throwable $ex) { |
||
| 50 | \App\Log::info('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate'); |
||
| 51 | 2 | } |
|
| 52 | if (!$stateA) { |
||
| 53 | $newDate = strtotime("-$numberOfDays day", strtotime($dateCur)); |
||
| 54 | $dateCur = date('Y-m-d', $newDate); |
||
| 55 | ++$numberOfDays; |
||
| 56 | if ($numberOfDays > $iterationsLimit) { |
||
| 57 | throw new \App\Exceptions\IntegrationException('ERR_ITERATIONS_LIMIT_EXCEEDED'); |
||
| 58 | } |
||
| 59 | } |
||
| 60 | 2 | } |
|
| 61 | 2 | if ($stateA && $tableBody) { |
|
|
Comprehensibility
Best Practice
introduced
by
|
|||
| 62 | 2 | $json = \App\Json::decode($tableBody); |
|
| 63 | 2 | if (!empty($json) && !empty($json[0]) && !empty($json[0]['rates'])) { |
|
| 64 | 2 | foreach ($json[0]['rates'] as $rawCurrency) { |
|
| 65 | if (empty($rawCurrency['currency'])) { |
||
| 66 | continue; |
||
| 67 | 2 | } |
|
| 68 | 2 | if ('XDR' === $rawCurrency['code']) { |
|
| 69 | continue; |
||
| 70 | 2 | } |
|
| 71 | $supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($rawCurrency['code'])] = $rawCurrency['code']; |
||
| 72 | } |
||
| 73 | } else { |
||
| 74 | \App\Log::error('Cannot parse server response' . $tableBody, __METHOD__); |
||
| 75 | } |
||
| 76 | } else { |
||
| 77 | throw new \App\Exceptions\IntegrationException('ERR_CANNOT_CONNECT_TO_REMOTE' . $tableBody); |
||
| 78 | 2 | } |
|
| 79 | return $supportedCurrencies; |
||
| 80 | } |
||
| 81 | |||
| 82 | // Returns banks main currency |
||
| 83 | 2 | ||
| 84 | public function getMainCurrencyCode() |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Fetch exchange rates. |
||
| 91 | * |
||
| 92 | * @param <Array> $currencies - list of systems active currencies |
||
| 93 | * @param <Date> $date - date for which exchange is fetched |
||
| 94 | * @param bool $cron - if true then it is fired by server and crms currency conversion rates are updated |
||
| 95 | 1 | * @param mixed $otherCurrencyCode |
|
| 96 | * @param mixed $dateParam |
||
| 97 | 1 | */ |
|
| 98 | 1 | public function getRates($otherCurrencyCode, $dateParam, $cron = false) |
|
| 189 | } |
||
| 190 | } |
||
| 191 | } |
||
| 194 |
Loading history...
