App\Labels

Complexity

Total Complexity

8

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	member()	0	19	7
A	role()	0	3	1

<?php
/**
 * Labels file.
 *
 * @package App
 *
 * @copyright YetiForce S.A.
 * @license   YetiForce Public License 6.5 (licenses/LicenseEN.txt or yetiforce.com)
 * @author    Radosław Skrzypczak <r.skrzypczak@yetiforce.com>
 */

namespace App;

/**
 * Labels class.
 */
class Labels
{
	/**
	 * Get member name.
	 *
	 * @param string $member
	 *
	 * @return string
	 */
	public static function member(string $member): string
	{
		$name = '';
		[$type, $id] = explode(':', $member);
		switch ($type) {
			case \App\PrivilegeUtil::MEMBER_TYPE_USERS:
				$name = \App\Fields\Owner::getUserLabel((int) $id) ?: '';
				break;
			case \App\PrivilegeUtil::MEMBER_TYPE_GROUPS:
				$name = \App\Fields\Owner::getGroupName((int) $id) ?: '';
				break;
			case \App\PrivilegeUtil::MEMBER_TYPE_ROLES:
			case \App\PrivilegeUtil::MEMBER_TYPE_ROLE_AND_SUBORDINATES:
				$name = self::role($id);
				break;
			default:
				break;
		}
		return $name;

The expression return $name could return the type true which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

	}

	/**
	 * Get role name.
	 *
	 * @param string $roleId
	 *
	 * @return string
	 */
	public static function role(string $roleId): string
	{
		return \App\PrivilegeUtil::getRoleDetail($roleId)['rolename'] ?? '';
	}
}