Yeelight / cloud2

app/Traits/BaseModelEvents.php

<?php

namespace Yeelight\Traits;

use Illuminate\Database\Eloquent\Model;
use Yeelight\Models\Observers\BaseModelObserver;

/**
 * Whenever a new model is saved for the first time,
 * the creating and created events will fire.
 * If a model already existed in the database and the save method is called,
 * the updating / updated events will fire.
 * However, in both cases, the saving / saved events will fire.
 *
 * @CREATE: saving > creating > created > saved
 * @UPDATE: saving > updating > updated > saved
 */
trait BaseModelEvents
{
    protected static function boot()
    {
        parent::boot();

        /** @var Model $ModelName */
        $ModelName = get_called_class();

        // Setup event bindings...
        $ModelName::observe(new BaseModelObserver());
    }

    public function onCreating()
    {

        // auto set user id
        if ($this->autoUserId && empty($this->user_id)) {
            $user_id = $this->getAuthUserId();

It seems like getAuthUserId() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($user_id > 0) {
                $this->user_id = $user_id;

The property user_id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
        }
    }

    public function onCreated()
    {
    }

    public function onUpdating()
    {
    }

    public function onUpdated()
    {
    }

    public function onSaving()
    {

        // update ips if true
        if ($this->ips) {
            $this->updateIps();

It seems like updateIps() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        // update users if true
        if ($this->update_users) {
            $this->updateUsers();

It seems like updateUsers() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
    }

    public function onSaved()
    {
    }

    public function onDeleting()
    {
    }

    public function onDeleted()
    {
    }

    public function onRestoring()
    {
    }

    public function onRestored()
    {
    }
}