Issues (413)

app/Http/Controllers/Controller.php (1 issue)

Labels
Severity
1
<?php
2
3
namespace Yeelight\Http\Controllers;
4
5
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
6
use Illuminate\Foundation\Bus\DispatchesJobs;
7
use Illuminate\Foundation\Validation\ValidatesRequests;
8
use Illuminate\Routing\Controller as BaseController;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Yeelight\Http\Controllers\BaseController. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
9
10
/**
11
 * Class Controller
12
 *
13
 * @category Yeelight
14
 *
15
 * @package Yeelight\Http\Controllers
16
 *
17
 * @author Sheldon Lee <[email protected]>
18
 *
19
 * @license https://opensource.org/licenses/MIT MIT
20
 *
21
 * @link https://www.yeelight.com
22
 */
23
class Controller extends BaseController
24
{
25
    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;
26
}
27