Yeelight\Transformers\BaseTransformer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	includeUser()	0	5	2
A	includeAuthUser()	0	5	2

<?php

namespace Yeelight\Transformers;

use Yeelight\Base\Models\BaseModel;
use Yeelight\Base\Transformers\Transformer;

/**
 * Class BaseTransformer
 *
 * @category Yeelight
 *
 * @package Yeelight\Transformers
 *
 * @author Sheldon Lee <xdlee110@gmail.com>
 *
 * @license https://opensource.org/licenses/MIT MIT
 *
 * @link https://www.yeelight.com
 */
class BaseTransformer extends Transformer
{
    /**
     * Include User.
     *
     * @param BaseModel $model
     *
     * @return \League\Fractal\Resource\Item
     */
    public function includeUser(BaseModel $model)
    {
        $user = $model->user;

The property user does not exist on Yeelight\Base\Models\BaseModel. Did you mean user_id?

        if ($user) {
            return $this->item($user, new UserTransformer(), 'user');
        }
    }

    /**
     * Include User.
     *
     * @param BaseModel $model
     *
     * @return \League\Fractal\Resource\Item
     */
    public function includeAuthUser(BaseModel $model)

The parameter $model is not used and could be removed.

    {
        $user = auth_user();
        if ($user) {

$user is of type Yeelight\Models\Foundation\BaseUser, thus it always evaluated to true.

            return $this->item($user, new UserTransformer());
        }
    }
}