Param::align() - Code Metrics - YarekTyshchenko/Sign - Measure and Improve Code Quality continuously with Scrutinizer

Param::align() A
last analyzed 2016-05-17 08:38 UTC

↳ Parent: Param

Complexity

Conditions	4
Paths	4

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	8
rs	9.2
cc	4
eloc	6
nc	4
nop	1

<?php
namespace Sign;

class Param {
    private $_value;
    private $_size;
    private $_bound = false;
    private $_pad = STR_PAD_RIGHT;

    public function setValue($value) {
        $this->_value = $value;
        $this->_bound = true;
    }

    public function align($type) {
        switch ($type) {
            case 'left': $this->_pad = STR_PAD_RIGHT;break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'center': $this->_pad = STR_PAD_BOTH;break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case 'right': $this->_pad = STR_PAD_LEFT;break;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }
        $this->_align = $type;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function value() {
        $value = str_pad($this->_value, $this->_size, ' ', $this->_pad);
        return $value;
    }

    public function bound() {
        return $this->_bound;
    }

    public function __construct($size) {
        $this->_size = $size;
    }
}


1			<?php
2			namespace Sign;
3
4			class Param {
5			private $_value;
6			private $_size;
7			private $_bound = false;
8			private $_pad = STR_PAD_RIGHT;
9
10			public function setValue($value) {
11			$this->_value = $value;
12			$this->_bound = true;
13			}
14
15			public function align($type) {
16			switch ($type) {
17			case 'left': $this->_pad = STR_PAD_RIGHT;break;
			0 ignored issues – show Coding Style introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
18			case 'center': $this->_pad = STR_PAD_BOTH;break;
			0 ignored issues – show Coding Style introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
19			case 'right': $this->_pad = STR_PAD_LEFT;break;
			0 ignored issues – show Coding Style introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
20			}
21			$this->_align = $type;
			0 ignored issues – show Bug introduced 2016-05-17 08:31 UTC by Report Bug Copy Issue Report The property `_align` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			}
23
24			public function value() {
25			$value = str_pad($this->_value, $this->_size, ' ', $this->_pad);
26			return $value;
27			}
28
29			public function bound() {
30			return $this->_bound;
31			}
32
33			public function __construct($size) {
34			$this->_size = $size;
35			}
36			}
37

YarekTyshchenko / Sign

Param::align() A last analyzed 2016-05-17 08:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Param::align() A
last analyzed 2016-05-17 08:38 UTC