HasPermissions::permissions() - Code Metrics - Inspection of "Updated the changelog" - Yard8/laravel-permissions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff4154...80790e )

by Yard8

created 2020-04-16 11:37 UTC

HasPermissions::permissions() A

↳ Parent: HasPermissions

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Yard8\LaravelPermissions\Traits;

use Illuminate\Support\Str;
use Yard8\LaravelPermissions\Models\Permission;
use Yard8\LaravelPermissions\Models\Role;

trait HasPermissions
{
    /**
     * Check if a user has a specific permission assigned to them.
     *
     * @param  string  $permission
     * @return  boolean
     */
    public function hasPermission($permission)
    {
        if ($this->hasRole(config('permissions.admin'))) {
            return true;
        }

        $permissions = $this->permissions->pluck('id')->toArray();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return in_array($permission, $permissions);
    }

    /**
     * Check if a user has any of the permissions assigned to them.
     *
     * @param  array  $permissions
     * @return  boolean
     */
    public function hasAnyPermission($permissions)
    {
        if ($this->hasRole(config('permissions.admin'))) {
            return true;
        }

        $assignedPermissions = $this->permissions->pluck('id')->toArray();

        foreach ($permissions as $permission) {
            if (in_array($permission, $assignedPermissions)) {
                return true;
            }
        }

        return false;
    }

    /**
     * Check if a user has has one of the roles assigned to them.
     *
     * @param  string|array  $roles
     * @return  boolean
     */
    public function hasRole($roles)
    {
        if (is_null($this->role)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return false;
        }

        $role = Str::slug($this->role->name);

        if (is_array($roles)) {
            return in_array($role, $roles);
        }

        return $role === $roles;
    }

    /**
     * Get the permissions assigned to the user.
     */
    public function permissions()
    {
        return $this->belongsToMany(Permission::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the role assigned to the user.
     */
    public function role()
    {
        return $this->belongsTo(Role::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Yard8\LaravelPermissions\Traits;
4
5			use Illuminate\Support\Str;
6			use Yard8\LaravelPermissions\Models\Permission;
7			use Yard8\LaravelPermissions\Models\Role;
8
9			trait HasPermissions
10			{
11			/**
12			* Check if a user has a specific permission assigned to them.
13			*
14			* @param string $permission
15			* @return boolean
16			*/
17			public function hasPermission($permission)
18			{
19			if ($this->hasRole(config('permissions.admin'))) {
20			return true;
21			}
22
23			$permissions = $this->permissions->pluck('id')->toArray();
			0 ignored issues – show Bug introduced 2019-10-18 08:15 UTC by Report Bug Copy Issue Report The property `permissions` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24
25			return in_array($permission, $permissions);
26			}
27
28			/**
29			* Check if a user has any of the permissions assigned to them.
30			*
31			* @param array $permissions
32			* @return boolean
33			*/
34			public function hasAnyPermission($permissions)
35			{
36			if ($this->hasRole(config('permissions.admin'))) {
37			return true;
38			}
39
40			$assignedPermissions = $this->permissions->pluck('id')->toArray();
41
42			foreach ($permissions as $permission) {
43			if (in_array($permission, $assignedPermissions)) {
44			return true;
45			}
46			}
47
48			return false;
49			}
50
51			/**
52			* Check if a user has has one of the roles assigned to them.
53			*
54			* @param string\|array $roles
55			* @return boolean
56			*/
57			public function hasRole($roles)
58			{
59			if (is_null($this->role)) {
			0 ignored issues – show Bug introduced 2019-10-18 08:15 UTC by Report Bug Copy Issue Report The property `role` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
60			return false;
61			}
62
63			$role = Str::slug($this->role->name);
64
65			if (is_array($roles)) {
66			return in_array($role, $roles);
67			}
68
69			return $role === $roles;
70			}
71
72			/**
73			* Get the permissions assigned to the user.
74			*/
75			public function permissions()
76			{
77			return $this->belongsToMany(Permission::class);
			0 ignored issues – show Bug introduced 2019-10-18 08:15 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
78			}
79
80			/**
81			* Get the role assigned to the user.
82			*/
83			public function role()
84			{
85			return $this->belongsTo(Role::class);
			0 ignored issues – show Bug introduced 2019-10-18 08:15 UTC by Report Bug Copy Issue Report It seems like `belongsTo()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
86			}
87			}
88

Yard8 / laravel-permissions

Push — master ( ff4154...80790e )

HasPermissions::permissions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like