Issues in ConfigFileTrait.php (master) - Issues in master - Yapeal/yapeal-ng - Measure and Improve Code Quality continuously with Scrutinizer

Issues (48)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Console/ConfigFileTrait.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types = 1);
/**
 * Contains trait ConfigFileTrait.
 *
 * PHP version 7.0+
 *
 * LICENSE:
 * This file is part of Yet Another Php Eve Api Library also know as Yapeal
 * which can be used to access the Eve Online API data and place it into a
 * database.
 * Copyright (C) 2016-2017 Michael Cummings
 *
 * This program is free software: you can redistribute it and/or modify it
 * under the terms of the GNU Lesser General Public License as published by the
 * Free Software Foundation, either version 3 of the License, or (at your
 * option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
 * for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program. If not, see
 * <http://spdx.org/licenses/LGPL-3.0.html>.
 *
 * You should be able to find a copy of this license in the COPYING-LESSER.md
 * file. A copy of the GNU GPL should also be available in the COPYING.md file.
 *
 * @copyright 2016-2017 Michael Cummings
 * @license   LGPL-3.0+
 * @author    Michael Cummings <[email protected]>
 */
namespace Yapeal\Console;

use Symfony\Component\Console\Input\InputOption;
use Yapeal\Configuration\ConfigManagementInterface;
use Yapeal\Container\ContainerInterface;

/**
 * Trait ConfigFileTrait.
 */
trait ConfigFileTrait
{
    /**
     * @throws \Symfony\Component\Console\Exception\LogicException
     */
    protected function addConfigFileOption()
    {
        $mess = 'Configuration file to get settings from.'
            . ' <comment>NOTE: A (missing, unreadable, empty, etc) file will be silently ignored.</comment>';
        $this->addOption('configFile', 'c', InputOption::VALUE_REQUIRED, $mess);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    /**
     * Process the configuration file gotten on the CLI.
     *
     * NOTE: All settings from this configuration file overwrite any existing values.
     *
     * @param string             $pathFile Path and file name of config file to
     *                                     be processed.
     * @param ContainerInterface $dic      Instance of Container that will be
     *                                     updated.
     *
     * @throws \DomainException
     * @throws \LogicException
     */
    protected function processConfigFile(string $pathFile, ContainerInterface $dic)
    {
        $pathFile = trim($pathFile);
        if ('' === $pathFile) {
            return;
        }
        /**
         * @var ConfigManagementInterface $manager
         */
        $manager = $dic['Yapeal.Configuration.Callable.Manager'];
        $manager->addConfigFile($pathFile, 1);
        $manager->update();
    }
}


1			<?php
2			declare(strict_types = 1);
3			/**
4			* Contains trait ConfigFileTrait.
5			*
6			* PHP version 7.0+
7			*
8			* LICENSE:
9			* This file is part of Yet Another Php Eve Api Library also know as Yapeal
10			* which can be used to access the Eve Online API data and place it into a
11			* database.
12			* Copyright (C) 2016-2017 Michael Cummings
13			*
14			* This program is free software: you can redistribute it and/or modify it
15			* under the terms of the GNU Lesser General Public License as published by the
16			* Free Software Foundation, either version 3 of the License, or (at your
17			* option) any later version.
18			*
19			* This program is distributed in the hope that it will be useful, but WITHOUT
20			* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
21			* FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
22			* for more details.
23			*
24			* You should have received a copy of the GNU Lesser General Public License
25			* along with this program. If not, see
26			* <http://spdx.org/licenses/LGPL-3.0.html>.
27			*
28			* You should be able to find a copy of this license in the COPYING-LESSER.md
29			* file. A copy of the GNU GPL should also be available in the COPYING.md file.
30			*
31			* @copyright 2016-2017 Michael Cummings
32			* @license LGPL-3.0+
33			* @author Michael Cummings <[email protected]>
34			*/
35			namespace Yapeal\Console;
36
37			use Symfony\Component\Console\Input\InputOption;
38			use Yapeal\Configuration\ConfigManagementInterface;
39			use Yapeal\Container\ContainerInterface;
40
41			/**
42			* Trait ConfigFileTrait.
43			*/
44			trait ConfigFileTrait
45			{
46			/**
47			* @throws \Symfony\Component\Console\Exception\LogicException
48			*/
49			protected function addConfigFileOption()
50			{
51			$mess = 'Configuration file to get settings from.'
52			. ' <comment>NOTE: A (missing, unreadable, empty, etc) file will be silently ignored.</comment>';
53			$this->addOption('configFile', 'c', InputOption::VALUE_REQUIRED, $mess);
			0 ignored issues – show Bug introduced 2016-08-28 20:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `addOption()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54			}
55			/**
56			* Process the configuration file gotten on the CLI.
57			*
58			* NOTE: All settings from this configuration file overwrite any existing values.
59			*
60			* @param string $pathFile Path and file name of config file to
61			* be processed.
62			* @param ContainerInterface $dic Instance of Container that will be
63			* updated.
64			*
65			* @throws \DomainException
66			* @throws \LogicException
67			*/
68			protected function processConfigFile(string $pathFile, ContainerInterface $dic)
69			{
70			$pathFile = trim($pathFile);
71			if ('' === $pathFile) {
72			return;
73			}
74			/**
75			* @var ConfigManagementInterface $manager
76			*/
77			$manager = $dic['Yapeal.Configuration.Callable.Manager'];
78			$manager->addConfigFile($pathFile, 1);
79			$manager->update();
80			}
81			}
82

Yapeal / yapeal-ng

Issues (48)

Security Analysis no request data

lib/Console/ConfigFileTrait.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like