Yapeal / yapeal-ng

lib/Xml/EveApiXmlData.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
      * Used to add item to arguments list.
      *
      * @param string $name
-     * @param mixed  $value
+     * @param string  $value
      *
      * @throws InvalidArgumentException
      * @return self Fluent interface.
@@ -82,7 +82,7 @@ 
      *
      * @param string $name
      *
-     * @return null|string
+     * @return string
      * @throws DomainException
      */
     public function getEveApiArgument($name)

Spacing +7 added lines, -7 removed lines

@@ -57,7 +57,7 @@ 
             return $this;
         }
         if (!is_string($name)) {
-            $mess = 'Name MUST be string but given ' . gettype($name);
+            $mess = 'Name MUST be string but given '.gettype($name);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiArguments[$name] = (string)$value;
@@ -89,7 +89,7 @@ 
     {
         $name = (string)$name;
         if (!array_key_exists($name, $this->eveApiArguments)) {
-            $mess = 'Unknown argument ' . $name;
+            $mess = 'Unknown argument '.$name;
             throw new DomainException($mess);
         }
         return $this->eveApiArguments[$name];
@@ -151,12 +151,12 @@ 
      */
     public function getHash()
     {
-        $hash = $this->getEveApiName() . $this->getEveApiSectionName();
+        $hash = $this->getEveApiName().$this->getEveApiSectionName();
         foreach ($this->getEveApiArguments() as $key => $value) {
             if ('mask' === $key) {
                 continue;
             }
-            $hash .= $key . $value;
+            $hash .= $key.$value;
         }
         return hash('md5', $hash);
     }
@@ -226,7 +226,7 @@ 
     public function setEveApiName($value)
     {
         if (!is_string($value)) {
-            $mess = 'Name MUST be string but was given ' . gettype($value);
+            $mess = 'Name MUST be string but was given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiName = $value;
@@ -243,7 +243,7 @@ 
     public function setEveApiSectionName($value)
     {
         if (!is_string($value)) {
-            $mess = 'Section name MUST be string but was given ' . gettype($value);
+            $mess = 'Section name MUST be string but was given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiSectionName = $value;
@@ -263,7 +263,7 @@ 
             $xml = '';
         }
         if (!is_string($xml)) {
-            $mess = 'Xml MUST be string but was given ' . gettype($xml);
+            $mess = 'Xml MUST be string but was given '.gettype($xml);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiXml = $xml;

lib/FileSystem/CommonFileHandlingTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 trait CommonFileHandlingTrait
 {
     /**
-     * @param                   $fileName
+     * @param                   string $fileName
      * @param MediatorInterface $yem
      * @param string            $mode
      *

Spacing +4 added lines, -4 removed lines

@@ -135,17 +135,17 @@ 
     protected function isWritablePath($path, MediatorInterface $yem)
     {
         if (!is_readable($path)) {
-            $mess = 'Cache path is NOT readable or does NOT exist, was given ' . $path;
+            $mess = 'Cache path is NOT readable or does NOT exist, was given '.$path;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess);
             return false;
         }
         if (!is_dir($path)) {
-            $mess = 'Cache path is NOT a directory, was given ' . $path;
+            $mess = 'Cache path is NOT a directory, was given '.$path;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess);
             return false;
         }
         if (!is_writable($path)) {
-            $mess = 'Cache path is NOT writable, was given ' . $path;
+            $mess = 'Cache path is NOT writable, was given '.$path;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess);
             return false;
         }
@@ -214,7 +214,7 @@ 
     protected function safeFileRead($fileName, MediatorInterface $yem)
     {
         if (!is_readable($fileName) || !is_file($fileName)) {
-            $mess = 'Could NOT find accessible file, was given ' . $fileName;
+            $mess = 'Could NOT find accessible file, was given '.$fileName;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::INFO, $mess);
             return false;
         }

lib/Log/MessageBuilderTrait.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      */
     protected function createEveApiMessage($messagePrefix, EveApiReadWriteInterface $data)
     {
-        $mess = $messagePrefix . ' Eve API %1$s/%2$s';
+        $mess = $messagePrefix.' Eve API %1$s/%2$s';
         $subs = [lcfirst($data->getEveApiSectionName()), $data->getEveApiName()];
         if ($data->hasEveApiArgument('keyID')) {
             $mess .= ' for keyID = %3$s';

lib/Xsl/Transformer.php

Spacing +4 added lines, -4 removed lines

@@ -57,7 +57,7 @@ 
      */
     public function __construct($dir = __DIR__)
     {
-        $this->setRelativeBaseDir($dir . '/');
+        $this->setRelativeBaseDir($dir.'/');
     }
     /**
      * @param EveApiEventInterface $event
@@ -117,15 +117,15 @@ 
         }
         $arguments = $data->getEveApiArguments();
         if (!empty($arguments['vCode'])) {
-            $arguments['vCode'] = substr($arguments['vCode'], 0, 8) . '...';
+            $arguments['vCode'] = substr($arguments['vCode'], 0, 8).'...';
         }
         unset($arguments['mask']);
         $json = json_encode($arguments);
         $xml = str_replace(
             ["encoding='UTF-8'?>\r\n<eveapi", "encoding='UTF-8'?>\n<eveapi"],
             [
-                "encoding='UTF-8'?>\r\n<?yapeal.parameters.json " . $json . "?>\r\n<eveapi",
-                "encoding='UTF-8'?>\n<?yapeal.parameters.json " . $json . "?>\n<eveapi"
+                "encoding='UTF-8'?>\r\n<?yapeal.parameters.json ".$json."?>\r\n<eveapi",
+                "encoding='UTF-8'?>\n<?yapeal.parameters.json ".$json."?>\n<eveapi"
             ],
             $xml
         );

lib/FileSystem/CachePreserver.php

Spacing +2 added lines, -2 removed lines

@@ -103,10 +103,10 @@
     public function setCachePath($value = null)
     {
         if ($value === null) {
-            $value = dirname(dirname(__DIR__)) . '/cache/';
+            $value = dirname(dirname(__DIR__)).'/cache/';
         }
         if (!is_string($value)) {
-            $mess = 'Cache path MUST be string, but was given ' . gettype($value);
+            $mess = 'Cache path MUST be string, but was given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         if ('' === $this->cachePath) {

lib/FileSystem/CacheRetriever.php

Spacing +4 added lines, -4 removed lines

@@ -106,10 +106,10 @@ 
     public function setCachePath($value = null)
     {
         if ($value === null) {
-            $value = dirname(dirname(__DIR__)) . '/cache/';
+            $value = dirname(dirname(__DIR__)).'/cache/';
         }
         if (!is_string($value)) {
-            $mess = 'Cache path MUST be string, but given ' . gettype($value);
+            $mess = 'Cache path MUST be string, but given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         $this->cachePath = $this->getFpn()
@@ -156,9 +156,9 @@ 
         }
         $now = time();
         /** @noinspection PhpUndefinedFieldInspection */
-        $current = strtotime($simple->currentTime[0] . '+00:00');
+        $current = strtotime($simple->currentTime[0].'+00:00');
         /** @noinspection PhpUndefinedFieldInspection */
-        $until = strtotime($simple->cachedUntil[0] . '+00:00');
+        $until = strtotime($simple->cachedUntil[0].'+00:00');
         // At minimum use cached XML for 5 minutes (300 secs).
         if (($now - $current) <= 300) {
             return false;

lib/Console/CommandToolsTrait.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     public function setCwd($value)
     {
         if (!is_string($value)) {
-            $mess = 'Cwd MUST be string but given ' . gettype($value);
+            $mess = 'Cwd MUST be string but given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         $this->cwd = $value;

lib/Console/Command/DatabaseUpdater.php

Spacing +4 added lines, -4 removed lines

@@ -79,7 +79,7 @@ 
         $output->writeln($name);
         $csq = $this->getCsq();
         $this->executeSqlStatements(
-            $csq->getDropAddOrModifyColumnProcedure() . PHP_EOL . $csq->getCreateAddOrModifyColumnProcedure(),
+            $csq->getDropAddOrModifyColumnProcedure().PHP_EOL.$csq->getCreateAddOrModifyColumnProcedure(),
             $name,
             $output
         );
@@ -169,7 +169,7 @@ 
     protected function getUpdateFileList(OutputInterface $output)
     {
         $fileNames = [];
-        $path = $this->getDic()['Yapeal.Sql.dir'] . 'updates/';
+        $path = $this->getDic()['Yapeal.Sql.dir'].'updates/';
         if (!is_readable($path) || !is_dir($path)) {
             $mess = sprintf(
                 '<info>Could NOT access update directory %1$s</info>',
@@ -257,8 +257,8 @@ 
             $stmt->execute([$updateVersion]);
             $pdo->commit();
         } catch (PDOException $exc) {
-            $mess = $sql . PHP_EOL;
-            $mess .= sprintf('Database error message was %s', $exc->getMessage()) . PHP_EOL;
+            $mess = $sql.PHP_EOL;
+            $mess .= sprintf('Database error message was %s', $exc->getMessage()).PHP_EOL;
             $mess .= sprintf(
                 'Database "version" update failed for %1$s',
                 $updateVersion

lib/Console/Command/AbstractDatabaseCommon.php

Spacing +2 added lines, -2 removed lines

@@ -180,7 +180,7 @@ 
             try {
                 $pdo->exec($sql);
             } catch (PDOException $exc) {
-                $mess = $sql . PHP_EOL;
+                $mess = $sql.PHP_EOL;
                 $mess .= sprintf(
                     'Sql failed in %1$s on statement %2$s with (%3$s) %4$s',
                     $fileName,
@@ -206,7 +206,7 @@ 
         $base = 'Yapeal.Sql.';
         foreach (['class', 'database', 'hostName', 'password', 'platform', 'tablePrefix', 'userName'] as $option) {
             if (!empty($options[$option])) {
-                $this->getDic()[$base . $option] = $options[$option];
+                $this->getDic()[$base.$option] = $options[$option];
             }
         }
         if (!empty($options['configFile'])) {