| Conditions | 6 |
| Paths | 6 |
| Total Lines | 61 |
| Code Lines | 50 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 56 | protected function applyVerbosityMap(OutputInterface $output) |
||
| 57 | { |
||
| 58 | $dic = $this->getDic(); |
||
| 59 | $verbosity = $output->getVerbosity(); |
||
| 60 | /** |
||
| 61 | * @var \Yapeal\Event\MediatorInterface $yem |
||
| 62 | * @var \Yapeal\Log\ActivationStrategy $strategy |
||
| 63 | * @var \Yapeal\Log\LineFormatter $cliLF |
||
| 64 | * @var \Yapeal\Log\LineFormatter $fileSystemLF |
||
| 65 | * @var \Yapeal\Log\StreamHandler $cliStream |
||
| 66 | * @var \Yapeal\Log\StreamHandler $fileSystemStream |
||
| 67 | */ |
||
| 68 | $yem = $dic['Yapeal.Event.Mediator']; |
||
| 69 | $cliLF = $dic['Yapeal.Log.Callable.CliLF']; |
||
| 70 | $cliLF->setPrettyJson(true); |
||
| 71 | $cliStream = $dic['Yapeal.Log.Callable.Cli']; |
||
| 72 | $cliStream->setPreserve(true); |
||
| 73 | $fileSystemLF = $dic['Yapeal.Log.Callable.FileSystemLF']; |
||
| 74 | $fileSystemLF->setPrettyJson(true); |
||
| 75 | $fileSystemStream = $dic['Yapeal.Log.Callable.FileSystem']; |
||
| 76 | $fileSystemStream->setPreserve(true); |
||
| 77 | $strategy = $dic['Yapeal.Log.Callable.Strategy']; |
||
| 78 | switch ($verbosity) { |
||
| 79 | case $output::VERBOSITY_QUIET: |
||
| 80 | $cliLF->setPrettyJson(false); |
||
| 81 | $cliStream->setPreserve(false); |
||
| 82 | $fileSystemLF->setPrettyJson(false); |
||
| 83 | $strategy->setActionLevel(Logger::ERROR); |
||
| 84 | $mess = 'Yapeal-ng has switched to quiet mode. Beyond this point only ERROR or higher level messages will trigger logging'; |
||
|
|
|||
| 85 | $yem->triggerLogEvent('Yapeal.Log.log', Logger::ERROR, $mess); |
||
| 86 | break; |
||
| 87 | case $output::VERBOSITY_NORMAL: |
||
| 88 | $cliLF->setPrettyJson(false); |
||
| 89 | $cliStream->setPreserve(false); |
||
| 90 | $fileSystemLF->setPrettyJson(false); |
||
| 91 | $strategy->setActionLevel(Logger::WARNING); |
||
| 92 | $mess = 'Yapeal-ng has switched to normal mode. Beyond this point any WARNING or higher level messages will trigger logging'; |
||
| 93 | $yem->triggerLogEvent('Yapeal.Log.log', Logger::WARNING, $mess); |
||
| 94 | break; |
||
| 95 | case $output::VERBOSITY_VERBOSE: |
||
| 96 | $cliLF->setPrettyJson(false); |
||
| 97 | $strategy->setActionLevel(Logger::NOTICE); |
||
| 98 | $mess = 'Yapeal-ng has switched to verbose mode. Beyond this point any NOTICE or higher level messages will trigger logging'; |
||
| 99 | $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess); |
||
| 100 | break; |
||
| 101 | case $output::VERBOSITY_VERY_VERBOSE: |
||
| 102 | $strategy->setActionLevel(Logger::INFO); |
||
| 103 | $mess = 'Yapeal-ng switched to very verbose mode. Beyond this point any INFO or higher level messages will trigger logging'; |
||
| 104 | $yem->triggerLogEvent('Yapeal.Log.log', Logger::INFO, $mess); |
||
| 105 | break; |
||
| 106 | case $output::VERBOSITY_DEBUG: |
||
| 107 | $strategy->setActionLevel(Logger::DEBUG); |
||
| 108 | $mess = 'Yapeal-ng has switched to debug mode. Beyond this point all message levels will trigger logging'; |
||
| 109 | $yem->triggerLogEvent('Yapeal.Log.log', Logger::DEBUG, $mess); |
||
| 110 | break; |
||
| 111 | default: |
||
| 112 | $mess = 'Unexpected and unknown verbosity value received from OutputInterface. Aborting ...'; |
||
| 113 | throw new \UnexpectedValueException($mess, 2); |
||
| 114 | } |
||
| 115 | return $this; |
||
| 116 | } |
||
| 117 | } |
||
| 118 |
Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line.