Yapeal\Sql\PDOAwareTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

36.36%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setPdo()	0	9	2
A	getPdo()	0	8	2

<?php
declare(strict_types = 1);
/**
 * Contains trait PDOAwareTrait.
 *
 * PHP version 7.0+
 *
 * LICENSE:
 * This file is part of Yet Another Php Eve Api Library also know as Yapeal
 * which can be used to access the Eve Online API data and place it into a
 * database.
 * Copyright (C) 2016-2017 Michael Cummings
 *
 * This program is free software: you can redistribute it and/or modify it
 * under the terms of the GNU Lesser General Public License as published by the
 * Free Software Foundation, either version 3 of the License, or (at your
 * option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
 * for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program. If not, see
 * <http://spdx.org/licenses/LGPL-3.0.html>.
 *
 * You should be able to find a copy of this license in the COPYING-LESSER.md
 * file. A copy of the GNU GPL should also be available in the COPYING.md file.
 *
 * @author    Michael Cummings <mgcummings@yahoo.com>
 * @copyright 2016-2017 Michael Cummings
 * @license   LGPL-3.0+
 */
namespace Yapeal\Sql;

/**
 * Trait PDOAwareTrait.
 */
trait PDOAwareTrait
{
    /**
     * @param ConnectionInterface $value

Should the type for parameter $value not be null|ConnectionInterface?

     *
     * @return static Fluent interface.
     * @throws \InvalidArgumentException
     */
    public function setPdo(ConnectionInterface $value = null)
    {
        if (!$value->isSql92Mode()) {

It seems like $value is not always an object, but can also be of type null. Maybe add an additional type check?

            $mess = 'Connection must be already initialized for SQL-92 mode';
            throw new \InvalidArgumentException($mess);
        }
        $this->pdo = $value;
        return $this;
    }
    /**
     * @return ConnectionInterface
     * @throws \LogicException
     */
    protected function getPdo(): ConnectionInterface
    {
        if (null === $this->pdo) {
            $mess = 'Tried to use pdo before it was set';
            throw new \LogicException($mess, 1);
        }
        return $this->pdo;
    }
    /**
     * @var ConnectionInterface $pdo
     */
    private $pdo;
}