Streak\Endpoint\Box

Complexity

Total Complexity

13

Size/Duplication

Total Lines	71
Duplicated Lines	30.99 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	3
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	0	4	1
B	findAll()	0	27	5
A	create()	10	10	2
A	delete()	0	4	1
A	edit()	12	12	3
A	find()	0	4	1

<?php

namespace Streak\Endpoint;

use Streak\Paginator;

class Box extends AbstractEndpoint
{
    const ENDPOINT = 'boxes';

    public function all()
    {
        return $this->client->get(self::ENDPOINT);
    }

    public function findAll($pipelineKey, $sortBy = null, Paginator $paginator = null)
    {
        $options = ['query' => []];

        if (null !== $sortBy) {
            if (!in_array($sortBy, ['creationTimestamp', 'lastUpdatedTimestamp'])) {
                throw new \InvalidArgumentException('Invalid sort field.');
            }

            $options['query']['sortBy'] = $sortBy;
        }

        if (null === $paginator) {
            $paginator = new Paginator();
        }

        while ($paginator->nextPage()) {
            $options['query']['page'] = $paginator->getPage();
            $options['query']['limit'] = $paginator->getLimit();

            $results = $this->client->get(sprintf('pipelines/%s/%s', $pipelineKey, self::ENDPOINT), $options);

            $paginator->addResults($results);

It seems like $results defined by $this->client->get(sprintf('pipelines/%s/%s', $pipelineKey, self::ENDPOINT), $options) on line 36 can also be of type string; however, Streak\Paginator::addResults() does only seem to accept array, maybe add an additional type check?

        }

        return $paginator->getResults();
    }

    public function create($pipelineKey, array $box)

This method seems to be duplicated in your project.

    {
        if (!isset($box['name'])) {
            throw new \InvalidArgumentException('Missing required fields.');
        }

        return $this->client->put(sprintf('pipelines/%s/%s', $pipelineKey, self::ENDPOINT), [
            'form_params' => $box,
        ]);
    }

    public function delete($boxKey)
    {
        return $this->client->delete(sprintf('%s/%s', self::ENDPOINT, $boxKey));
    }

    public function edit($boxKey, array $box)

This method seems to be duplicated in your project.

    {
        foreach ($box as $field => $value) {
            if (!in_array($field, ['name', 'notes', 'stageKey', 'followerKeys', 'fields'])) {
                throw new \InvalidArgumentException('Not allowed field.');
            }
        }

        return $this->client->post(sprintf('%s/%s', self::ENDPOINT, $boxKey), [
            'json' => $box,
        ]);
    }

    public function find($boxKey)
    {
        return $this->client->get(sprintf('%s/%s', self::ENDPOINT, $boxKey));
    }
}