Issues in viewcat.php - Fixed Issues - Inspection of "Merge pull request #11 from bleekk/master" - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 954431...eec6a1 )

by Michael

created 2017-05-19 09:11 UTC

viewcat.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @category        Module
 * @package         Xoopstube
 * @author          XOOPS Development Team
 * @copyright       2001-2016 XOOPS Project (http://xoops.org)
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @link            http://xoops.org/
 * @since           1.0.6
 */

include __DIR__ . '/header.php';

// Begin Main page Heading etc
$cid        = XoopsRequest::getInt('cid', 0, 'GET'); //xtubeCleanRequestVars($_REQUEST, 'cid', 0);
$selectdate = XoopsRequest::getString('selectdate', ''); //xtubeCleanRequestVars($_REQUEST, 'selectdate', '');
$list       = XoopsRequest::getString('list', '');// xtubeCleanRequestVars($_REQUEST, 'list', '');
$start      = XoopsRequest::getInt('start', 0, 'GET'); //xtubeCleanRequestVars($_REQUEST, 'start', 0);

$catsort = $GLOBALS['xoopsModuleConfig']['sortcats'];
$mytree  = new XoopstubeTree($GLOBALS['xoopsDB']->prefix('xoopstube_cat'), 'cid', 'pid');
$arr     = $mytree->getFirstChild($cid, $catsort);

if (is_array($arr) > 0 && !$list && !$selectdate) {
    if (false === XoopstubeUtilities::xtubeCheckGroups($cid)) {
        redirect_header('index.php', 1, _MD_XOOPSTUBE_MUSTREGFIRST);
    }
}

$xoopsOption['template_main'] = 'xoopstube_viewcat.tpl';

include XOOPS_ROOT_PATH . '/header.php';

global $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
//$catarray['letters']     = XoopstubeUtilities::xtubeGetLetters();
$catarray['letters']     = XoopstubeUtilities::xoopstubeLettersChoice();
$catarray['imageheader'] = XoopstubeUtilities::xtubeRenderImageHeader();
$xoopsTpl->assign('catarray', $catarray);

//$catArray['letters'] = XoopstubeUtilities::xtubeLettersChoice();

//$catArray['letters'] = XoopstubeUtilities::xoopstubeLettersChoice();
//$catArray['toolbar'] = xoopstube_toolbar();
//$xoopsTpl->assign('catarray', $catArray);

// Breadcrumb
$pathstring = '<a href="index.php">' . _MD_XOOPSTUBE_MAIN . '</a>&nbsp;:&nbsp;';
$pathstring .= $mytree->getNicePathFromId($cid, 'title', 'viewcat.php?op=');
$xoopsTpl->assign('category_path', $pathstring);
$xoopsTpl->assign('category_id', $cid);

// Display Sub-categories for selected Category
if (is_array($arr) > 0 && !$list && !$selectdate) {
    $scount = 1;
    foreach ($arr as $ele) {
        if (false === XoopstubeUtilities::xtubeCheckGroups($ele['cid'])) {
            continue;
        }
        $sub_arr         = array();
        $sub_arr         = $mytree->getFirstChild($ele['cid'], $catsort);
        $space           = 1;
        $chcount         = 1;
        $infercategories = '';
        foreach ($sub_arr as $sub_ele) {
            // Subitem file count
            $hassubitems = XoopstubeUtilities::xtubeGetTotalItems($sub_ele['cid']);
            // Filter group permissions
            if (true === XoopstubeUtilities::xtubeCheckGroups($sub_ele['cid'])) {
                // If subcategory count > 5 then finish adding subcats to $infercategories and end
                if ($chcount > 5) {
                    $infercategories .= '...';
                    break;
                }
                if ($space > 0) {
                    $infercategories .= ', ';
                }

                $infercategories .= '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewcat.php?cid=' . $sub_ele['cid'] . '">'
                                    . $xtubemyts->htmlSpecialCharsStrip($sub_ele['title']) . '</a> (' . $hassubitems['count'] . ')';
                ++$space;
                ++$chcount;
            }
        }
        $totalvideos = XoopstubeUtilities::xtubeGetTotalItems($ele['cid']);
        $indicator   = XoopstubeUtilities::xtubeIsNewImage($totalvideos['published']);

        // This code is copyright WF-Projects
        // Using this code without our permission or removing this code voids the license agreement

        $_image = $ele['imgurl'] ? urldecode($ele['imgurl']) : '';
        if ($_image !== '' && $GLOBALS['xoopsModuleConfig']['usethumbs']) {
            $_thumb_image = new XtubeThumbsNails($_image, $GLOBALS['xoopsModuleConfig']['catimage'], 'thumbs');
            if ($_thumb_image) {
                $_thumb_image->setUseThumbs(1);
                $_thumb_image->setImageType('gd2');
                $_image = $_thumb_image->createThumbnail($GLOBALS['xoopsModuleConfig']['shotwidth'], $GLOBALS['xoopsModuleConfig']['shotheight'], $GLOBALS['xoopsModuleConfig']['imagequality'],
                                                         $GLOBALS['xoopsModuleConfig']['updatethumbs'], $GLOBALS['xoopsModuleConfig']['imageAspect']);
            }
        }

        if (empty($_image) || '' === $_image) {
            $imgurl  = $indicator['image'];
            $_width  = 33;
            $_height = 24;
        } else {
            $imgurl  = "{$GLOBALS['xoopsModuleConfig']['catimage']}/$_image";
            $_width  = $GLOBALS['xoopsModuleConfig']['shotwidth'];
            $_height = $GLOBALS['xoopsModuleConfig']['shotheight'];
        }
        /*
        * End
        */

        $xoopsTpl->append('subcategories', array(
            'title'           => $xtubemyts->htmlSpecialCharsStrip($ele['title']),
            'id'              => $ele['cid'],
            'image'           => XOOPS_URL . "/$imgurl",
            'width'           => $_width,
            'height'          => $_height,
            'infercategories' => $infercategories,
            'totalvideos'     => $totalvideos['count'],
            'count'           => $scount,
            'alttext'         => $ele['description']
        ));
        ++$scount;
    }
}

// Show Description for Category listing
$sql         = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_cat') . ' WHERE cid=' . (int)$cid;
$head_arr    = $GLOBALS['xoopsDB']->fetchArray($GLOBALS['xoopsDB']->query($sql));
$html        = $head_arr['nohtml'] ? 0 : 1;
$smiley      = $head_arr['nosmiley'] ? 0 : 1;
$xcodes      = $head_arr['noxcodes'] ? 0 : 1;
$images      = $head_arr['noimages'] ? 0 : 1;
$breaks      = $head_arr['nobreak'] ? 1 : 0;
$description =& $xtubemyts->displayTarea($head_arr['description'], $html, $smiley, $xcodes, $images, $breaks);
$xoopsTpl->assign('description', $description);
$moduleHandler = xoops_getHandler('module');
$versioninfo   = $moduleHandler->get($xoopsModule->getVar('mid'));
if ($head_arr['title'] > '') {
    $xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name') . ':&nbsp;' . $head_arr['title']);
} else {
    $xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name'));
}

if ($head_arr['client_id'] > 0) {
    $catarray['imageheader'] = XoopstubeUtilities::xtubeGetBannerFromClientId($head_arr['client_id']);
} elseif ($head_arr['banner_id'] > 0) {
    $catarray['imageheader'] = XoopstubeUtilities::xtubeGetBannerFromBannerId($head_arr['banner_id']);
} else {
    $catarray['imageheader'] = XoopstubeUtilities::xtubeRenderImageHeader();
}
$xoopsTpl->assign('catarray', $catarray);
// Extract linkload information from database
$xoopsTpl->assign('show_categort_title', true);

$orderby0 = (isset($_REQUEST['orderby'])
             && !empty($_REQUEST['orderby'])) ? XoopstubeUtilities::xtubeConvertOrderByIn(htmlspecialchars($_REQUEST['orderby'])) : XoopstubeUtilities::xtubeConvertOrderByIn($GLOBALS['xoopsModuleConfig']['linkxorder']);
$orderby  = XoopsRequest::getString('orderby', '', 'GET') ? XoopstubeUtilities::xtubeConvertOrderByIn(XoopsRequest::getString('orderby', '',
                                                                                                                              'GET')) : XoopstubeUtilities::xtubeConvertOrderByIn($GLOBALS['xoopsModuleConfig']['linkxorder']);

if ($selectdate) {
    $d = date('j', $selectdate);
    $m = date('m', $selectdate);
    $y = date('Y', $selectdate);

    $stat_begin = mktime(0, 0, 0, $m, $d, $y);
    $stat_end   = mktime(23, 59, 59, $m, $d, $y);

    $query  = ' WHERE published>=' . $stat_begin . ' AND published<=' . $stat_end . ' AND (expired=0 OR expired>' . time() . ') AND offline=0 AND cid>0';
    $sql    = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
    $result = $GLOBALS['xoopsDB']->query($sql, $GLOBALS['xoopsModuleConfig']['perpage'], $start);

    $sql = 'SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query;
    list($count) = $GLOBALS['xoopsDB']->fetchRow($GLOBALS['xoopsDB']->query($sql));

    $list_by = 'selectdate=' . $selectdate;
} elseif ($list) {
    $query = " WHERE title LIKE '$list%' AND (published>0 AND published<=" . time() . ') AND (expired=0 OR expired>' . time() . ') AND offline=0 AND cid>0';

    $sql    = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
    $result = $GLOBALS['xoopsDB']->query($sql, $GLOBALS['xoopsModuleConfig']['perpage'], $start);

    $sql = 'SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query;
    list($count) = $GLOBALS['xoopsDB']->fetchRow($GLOBALS['xoopsDB']->query($sql));
    $list_by = "list=$list";
} else {
    $query = 'WHERE a.published>0 AND a.published<=' . time() . ' AND (a.expired=0 OR a.expired>' . time() . ') AND a.offline=0' . ' AND (b.cid=a.cid OR (a.cid=' . $cid . ' OR b.cid=' . $cid . '))';

    $sql    =
        'SELECT DISTINCT a.* FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('xoopstube_altcat') . ' b ON b.lid=a.lid ' . $query . ' ORDER BY '
        . $orderby;
    $result = $GLOBALS['xoopsDB']->query($sql, $GLOBALS['xoopsModuleConfig']['perpage'], $start);

    $sql2 = 'SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('xoopstube_altcat') . ' b ON b.lid=a.lid ' . $query;
    list($count) = $GLOBALS['xoopsDB']->fetchRow($GLOBALS['xoopsDB']->query($sql2));
    $order   = XoopstubeUtilities::xtubeConvertOrderByOut($orderby);
    $list_by = 'cid=' . $cid . '&orderby=' . $order;
    $xoopsTpl->assign('show_categort_title', false);
}
$pagenav = new XoopsPageNav($count, $GLOBALS['xoopsModuleConfig']['perpage'], $start, 'start', $list_by);

// Show links
if ($count > 0) {
    $moderate = 0;
    while (false !== ($video_arr = $GLOBALS['xoopsDB']->fetchArray($result))) {
        if (true === XoopstubeUtilities::xtubeCheckGroups($video_arr['cid'])) {
            require XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/include/videoloadinfo.php';
            $xoopsTpl->append('video', $video);
        }
    }

    unset($video_arr);

    // Show order box
    $xoopsTpl->assign('show_videos', false);
    if ($count > 1 && $cid !== 0) {
        $xoopsTpl->assign('show_videos', true);
        $orderbyTrans = XoopstubeUtilities::xtubeConvertOrderByTrans($orderby);
        $xoopsTpl->assign('lang_cursortedby', sprintf(_MD_XOOPSTUBE_CURSORTBY, XoopstubeUtilities::xtubeConvertOrderByTrans($orderby)));
        $orderby = XoopstubeUtilities::xtubeConvertOrderByOut($orderby);
    }

    // Screenshots display
    $xoopsTpl->assign('show_screenshot', false);
    if (isset($GLOBALS['xoopsModuleConfig']['screenshot']) && $GLOBALS['xoopsModuleConfig']['screenshot'] == 1) {
        $xoopsTpl->assign('shotwidth', $GLOBALS['xoopsModuleConfig']['shotwidth']);
        $xoopsTpl->assign('shotheight', $GLOBALS['xoopsModuleConfig']['shotheight']);
        $xoopsTpl->assign('show_screenshot', true);
    }

    // Nav page render
    $page_nav = $pagenav->renderNav();
    $istrue   = (isset($page_nav) && !empty($page_nav)) ? true : false;
    $xoopsTpl->assign('page_nav', $istrue);
    $xoopsTpl->assign('pagenav', $page_nav);
    $xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
}

$xoopsTpl->assign('cat_columns', $GLOBALS['xoopsModuleConfig']['catcolumns']);

include XOOPS_ROOT_PATH . '/footer.php';


Push — master ( 954431...eec6a1 )

viewcat.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2
3		/**
4		* Module: XoopsTube
5		*
6		* You may not change or alter any portion of this comment or credits
7		* of supporting developers from this source code or any supporting source code
8		* which is considered copyrighted (c) material of the original comment or credit authors.
9		*
10		* PHP version 5
11		*
12		* @category Module
13		* @package Xoopstube
14		* @author XOOPS Development Team
15		* @copyright 2001-2016 XOOPS Project (http://xoops.org)
16		* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
17		* @link http://xoops.org/
18		* @since 1.0.6
19		*/
20
21		include __DIR__ . '/header.php';
22
23		// Begin Main page Heading etc
24		$cid = XoopsRequest::getInt('cid', 0, 'GET'); //xtubeCleanRequestVars($_REQUEST, 'cid', 0);
25		$selectdate = XoopsRequest::getString('selectdate', ''); //xtubeCleanRequestVars($_REQUEST, 'selectdate', '');
26		$list = XoopsRequest::getString('list', '');// xtubeCleanRequestVars($_REQUEST, 'list', '');
27		$start = XoopsRequest::getInt('start', 0, 'GET'); //xtubeCleanRequestVars($_REQUEST, 'start', 0);
28
29		$catsort = $GLOBALS['xoopsModuleConfig']['sortcats'];
30		$mytree = new XoopstubeTree($GLOBALS['xoopsDB']->prefix('xoopstube_cat'), 'cid', 'pid');
31		$arr = $mytree->getFirstChild($cid, $catsort);
32
33		if (is_array($arr) > 0 && !$list && !$selectdate) {
34		if (false === XoopstubeUtilities::xtubeCheckGroups($cid)) {
35		redirect_header('index.php', 1, _MD_XOOPSTUBE_MUSTREGFIRST);
36		}
37		}
38
39		$xoopsOption['template_main'] = 'xoopstube_viewcat.tpl';
40
41		include XOOPS_ROOT_PATH . '/header.php';
42
43		global $xoopsModule;
		0 ignored issues – show Compatibility Best Practice introduced 2016-06-16 09:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
44		//$catarray['letters'] = XoopstubeUtilities::xtubeGetLetters();
45		$catarray['letters'] = XoopstubeUtilities::xoopstubeLettersChoice();
46		$catarray['imageheader'] = XoopstubeUtilities::xtubeRenderImageHeader();
47		$xoopsTpl->assign('catarray', $catarray);
48
49		//$catArray['letters'] = XoopstubeUtilities::xtubeLettersChoice();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-16 09:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50		//$catArray['letters'] = XoopstubeUtilities::xoopstubeLettersChoice();
51		//$catArray['toolbar'] = xoopstube_toolbar();
52		//$xoopsTpl->assign('catarray', $catArray);
53
54		// Breadcrumb
55		$pathstring = '<a href="index.php">' . _MD_XOOPSTUBE_MAIN . '</a> : ';
56		$pathstring .= $mytree->getNicePathFromId($cid, 'title', 'viewcat.php?op=');
57		$xoopsTpl->assign('category_path', $pathstring);
58		$xoopsTpl->assign('category_id', $cid);
59
60		// Display Sub-categories for selected Category
61		if (is_array($arr) > 0 && !$list && !$selectdate) {
62		$scount = 1;
63		foreach ($arr as $ele) {
64		if (false === XoopstubeUtilities::xtubeCheckGroups($ele['cid'])) {
65		continue;
66		}
67		$sub_arr = array();
68		$sub_arr = $mytree->getFirstChild($ele['cid'], $catsort);
69		$space = 1;
70		$chcount = 1;
71		$infercategories = '';
72	View Code Duplication	foreach ($sub_arr as $sub_ele) {
73		// Subitem file count
74		$hassubitems = XoopstubeUtilities::xtubeGetTotalItems($sub_ele['cid']);
75		// Filter group permissions
76		if (true === XoopstubeUtilities::xtubeCheckGroups($sub_ele['cid'])) {
77		// If subcategory count > 5 then finish adding subcats to $infercategories and end
78		if ($chcount > 5) {
79		$infercategories .= '...';
80		break;
81		}
82		if ($space > 0) {
83		$infercategories .= ', ';
84		}
85
86		$infercategories .= '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewcat.php?cid=' . $sub_ele['cid'] . '">'
87		. $xtubemyts->htmlSpecialCharsStrip($sub_ele['title']) . '</a> (' . $hassubitems['count'] . ')';
88		++$space;
89		++$chcount;
90		}
91		}
92		$totalvideos = XoopstubeUtilities::xtubeGetTotalItems($ele['cid']);
93		$indicator = XoopstubeUtilities::xtubeIsNewImage($totalvideos['published']);
94
95		// This code is copyright WF-Projects
96		// Using this code without our permission or removing this code voids the license agreement
97
98		$_image = $ele['imgurl'] ? urldecode($ele['imgurl']) : '';
99	View Code Duplication	if ($_image !== '' && $GLOBALS['xoopsModuleConfig']['usethumbs']) {
100		$_thumb_image = new XtubeThumbsNails($_image, $GLOBALS['xoopsModuleConfig']['catimage'], 'thumbs');
101		if ($_thumb_image) {
102		$_thumb_image->setUseThumbs(1);
103		$_thumb_image->setImageType('gd2');
104		$_image = $_thumb_image->createThumbnail($GLOBALS['xoopsModuleConfig']['shotwidth'], $GLOBALS['xoopsModuleConfig']['shotheight'], $GLOBALS['xoopsModuleConfig']['imagequality'],
105		$GLOBALS['xoopsModuleConfig']['updatethumbs'], $GLOBALS['xoopsModuleConfig']['imageAspect']);
106		}
107		}
108
109	View Code Duplication	if (empty($_image) \|\| '' === $_image) {
110		$imgurl = $indicator['image'];
111		$_width = 33;
112		$_height = 24;
113		} else {
114		$imgurl = "{$GLOBALS['xoopsModuleConfig']['catimage']}/$_image";
115		$_width = $GLOBALS['xoopsModuleConfig']['shotwidth'];
116		$_height = $GLOBALS['xoopsModuleConfig']['shotheight'];
117		}
118		/*
119		* End
120		*/
121
122		$xoopsTpl->append('subcategories', array(
123		'title' => $xtubemyts->htmlSpecialCharsStrip($ele['title']),
124		'id' => $ele['cid'],
125		'image' => XOOPS_URL . "/$imgurl",
126		'width' => $_width,
127		'height' => $_height,
128		'infercategories' => $infercategories,
129		'totalvideos' => $totalvideos['count'],
130		'count' => $scount,
131		'alttext' => $ele['description']
132		));
133		++$scount;
134		}
135		}
136
137		// Show Description for Category listing
138		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_cat') . ' WHERE cid=' . (int)$cid;
139		$head_arr = $GLOBALS['xoopsDB']->fetchArray($GLOBALS['xoopsDB']->query($sql));
140		$html = $head_arr['nohtml'] ? 0 : 1;
141		$smiley = $head_arr['nosmiley'] ? 0 : 1;
142		$xcodes = $head_arr['noxcodes'] ? 0 : 1;
143		$images = $head_arr['noimages'] ? 0 : 1;
144		$breaks = $head_arr['nobreak'] ? 1 : 0;
145		$description =& $xtubemyts->displayTarea($head_arr['description'], $html, $smiley, $xcodes, $images, $breaks);
146		$xoopsTpl->assign('description', $description);
147		$moduleHandler = xoops_getHandler('module');
148		$versioninfo = $moduleHandler->get($xoopsModule->getVar('mid'));
149		if ($head_arr['title'] > '') {
150		$xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name') . ': ' . $head_arr['title']);
151		} else {
152		$xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name'));
153		}
154
155		if ($head_arr['client_id'] > 0) {
156		$catarray['imageheader'] = XoopstubeUtilities::xtubeGetBannerFromClientId($head_arr['client_id']);
157		} elseif ($head_arr['banner_id'] > 0) {
158		$catarray['imageheader'] = XoopstubeUtilities::xtubeGetBannerFromBannerId($head_arr['banner_id']);
159		} else {
160		$catarray['imageheader'] = XoopstubeUtilities::xtubeRenderImageHeader();
161		}
162		$xoopsTpl->assign('catarray', $catarray);
163		// Extract linkload information from database
164		$xoopsTpl->assign('show_categort_title', true);
165
166		$orderby0 = (isset($_REQUEST['orderby'])
167		&& !empty($_REQUEST['orderby'])) ? XoopstubeUtilities::xtubeConvertOrderByIn(htmlspecialchars($_REQUEST['orderby'])) : XoopstubeUtilities::xtubeConvertOrderByIn($GLOBALS['xoopsModuleConfig']['linkxorder']);
168		$orderby = XoopsRequest::getString('orderby', '', 'GET') ? XoopstubeUtilities::xtubeConvertOrderByIn(XoopsRequest::getString('orderby', '',
169		'GET')) : XoopstubeUtilities::xtubeConvertOrderByIn($GLOBALS['xoopsModuleConfig']['linkxorder']);
170
171		if ($selectdate) {
172		$d = date('j', $selectdate);
173		$m = date('m', $selectdate);
174		$y = date('Y', $selectdate);
175
176		$stat_begin = mktime(0, 0, 0, $m, $d, $y);
177		$stat_end = mktime(23, 59, 59, $m, $d, $y);
178
179		$query = ' WHERE published>=' . $stat_begin . ' AND published<=' . $stat_end . ' AND (expired=0 OR expired>' . time() . ') AND offline=0 AND cid>0';
180		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
181		$result = $GLOBALS['xoopsDB']->query($sql, $GLOBALS['xoopsModuleConfig']['perpage'], $start);
182
183		$sql = 'SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query;
184		list($count) = $GLOBALS['xoopsDB']->fetchRow($GLOBALS['xoopsDB']->query($sql));
185
186		$list_by = 'selectdate=' . $selectdate;
187		} elseif ($list) {
188		$query = " WHERE title LIKE '$list%' AND (published>0 AND published<=" . time() . ') AND (expired=0 OR expired>' . time() . ') AND offline=0 AND cid>0';
189
190		$sql = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
191		$result = $GLOBALS['xoopsDB']->query($sql, $GLOBALS['xoopsModuleConfig']['perpage'], $start);
192
193		$sql = 'SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . $query;
194		list($count) = $GLOBALS['xoopsDB']->fetchRow($GLOBALS['xoopsDB']->query($sql));
195		$list_by = "list=$list";
196		} else {
197		$query = 'WHERE a.published>0 AND a.published<=' . time() . ' AND (a.expired=0 OR a.expired>' . time() . ') AND a.offline=0' . ' AND (b.cid=a.cid OR (a.cid=' . $cid . ' OR b.cid=' . $cid . '))';
198
199		$sql =
200		'SELECT DISTINCT a.* FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('xoopstube_altcat') . ' b ON b.lid=a.lid ' . $query . ' ORDER BY '
201		. $orderby;
202		$result = $GLOBALS['xoopsDB']->query($sql, $GLOBALS['xoopsModuleConfig']['perpage'], $start);
203
204		$sql2 = 'SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('xoopstube_altcat') . ' b ON b.lid=a.lid ' . $query;
205		list($count) = $GLOBALS['xoopsDB']->fetchRow($GLOBALS['xoopsDB']->query($sql2));
206		$order = XoopstubeUtilities::xtubeConvertOrderByOut($orderby);
207		$list_by = 'cid=' . $cid . '&orderby=' . $order;
208		$xoopsTpl->assign('show_categort_title', false);
209		}
210		$pagenav = new XoopsPageNav($count, $GLOBALS['xoopsModuleConfig']['perpage'], $start, 'start', $list_by);
211
212		// Show links
213		if ($count > 0) {
214		$moderate = 0;
215		while (false !== ($video_arr = $GLOBALS['xoopsDB']->fetchArray($result))) {
216		if (true === XoopstubeUtilities::xtubeCheckGroups($video_arr['cid'])) {
217		require XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/include/videoloadinfo.php';
218		$xoopsTpl->append('video', $video);
219		}
220		}
221
222		unset($video_arr);
223
224		// Show order box
225		$xoopsTpl->assign('show_videos', false);
226		if ($count > 1 && $cid !== 0) {
227		$xoopsTpl->assign('show_videos', true);
228		$orderbyTrans = XoopstubeUtilities::xtubeConvertOrderByTrans($orderby);
229		$xoopsTpl->assign('lang_cursortedby', sprintf(_MD_XOOPSTUBE_CURSORTBY, XoopstubeUtilities::xtubeConvertOrderByTrans($orderby)));
230		$orderby = XoopstubeUtilities::xtubeConvertOrderByOut($orderby);
231		}
232
233		// Screenshots display
234		$xoopsTpl->assign('show_screenshot', false);
235	View Code Duplication	if (isset($GLOBALS['xoopsModuleConfig']['screenshot']) && $GLOBALS['xoopsModuleConfig']['screenshot'] == 1) {
236		$xoopsTpl->assign('shotwidth', $GLOBALS['xoopsModuleConfig']['shotwidth']);
237		$xoopsTpl->assign('shotheight', $GLOBALS['xoopsModuleConfig']['shotheight']);
238		$xoopsTpl->assign('show_screenshot', true);
239		}
240
241		// Nav page render
242		$page_nav = $pagenav->renderNav();
243		$istrue = (isset($page_nav) && !empty($page_nav)) ? true : false;
244		$xoopsTpl->assign('page_nav', $istrue);
245		$xoopsTpl->assign('pagenav', $page_nav);
246		$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
247		}
248
249		$xoopsTpl->assign('cat_columns', $GLOBALS['xoopsModuleConfig']['catcolumns']);
250
251		include XOOPS_ROOT_PATH . '/footer.php';
252

XoopsModules25x / xoopstube

Push — master ( 954431...eec6a1 )

viewcat.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like