XoopsModules25x /
xoopstube
| Conditions | 23 |
| Paths | 6914 |
| Total Lines | 185 |
| Code Lines | 142 |
| Lines | 12 |
| Ratio | 6.49 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 55 | global $xoopsModule, $pathIcon16; |
||
| 56 | require_once XOOPS_ROOT_PATH . '/class/xoopslists.php'; |
||
| 57 | $db = \XoopsDatabaseFactory::getDatabaseConnection(); |
||
| 58 | xoops_loadLanguage('admin', 'system'); |
||
| 59 | xoops_loadLanguage('admin/blocksadmin', 'system'); |
||
| 60 | xoops_loadLanguage('admin/groups', 'system'); |
||
| 61 | |||
| 62 | /** @var \XoopsModuleHandler $moduleHandler */ |
||
| 63 | $moduleHandler = xoops_getHandler('module'); |
||
| 64 | /** @var \XoopsMemberHandler $memberHandler */ |
||
| 65 | $memberHandler = xoops_getHandler('member'); |
||
| 66 | /** @var \XoopsGroupPermHandler $grouppermHandler */ |
||
| 67 | $grouppermHandler = xoops_getHandler('groupperm'); |
||
| 68 | $groups = $memberHandler->getGroups(); |
||
| 69 | $criteria = new \CriteriaCompo(new \Criteria('hasmain', 1)); |
||
| 70 | $criteria->add(new \Criteria('isactive', 1)); |
||
| 71 | $module_list = $moduleHandler->getList($criteria); |
||
| 72 | $module_list[-1] = _AM_SYSTEM_BLOCKS_TOPPAGE; |
||
| 73 | $module_list[0] = _AM_SYSTEM_BLOCKS_ALLPAGES; |
||
| 74 | ksort($module_list); |
||
| 75 | echo " |
||
| 76 | <h4 style='text-align:left;'>" . _AM_XOOPSTUBE_BADMIN . '</h4>'; |
||
| 77 | /** @var \XoopsModuleHandler $moduleHandler */ |
||
| 78 | $moduleHandler = xoops_getHandler('module'); |
||
|
Unused Code
introduced
by
|
|||
| 79 | echo "<form action='" . $_SERVER['SCRIPT_NAME'] . "' name='blockadmin' method='post'>"; |
||
| 80 | echo $GLOBALS['xoopsSecurity']->getTokenHTML(); |
||
| 81 | echo "<table width='100%' class='outer' cellpadding='4' cellspacing='1'> |
||
| 82 | <tr valign='middle'><th align='center'>" |
||
| 83 | . _AM_XOOPSTUBE_TITLE |
||
| 84 | . "</th><th align='center' nowrap='nowrap'>" |
||
| 85 | . _AM_XOOPSTUBE_SIDE |
||
| 86 | . '<br>' |
||
| 87 | . _LEFT |
||
| 88 | . '-' |
||
| 89 | . _CENTER |
||
| 90 | . '-' |
||
| 91 | . _RIGHT |
||
| 92 | . "</th><th align='center'>" |
||
| 93 | . _AM_XOOPSTUBE_WEIGHT |
||
| 94 | . "</th><th align='center'>" |
||
| 95 | . _AM_XOOPSTUBE_VISIBLE |
||
| 96 | . "</th><th align='center'>" |
||
| 97 | . _AM_SYSTEM_BLOCKS_VISIBLEIN |
||
| 98 | . "</th><th align='center'>" |
||
| 99 | . _AM_SYSTEM_ADGS |
||
| 100 | . "</th><th align='center'>" |
||
| 101 | . _AM_SYSTEM_BLOCKS_BCACHETIME |
||
| 102 | . "</th><th align='center'>" |
||
| 103 | . _AM_XOOPSTUBE_ACTION |
||
| 104 | . '</th></tr> |
||
| 105 | '; |
||
| 106 | $block_arr = \XoopsBlock::getByModule($xoopsModule->mid()); |
||
| 107 | $block_count = count($block_arr); |
||
| 108 | $class = 'even'; |
||
| 109 | $cachetimes = [ |
||
| 110 | '0' => _NOCACHE, |
||
| 111 | '30' => sprintf(_SECONDS, 30), |
||
| 112 | '60' => _MINUTE, |
||
| 113 | '300' => sprintf(_MINUTES, 5), |
||
| 114 | '1800' => sprintf(_MINUTES, 30), |
||
| 115 | '3600' => _HOUR, |
||
| 116 | '18000' => sprintf(_HOURS, 5), |
||
| 117 | '86400' => _DAY, |
||
| 118 | '259200' => sprintf(_DAYS, 3), |
||
| 119 | '604800' => _WEEK, |
||
| 120 | '2592000' => _MONTH, |
||
| 121 | ]; |
||
| 122 | foreach ($block_arr as $i) { |
||
| 123 | $groups_perms = $grouppermHandler->getGroupIds('block_read', $i->getVar('bid')); |
||
| 124 | $sql = 'SELECT module_id FROM ' . $db->prefix('block_module_link') . ' WHERE block_id=' . $i->getVar('bid'); |
||
| 125 | $result = $db->query($sql); |
||
| 126 | $modules = []; |
||
| 127 | while (false !== ($row = $db->fetchArray($result))) { |
||
| 128 | $modules[] = (int)$row['module_id']; |
||
| 129 | } |
||
| 130 | |||
| 131 | $cachetime_options = ''; |
||
| 132 | foreach ($cachetimes as $cachetime => $cachetime_name) { |
||
| 133 | if ($i->getVar('bcachetime') == $cachetime) { |
||
| 134 | $cachetime_options .= "<option value='$cachetime' selected='selected'>$cachetime_name</option>\n"; |
||
| 135 | } else { |
||
| 136 | $cachetime_options .= "<option value='$cachetime'>$cachetime_name</option>\n"; |
||
| 137 | } |
||
| 138 | } |
||
| 139 | |||
| 140 | $sel0 = $sel1 = $ssel0 = $ssel1 = $ssel2 = $ssel3 = $ssel4 = $ssel5 = $ssel6 = $ssel7 = ''; |
||
| 141 | if (1 === $i->getVar('visible')) { |
||
| 142 | $sel1 = ' checked'; |
||
| 143 | } else { |
||
| 144 | $sel0 = ' checked'; |
||
| 145 | } |
||
| 146 | if (XOOPS_SIDEBLOCK_LEFT === $i->getVar('side')) { |
||
| 147 | $ssel0 = ' checked'; |
||
| 148 | } elseif (XOOPS_SIDEBLOCK_RIGHT === $i->getVar('side')) { |
||
| 149 | $ssel1 = ' checked'; |
||
| 150 | } elseif (XOOPS_CENTERBLOCK_LEFT === $i->getVar('side')) { |
||
| 151 | $ssel2 = ' checked'; |
||
| 152 | } elseif (XOOPS_CENTERBLOCK_RIGHT === $i->getVar('side')) { |
||
| 153 | $ssel4 = ' checked'; |
||
| 154 | } elseif (XOOPS_CENTERBLOCK_CENTER === $i->getVar('side')) { |
||
| 155 | $ssel3 = ' checked'; |
||
| 156 | } elseif (XOOPS_CENTERBLOCK_BOTTOMLEFT === $i->getVar('side')) { |
||
| 157 | $ssel5 = ' checked'; |
||
| 158 | } elseif (XOOPS_CENTERBLOCK_BOTTOMRIGHT === $i->getVar('side')) { |
||
| 159 | $ssel6 = ' checked'; |
||
| 160 | } elseif (XOOPS_CENTERBLOCK_BOTTOM === $i->getVar('side')) { |
||
| 161 | $ssel7 = ' checked'; |
||
| 162 | } |
||
| 163 | if ('' === $i->getVar('title')) { |
||
| 164 | $title = ' '; |
||
| 165 | } else { |
||
| 166 | $title = $i->getVar('title'); |
||
| 167 | } |
||
| 168 | $name = $i->getVar('name'); |
||
| 169 | echo "<tr valign='top'><td class='$class' align='center'><input type='text' name='title[" |
||
| 170 | . $i->getVar('bid') |
||
| 171 | . "]' value='" |
||
| 172 | . $title |
||
| 173 | . "'></td><td class='$class' align='center' nowrap='nowrap'> |
||
| 174 | <div align='center' > |
||
| 175 | <input type='radio' name='side[" |
||
| 176 | . $i->getVar('bid') |
||
| 177 | . "]' value='" |
||
| 178 | . XOOPS_CENTERBLOCK_LEFT |
||
| 179 | . "'$ssel2> |
||
| 180 | <input type='radio' name='side[" |
||
| 181 | . $i->getVar('bid') |
||
| 182 | . "]' value='" |
||
| 183 | . XOOPS_CENTERBLOCK_CENTER |
||
| 184 | . "'$ssel3> |
||
| 185 | <input type='radio' name='side[" |
||
| 186 | . $i->getVar('bid') |
||
| 187 | . "]' value='" |
||
| 188 | . XOOPS_CENTERBLOCK_RIGHT |
||
| 189 | . "'$ssel4> |
||
| 190 | </div> |
||
| 191 | <div> |
||
| 192 | <span style='float:right;'><input type='radio' name='side[" |
||
| 193 | . $i->getVar('bid') |
||
| 194 | . "]' value='" |
||
| 195 | . XOOPS_SIDEBLOCK_RIGHT |
||
| 196 | . "'$ssel1></span> |
||
| 197 | <div align='left'><input type='radio' name='side[" |
||
| 198 | . $i->getVar('bid') |
||
| 199 | . "]' value='" |
||
| 200 | . XOOPS_SIDEBLOCK_LEFT |
||
| 201 | . "'$ssel0></div> |
||
| 202 | </div> |
||
| 203 | <div align='center'> |
||
| 204 | <input type='radio' name='side[" |
||
| 205 | . $i->getVar('bid') |
||
| 206 | . "]' value='" |
||
| 207 | . XOOPS_CENTERBLOCK_BOTTOMLEFT |
||
| 208 | . "'$ssel5> |
||
| 209 | <input type='radio' name='side[" |
||
| 210 | . $i->getVar('bid') |
||
| 211 | . "]' value='" |
||
| 212 | . XOOPS_CENTERBLOCK_BOTTOM |
||
| 213 | . "'$ssel7> |
||
| 214 | <input type='radio' name='side[" |
||
| 215 | . $i->getVar('bid') |
||
| 216 | . "]' value='" |
||
| 217 | . XOOPS_CENTERBLOCK_BOTTOMRIGHT |
||
| 218 | . "'$ssel6> |
||
| 219 | </div> |
||
| 220 | </td><td class='$class' align='center'><input type='text' name='weight[" |
||
| 221 | . $i->getVar('bid') |
||
| 222 | . "]' value='" |
||
| 223 | . $i->getVar('weight') |
||
| 224 | . "' size='5' maxlength='5'></td><td class='$class' align='center' nowrap><input type='radio' name='visible[" |
||
| 225 | . $i->getVar('bid') |
||
| 226 | . "]' value='1'$sel1>" |
||
| 227 | . _YES |
||
| 228 | . " <input type='radio' name='visible[" |
||
| 229 | . $i->getVar('bid') |
||
| 230 | . "]' value='0'$sel0>" |
||
| 231 | . _NO |
||
| 232 | . '</td>'; |
||
| 233 | |||
| 234 | echo "<td class='$class' align='center'><select size='5' name='bmodule[" . $i->getVar('bid') . "][]' id='bmodule[" . $i->getVar('bid') . "][]' multiple='multiple'>"; |
||
| 235 | foreach ($module_list as $k => $v) { |
||
| 236 | echo "<option value='$k'" . (in_array($k, $modules) ? " selected='selected'" : '') . ">$v</option>"; |
||
| 237 | } |
||
| 238 | echo '</select></td>'; |
||
| 239 | |||
| 240 | echo "<td class='$class' align='center'><select size='5' name='groups[" . $i->getVar('bid') . "][]' id='groups[" . $i->getVar('bid') . "][]' multiple='multiple'>"; |
||
| 571 |
Loading history...