xoopstube_top.php ➔ getThumbsTopVideoBlock() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ca430...3024c9 )

by Michael

created 2016-06-01 04:12 UTC

xoopstube_top.php ➔ getThumbsTopVideoBlock() D

↳ Parent: Project

Complexity

Conditions	10
Paths	512

Size

Total Lines	57
Code Lines	37

Duplication

Lines	22
Ratio	38.6 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	37
c	1
b	0
f	0
nc	512
nop	5
dl	22
loc	57
rs	4.847

How to fix Long Method Complexity

<?php
/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @category        Module
 * @package         Xoopstube
 * @author          XOOPS Development Team
 * @copyright       2001-2013 The XOOPS Project
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @version         $Id$
 * @link            http://sourceforge.net/projects/xoops/
 * @since           1.0.6
 */

/**
 * @param int    $cid
 * @param string $permType
 * @param bool   $redirect
 *
 * @return bool

 */
function checkBlockGroups($cid = 0, $permType = 'XTubeCatPerm', $redirect = false)

{
    $mydirname = basename(dirname(__DIR__));
    global $xoopsUser;
function myFunction($a, $b) {
    // Do something
}

    $groups         = is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
    $gperm_handler  = & xoops_gethandler('groupperm');
    $module_handler = & xoops_gethandler('module');
    $module         = & $module_handler->getByDirname($mydirname);
    if (!$gperm_handler->checkRight($permType, $cid, $groups, $module->getVar('mid'))) {
        if ($redirect == false) {

            return false;
        } else {
            redirect_header('index.php', 3, _NOPERM);
            exit();

        }
    }
    unset($module);

    return true;
}

/**
 * @param int    $cid
 * @param string $permType
 * @param bool   $redirect
 *
 * @return bool
 */
function xtubeCheckBlockGroups($cid = 0, $permType = 'XTubeCatPerm', $redirect = false)
{
    $mydirname = basename(dirname(__DIR__));
    global $xoopsUser;
function myFunction($a, $b) {
    // Do something
}

    $groups        = is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
    $modhandler    = xoops_gethandler('module');
    $xtubeModule   = $modhandler->getByDirname($mydirname);
    $gperm_handler = & xoops_gethandler('groupperm');
    if (!$gperm_handler->checkRight($permType, $cid, $groups, $xtubeModule->getVar('mid'))) {
        if ($redirect == false) {

            return false;
        }
    }

    return true;
}

/**
 * @param       $bvidid
 * @param       $btitle
 * @param       $bsource
 * @param       $bpicurl
 * @param array $size
 *
 * @return string
 */
function getThumbsTopVideoBlock($bvidid, $btitle, $bsource, $bpicurl, $size = array())
{
    $thumbb            = '';
    $modhandler        = xoops_gethandler('module');
    $xtubeModule       = $modhandler->getByDirname('xoopstube');
    $config_handler    = xoops_gethandler('config');
    $xtubeModuleConfig = $config_handler->getConfigsByCat(0, $xtubeModule->getVar('mid'));
    if (isset($size['shotwidth'])) {
        $xtubeModuleConfig['shotwidth'] = $size['shotwidth'];
    }
    if (isset($size['shotheight'])) {
        $xtubeModuleConfig['shotheight'] = $size['shotheight'];
    }
// Determine if video source YouTube
    if ($bsource == 0) {

        $thumbb
            = '<img src="http://img.youtube.com/vi/' . $bvidid . '/default.jpg" title="' . $btitle . '" alt="' . $btitle . '" width="' . $xtubeModuleConfig['shotwidth'] . '" height="'
            . $xtubeModuleConfig['shotheight'] . '"  border="0" />';
    }
    // Determine if video source MetaCafe
    if ($bsource == 1) {
        list($metaclip) = explode('[/]', $bvidid);
        $videothumb['metathumb'] = $metaclip;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $thumbb
                                 =
            '<img src="http://www.metacafe.com/thumb/' . $videothumb['metathumb'] . '.jpg" title="' . $btitle . '" alt="' . $btitle . '" width="' . $xtubeModuleConfig['shotwidth'] . '" height="'
            . $xtubeModuleConfig['shotheight'] . '"  border="0" />';
    }
// Determine if video source iFilm/Spike
    if ($bsource == 2) {
        $thumbb = '<img src="http://img2.ifilmpro.com/resize/image/stills/films/resize/istd/' . $bvidid . '.jpg?width=' . $xtubeModuleConfig['shotwidth'] . ' title="' . $btitle . '" alt="' . $btitle
            . '" border="0" />';
    }
// Determine if video source Photobucket
    if ($bsource == 3) {

        $thumbb
            = '<img src="http://i153.photobucket.com/albums/' . $bvidid . '.jpg" title="' . $btitle . '" alt="' . $btitle . '" width="' . $xtubeModuleConfig['shotwidth'] . '" height="'
            . $xtubeModuleConfig['shotheight'] . '"  border="0" />';
    }
// Determine if video source Google Video / MySpace TV / DailyMotion
    if ($bsource == 100) {

        $thumbb = '<img src="' . $bpicurl . '" title="' . $btitle . '" alt="' . $btitle . '" width="' . $xtubeModuleConfig['shotwidth'] . '" height="' . $xtubeModuleConfig['shotheight']
            . '"  border="0" />';
    }
// Determine if video source MySpace TV
    if ($bsource == 101) {

        $thumbb = '<img src="' . $bpicurl . '" title="' . $btitle . '" alt="' . $btitle . '" width="' . $xtubeModuleConfig['shotwidth'] . '" height="' . $xtubeModuleConfig['shotheight']
            . '"  border="0" />';
    }
// Determine if video source DailyMotion
    if ($bsource == 102) {

        $thumbb = '<img src="' . $bpicurl . '" title="' . $btitle . '" alt="' . $btitle . '" width="' . $xtubeModuleConfig['shotwidth'] . '" height="' . $xtubeModuleConfig['shotheight']
            . '"  border="0" />';
    }

    return $thumbb;
}

/* Function: b_xoopstube_spotlight_show
 * Input   : $options[0] = date for the most recent videos
 * 			   hits for the most popular videos
 *           $block['content'] = The optional above content
 *           $options[1] = How many videos are displayes
 * Output  : Returns the most recent or most popular videos
 */
/**
 * @param $options
 *
 * @return array

 */
function getSpotlightVideos($options)
{
    global $xoopsDB, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
    include_once dirname(__DIR__) . '/include/video.php';
    $block             = array();
    $modhandler        = xoops_gethandler('module');
    $xtubeModule       = $modhandler->getByDirname('xoopstube');
    $config_handler    = xoops_gethandler('config');
    $xtubeModuleConfig = $config_handler->getConfigsByCat(0, $xtubeModule->getVar('mid'));
    $xtubemyts         = & MyTextSanitizer :: getInstance();

    $options[1] = 4;
    $result     = $xoopsDB->query(
        "SELECT lid, cid, title, vidid, date, hits, vidsource, picurl FROM " . $xoopsDB->prefix('xoopstube_videos') . " WHERE published > 0 AND published <= " . time()
        . " AND (expired = 0 OR expired > " . time() . ") AND offline = 0 ORDER BY " . $options[0] . " DESC",
        $options[1],
        0
    );

    $i = 0;
    while ($myrow = $xoopsDB->fetchArray($result)) {
        if (false == checkBlockGroups($myrow['cid']) || $myrow['cid'] == 0) {

            continue;
        }
        if (xtubeCheckBlockGroups($myrow['cid']) == false) {

            exit;

        }
        $videoload = array();
        $title     = $xtubemyts->htmlSpecialChars($xtubemyts->stripSlashesGPC($myrow["title"]));
        if (!XOOPS_USE_MULTIBYTES) {

            if (strlen($myrow['title']) >= $options[2]) {
                $title = substr($myrow['title'], 0, ($options[2] - 1)) . "...";
            }
        }
        $videoload['id']    = intval($myrow['lid']);
        $videoload['cid']   = intval($myrow['cid']);
        $videoload['title'] = $title;
        if ($options[0] == "date") {

            $videoload['date'] = formatTimestamp($myrow['date'], $xtubeModuleConfig['dateformat']);
        } elseif ($options[0] == "hits") {
            $videoload['hits'] = $myrow['hits'];
        }

        $size               = array();
        $rate               = 425 / 350;
        $size['shotwidth']  = '100';
        $size['shotheight'] = intval($size['shotwidth'] / $rate);

        if ($i == 0 && $myrow['vidsource'] == 0) {
            $videowidth  = 340;
            $videoheight = intval($videowidth / $rate);
            $showvideo
                                    = '<object width="' . $videowidth . '" height="' . $videoheight . '"><param name="movie" value="http://www.youtube.com/v/' . $myrow['vidid']
                . '"></param><param name="wmode" value="transparent"></param><embed src="http://www.youtube.com/v/' . $myrow['vidid']
                . '" type="application/x-shockwave-flash" wmode="transparent" width="' . $videowidth . '" height="' . $videoheight . '"></embed></object>';
            $videoload['showvideo'] = $showvideo;
        }

        $videoload['videothumb'] = getThumbsTopVideoBlock(
            $myrow['vidid'],
            $title,
            $myrow['vidsource'],
            $myrow['picurl'],
            $size
        );

        $videoload['dirname'] = $xtubeModule->getVar('dirname');
        $block['videos'][]    = $videoload;
        ++$i;
    }
    unset($_block_check_array);

    return $block;
}

// Function: showTopVideoBlock
// Input   : $options[0] = date for the most recent videos
// 			   hits for the most popular videos
//           $block['content'] = The optional above content
//           $options[1] = How many videos are displayes
//           $options[2] = Length of title
//           $options[3] = Set date format
// Output  : Returns the most recent or most popular videos
/**
 * @param $options
 *
 * @return array

 */
function showTopVideoBlock($options)
{
    global $xoopsDB, $xoopsModule, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
    $mydirname         = basename(dirname(__DIR__));
    $block             = array();
    $modhandler        = xoops_gethandler('module');
    $xtubeModule       = $modhandler->getByDirname($mydirname);
    $config_handler    = xoops_gethandler('config');
    $xtubeModuleConfig = $config_handler->getConfigsByCat(0, $xtubeModule->getVar('mid'));
    $xtubemyts         = & MyTextSanitizer :: getInstance();

    if (isset($options[4]) && ($options[4] > 0)) {
        $result = $xoopsDB->query(
            'SELECT lid, cid, title, vidid, screenshot, published, hits, vidsource, picurl FROM ' . $xoopsDB->prefix(
                'xoopstube_videos'
            ) . ' WHERE published>0
                                    AND published<=' . time() . '
                                    AND (expired=0 OR expired>' . time() . ')
                                    AND offline=0
                                    AND cid=' . $options[4] . '
                                    ORDER BY ' . $options[0] . '
                                    DESC',
            $options[1],
            0
        );
    } else {
        $result = $xoopsDB->query(
            'SELECT lid, cid, title, vidid, screenshot, published, hits, vidsource, picurl FROM ' . $xoopsDB->prefix(
                'xoopstube_videos'
            ) . ' WHERE published>0
                                    AND published<=' . time() . '
                                    AND (expired=0 OR expired>' . time() . ')
                                    AND offline=0
                                    ORDER BY ' . $options[0] . '
                                    DESC',
            $options[1],
            0
        );
    }

    include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/video.php';
    include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/functions.php';

    while ($myrow = $xoopsDB->fetchArray($result)) {

        if (false == checkBlockGroups($myrow['cid']) || $myrow['cid'] == 0) {

            continue;
        }

        if (xtubeCheckBlockGroups($myrow['cid']) == false) {

            exit;

        }

        $videoload = array();
        $title     = $xtubemyts->htmlSpecialChars($xtubemyts->stripSlashesGPC($myrow['title']));
        if (!XOOPS_USE_MULTIBYTES) {

            if (strlen($myrow['title']) >= $options[2]) {
                $title = substr($myrow['title'], 0, ($options[2] - 1)) . '...';
            }
        }
        $videoload['id']    = intval($myrow['lid']);
        $videoload['cid']   = intval($myrow['cid']);
        $videoload['title'] = $title;
        if ($options[0] == 'published') {

            $videoload['date'] = xtubeGetTimestamp(formatTimestamp($myrow['published'], $options[3]));
        } elseif ($options[0] == 'hits') {
            $videoload['hits'] = $myrow['hits'];
        }

        $videoload['videothumb'] = xtubeGetVideoThumb(
            $myrow['vidid'],
            $title,
            $myrow['vidsource'],
            $myrow['picurl'],
            $xtubeModuleConfig['videoimgdir'] . '/' . $myrow['screenshot'],
            $xtubeModuleConfig['shotwidth'],
            $xtubeModuleConfig['shotheight']
        );
        $videoload['dirname']    = $xtubeModule->getVar('dirname');
        $videoload['width']      = $xtubeModuleConfig['shotwidth'] + 2;
        $block['videos'][]       = $videoload;
    }
    unset($_block_check_array);

    return $block;
}

// Function: getRandomVideo
// Output  : Returns random video
/**
 * @param $options
 *
 * @return array
 */
function getRandomVideo($options)
{
    global $xoopsDB, $xoopsModuleConfig, $xtubemyts;
function myFunction($a, $b) {
    // Do something
}
    $mydirname         = basename(dirname(__DIR__));
    $block             = array();
    $modhandler        = xoops_gethandler('module');
    $xtubeModule       = $modhandler->getByDirname($mydirname);
    $config_handler    = xoops_gethandler('config');
    $xtubeModuleConfig = $config_handler->getConfigsByCat(0, $xtubeModule->getVar('mid'));
    $xtubemyts         = & MyTextSanitizer :: getInstance();

    if (isset($options[4]) && ($options[4] > 0)) {

        $result2 = $xoopsDB->query(
            'SELECT lid, cid, title, vidid, screenshot, published, vidsource, picurl FROM ' . $xoopsDB->prefix(
                'xoopstube_videos'
            ) . ' WHERE published > 0
                                    AND published<=' . time() . '
                                    AND (expired=0 OR expired>' . time() . ')
                                    AND offline=0
                                    AND cid=' . $options[4] . '
                                    ORDER BY RAND() LIMIT ' . $options[1]
        );
    } else {
        $result2 = $xoopsDB->query(
            'SELECT lid, cid, title, vidid, screenshot, published, vidsource, picurl FROM ' . $xoopsDB->prefix(
                'xoopstube_videos'
            ) . ' WHERE published > 0
                                    AND published<=' . time() . '
                                    AND (expired=0 OR expired>' . time() . ')
                                    AND offline=0
                                    ORDER BY RAND() LIMIT ' . $options[1]
        );
    }

    include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/video.php';
    include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/functions.php';

    while ($myrow = $xoopsDB->fetchArray($result2)) {

        if (false == checkBlockGroups($myrow['cid']) || $myrow['cid'] == 0) {

            continue;
        }
        $videorandom = array();
        $title       = $xtubemyts->htmlSpecialChars($xtubemyts->stripSlashesGPC($myrow['title']));
        if (!XOOPS_USE_MULTIBYTES) {

            if (strlen($myrow['title']) >= $options[2]) {
                $title = substr($myrow['title'], 0, ($options[2] - 1)) . '...';
            }
        }
        $videorandom['id']    = intval($myrow['lid']);
        $videorandom['cid']   = intval($myrow['cid']);
        $videorandom['title'] = $title;
        if (isset($options[3])) {

            $videorandom['date'] = xtubeGetTimestamp(formatTimestamp($myrow['published'], $options[3]));
        }
        $videorandom['videothumb'] = xtubeGetVideoThumb(
            $myrow['vidid'],
            $myrow['title'],
            $myrow['vidsource'],
            $myrow['picurl'],
            $xtubeModuleConfig['videoimgdir'] . '/' . $myrow['screenshot'],
            $xtubeModuleConfig['shotwidth'],
            $xtubeModuleConfig['shotheight']
        );
        $videorandom['dirname']    = $xtubeModule->getVar('dirname');
        $videorandomh['width']     = $xtubeModuleConfig['shotwidth'] + 2;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $block['random'][]         = $videorandom;
    }
    unset($_block_check_array);

    return $block;
}

// Function: b_xoopstube_random_h
// Output  : Returns random video in horizontal block
/**
 * @param $options
 *
 * @return array
 */
function getRandomVideoForHorizontalBlock($options)
{
    global $xoopsDB, $xoopsModuleConfig, $xtubemyts;
function myFunction($a, $b) {
    // Do something
}
    $mydirname         = basename(dirname(__DIR__));
    $block             = array();
    $modhandler        = xoops_gethandler('module');
    $xtubeModule       = $modhandler->getByDirname($mydirname);
    $config_handler    = xoops_gethandler('config');
    $xtubeModuleConfig = $config_handler->getConfigsByCat(0, $xtubeModule->getVar('mid'));
    $xtubemyts         = & MyTextSanitizer :: getInstance();

    if (isset($options[4]) && ($options[4] > 0)) {

        $result2 = $xoopsDB->query(
            'SELECT lid, cid, title, vidid, screenshot, published, vidsource, picurl FROM ' . $xoopsDB->prefix(
                'xoopstube_videos'
            ) . ' WHERE published > 0
                                    AND published<=' . time() . '
                                    AND (expired=0 OR expired>' . time() . ')
                                    AND offline=0
                                    AND cid=' . $options[4] . '
                                    ORDER BY RAND() LIMIT ' . $options[1]
        );
    } else {
        $result2 = $xoopsDB->query(
            'SELECT lid, cid, title, vidid, screenshot, published, vidsource, picurl FROM ' . $xoopsDB->prefix(
                'xoopstube_videos'
            ) . ' WHERE published > 0
                                    AND published<=' . time() . '
                                    AND (expired=0 OR expired>' . time() . ')
                                    AND offline=0
                                    ORDER BY RAND() LIMIT ' . $options[1]
        );
    }

    include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/video.php';
    include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/functions.php';

    while ($myrow = $xoopsDB->fetchArray($result2)) {

        if (false == checkBlockGroups($myrow['cid']) || $myrow['cid'] == 0) {

            continue;
        }
        $videorandomh            = array();
        $title                   = $xtubemyts->htmlSpecialChars($xtubemyts->stripSlashesGPC($myrow['title']));
        $videorandomh['balloon'] = $myrow['title'];
        if (!XOOPS_USE_MULTIBYTES) {

            if (strlen($myrow['title']) >= $options[2]) {
                $title = substr($myrow['title'], 0, ($options[2] - 1)) . '...';
            }
        }
        $videorandomh['id']    = intval($myrow['lid']);
        $videorandomh['cid']   = intval($myrow['cid']);
        $videorandomh['title'] = $title;
        if (isset($options[3])) {

            $videorandomh['date'] = xtubeGetTimestamp(formatTimestamp($myrow['published'], $options[3]));
        }
        include_once XOOPS_ROOT_PATH . '/modules/' . $xtubeModule->getVar('dirname') . '/include/video.php';
        $videorandomh['videothumb'] = xtubeGetVideoThumb(
            $myrow['vidid'],
            $myrow['title'],
            $myrow['vidsource'],
            $myrow['picurl'],
            $xtubeModuleConfig['videoimgdir'] . '/' . $myrow['screenshot'],
            $xtubeModuleConfig['shotwidth'],
            $xtubeModuleConfig['shotheight']
        );
        $videorandomh['dirname']    = $xtubeModule->getVar('dirname');
        $videorandomh['width']      = $xtubeModuleConfig['shotwidth'] + 2;
        $block['random'][]          = $videorandomh;
    }
    unset($_block_check_array);

    return $block;
}

// editTopVideoBlock()
// @param $options
// @return
/**
 * @param $options
 *
 * @return string
 */
function editTopVideoBlock($options)
{
    $form = '' . _MB_XOOPSTUBE_DISP . '&nbsp;';
    $form .= "<input type='hidden' name='options[]' value='";
    if ($options[0] == "published") {
        $form .= "published'";
    }
    if ($options[0] == "random") {
        $form .= "random'";
    }
    if ($options[0] == "randomh") {
        $form .= "randomh'";
    } else {
        $form .= "hits'";
    }
    $form .= " />";
    $form .= "<input type='text' name='options[]' value='" . $options[1] . "' />&nbsp;" . _MB_XOOPSTUBE_FILES . "";
    $form .= "&nbsp;<br />" . _MB_XOOPSTUBE_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "' />&nbsp;" . _MB_XOOPSTUBE_LENGTH . "";
    $form .= "&nbsp;<br />" . _MB_XOOPSTUBE_DATEFORMAT . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "' />&nbsp;" . _MB_XOOPSTUBE_DATEFORMATMANUAL;

    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $cat_arr = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    include_once XOOPS_ROOT_PATH . '/modules/xoopstube/class/xoopstubetree.php';
    $xt      = new XoopstubeTree($xoopsDB->prefix('xoopstube_cat'), 'cid', 'pid');
    $cat_arr = $xt->getChildTreeArray(0, 'title');

    $form .= "<br />" . _MB_XOOPSTUBE_SELECTCAT . "<br /><select name=\"options[]\" multiple=\"multiple\" size=\"5\">";
    if (array_search(0, $options) === false) {
        $form .= "<option value=\"0\">" . _MB_XOOPSTUBE_ALLCAT . "</option>";
    } else {
        $form .= "<option value=\"0\" selected=\"selected\">" . _MB_XOOPSTUBE_ALLCAT . "</option>";
    }

    foreach ($cat_arr as $catlist) {
        if (array_search($catlist, $options) === false) {
            $form .= "<option value=\"" . $catlist['cid'] . "\">" . $catlist['title'] . "</option>";
        } else {
            $form
                .= "<option value=\"" . $catlist['cid'] . "\" selected=\"selected\">" . $catlist['title'] . "</option>";
        }
    }
    $form .= "</select>";

    return $form;
}


Push — master ( 8ca430...3024c9 )

xoopstube_top.php ➔ getThumbsTopVideoBlock() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		/**
3		* Module: XoopsTube
4		*
5		* You may not change or alter any portion of this comment or credits
6		* of supporting developers from this source code or any supporting source code
7		* which is considered copyrighted (c) material of the original comment or credit authors.
8		*
9		* PHP version 5
10		*
11		* @category Module
12		* @package Xoopstube
13		* @author XOOPS Development Team
14		* @copyright 2001-2013 The XOOPS Project
15		* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
16		* @version $Id$
17		* @link http://sourceforge.net/projects/xoops/
18		* @since 1.0.6
19		*/
20
21		/**
22		* @param int $cid
23		* @param string $permType
24		* @param bool $redirect
25		*
26		* @return bool
		0 ignored issues – show Documentation introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report Should the return type not be `null\|boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
27		*/
28	View Code Duplication	function checkBlockGroups($cid = 0, $permType = 'XTubeCatPerm', $redirect = false)
		0 ignored issues – show Duplication introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$mydirname = basename(dirname(__DIR__));
31		global $xoopsUser;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
32
33		$groups = is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
34		$gperm_handler = & xoops_gethandler('groupperm');
35		$module_handler = & xoops_gethandler('module');
36		$module = & $module_handler->getByDirname($mydirname);
37		if (!$gperm_handler->checkRight($permType, $cid, $groups, $module->getVar('mid'))) {

XoopsModules25x / xoopstube

Push — master ( 8ca430...3024c9 )

xoopstube_top.php ➔ getThumbsTopVideoBlock() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like