blocksadmin.php ➔ isBlockCloned() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ca430...3024c9 )

by Michael

created 2016-06-01 04:12 UTC

blocksadmin.php ➔ isBlockCloned() C

↳ Parent: Project

Complexity

Conditions	12
Paths	106

Size

Total Lines	70
Code Lines	55

Duplication

Lines	12
Ratio	17.14 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	12
eloc	55
c	2
b	0
f	0
nc	106
nop	7
dl	12
loc	70
rs	5.4955

How to fix Long Method Complexity

<?php

/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @category        Module
 * @package         Xoopstube
 * @author          Fernando Santos (topet05), [email protected]
 * @copyright       Mastop InfoDigital (c) 2003-2007
 * @link            http://www.mastop.com.br
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @since           1.0.6
 * @version         $Id$
 */

include_once __DIR__ . '/admin_header.php';
if (!is_object($xoopsUser) || !is_object($xoopsModule) || !$xoopsUser->isAdmin($xoopsModule->mid())) {
    exit(_AM_XOOPSTUBE_ERROR403);
}
if ($xoopsUser->isAdmin($xoopsModule->mid())) {
    include_once XOOPS_ROOT_PATH . '/class/xoopsblock.php';
    $op = "list";
    if (isset($_POST)) {
        foreach ($_POST as $k => $v) {
            $$k = $v;
        }
    }

    if (isset($_GET['op'])) {
        if ($_GET['op'] == "edit" || $_GET['op'] == "delete" || $_GET['op'] == "delete_ok" || $_GET['op'] == "clone"
            || $_GET['op'] == "edit"
        ) {
            $op  = $_GET['op'];
            $bid = isset($_GET['bid']) ? intval($_GET['bid']) : 0;
        }
    }

    /**
     *
     */
    function listBlocks()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $xoopsUser, $xoopsConfig, $xoopsModule, $pathIcon16;
function myFunction($a, $b) {
    // Do something
}
        include_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
        $db =& XoopsDatabaseFactory::getDatabaseConnection();
        if (file_exists(

            XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php"
        )
        ) {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php");
            //include_once(XOOPS_ROOT_PATH."/modules/system/language/".$xoopsConfig['language']."/admin/groups.php");

        } else {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/blocksadmin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/groups.php");
        }
        $module_handler     =& xoops_gethandler('module');
        $member_handler     =& xoops_gethandler('member');
        $moduleperm_handler =& xoops_gethandler('groupperm');
        $groups             =& $member_handler->getGroups();
        $criteria           = new CriteriaCompo(new Criteria('hasmain', 1));
        $criteria->add(new Criteria('isactive', 1));
        $module_list     =& $module_handler->getList($criteria);
        $module_list[-1] = _AM_SYSTEM_BLOCKS_TOPPAGE;
        $module_list[0]  = _AM_SYSTEM_BLOCKS_ALLPAGES;
        ksort($module_list);
        echo "
        <h4 style='text-align:left;'>" . _AM_XOOPSTUBE_BADMIN . "</h4>";
        $module_handler =& xoops_gethandler('module');
        echo "<form action='" . $_SERVER['PHP_SELF'] . "' name='blockadmin' method='post'>
        <table width='100%' class='outer' cellpadding='4' cellspacing='1'>
        <tr valign='middle'><th align='center'>" . _AM_XOOPSTUBE_TITLE . "</th><th align='center' nowrap='nowrap'>" . _AM_XOOPSTUBE_SIDE . "<br />" . _LEFT . "-" . _CENTER . "-" . _RIGHT
            . "</th><th align='center'>" . _AM_XOOPSTUBE_WEIGHT . "</th><th align='center'>" . _AM_XOOPSTUBE_VISIBLE . "</th><th align='center'>" . _AM_SYSTEM_BLOCKS_VISIBLEIN
            . "</th><th align='center'>" . _AM_SYSTEM_ADGS . "</th><th align='center'>" . _AM_SYSTEM_BLOCKS_BCACHETIME . "</th><th align='center'>" . _AM_XOOPSTUBE_ACTION . "</th></tr>
        ";
        $block_arr   =& XoopsBlock::getByModule($xoopsModule->mid());
        $block_count = count($block_arr);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $class       = 'even';
        $cachetimes  = array(
            '0'       => _NOCACHE,
            '30'      => sprintf(_SECONDS, 30),
            '60'      => _MINUTE,
            '300'     => sprintf(_MINUTES, 5),
            '1800'    => sprintf(_MINUTES, 30),
            '3600'    => _HOUR,
            '18000'   => sprintf(_HOURS, 5),
            '86400'   => _DAY,
            '259200'  => sprintf(_DAYS, 3),
            '604800'  => _WEEK,
            '2592000' => _MONTH
        );
        foreach ($block_arr as $i) {
            $groups_perms =& $moduleperm_handler->getGroupIds('block_read', $i->getVar("bid"));
            $sql
                          = 'SELECT module_id FROM ' . $db->prefix('block_module_link') . ' WHERE block_id=' . $i->getVar("bid");
            $result       = $db->query($sql);
            $modules      = array();
            while ($row = $db->fetchArray($result)) {
                $modules[] = intval($row['module_id']);
            }

            $cachetime_options = '';
            foreach ($cachetimes as $cachetime => $cachetime_name) {
                if ($i->getVar('bcachetime') == $cachetime) {
                    $cachetime_options .= "<option value='$cachetime' selected='selected'>$cachetime_name</option>\n";
                } else {
                    $cachetime_options .= "<option value='$cachetime'>$cachetime_name</option>\n";
                }
            }

            $sel0 = $sel1 = $ssel0 = $ssel1 = $ssel2 = $ssel3 = $ssel4 = $ssel5 = $ssel6 = $ssel7 = "";
            if ($i->getVar("visible") == 1) {
                $sel1 = " checked='checked'";
            } else {
                $sel0 = " checked='checked'";
            }
            if ($i->getVar("side") == XOOPS_SIDEBLOCK_LEFT) {
                $ssel0 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_SIDEBLOCK_RIGHT) {
                $ssel1 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_CENTERBLOCK_LEFT) {
                $ssel2 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_CENTERBLOCK_RIGHT) {
                $ssel4 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_CENTERBLOCK_CENTER) {
                $ssel3 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_CENTERBLOCK_BOTTOMLEFT) {
                $ssel5 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_CENTERBLOCK_BOTTOMRIGHT) {
                $ssel6 = " checked='checked'";
            } elseif ($i->getVar("side") == XOOPS_CENTERBLOCK_BOTTOM) {
                $ssel7 = " checked='checked'";
            }
            if ($i->getVar("title") == "") {
                $title = "&nbsp;";
            } else {
                $title = $i->getVar("title");
            }
            $name = $i->getVar("name");
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            echo "<tr valign='top'><td class='$class' align='center'><input type='text' name='title[" . $i->getVar("bid") . "]' value='" . $title . "'></td><td class='$class' align='center' nowrap='nowrap'>
                    <div align='center' >
                    <input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_CENTERBLOCK_LEFT . "'$ssel2 />
                        <input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_CENTERBLOCK_CENTER . "'$ssel3 />
                    <input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_CENTERBLOCK_RIGHT . "'$ssel4 />
                    </div>
                    <div>
                        <span style='float:right'><input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_SIDEBLOCK_RIGHT . "'$ssel1 /></span>
                    <div align='left'><input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_SIDEBLOCK_LEFT . "'$ssel0 /></div>
                    </div>
                    <div align='center'>
                    <input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_CENTERBLOCK_BOTTOMLEFT . "'$ssel5 />
                        <input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_CENTERBLOCK_BOTTOM . "'$ssel7 />
                    <input type='radio' name='side[" . $i->getVar("bid") . "]' value='" . XOOPS_CENTERBLOCK_BOTTOMRIGHT . "'$ssel6 />
                    </div>
                </td><td class='$class' align='center'><input type='text' name='weight[" . $i->getVar("bid") . "]' value='" . $i->getVar("weight") . "' size='5' maxlength='5' /></td><td class='$class' align='center' nowrap><input type='radio' name='visible["
                . $i->getVar("bid") . "]' value='1'$sel1>" . _YES . "&nbsp;<input type='radio' name='visible[" . $i->getVar("bid") . "]' value='0'$sel0>" . _NO . "</td>";

            echo "<td class='$class' align='center'><select size='5' name='bmodule[" . $i->getVar("bid") . "][]' id='bmodule[" . $i->getVar("bid") . "][]' multiple='multiple'>";
            foreach ($module_list as $k => $v) {
                echo "<option value='$k'" . ((in_array($k, $modules)) ? " selected='selected'" : "") . ">$v</option>";
            }
            echo "</select></td>";

            echo "<td class='$class' align='center'><select size='5' name='groups[" . $i->getVar("bid") . "][]' id='groups[" . $i->getVar("bid") . "][]' multiple='multiple'>";
            foreach ($groups as $grp) {
                echo "<option value='" . $grp->getVar('groupid') . "' " . ((in_array(
                        $grp->getVar('groupid'),
                        $groups_perms
                    )) ? " selected='selected'" : "") . ">" . $grp->getVar('name') . "</option>";
            }
            echo "</select></td>";

            // Cache lifetime
            echo '<td class="' . $class . '" align="center"> <select name="bcachetime[' . $i->getVar("bid") . ']" size="1">' . $cachetime_options . '</select>
                                    </td>';

// Actions

            echo
                "<td class='$class' align='center'><a href='blocksadmin.php?op=edit&amp;bid=" . $i->getVar("bid") . "'><img src=" . $pathIcon16 . '/edit.png' . " alt='" . _EDIT . "' title='" . _EDIT . "' />
                 </a> <a href='blocksadmin.php?op=clone&amp;bid=" . $i->getVar("bid") . "'><img src=" . $pathIcon16 . '/editcopy.png' . " alt='" . _CLONE . "' title='" . _CLONE . "' />
                 </a>";
            if ($i->getVar('block_type') != 'S' && $i->getVar('block_type') != 'M') {
                echo "&nbsp;<a href='" . XOOPS_URL . "/modules/system/admin.php?fct=blocksadmin&amp;op=delete&amp;bid=" . $i->getVar("bid") . "'><img src=" . $pathIcon16 . '/delete.png' . " alt='"
                    . _DELETE . "' title='" . _DELETE . "' />
                     </a>";
            }
            echo "
            <input type='hidden' name='oldtitle[" . $i->getVar("bid") . "]' value='" . $i->getVar('title') . "' />
            <input type='hidden' name='oldside[" . $i->getVar("bid") . "]' value='" . $i->getVar('side') . "' />
            <input type='hidden' name='oldweight[" . $i->getVar("bid") . "]' value='" . $i->getVar('weight') . "' />
            <input type='hidden' name='oldvisible[" . $i->getVar("bid") . "]' value='" . $i->getVar('visible') . "' />
            <input type='hidden' name='oldgroups[" . $i->getVar("groups") . "]' value='" . $i->getVar('groups') . "' />
            <input type='hidden' name='oldbcachetime[" . $i->getVar("bid") . "]' value='" . $i->getVar('bcachetime') . "' />
            <input type='hidden' name='bid[" . $i->getVar("bid") . "]' value='" . $i->getVar("bid") . "' />
            </td></tr>
            ";
            $class = ($class == 'even') ? 'odd' : 'even';
        }
        echo "<tr><td class='foot' align='center' colspan='7'>
        <input type='hidden' name='op' value='order' />
        " . $GLOBALS['xoopsSecurity']->getTokenHTML() . "
        <input type='submit' name='submit' value='" . _SUBMIT . "' />
        </td></tr></table>
        </form>
        <br /><br />";
    }

    /**
     * @param $bid
     */
    function cloneBlock($bid)
    {
        include_once __DIR__ . '/admin_header.php';
        //include_once __DIR__ . '/admin_header.php';

        xoops_cp_header();

        global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}

//xoops_loadLanguage('admin', XTUBE_DIRNAME);

//xoops_loadLanguage('modinfo', XTUBE_DIRNAME);
//xoops_loadLanguage('main', XTUBE_DIRNAME);

        if (file_exists(

            XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php"
        )
        ) {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/groups.php");
        } else {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/blocksadmin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/groups.php");
        }
//        mpu_adm_menu();
        $myblock = new XoopsBlock($bid);
        $db      =& XoopsDatabaseFactory::getDatabaseConnection();
        $sql     = 'SELECT module_id FROM ' . $db->prefix('block_module_link') . ' WHERE block_id=' . intval($bid);
        $result  = $db->query($sql);
        $modules = array();
        while ($row = $db->fetchArray($result)) {
            $modules[] = intval($row['module_id']);
        }
        $is_custom = ($myblock->getVar('block_type') == 'C' || $myblock->getVar('block_type') == 'E') ? true : false;
        $block     = array(
            'title'      => $myblock->getVar('title') . ' Clone',
            'form_title' => _AM_XOOPSTUBE_BLOCKS_CLONEBLOCK,
            'name'       => $myblock->getVar('name'),
            'side'       => $myblock->getVar('side'),
            'weight'     => $myblock->getVar('weight'),
            'visible'    => $myblock->getVar('visible'),
            'content'    => $myblock->getVar('content', 'N'),
            'modules'    => $modules,
            'is_custom'  => $is_custom,
            'ctype'      => $myblock->getVar('c_type'),
            'bcachetime' => $myblock->getVar('bcachetime'),
            'op'         => 'clone_ok',
            'bid'        => $myblock->getVar('bid'),
            'edit_form'  => $myblock->getOptions(),
            'template'   => $myblock->getVar('template'),
            'options'    => $myblock->getVar('options')
        );
        echo '<a href="blocksadmin.php">' . _AM_BADMIN . '</a>&nbsp;<span style="font-weight:bold;">&raquo;&raquo;</span>&nbsp;' . _AM_SYSTEM_BLOCKS_CLONEBLOCK . '<br /><br />';
        include __DIR__ . '/blockform.php';
        $form->display();

//        xoops_cp_footer();
        include_once __DIR__ . '/admin_footer.php';
        exit();

    }

    /**
     * @param $bid
     * @param $bside
     * @param $bweight
     * @param $bvisible
     * @param $bcachetime
     * @param $bmodule
     * @param $options
     */
    function isBlockCloned($bid, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $xoopsUser, $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
        if (file_exists(

            XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php"
        )
        ) {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php");
            //include_once(XOOPS_ROOT_PATH."/modules/system/language/".$xoopsConfig['language']."/admin/groups.php");

        } else {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/blocksadmin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/groups.php");
        }
        $block = new XoopsBlock($bid);
        $clone =& $block->xoopsClone();
        if (empty($bmodule)) {
            xoops_cp_header();
            xoops_error(sprintf(_AM_NOTSELNG, _AM_VISIBLEIN));
            xoops_cp_footer();
            exit();

        }
        $clone->setVar('side', $bside);
        $clone->setVar('weight', $bweight);
        $clone->setVar('visible', $bvisible);
        //$clone->setVar('content', $_POST['bcontent']);

        $clone->setVar('title', $_POST['btitle']);
        $clone->setVar('bcachetime', $bcachetime);
        if (isset($options) && (count($options) > 0)) {
            $options = implode('|', $options);
            $clone->setVar('options', $options);
        }
        $clone->setVar('bid', 0);
        if ($block->getVar('block_type') == 'C' || $block->getVar('block_type') == 'E') {
            $clone->setVar('block_type', 'E');
        } else {
            $clone->setVar('block_type', 'D');
        }
        $newid = $clone->store();
        if (!$newid) {
            xoops_cp_header();
            $clone->getHtmlErrors();
            xoops_cp_footer();
            exit();

        }
        if ($clone->getVar('template') != '') {
            $tplfile_handler =& xoops_gethandler('tplfile');
            $btemplate       =& $tplfile_handler->find($GLOBALS['xoopsConfig']['template_set'], 'block', $bid);
            if (count($btemplate) > 0) {
                $tplclone =& $btemplate[0]->xoopsClone();
                $tplclone->setVar('tpl_id', 0);
                $tplclone->setVar('tpl_refid', $newid);
                $tplfile_handler->insert($tplclone);
            }
        }
        $db =& XoopsDatabaseFactory::getDatabaseConnection();
        foreach ($bmodule as $bmid) {
            $sql = 'INSERT INTO ' . $db->prefix('block_module_link') . ' (block_id, module_id) VALUES (' . $newid . ', ' . $bmid . ')';
            $db->query($sql);
        }
        $groups =& $xoopsUser->getGroups();
        $count  = count($groups);
        for ($i = 0; $i < $count; ++$i) {
            $sql
                = "INSERT INTO " . $db->prefix('group_permission') . " (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES (" . $groups[$i] . ", " . $newid . ", 1, 'block_read')";
            $db->query($sql);
        }
        redirect_header('blocksadmin.php?op=listar', 1, _AM_DBUPDATED);
    }

    /**
     * @param $bid
     * @param $title
     * @param $weight
     * @param $visible
     * @param $side
     * @param $bcachetime
     */
    function xtubeSetOrder($bid, $title, $weight, $visible, $side, $bcachetime)
    {
        $myblock = new XoopsBlock($bid);
        $myblock->setVar('title', $title);
        $myblock->setVar('weight', $weight);
        $myblock->setVar('visible', $visible);
        $myblock->setVar('side', $side);
        $myblock->setVar('bcachetime', $bcachetime);
        $myblock->store();
    }

    /**
     * @param $bid
     */
    function xtubeEditBlock($bid)
    {
        include_once __DIR__ . '/admin_header.php';
        //include_once __DIR__ . '/admin_header.php';

        xoops_cp_header();

        global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}

//xoops_loadLanguage('admin', XTUBE_DIRNAME);

//xoops_loadLanguage('modinfo', XTUBE_DIRNAME);
//xoops_loadLanguage('main', XTUBE_DIRNAME);

        if (file_exists(

            XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php"
        )
        ) {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/blocksadmin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/" . $xoopsConfig['language'] . "/admin/groups.php");
        } else {
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/blocksadmin.php");
            include_once(XOOPS_ROOT_PATH . "/modules/system/language/portuguesebr/admin/groups.php");
        }
//        mpu_adm_menu();
        $myblock = new XoopsBlock($bid);
        $db      =& XoopsDatabaseFactory::getDatabaseConnection();
        $sql     = 'SELECT module_id FROM ' . $db->prefix('block_module_link') . ' WHERE block_id=' . intval($bid);
        $result  = $db->query($sql);
        $modules = array();
        while ($row = $db->fetchArray($result)) {
            $modules[] = intval($row['module_id']);
        }
        $is_custom = ($myblock->getVar('block_type') == 'C' || $myblock->getVar('block_type') == 'E') ? true : false;
        $block     = array(
            'title'      => $myblock->getVar('title'),
            'form_title' => _AM_XOOPSTUBE_BLOCKS_EDITBLOCK,
            //        'name'       => $myblock->getVar('name'),

            'side'       => $myblock->getVar('side'),
            'weight'     => $myblock->getVar('weight'),
            'visible'    => $myblock->getVar('visible'),
            'content'    => $myblock->getVar('content', 'N'),
            'modules'    => $modules,
            'is_custom'  => $is_custom,
            'ctype'      => $myblock->getVar('c_type'),
            'bcachetime' => $myblock->getVar('bcachetime'),
            'op'         => 'edit_ok',
            'bid'        => $myblock->getVar('bid'),
            'edit_form'  => $myblock->getOptions(),
            'template'   => $myblock->getVar('template'),
            'options'    => $myblock->getVar('options')
        );
        echo '<a href="blocksadmin.php">' . _AM_BADMIN . '</a>&nbsp;<span style="font-weight:bold;">&raquo;&raquo;</span>&nbsp;' . _AM_SYSTEM_BLOCKS_EDITBLOCK . '<br /><br />';
        include 'blockform.php';
        $form->display();

//        xoops_cp_footer();
        include_once __DIR__ . '/admin_footer.php';
        exit();

    }

    /**
     * @param $bid
     * @param $btitle
     * @param $bside
     * @param $bweight
     * @param $bvisible
     * @param $bcachetime
     * @param $bmodule
     * @param $options
     * @param $groups
     */
    function xtubeUpdateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $myblock = new XoopsBlock($bid);
        $myblock->setVar('title', $btitle);
        $myblock->setVar('weight', $bweight);
        $myblock->setVar('visible', $bvisible);
        $myblock->setVar('side', $bside);
        $myblock->setVar('bcachetime', $bcachetime);
        $myblock->store();

        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        if (!empty($bmodule) && count($bmodule) > 0) {
            $sql = sprintf("DELETE FROM %s WHERE block_id = %u", $xoopsDB->prefix('block_module_link'), $bid);
            $xoopsDB->query($sql);
            if (in_array(0, $bmodule)) {
                $sql = sprintf(
                    "INSERT INTO %s (block_id, module_id) VALUES (%u, %d)",
                    $xoopsDB->prefix('block_module_link'),
                    $bid,
                    0
                );
                $xoopsDB->query($sql);
            } else {

                foreach ($bmodule as $bmid) {
                    $sql = sprintf(
                        "INSERT INTO %s (block_id, module_id) VALUES (%u, %d)",
                        $xoopsDB->prefix('block_module_link'),
                        $bid,
                        intval($bmid)
                    );
                    $xoopsDB->query($sql);
                }
            }
        }
        $sql = sprintf("DELETE FROM %s WHERE gperm_itemid = %u", $xoopsDB->prefix('group_permission'), $bid);
        $xoopsDB->query($sql);
        if (!empty($groups)) {
            foreach ($groups as $grp) {

                $sql = sprintf(
                    "INSERT INTO %s (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES (%u, %u, 1, 'block_read')",
                    $xoopsDB->prefix('group_permission'),
                    $grp,
                    $bid
                );
                $xoopsDB->query($sql);
            }
        }
        redirect_header($_SERVER['PHP_SELF'], 1, _AM_XOOPSTUBE_UPDATE_SUCCESS);
        exit();

    }

    if ($op == "list") {
        xoops_cp_header();
//        mpu_adm_menu();
        listBlocks();
        include_once __DIR__ . '/admin_footer.php';
        exit();
    }

    if ($op == "order") {
        if (!$GLOBALS['xoopsSecurity']->check()) {
            redirect_header($_SERVER['PHP_SELF'], 3, implode('<br />', $GLOBALS['xoopsSecurity']->getErrors()));
            exit();
        }
        foreach (array_keys($bid) as $i) {
            if ($oldtitle[$i] != $title[$i] || $oldweight[$i] != $weight[$i] || $oldvisible[$i] != $visible[$i]
                || $oldside[$i] != $side[$i]
                || $oldbcachetime[$i] != $bcachetime[$i]
            ) {
                xtubeSetOrder(
                    $bid[$i],
                    $title[$i],
                    $weight[$i],
                    $visible[$i],
                    $side[$i],
                    $bcachetime[$i],
                    $bmodule[$i]

                );
            }
            if (!empty($bmodule[$i]) && count($bmodule[$i]) > 0) {
                $sql = sprintf("DELETE FROM %s WHERE block_id = %u", $xoopsDB->prefix('block_module_link'), $bid[$i]);
                $xoopsDB->query($sql);
                if (in_array(0, $bmodule[$i])) {
                    $sql = sprintf(
                        "INSERT INTO %s (block_id, module_id) VALUES (%u, %d)",
                        $xoopsDB->prefix('block_module_link'),
                        $bid[$i],
                        0
                    );
                    $xoopsDB->query($sql);
                } else {

                    foreach ($bmodule[$i] as $bmid) {
                        $sql = sprintf(
                            "INSERT INTO %s (block_id, module_id) VALUES (%u, %d)",
                            $xoopsDB->prefix('block_module_link'),
                            $bid[$i],
                            intval($bmid)
                        );
                        $xoopsDB->query($sql);
                    }
                }
            }
            $sql = sprintf("DELETE FROM %s WHERE gperm_itemid = %u", $xoopsDB->prefix('group_permission'), $bid[$i]);
            $xoopsDB->query($sql);
            if (!empty($groups[$i])) {
                foreach ($groups[$i] as $grp) {

                    $sql = sprintf(
                        "INSERT INTO %s (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES (%u, %u, 1, 'block_read')",
                        $xoopsDB->prefix('group_permission'),
                        $grp,
                        $bid[$i]
                    );
                    $xoopsDB->query($sql);
                }
            }
        }
        redirect_header($_SERVER['PHP_SELF'], 1, _AM_XOOPSTUBE_UPDATE_SUCCESS);
        exit();
    }
    if ($op == 'clone') {
        cloneBlock($bid);
    }

    if ($op == 'edit') {
        xtubeEditBlock($bid);
    }

    if ($op == 'edit_ok') {
        xtubeUpdateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups);

    }

    if ($op == 'clone_ok') {
        isBlockCloned($bid, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options);
    }
} else {
    echo _AM_XOOPSTUBE_ERROR403;
}


Push — master ( 8ca430...3024c9 )

blocksadmin.php ➔ isBlockCloned() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-01 04:15 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 46 and the first side effect is on line 26. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Module: XoopsTube
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			*
9			* PHP version 5
10			*
11			* @category Module
12			* @package Xoopstube
13			* @author Fernando Santos (topet05), [email protected]
14			* @copyright Mastop InfoDigital (c) 2003-2007
15			* @link http://www.mastop.com.br
16			* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
17			* @since 1.0.6
18			* @version $Id$
19			*/
20
21			include_once __DIR__ . '/admin_header.php';
22			if (!is_object($xoopsUser) \|\| !is_object($xoopsModule) \|\| !$xoopsUser->isAdmin($xoopsModule->mid())) {
23			exit(_AM_XOOPSTUBE_ERROR403);
24			}
25			if ($xoopsUser->isAdmin($xoopsModule->mid())) {
26			include_once XOOPS_ROOT_PATH . '/class/xoopsblock.php';
27			$op = "list";
28			if (isset($_POST)) {
29			foreach ($_POST as $k => $v) {
30			$$k = $v;
31			}
32			}
33
34			if (isset($_GET['op'])) {
35			if ($_GET['op'] == "edit" \|\| $_GET['op'] == "delete" \|\| $_GET['op'] == "delete_ok" \|\| $_GET['op'] == "clone"
36			\|\| $_GET['op'] == "edit"
37			) {
38			$op = $_GET['op'];
39			$bid = isset($_GET['bid']) ? intval($_GET['bid']) : 0;

XoopsModules25x / xoopstube

Push — master ( 8ca430...3024c9 )

blocksadmin.php ➔ isBlockCloned() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like