DirectoryChecker::createDirectory() - Code Metrics - Inspection of "remove travis" - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ca430...3024c9 )

by Michael

created 2016-06-01 04:12 UTC

DirectoryChecker::createDirectory() A

↳ Parent: DirectoryChecker

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	3
eloc	3
c	2
b	0
f	0
nc	3
nop	2
dl	0
loc	22
rs	9.2

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */
/**
 * WF-Downloads module
 *
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package         wfdownload
 * @since           3.23
 * @author          Xoops Development Team
 * @version         svn:$id$
 */

//defined('XOOPS_ROOT_PATH') || die('XOOPS Root Path not defined');


require_once dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';

/**
 * Class DirectoryChecker
 * check status of a directory
 */
class DirectoryChecker
namespace YourVendor;

class YourClass { }
{
    /**
     * @param       $path
     * @param int   $mode
     * @param array $languageConstants
     * @param       $redirectFile
     *
     * @return bool|string
     */
    public static function getDirectoryStatus($path, $mode = 0777, $languageConstants = array(), $redirectFile)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $pathIcon16;
function myFunction($a, $b) {
    // Do something
}

        $languageConstants1 = array($languageConstants[5], $languageConstants[6]);
        $languageConstants2 = array($languageConstants[7], $languageConstants[8]);

        $myWords1 = urlencode(json_encode($languageConstants1));
        $myWords2 = urlencode(json_encode($languageConstants2));

        if (empty($path)) {
            return false;
        }
        if (!@is_dir($path)) {
            $path_status
                = "<img src='" . $pathIcon16 . "/0.png'   >" . $path . ' ( ' . $languageConstants[1] . ' ) ' . "<a href=" . $_SERVER['PHP_SELF'] . "?op=dashboard&dircheck=createdir&amp;path=$path&amp;redirect=$redirectFile&amp;languageConstants=$myWords1>"
                . $languageConstants[2] . '</a>';
        } elseif (@is_writable($path)) {
            $path_status = "<img src='" . $pathIcon16 . "/1.png'   >" . $path . ' ( ' . $languageConstants[0] . ' ) ';
            $currentMode = (substr(decoct(fileperms($path)), 2));
            if ($currentMode != decoct($mode)) {
                $path_status = "<img src='" . $pathIcon16 . "/0.png'   >" . $path . sprintf(
                        $languageConstants[3],
                        decoct($mode),
                        $currentMode
                    ) . "<a href=" . $_SERVER['PHP_SELF'] . "?op=dashboard&dircheck=setperm&amp;mode=$mode&amp;path=$path&amp;redirect=$redirectFile&amp;languageConstants=$myWords2> "
                    . $languageConstants[4] . '</a>';
            }
        } else {
            $currentMode = (substr(decoct(fileperms($path)), 2));
            $path_status = "<img src='" . $pathIcon16 . "/0.png'   >" . $path . sprintf(
                    $languageConstants[3],
                    decoct($mode),
                    $currentMode
                ) . "<a href=" . $_SERVER['PHP_SELF'] . "?mode&amp;path=$path&amp;redirect=$redirectFile&amp;languageConstants=$myWords2> " . $languageConstants[4] . '</a>';
        }

        return $path_status;
    }

    /**
     * @param     $target
     * @param int $mode
     *
     * @return bool
     */
    public static function createDirectory($target, $mode = 0777)
    {
        $target = str_replace("..", "", $target);
        // http://www.php.net/manual/en/function.mkdir.php
        /*

                $dirs = array();

                while (realpath($target) === false && !empty($target)) {
                    array_unshift($dirs, basename($target));
                    $target = dirname($target);
                };
                $target = realpath($target);
        // this next test should handle bug on BSD with PHP < 5.3.0
                if (!is_dir($target)) {
                    array_unshift($dirs, basename($target));
                    $target = realpath(dirname($target));
                }

        */

        return is_dir($target) or (self::createDirectory(dirname($target), $mode) and mkdir($target, $mode));
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
    }

    /**
     * @param     $target
     * @param int $mode
     *
     * @return bool
     */
    public static function setDirectoryPermissions($target, $mode = 0777)
    {
        $target = str_replace("..", "", $target);

        return @chmod($target, (int)$mode);
    }
}

$dircheck = (isset($_GET['dircheck'])) ? filter_input(INPUT_GET, 'dircheck', FILTER_SANITIZE_STRING) : "";

switch ($dircheck) {
    case "createdir":
        $languageConstants = array();
        if (isset($_GET['path'])) {
            $path = filter_input(INPUT_GET, 'path', FILTER_SANITIZE_STRING);
        }
        if (isset($_GET['redirect'])) {
            $redirect = filter_input(INPUT_GET, 'redirect', FILTER_SANITIZE_STRING);
        }
        if (isset($_GET['languageConstants'])) {
            $languageConstants = json_decode($_GET['languageConstants']);
        }
        $result = DirectoryChecker::createDirectory($path);
        $msg    = ($result) ? $languageConstants[0] : $languageConstants[1];
        redirect_header($redirect, 2, $msg . ': ' . $path);
        exit();
        break;
    case "setperm":
        $languageConstants = array();
        if (isset($_GET['path'])) {
            $path = filter_input(INPUT_GET, 'path', FILTER_SANITIZE_STRING);
        }
        if (isset($_GET['mode'])) {
            $mode = filter_input(INPUT_GET, 'mode', FILTER_SANITIZE_STRING);
        }
        if (isset($_GET['redirect'])) {
            $redirect = filter_input(INPUT_GET, 'redirect', FILTER_SANITIZE_STRING);
        }
        if (isset($_GET['languageConstants'])) {
            $languageConstants = json_decode($_GET['languageConstants']);
        }
        $result = DirectoryChecker::setDirectoryPermissions($path, $mode);
        $msg    = ($result) ? $languageConstants[0] : $languageConstants[1];
        redirect_header($redirect, 2, $msg . ': ' . $path);
        exit();
        break;
}


Push — master ( 8ca430...3024c9 )

DirectoryChecker::createDirectory() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

XoopsModules25x / xoopstube

Push — master ( 8ca430...3024c9 )

DirectoryChecker::createDirectory() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like