XoopstubeLists::value() - Code Metrics - Inspection of "Merge pull request #14 from trabisdementia/Bleek" - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (ddc2b8)

by Michael

created 2017-05-19 09:37 UTC

XoopstubeLists::value() A

↳ Parent: XoopstubeLists

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @category        Module
 * @package         Xoopstube
 * @author          XOOPS Development Team
 * @copyright       2001-2016 XOOPS Project (http://xoops.org)
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @link            http://xoops.org/
 * @since           1.0.6
 */
class XoopstubeLists
namespace YourVendor;

class YourClass { }
{
    public $value;
    public $selected;
    public $path = 'uploads';
    public $size;
    public $emptyselect;
    public $type;
    public $prefix;
    public $suffix;

    /**
     * @param string $path
     * @param null   $value
     * @param string $selected
     * @param int    $size
     * @param int    $emptyselect
     * @param int    $type
     * @param string $prefix
     * @param string $suffix
     */
    public function __construct(
        $path = 'uploads',
        $value = null,
        $selected = '',
        $size = 1,
        $emptyselect = 0,
        $type = 0,
        $prefix = '',

        $suffix = ''

    ) {
        $this->value       = $value;
        $this->selection   = $selected;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->path        = $path;
        $this->size        = (int)$size;
        $this->emptyselect = $emptyselect ? 0 : 1;
        $this->type        = $type;
    }

    /**
     * @param $this_array
     *
     * @return string
     */
    public function &getarray($this_array)

    {
        $ret = "<select size='" . $this->size() . "' name='$this->value()'>";
        if ($this->emptyselect) {
            $ret .= "<option value='" . $this->value() . "'>----------------------</option>";
        }
        foreach ($this_array as $content) {
            $opt_selected = '';

            if ($content[0] == $this->isSelected()) {
                $opt_selected = "selected='selected'";
            }
            $ret .= "<option value='" . $content . "' $opt_selected>" . $content . '</option>';
        }
        $ret .= '</select>';

        return $ret;
    }

    /**
     * Private to be called by other parts of the class
     *
     * @param $dirname
     *
     * @return array
     */
    public function &getDirListAsArray($dirname)
    {
        $dirlist = array();
        if (is_dir($dirname) && $handle = opendir($dirname)) {
            while (false !== ($file = readdir($handle))) {
                if (!preg_match("/^[.]{1,2}$/", $file)) {
                    if (strtolower($file) !== 'cvs' && is_dir($dirname . $file)) {
                        $dirlist[$file] = $file;
                    }
                }
            }
            closedir($handle);

            reset($dirlist);
        }

        return $dirlist;
    }

    /**
     * @param        $dirname
     * @param string $type
     * @param string $prefix
     * @param int    $noselection
     *
     * @return array
     */
    public static function &getListTypeAsArray($dirname, $type = '', $prefix = '', $noselection = 1)
    {
        $filelist = array();
        switch (trim($type)) {
            case 'images':
                $types = '[.gif|.jpg|.png]';
                if ($noselection) {
                    $filelist[''] = _AM_XOOPSTUBE_NOIMAGE;
                }
                break;
            case 'media':
                $types = '[.aac|.flv|.mp3|.mp4|.swf]';
                if ($noselection) {
                    $filelist[''] = _AM_XOOPSTUBE_NOVIDEO;
                }
                break;
            case 'html':
                $types = '[.htm|.tpl|.html|.xhtml|.php|.php3|.phtml|.txt]';
                if ($noselection) {
                    $filelist[''] = _AM_XOOPSTUBE_NOSELECT;
                }
                break;
            default:
                $types = '';
                if ($noselection) {
                    $filelist[''] = _AM_XOOPSTUBE_NOFILESELECT;
                }
                break;
        }

        if ('/' === substr($dirname, -1)) {
            $dirname = substr($dirname, 0, -1);
        }

        if (is_dir($dirname) && $handle = opendir($dirname)) {
            while (false !== ($file = readdir($handle))) {
                if (!preg_match("/^[.]{1,2}$/", $file) && preg_match("/$types$/i", $file) && is_file($dirname . '/' . $file)) {
                    if ('blank.gif' === strtolower($file)) {
                        continue;
                    }
                    $file            = $prefix . $file;
                    $filelist[$file] = $file;
                }
            }
            closedir($handle);
            asort($filelist);
            reset($filelist);
        }

        return $filelist;
    }

    /**
     * @return null
     */
    public function value()
    {
        return $this->value;
    }

    public function isSelected()

    {
        return $this->selected;
    }

    /**
     * @return string
     */
    public function paths()
    {
        return $this->path;
    }

    /**
     * @return int
     */
    public function size()
    {
        return $this->size;
    }

    /**
     * @return int
     */
    public function isEmptySelect()
    {
        return $this->emptyselect;
    }

    /**
     * @return int
     */
    public function getType()
    {
        return $this->type;
    }

    public function getPrefix()

    {
        return $this->prefix;
    }

    public function getSuffix()

    {
        return $this->suffix;
    }
}


1		<?php
2
3		/**
4		* Module: XoopsTube
5		*
6		* You may not change or alter any portion of this comment or credits
7		* of supporting developers from this source code or any supporting source code
8		* which is considered copyrighted (c) material of the original comment or credit authors.
9		*
10		* PHP version 5
11		*
12		* @category Module
13		* @package Xoopstube
14		* @author XOOPS Development Team
15		* @copyright 2001-2016 XOOPS Project (http://xoops.org)
16		* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
17		* @link http://xoops.org/
18		* @since 1.0.6
19		*/
20		class XoopstubeLists
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
21		{
22		public $value;
23		public $selected;
24		public $path = 'uploads';
25		public $size;
26		public $emptyselect;
27		public $type;
28		public $prefix;
29		public $suffix;
30
31		/**
32		* @param string $path
33		* @param null $value
34		* @param string $selected
35		* @param int $size
36		* @param int $emptyselect
37		* @param int $type
38		* @param string $prefix
39		* @param string $suffix
40		*/
41		public function __construct(
42		$path = 'uploads',
43		$value = null,
44		$selected = '',
45		$size = 1,
46		$emptyselect = 0,
47		$type = 0,
48		$prefix = '',
		0 ignored issues – show Unused Code introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report The parameter `$prefix` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
49		$suffix = ''
		0 ignored issues – show Unused Code introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report The parameter `$suffix` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
50		) {
51		$this->value = $value;
52		$this->selection = $selected;
		0 ignored issues – show Bug introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report The property `selection` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53		$this->path = $path;
54		$this->size = (int)$size;
55		$this->emptyselect = $emptyselect ? 0 : 1;
56		$this->type = $type;
57		}
58
59		/**
60		* @param $this_array
61		*
62		* @return string
63		*/
64	View Code Duplication	public function &getarray($this_array)
		0 ignored issues – show Duplication introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$ret = "<select size='" . $this->size() . "' name='$this->value()'>";
67		if ($this->emptyselect) {
68		$ret .= "<option value='" . $this->value() . "'>----------------------</option>";
69		}
70		foreach ($this_array as $content) {
71		$opt_selected = '';
72
73		if ($content[0] == $this->isSelected()) {
74		$opt_selected = "selected='selected'";
75		}
76		$ret .= "<option value='" . $content . "' $opt_selected>" . $content . '</option>';
77		}
78		$ret .= '</select>';
79
80		return $ret;
81		}
82
83		/**
84		* Private to be called by other parts of the class
85		*
86		* @param $dirname
87		*
88		* @return array
89		*/
90		public function &getDirListAsArray($dirname)
91		{
92		$dirlist = array();
93		if (is_dir($dirname) && $handle = opendir($dirname)) {
94		while (false !== ($file = readdir($handle))) {
95		if (!preg_match("/^[.]{1,2}$/", $file)) {
96		if (strtolower($file) !== 'cvs' && is_dir($dirname . $file)) {
97		$dirlist[$file] = $file;
98		}
99		}
100		}
101		closedir($handle);
102
103		reset($dirlist);
104		}
105
106		return $dirlist;
107		}
108
109		/**
110		* @param $dirname
111		* @param string $type
112		* @param string $prefix
113		* @param int $noselection
114		*
115		* @return array
116		*/
117		public static function &getListTypeAsArray($dirname, $type = '', $prefix = '', $noselection = 1)
118		{
119		$filelist = array();
120		switch (trim($type)) {
121		case 'images':
122		$types = '[.gif\|.jpg\|.png]';
123		if ($noselection) {
124		$filelist[''] = _AM_XOOPSTUBE_NOIMAGE;
125		}
126		break;
127		case 'media':
128		$types = '[.aac\|.flv\|.mp3\|.mp4\|.swf]';
129		if ($noselection) {
130		$filelist[''] = _AM_XOOPSTUBE_NOVIDEO;
131		}
132		break;
133		case 'html':
134		$types = '[.htm\|.tpl\|.html\|.xhtml\|.php\|.php3\|.phtml\|.txt]';
135		if ($noselection) {
136		$filelist[''] = _AM_XOOPSTUBE_NOSELECT;
137		}
138		break;
139		default:
140		$types = '';
141		if ($noselection) {
142		$filelist[''] = _AM_XOOPSTUBE_NOFILESELECT;
143		}
144		break;
145		}
146
147		if ('/' === substr($dirname, -1)) {
148		$dirname = substr($dirname, 0, -1);
149		}
150
151		if (is_dir($dirname) && $handle = opendir($dirname)) {
152		while (false !== ($file = readdir($handle))) {
153		if (!preg_match("/^[.]{1,2}$/", $file) && preg_match("/$types$/i", $file) && is_file($dirname . '/' . $file)) {
154		if ('blank.gif' === strtolower($file)) {
155		continue;
156		}
157		$file = $prefix . $file;
158		$filelist[$file] = $file;
159		}
160		}
161		closedir($handle);
162		asort($filelist);
163		reset($filelist);
164		}
165
166		return $filelist;
167		}
168
169		/**
170		* @return null
171		*/
172		public function value()
173		{
174		return $this->value;
175		}
176
177		public function isSelected()
		0 ignored issues – show Documentation introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
178		{
179		return $this->selected;
180		}
181
182		/**
183		* @return string
184		*/
185		public function paths()
186		{
187		return $this->path;
188		}
189
190		/**
191		* @return int
192		*/
193		public function size()
194		{
195		return $this->size;
196		}
197
198		/**
199		* @return int
200		*/
201		public function isEmptySelect()
202		{
203		return $this->emptyselect;
204		}
205
206		/**
207		* @return int
208		*/
209		public function getType()
210		{
211		return $this->type;
212		}
213
214		public function getPrefix()
		0 ignored issues – show Documentation introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
215		{
216		return $this->prefix;
217		}
218
219		public function getSuffix()
		0 ignored issues – show Documentation introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
220		{
221		return $this->suffix;
222		}
223		}
224

XoopsModules25x / xoopstube

Branch — master (ddc2b8)

XoopstubeLists::value() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like