Issues in viewcat.php - Fixed Issues - Inspection of "Merge pull request #5 from mambax7/master" - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (954431)

by Michael

created 2016-06-16 09:31 UTC

viewcat.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @category        Module
 * @package         Xoopstube
 * @author          XOOPS Development Team
 * @copyright       2001-2013 The XOOPS Project
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @version         $Id$
 * @link            http://sourceforge.net/projects/xoops/
 * @since           1.0.6
 */

include __DIR__ . '/header.php';

// Begin Main page Heading etc
$cid        = xtubeCleanRequestVars($_REQUEST, 'cid', 0);
$selectdate = xtubeCleanRequestVars($_REQUEST, 'selectdate', '');
$list       = xtubeCleanRequestVars($_REQUEST, 'list', '');
$start      = xtubeCleanRequestVars($_REQUEST, 'start', 0);
$start      = intval($start);
$cid        = intval($cid);

$catsort = $xoopsModuleConfig['sortcats'];
$mytree  = new XoopstubeTree($xoopsDB->prefix('xoopstube_cat'), 'cid', 'pid');
$arr     = $mytree->getFirstChild($cid, $catsort);

if (is_array($arr) > 0 && !$list && !$selectdate) {
    if (false == xtubeCheckGroups($cid)) {
        redirect_header('index.php', 1, _MD_XOOPSTUBE_MUSTREGFIRST);
        exit();
    }
}

$xoopsOption['template_main'] = 'xoopstube_viewcat.tpl';

include XOOPS_ROOT_PATH . '/header.php';

global $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
$catarray['letters']     = xtubeGetLetters();
$catarray['imageheader'] = xtubeRenderImageHeader();
$xoopsTpl->assign('catarray', $catarray);

$catArray['letters'] = xtubeLettersChoice();
//$catArray['toolbar'] = xoopstube_toolbar();

$xoopsTpl->assign('catarray', $catArray);

// Breadcrumb
$pathstring = '<a href="index.php">' . _MD_XOOPSTUBE_MAIN . '</a>&nbsp;:&nbsp;';
$pathstring .= $mytree->getNicePathFromId($cid, 'title', 'viewcat.php?op=');
$xoopsTpl->assign('category_path', $pathstring);
$xoopsTpl->assign('category_id', $cid);

// Display Sub-categories for selected Category
if (is_array($arr) > 0 && !$list && !$selectdate) {
    $scount = 1;
    foreach ($arr as $ele) {
        if (xtubeCheckGroups($ele['cid']) == false) {
            continue;
        }
        $sub_arr         = array();
        $sub_arr         = $mytree->getFirstChild($ele['cid'], $catsort);
        $space           = 1;
        $chcount         = 1;
        $infercategories = '';
        foreach ($sub_arr as $sub_ele) {
            // Subitem file count
            $hassubitems = xtubeGetTotalItems($sub_ele['cid']);
            // Filter group permissions
            if (true == xtubeCheckGroups($sub_ele['cid'])) {
                // If subcategory count > 5 then finish adding subcats to $infercategories and end
                if ($chcount > 5) {
                    $infercategories .= '...';
                    break;
                }
                if ($space > 0) {
                    $infercategories .= ', ';
                }

                $infercategories
                    .= '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewcat.php?cid=' . $sub_ele['cid'] . '">' . $xtubemyts->htmlSpecialCharsStrip($sub_ele['title'])
                    . '</a> (' . $hassubitems['count'] . ')';
                ++$space;
                ++$chcount;
            }
        }
        $totalvideos = xtubeGetTotalItems($ele['cid']);
        $indicator   = xtubeIsNewImage($totalvideos['published']);

        // This code is copyright WF-Projects
        // Using this code without our permission or removing this code voids the license agreement

        $_image = ($ele['imgurl']) ? urldecode($ele['imgurl']) : '';
        if ($_image != '' && $xoopsModuleConfig['usethumbs']) {
            $_thumb_image = new XtubeThumbsNails($_image, $xoopsModuleConfig['catimage'], 'thumbs');
            if ($_thumb_image) {
                $_thumb_image->setUseThumbs(1);
                $_thumb_image->setImageType('gd2');
                $_image = $_thumb_image->createThumbnail(
                    $xoopsModuleConfig['shotwidth'],
                    $xoopsModuleConfig['shotheight'],
                    $xoopsModuleConfig['imagequality'],
                    $xoopsModuleConfig['updatethumbs'],
                    $xoopsModuleConfig['keepaspect']
                );
            }
        }

        if (empty($_image) || $_image == '') {

            $imgurl  = $indicator['image'];
            $_width  = 33;
            $_height = 24;
        } else {
            $imgurl  = "{$xoopsModuleConfig['catimage']}/$_image";
            $_width  = $xoopsModuleConfig['shotwidth'];
            $_height = $xoopsModuleConfig['shotheight'];
        }
        /*
        * End
        */

        $xoopsTpl->append(
            'subcategories',
            array(
                'title'           => $xtubemyts->htmlSpecialCharsStrip($ele['title']),
                'id'              => $ele['cid'],
                'image'           => XOOPS_URL . "/$imgurl",
                'width'           => $_width,
                'height'          => $_height,
                'infercategories' => $infercategories,
                'totalvideos'     => $totalvideos['count'],
                'count'           => $scount,
                'alttext'         => $ele['description']
            )
        );
        ++$scount;
    }
}

// Show Description for Category listing
$sql         = 'SELECT * FROM ' . $xoopsDB->prefix('xoopstube_cat') . ' WHERE cid=' . intval($cid);
$head_arr    = $xoopsDB->fetchArray($xoopsDB->query($sql));
$html        = ($head_arr['nohtml']) ? 0 : 1;
$smiley      = ($head_arr['nosmiley']) ? 0 : 1;
$xcodes      = ($head_arr['noxcodes']) ? 0 : 1;
$images      = ($head_arr['noimages']) ? 0 : 1;
$breaks      = ($head_arr['nobreak']) ? 1 : 0;
$description = $xtubemyts->displayTarea($head_arr['description'], $html, $smiley, $xcodes, $images, $breaks);
$xoopsTpl->assign('description', $description);
$module_handler = & xoops_gethandler('module');
$versioninfo    = & $module_handler->get($xoopsModule->getVar('mid'));
if ($head_arr['title'] > '') {
    $xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name') . ':&nbsp;' . $head_arr['title']);
} else {
    $xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name'));
}

if ($head_arr['client_id'] > 0) {
    $catarray['imageheader'] = xtubeGetBannerFromClientId($head_arr['client_id']);
} elseif ($head_arr['banner_id'] > 0) {
    $catarray['imageheader'] = xtubeGetBannerFromBannerId($head_arr['banner_id']);
} else {
    $catarray['imageheader'] = xtubeRenderImageHeader();
}
$xoopsTpl->assign('catarray', $catarray);
// Extract linkload information from database
$xoopsTpl->assign('show_categort_title', true);

$orderby = (isset($_REQUEST['orderby']) && !empty($_REQUEST['orderby'])) ? xtubeConvertOrderByIn(htmlspecialchars($_REQUEST['orderby'])) : xtubeConvertOrderByIn($xoopsModuleConfig['linkxorder']);

if ($selectdate) {

    $d = date('j', $selectdate);
    $m = date('m', $selectdate);
    $y = date('Y', $selectdate);

    $stat_begin = mktime(0, 0, 0, $m, $d, $y);
    $stat_end   = mktime(23, 59, 59, $m, $d, $y);

    $query
        = ' WHERE published>=' . $stat_begin . ' AND published<=' . $stat_end . ' AND (expired=0 OR expired>' . time() . ') AND offline=0 AND cid>0';

    $sql    = 'SELECT * FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
    $result = $xoopsDB->query($sql, $xoopsModuleConfig['perpage'], $start);

    $sql = 'SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query;
    list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql));

    $list_by = 'selectdate=' . $selectdate;

} elseif ($list) {

    $query
        = " WHERE title LIKE '$list%' AND (published>0 AND published<=" . time() . ") AND (expired=0 OR expired>" . time() . ") AND offline=0 AND cid>0";

    $sql    = 'SELECT * FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
    $result = $xoopsDB->query($sql, $xoopsModuleConfig['perpage'], $start);

    $sql = 'SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query;
    list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql));
    $list_by = "list=$list";

} else {

    $query = 'WHERE a.published>0 AND a.published<=' . time() . ' AND (a.expired=0 OR a.expired>' . time() . ') AND a.offline=0' . ' AND (b.cid=a.cid OR (a.cid=' . $cid . ' OR b.cid=' . $cid . '))';

    $sql    = 'SELECT DISTINCT a.* FROM ' . $xoopsDB->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $xoopsDB->prefix(
            'xoopstube_altcat'
        ) . ' b ON b.lid=a.lid ' . $query . ' ORDER BY ' . $orderby;
    $result = $xoopsDB->query($sql, $xoopsModuleConfig['perpage'], $start);

    $sql2 = 'SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $xoopsDB->prefix(
            'xoopstube_altcat'
        ) . ' b ON b.lid=a.lid ' . $query;
    list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql2));
    $order   = xtubeConvertOrderByOut($orderby);
    $list_by = 'cid=' . $cid . '&orderby=' . $order;
    $xoopsTpl->assign('show_categort_title', false);

}
$pagenav = new XoopsPageNav($count, $xoopsModuleConfig['perpage'], $start, 'start', $list_by);

// Show links
if ($count > 0) {
    $moderate = 0;
    while ($video_arr = $xoopsDB->fetchArray($result)) {
        if (xtubeCheckGroups($video_arr['cid']) == true) {
            require XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/include/videoloadinfo.php';
            $xoopsTpl->append('video', $video);
        }
    }

    unset($video_arr);

    // Show order box
    $xoopsTpl->assign('show_videos', false);
    if ($count > 1 && $cid != 0) {
        $xoopsTpl->assign('show_videos', true);
        $orderbyTrans = xtubeConvertOrderByTrans($orderby);
        $xoopsTpl->assign('lang_cursortedby', sprintf(_MD_XOOPSTUBE_CURSORTBY, xtubeConvertOrderByTrans($orderby)));
        $orderby = xtubeConvertOrderByOut($orderby);
    }

    // Screenshots display
    $xoopsTpl->assign('show_screenshot', false);
    if (isset($xoopsModuleConfig['screenshot']) && $xoopsModuleConfig['screenshot'] == 1) {

        $xoopsTpl->assign('shotwidth', $xoopsModuleConfig['shotwidth']);
        $xoopsTpl->assign('shotheight', $xoopsModuleConfig['shotheight']);
        $xoopsTpl->assign('show_screenshot', true);
    }

    // Nav page render
    $page_nav = $pagenav->renderNav();
    $istrue   = (isset($page_nav) && !empty($page_nav)) ? true : false;
    $xoopsTpl->assign('page_nav', $istrue);
    $xoopsTpl->assign('pagenav', $page_nav);
    $xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
}

$xoopsTpl->assign('cat_columns', $xoopsModuleConfig['catcolumns']);

include XOOPS_ROOT_PATH . '/footer.php';


Branch — master (954431)

viewcat.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2
3		/**
4		* Module: XoopsTube
5		*
6		* You may not change or alter any portion of this comment or credits
7		* of supporting developers from this source code or any supporting source code
8		* which is considered copyrighted (c) material of the original comment or credit authors.
9		*
10		* PHP version 5
11		*
12		* @category Module
13		* @package Xoopstube
14		* @author XOOPS Development Team
15		* @copyright 2001-2013 The XOOPS Project
16		* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
17		* @version $Id$
18		* @link http://sourceforge.net/projects/xoops/
19		* @since 1.0.6
20		*/
21
22		include __DIR__ . '/header.php';
23
24		// Begin Main page Heading etc
25		$cid = xtubeCleanRequestVars($_REQUEST, 'cid', 0);
26		$selectdate = xtubeCleanRequestVars($_REQUEST, 'selectdate', '');
27		$list = xtubeCleanRequestVars($_REQUEST, 'list', '');
28		$start = xtubeCleanRequestVars($_REQUEST, 'start', 0);
29		$start = intval($start);
30		$cid = intval($cid);
31
32		$catsort = $xoopsModuleConfig['sortcats'];
33		$mytree = new XoopstubeTree($xoopsDB->prefix('xoopstube_cat'), 'cid', 'pid');
34		$arr = $mytree->getFirstChild($cid, $catsort);
35
36		if (is_array($arr) > 0 && !$list && !$selectdate) {
37		if (false == xtubeCheckGroups($cid)) {
38		redirect_header('index.php', 1, _MD_XOOPSTUBE_MUSTREGFIRST);
39		exit();
40		}
41		}
42
43		$xoopsOption['template_main'] = 'xoopstube_viewcat.tpl';
44
45		include XOOPS_ROOT_PATH . '/header.php';
46
47		global $xoopsModuleConfig, $xoopsModule;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
48		$catarray['letters'] = xtubeGetLetters();
49		$catarray['imageheader'] = xtubeRenderImageHeader();
50		$xoopsTpl->assign('catarray', $catarray);
51
52		$catArray['letters'] = xtubeLettersChoice();
53		//$catArray['toolbar'] = xoopstube_toolbar();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-01 04:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
54		$xoopsTpl->assign('catarray', $catArray);
55
56		// Breadcrumb
57		$pathstring = '<a href="index.php">' . _MD_XOOPSTUBE_MAIN . '</a> : ';
58		$pathstring .= $mytree->getNicePathFromId($cid, 'title', 'viewcat.php?op=');
59		$xoopsTpl->assign('category_path', $pathstring);
60		$xoopsTpl->assign('category_id', $cid);
61
62		// Display Sub-categories for selected Category
63		if (is_array($arr) > 0 && !$list && !$selectdate) {
64		$scount = 1;
65		foreach ($arr as $ele) {
66		if (xtubeCheckGroups($ele['cid']) == false) {
67		continue;
68		}
69		$sub_arr = array();
70		$sub_arr = $mytree->getFirstChild($ele['cid'], $catsort);
71		$space = 1;
72		$chcount = 1;
73		$infercategories = '';
74		foreach ($sub_arr as $sub_ele) {
75		// Subitem file count
76		$hassubitems = xtubeGetTotalItems($sub_ele['cid']);
77		// Filter group permissions
78		if (true == xtubeCheckGroups($sub_ele['cid'])) {
79		// If subcategory count > 5 then finish adding subcats to $infercategories and end
80		if ($chcount > 5) {
81		$infercategories .= '...';
82		break;
83		}
84		if ($space > 0) {
85		$infercategories .= ', ';
86		}
87
88		$infercategories
89		.= '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewcat.php?cid=' . $sub_ele['cid'] . '">' . $xtubemyts->htmlSpecialCharsStrip($sub_ele['title'])
90		. '</a> (' . $hassubitems['count'] . ')';
91		++$space;
92		++$chcount;
93		}
94		}
95		$totalvideos = xtubeGetTotalItems($ele['cid']);
96		$indicator = xtubeIsNewImage($totalvideos['published']);
97
98		// This code is copyright WF-Projects
99		// Using this code without our permission or removing this code voids the license agreement
100
101		$_image = ($ele['imgurl']) ? urldecode($ele['imgurl']) : '';
102	View Code Duplication	if ($_image != '' && $xoopsModuleConfig['usethumbs']) {
103		$_thumb_image = new XtubeThumbsNails($_image, $xoopsModuleConfig['catimage'], 'thumbs');
104		if ($_thumb_image) {
105		$_thumb_image->setUseThumbs(1);
106		$_thumb_image->setImageType('gd2');
107		$_image = $_thumb_image->createThumbnail(
108		$xoopsModuleConfig['shotwidth'],
109		$xoopsModuleConfig['shotheight'],
110		$xoopsModuleConfig['imagequality'],
111		$xoopsModuleConfig['updatethumbs'],
112		$xoopsModuleConfig['keepaspect']
113		);
114		}
115		}
116
117	View Code Duplication	if (empty($_image) \|\| $_image == '') {
		0 ignored issues – show Duplication introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118		$imgurl = $indicator['image'];
119		$_width = 33;
120		$_height = 24;
121		} else {
122		$imgurl = "{$xoopsModuleConfig['catimage']}/$_image";
123		$_width = $xoopsModuleConfig['shotwidth'];
124		$_height = $xoopsModuleConfig['shotheight'];
125		}
126		/*
127		* End
128		*/
129
130		$xoopsTpl->append(
131		'subcategories',
132		array(
133		'title' => $xtubemyts->htmlSpecialCharsStrip($ele['title']),
134		'id' => $ele['cid'],
135		'image' => XOOPS_URL . "/$imgurl",
136		'width' => $_width,
137		'height' => $_height,
138		'infercategories' => $infercategories,
139		'totalvideos' => $totalvideos['count'],
140		'count' => $scount,
141		'alttext' => $ele['description']
142		)
143		);
144		++$scount;
145		}
146		}
147
148		// Show Description for Category listing
149		$sql = 'SELECT * FROM ' . $xoopsDB->prefix('xoopstube_cat') . ' WHERE cid=' . intval($cid);
150		$head_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));
151		$html = ($head_arr['nohtml']) ? 0 : 1;
152		$smiley = ($head_arr['nosmiley']) ? 0 : 1;
153		$xcodes = ($head_arr['noxcodes']) ? 0 : 1;
154		$images = ($head_arr['noimages']) ? 0 : 1;
155		$breaks = ($head_arr['nobreak']) ? 1 : 0;
156		$description = $xtubemyts->displayTarea($head_arr['description'], $html, $smiley, $xcodes, $images, $breaks);
157		$xoopsTpl->assign('description', $description);
158		$module_handler = & xoops_gethandler('module');
159		$versioninfo = & $module_handler->get($xoopsModule->getVar('mid'));
160		if ($head_arr['title'] > '') {
161		$xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name') . ': ' . $head_arr['title']);
162		} else {
163		$xoopsTpl->assign('xoops_pagetitle', $versioninfo->getInfo('name'));
164		}
165
166		if ($head_arr['client_id'] > 0) {
167		$catarray['imageheader'] = xtubeGetBannerFromClientId($head_arr['client_id']);
168		} elseif ($head_arr['banner_id'] > 0) {
169		$catarray['imageheader'] = xtubeGetBannerFromBannerId($head_arr['banner_id']);
170		} else {
171		$catarray['imageheader'] = xtubeRenderImageHeader();
172		}
173		$xoopsTpl->assign('catarray', $catarray);
174		// Extract linkload information from database
175		$xoopsTpl->assign('show_categort_title', true);
176
177		$orderby = (isset($_REQUEST['orderby']) && !empty($_REQUEST['orderby'])) ? xtubeConvertOrderByIn(htmlspecialchars($_REQUEST['orderby'])) : xtubeConvertOrderByIn($xoopsModuleConfig['linkxorder']);
178
179		if ($selectdate) {
180
181		$d = date('j', $selectdate);
182		$m = date('m', $selectdate);
183		$y = date('Y', $selectdate);
184
185		$stat_begin = mktime(0, 0, 0, $m, $d, $y);
186		$stat_end = mktime(23, 59, 59, $m, $d, $y);
187
188		$query
189		= ' WHERE published>=' . $stat_begin . ' AND published<=' . $stat_end . ' AND (expired=0 OR expired>' . time() . ') AND offline=0 AND cid>0';
190
191		$sql = 'SELECT * FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
192		$result = $xoopsDB->query($sql, $xoopsModuleConfig['perpage'], $start);
193
194		$sql = 'SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query;
195		list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql));
196
197		$list_by = 'selectdate=' . $selectdate;
198
199		} elseif ($list) {
200
201		$query
202		= " WHERE title LIKE '$list%' AND (published>0 AND published<=" . time() . ") AND (expired=0 OR expired>" . time() . ") AND offline=0 AND cid>0";
203
204		$sql = 'SELECT * FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query . ' ORDER BY ' . $orderby;
205		$result = $xoopsDB->query($sql, $xoopsModuleConfig['perpage'], $start);
206
207		$sql = 'SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xoopstube_videos') . $query;
208		list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql));
209		$list_by = "list=$list";
210
211		} else {
212
213		$query = 'WHERE a.published>0 AND a.published<=' . time() . ' AND (a.expired=0 OR a.expired>' . time() . ') AND a.offline=0' . ' AND (b.cid=a.cid OR (a.cid=' . $cid . ' OR b.cid=' . $cid . '))';
214
215		$sql = 'SELECT DISTINCT a.* FROM ' . $xoopsDB->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $xoopsDB->prefix(
216		'xoopstube_altcat'
217		) . ' b ON b.lid=a.lid ' . $query . ' ORDER BY ' . $orderby;
218		$result = $xoopsDB->query($sql, $xoopsModuleConfig['perpage'], $start);
219
220		$sql2 = 'SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xoopstube_videos') . ' a LEFT JOIN ' . $xoopsDB->prefix(
221		'xoopstube_altcat'
222		) . ' b ON b.lid=a.lid ' . $query;
223		list($count) = $xoopsDB->fetchRow($xoopsDB->query($sql2));
224		$order = xtubeConvertOrderByOut($orderby);
225		$list_by = 'cid=' . $cid . '&orderby=' . $order;
226		$xoopsTpl->assign('show_categort_title', false);
227
228		}
229		$pagenav = new XoopsPageNav($count, $xoopsModuleConfig['perpage'], $start, 'start', $list_by);
230
231		// Show links
232		if ($count > 0) {
233		$moderate = 0;
234		while ($video_arr = $xoopsDB->fetchArray($result)) {
235		if (xtubeCheckGroups($video_arr['cid']) == true) {
236		require XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/include/videoloadinfo.php';
237		$xoopsTpl->append('video', $video);
238		}
239		}
240
241		unset($video_arr);
242
243		// Show order box
244		$xoopsTpl->assign('show_videos', false);
245		if ($count > 1 && $cid != 0) {
246		$xoopsTpl->assign('show_videos', true);
247		$orderbyTrans = xtubeConvertOrderByTrans($orderby);
248		$xoopsTpl->assign('lang_cursortedby', sprintf(_MD_XOOPSTUBE_CURSORTBY, xtubeConvertOrderByTrans($orderby)));
249		$orderby = xtubeConvertOrderByOut($orderby);
250		}
251
252		// Screenshots display
253		$xoopsTpl->assign('show_screenshot', false);
254	View Code Duplication	if (isset($xoopsModuleConfig['screenshot']) && $xoopsModuleConfig['screenshot'] == 1) {
		0 ignored issues – show Duplication introduced 2016-01-18 10:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
255		$xoopsTpl->assign('shotwidth', $xoopsModuleConfig['shotwidth']);
256		$xoopsTpl->assign('shotheight', $xoopsModuleConfig['shotheight']);
257		$xoopsTpl->assign('show_screenshot', true);
258		}
259
260		// Nav page render
261		$page_nav = $pagenav->renderNav();
262		$istrue = (isset($page_nav) && !empty($page_nav)) ? true : false;
263		$xoopsTpl->assign('page_nav', $istrue);
264		$xoopsTpl->assign('pagenav', $page_nav);
265		$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
266		}
267
268		$xoopsTpl->assign('cat_columns', $xoopsModuleConfig['catcolumns']);
269
270		include XOOPS_ROOT_PATH . '/footer.php';
271

XoopsModules25x / xoopstube

Branch — master (954431)

viewcat.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like