XoopsModules25x / xoopstube

ratevideo.php

<?php

/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @category        Module
 * @package         Xoopstube
 * @author          XOOPS Development Team
 * @copyright       2001-2016 XOOPS Project (http://xoops.org)
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @link            http://xoops.org/
 * @since           1.0.6
 */

include __DIR__ . '/header.php';

global $xtubemyts, $xoTheme;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

// Check if videoload POSTER is voting (UNLESS Anonymous users allowed to post)
$lid = XoopsRequest::getInt('lid', XoopsRequest::getInt('lid', '', 'POST'), 'GET');

$ip         = getenv('REMOTE_ADDR');
$ratinguser = (!is_object($GLOBALS['xoopsUser'])) ? 0 : $GLOBALS['xoopsUser']->getVar('uid');

if (0 == $GLOBALS['xoopsModuleConfig']['showrating'] || '' === $lid) {
    $ratemessage = _MD_XOOPSTUBE_CANTVOTEOWN;
    redirect_header('index.php', 4, $ratemessage);
}

if ($ratinguser !== 0) {
    $result = $GLOBALS['xoopsDB']->query('SELECT cid, submitter FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . ' WHERE lid=' . (int)$lid);
    while (false !== (list($cid, $ratinguserDB) = $GLOBALS['xoopsDB']->fetchRow($result))) {

This code seems to be duplicated across your project.

        if ($ratinguserDB === $ratinguser) {
            $ratemessage = _MD_XOOPSTUBE_CANTVOTEOWN;
            redirect_header('singlevideo.php?cid=' . (int)$cid . '&lid=' . (int)$lid, 4, $ratemessage);
        }
    }
    // Check if REG user is trying to vote twice.
    $result = $GLOBALS['xoopsDB']->query('SELECT cid, ratinguser FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_votedata') . ' WHERE lid=' . (int)$lid);
    while (false !== (list($cid, $ratinguserDB) = $GLOBALS['xoopsDB']->fetchRow($result))) {

This code seems to be duplicated across your project.

        if ($ratinguserDB === $ratinguser) {
            $ratemessage = _MD_XOOPSTUBE_VOTEONCE;
            redirect_header('singlevideo.php?cid=' . (int)$cid . '&lid=' . (int)$lid, 4, $ratemessage);
        }
    }
} else {
    // Check if ANONYMOUS user is trying to vote more than once per day.
    $yesterday = (time() - (86400 * $anonwaitdays));
    $result    = $GLOBALS['xoopsDB']->query('SELECT COUNT(*) FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_votedata') . ' WHERE lid=' . (int)$lid . ' AND ratinguser=0 AND ratinghostname=' . $ip
                                            . '  AND ratingtimestamp > ' . $yesterday);
    list($anonvotecount) = $GLOBALS['xoopsDB']->fetchRow($result);
    if ($anonvotecount >= 1) {
        $ratemessage = _MD_XOOPSTUBE_VOTEONCE;
        redirect_header('singlevideo.php?cid=' . (int)$cid . '&lid=' . (int)$lid, 4, $ratemessage);
    }
}

if (!empty(XoopsRequest::getString('submit', ''))) {
    $ratinguser = (!is_object($GLOBALS['xoopsUser'])) ? 0 : $GLOBALS['xoopsUser']->getVar('uid');
    // Make sure only 1 anonymous from an IP in a single day.
    $anonwaitdays = 1;
    $ip           = getenv('REMOTE_ADDR');
    $lid          = XoopsRequest::getInt('lid', 0, 'POST');
    $cid          = XoopsRequest::getInt('cid', 0, 'POST');
    $rating       = XoopsRequest::getInt('rating', 0, 'POST');
    //    $title        = $xtubemyts->addslashes(trim(XoopsRequest::getString('title', '', 'POST')));

62% of this comment could be valid code. Did you maybe forget this after debugging?

    $title = XoopsRequest::getString('title', '', 'POST');
    // Check if Rating is Null
    if (0 == $rating) {
        $ratemessage = _MD_XOOPSTUBE_NORATING;
        redirect_header('ratevideo.php?cid=' . (int)$cid . '&lid=' . (int)$lid, 4, $ratemessage);
    }
    // All is well.  Add to Line Item Rate to DB.
    $newid    = $GLOBALS['xoopsDB']->genId($GLOBALS['xoopsDB']->prefix('xoopstube_votedata') . '_ratingid_seq');
    $datetime = time();
    $sql      =
        sprintf('INSERT INTO %s (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp, title) VALUES (%u, %u, %u, %u, %s, %u, %s)', $GLOBALS['xoopsDB']->prefix('xoopstube_votedata'),
                $newid, (int)$lid, $ratinguser, $rating, $GLOBALS['xoopsDB']->quoteString($ip), $datetime, $GLOBALS['xoopsDB']->quoteString($title));
    if (!$result = $GLOBALS['xoopsDB']->query($sql)) {
        $ratemessage = _MD_XOOPSTUBE_ERROR;
    } else {
        // All is well.  Calculate Score & Add to Summary (for quick retrieval & sorting) to DB.
        XoopstubeUtilities::xtubeUpdateRating($lid);
        $ratemessage = _MD_XOOPSTUBE_VOTEAPPRE . '<br>' . sprintf(_MD_XOOPSTUBE_THANKYOU, $GLOBALS['xoopsConfig']['sitename']);
    }
    redirect_header('singlevideo.php?cid=' . (int)$cid . '&amp;lid=' . (int)$lid, 4, $ratemessage);
} else {
    //TODO add
    $xoopsOption['template_main'] = 'xoopstube_ratevideo.tpl';
    include XOOPS_ROOT_PATH . '/header.php';

    $catarray['imageheader'] = XoopstubeUtilities::xtubeRenderImageHeader();
    $cid                     = XoopsRequest::getInt('cid', XoopsRequest::getInt('cid', '', 'POST'), 'GET');

    $catarray['imageheader'] = XoopstubeUtilities::xtubeRenderImageHeader();
    $xoopsTpl->assign('catarray', $catarray);

    $result = $GLOBALS['xoopsDB']->query('SELECT title FROM ' . $GLOBALS['xoopsDB']->prefix('xoopstube_videos') . ' WHERE lid=' . (int)$lid);
    list($title) = $GLOBALS['xoopsDB']->fetchRow($result);
    $xoopsTpl->assign('video', array(
        'id'    => (int)$lid,
        'cid'   => (int)$cid,
        'title' => $xtubemyts->htmlSpecialCharsStrip($title)
    ));

    XoopstubeUtilities::xtubeSetNoIndexNoFollow();

    $xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
    include XOOPS_ROOT_PATH . '/footer.php';
}

XoopstubeUtilities::xtubeSetNoIndexNoFollow();

$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
include XOOPS_ROOT_PATH . '/footer.php';