XoopsModules25x /
xoopstube
| Total Complexity | 54 |
| Total Lines | 223 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like FilesManagement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FilesManagement, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 20 | trait FilesManagement |
||
| 21 | { |
||
| 22 | /** |
||
| 23 | * Function responsible for checking if a directory exists, we can also write in and create an index.html file |
||
| 24 | * |
||
| 25 | * @param string $folder The full path of the directory to check |
||
| 26 | * |
||
| 27 | * @throws \RuntimeException |
||
| 28 | */ |
||
| 29 | public static function createFolder($folder) |
||
| 41 | } |
||
| 42 | } |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @param $file |
||
| 46 | * @param $folder |
||
| 47 | * @return bool |
||
| 48 | */ |
||
| 49 | public static function copyFile($file, $folder) |
||
| 50 | { |
||
| 51 | return \copy($file, $folder); |
||
| 52 | } |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @param $src |
||
| 56 | * @param $dst |
||
| 57 | */ |
||
| 58 | public static function recurseCopy($src, $dst) |
||
| 75 | } |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Remove files and (sub)directories |
||
| 79 | * |
||
| 80 | * @param string $src source directory to delete |
||
| 81 | * |
||
| 82 | * @return bool true on success |
||
| 83 | * @uses \Xmf\Module\Helper::isUserAdmin() |
||
| 84 | * |
||
| 85 | * @uses \Xmf\Module\Helper::getHelper() |
||
| 86 | */ |
||
| 87 | public static function deleteDirectory($src) |
||
| 121 | } |
||
| 122 | |||
| 123 | /** |
||
| 124 | * Recursively remove directory |
||
| 125 | * |
||
| 126 | * @todo currently won't remove directories with hidden files, should it? |
||
| 127 | * |
||
| 128 | * @param string $src directory to remove (delete) |
||
| 129 | * |
||
| 130 | * @return bool true on success |
||
| 131 | */ |
||
| 132 | public static function rrmdir($src) |
||
| 133 | { |
||
| 134 | // Only continue if user is a 'global' Admin |
||
| 135 | if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) { |
||
| 136 | return false; |
||
| 137 | } |
||
| 138 | |||
| 139 | // If source is not a directory stop processing |
||
| 140 | if (!\is_dir($src)) { |
||
| 141 | return false; |
||
| 142 | } |
||
| 143 | |||
| 144 | $success = true; |
||
|
Unused Code
introduced
by
|
|||
| 145 | |||
| 146 | // Open the source directory to read in files |
||
| 147 | $iterator = new \DirectoryIterator($src); |
||
| 148 | foreach ($iterator as $fObj) { |
||
| 149 | if ($fObj->isFile()) { |
||
| 150 | $filename = $fObj->getPathname(); |
||
| 151 | $fObj = null; // clear this iterator object to close the file |
||
| 152 | if (!\unlink($filename)) { |
||
| 153 | return false; // couldn't delete the file |
||
| 154 | } |
||
| 155 | } elseif (!$fObj->isDot() && $fObj->isDir()) { |
||
| 156 | // Try recursively on directory |
||
| 157 | self::rrmdir($fObj->getPathname()); |
||
| 158 | } |
||
| 159 | } |
||
| 160 | $iterator = null; // clear iterator Obj to close file/directory |
||
| 161 | return \rmdir($src); // remove the directory & return results |
||
| 162 | } |
||
| 163 | |||
| 164 | /** |
||
| 165 | * Recursively move files from one directory to another |
||
| 166 | * |
||
| 167 | * @param string $src - Source of files being moved |
||
| 168 | * @param string $dest - Destination of files being moved |
||
| 169 | * |
||
| 170 | * @return bool true on success |
||
| 171 | */ |
||
| 172 | public static function rmove($src, $dest) |
||
| 202 | } |
||
| 203 | |||
| 204 | /** |
||
| 205 | * Recursively copy directories and files from one directory to another |
||
| 206 | * |
||
| 207 | * @param string $src - Source of files being moved |
||
| 208 | * @param string $dest - Destination of files being moved |
||
| 209 | * |
||
| 210 | * @return bool true on success |
||
| 211 | * @uses \Xmf\Module\Helper::isUserAdmin() |
||
| 212 | * |
||
| 213 | * @uses \Xmf\Module\Helper::getHelper() |
||
| 214 | */ |
||
| 215 | public static function rcopy($src, $dest) |
||
| 245 |
Loading history...