User_language::getUserbar() - Code Metrics - Inspection of "updates for 2.0" - XoopsModules25x/xoopspoll - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#18)

by Michael

created 2020-08-09 02:37 UTC

User_language::getUserbar() B

↳ Parent: User_language

Complexity

Conditions	10
Paths	129

Size

Total Lines	56
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	37
c	1
b	0
f	0
nc	129
nop	0
dl	0
loc	56
rs	7.425

How to fix Long Method Complexity

<?php
/**
 * User Language Class (moved from 'main' language file)
 * @package   ::    newbb
 * @subpackage:: class
 */

require_once $GLOBALS['xoops']->path('modules/newbb/class/user.php');

/**
 *
 * Allows setting for user information
 * If you have a customized userbar, define it here.
 *
 */
class User_language extends User
{

    /**
     * User_language constructor.
     * @param $user
     */
    public function __construct($user)
    {
        parent::__construct($user);
    }

    /**
     * @return array|null
     */
    public function getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
        }
        $user      = $this->user;
        $userbar   = [];
        $userbar[] = [
            'link' => $GLOBALS['xoops']->url('userinfo.php?uid=' . $user->getVar('uid')),
            'name' => PROFILE

        ];
        if (is_object($xoopsUser)) {
            $userbar[] = [
                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "','pmlite', 450, 380);",
                'name' => _MD_PM
            ];
        }
        if ($user->getVar('user_viewemail') || $isadmin) {
            $userbar[] = [
                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "','new');",
                'name' => _MD_EMAIL
            ];
        }
        if ($user->getVar('url')) {
            $userbar[] = [
                'link' => "javascript:void window.open('" . $user->getVar('url') . "','new');",
                'name' => _MD_WWW
            ];
        }
        if ($user->getVar('user_icq')) {
            $userbar[] = [
                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $user->getVar('user_icq') . "','new');",
                'name' => _MD_ICQ
            ];
        }
        if ($user->getVar('user_aim')) {
            $userbar[] = [
                'link' => "javascript:void window.open('aim:goim?screenname=" . $user->getVar('user_aim') . '&amp;message=Hi+' . $user->getVar('user_aim') . '+Are+you+there?' . "','new');",
                'name' => _MD_AIM
            ];
        }
        if ($user->getVar('user_yim')) {
            $userbar[] = [
                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $user->getVar('user_yim') . '&.src=pg' . "','new');",
                'name' => _MD_YIM
            ];
        }
        if ($user->getVar('user_msnm')) {
            $userbar[] = [
                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $user->getVar('user_msnm') . "','new');",
                'name' => _MD_MSNM
            ];
        }

        return $userbar;
    }
}


1			<?php
2			/**
3			* User Language Class (moved from 'main' language file)
4			* @package :: newbb
5			* @subpackage:: class
6			*/
7
8			require_once $GLOBALS['xoops']->path('modules/newbb/class/user.php');
9
10			/**
11			*
12			* Allows setting for user information
13			* If you have a customized userbar, define it here.
14			*
15			*/
16			class User_language extends User
17			{
18
19			/**
20			* User_language constructor.
21			* @param $user
22			*/
23			public function __construct($user)
24			{
25			parent::__construct($user);
26			}
27
28			/**
29			* @return array\|null
30			*/
31			public function getUserbar()
32			{
33			global $xoopsModuleConfig, $xoopsUser, $isadmin;
34			if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
35			return null;
36			}
37			$user = $this->user;
38			$userbar = [];
39			$userbar[] = [
40			'link' => $GLOBALS['xoops']->url('userinfo.php?uid=' . $user->getVar('uid')),
41			'name' => PROFILE
			0 ignored issues – show Bug introduced 2020-07-24 11:13 UTC by Report Bug Copy Issue Report The constant `PROFILE` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
42			];
43			if (is_object($xoopsUser)) {
44			$userbar[] = [
45			'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&to_userid=' . $user->getVar('uid') . "','pmlite', 450, 380);",
46			'name' => _MD_PM
47			];
48			}
49			if ($user->getVar('user_viewemail') \|\| $isadmin) {
50			$userbar[] = [
51			'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "','new');",
52			'name' => _MD_EMAIL
53			];
54			}
55			if ($user->getVar('url')) {
56			$userbar[] = [
57			'link' => "javascript:void window.open('" . $user->getVar('url') . "','new');",
58			'name' => _MD_WWW
59			];
60			}
61			if ($user->getVar('user_icq')) {
62			$userbar[] = [
63			'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $user->getVar('user_icq') . "','new');",
64			'name' => _MD_ICQ
65			];
66			}
67			if ($user->getVar('user_aim')) {
68			$userbar[] = [
69			'link' => "javascript:void window.open('aim:goim?screenname=" . $user->getVar('user_aim') . '&message=Hi+' . $user->getVar('user_aim') . '+Are+you+there?' . "','new');",
70			'name' => _MD_AIM
71			];
72			}
73			if ($user->getVar('user_yim')) {
74			$userbar[] = [
75			'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $user->getVar('user_yim') . '&.src=pg' . "','new');",
76			'name' => _MD_YIM
77			];
78			}
79			if ($user->getVar('user_msnm')) {
80			$userbar[] = [
81			'link' => "javascript:void window.open('http://members.msn.com?mem=" . $user->getVar('user_msnm') . "','new');",
82			'name' => _MD_MSNM
83			];
84			}
85
86			return $userbar;
87			}
88			}
89

XoopsModules25x / xoopspoll

Pull Request — master (#18)

User_language::getUserbar() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like