XoopspollRenderer::assignForm() - Code Metrics - Inspection of "Merge pull request #16 from geekwright/mambax7-mas..." - XoopsModules25x/xoopspoll - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 8b9728...8dad3b )

by Michael
created 2016-09-22 04:23 UTC
XoopspollRenderer::assignForm() B

↳ Parent: XoopspollRenderer
Complexity

Conditions	9
Paths	64
Size

Total Lines	55
Code Lines	32
Duplication

Lines	7
Ratio	12.73 %
Importance

Changes
Metric	Value
cc	9
eloc	32
nc	64
nop	1
dl	7
loc	55
rs	7.2446
c	0
b	0
f	0
How to fix Long Method

<?php

/*
               XOOPS - PHP Content Management System
                   Copyright (c) 2000-2016 XOOPS.org
                      <http://xoops.org/>
 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation; either version 2 of the License, or
 (at your option) any later version.

 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting
 source code which is considered copyrighted (c) material of the
 original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.

 You should have received a copy of the GNU General Public License
 along with this program; if not, write to the Free Software
 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
*/

/**
 * Poll Renderer class for the XoopsPoll Module
 *
 * @copyright ::  {@link http://xoops.org/ XOOPS Project}
 * @license   ::  {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @package   ::  xoopspoll
 * @subpackage::  admin
 * @since     ::  1.0
 * @author    ::  {@link http://www.myweb.ne.jp/ Kazumi Ono (AKA onokazu)}
 */

xoops_loadLanguage('main', 'xoopspoll');
xoops_load('constants', 'xoopspoll');
xoops_load('pollUtility', 'xoopspoll');

/**
 * Class XoopspollRenderer
 */
class XoopspollRenderer
namespace YourVendor;

class YourClass { }
{
    // XoopsPoll class object
    protected $pollObj;
    protected $pHandler;
    protected $oHandler;
    protected $lHandler;

    // constructor(s)
    /**
     * @param null $poll
     */
    public function __construct($poll = null)
    {
        // setup handlers
        $this->pHandler = xoops_getModuleHandler('poll', 'xoopspoll');
        $this->oHandler = xoops_getModuleHandler('option', 'xoopspoll');
        $this->lHandler = xoops_getModuleHandler('log', 'xoopspoll');

        if ($poll instanceof XoopspollPoll) {
            $this->pollObj = $poll;
        } elseif (!empty($poll) && ((int)$poll > 0)) {
            $this->pollObj = $this->pHandler->get((int)$poll);
        } else {
            $this->pollObj = $this->pHandler->create();
        }
    }

    /**
     * @param null $poll
     */
    public function XoopspollRenderer($poll = null)
    {
        $this->__construct($poll);
    }

    /**
     *
     * create html form to display poll
     * @access public
     * @return string html form for display
     */
    public function renderForm()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $myTpl = new XoopsTpl();
        $this->assignForm($myTpl);  // get the poll information

        return $myTpl->fetch($GLOBALS['xoops']->path('modules/xoopspoll/templates/xoopspoll_view.tpl'));
    }

    /**
     *
     * assigns form values to template for display
     * @access public
     * @var    XoopsTpl $tpl
     * @return null
     */
    public function assignForm(XoopsTpl $tpl)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $myts       = MyTextSanitizer::getInstance();
        $optionObjs = $this->oHandler->getAllByPollId($this->pollObj->getVar('poll_id'));

        if (empty($optionObjs)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            /* there was a problem with missing Options */
            //            redirect_header($_SERVER['HTTP_REFERER'], XoopspollConstants::REDIRECT_DELAY_MEDIUM, _MD_XOOPSPOLL_ERROR_OPTIONS_MISSING);

        }

        if (XoopspollConstants::MULTIPLE_SELECT_POLL === (int) $this->pollObj->getVar('multiple')) {

            $optionType = 'checkbox';
            $optionName = 'option_id[]';
        } else {
            $optionType = 'radio';
            $optionName = 'option_id';
        }
        foreach ($optionObjs as $optionObj) {
            $options[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                'input' => "<input type='{$optionType}' " . "name='{$optionName}' " . "value='" . $optionObj->getVar('option_id') . "' />",
                'text'  => $optionObj->getVar('option_text')
            );
        }
        $uid = (isset($GLOBALS['xoopsUser'])
                && is_object($GLOBALS['xoopsUser'])) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
        if ($this->pollObj->isAllowedToVote()
            && (!$this->lHandler->hasVoted($this->pollObj->getVar('poll_id'), xoops_getenv('REMOTE_ADDR'), $uid))
        ) {
            $can_vote = true;
        } else {
            $can_vote = false;
        }
        /*

                $tpl->assign('poll', array(
                                       'question'     => $myts->htmlSpecialChars($this->pollObj->getVar('question')),
                                       'pollId'       => $this->pollObj->getVar('poll_id'),
                                       'viewresults'  => $GLOBALS['xoops']->url("modules/xoopspoll/pollresults.php") . "?poll_id=" . $this->pollObj->getVar('poll_id'),
                                       'options'      => $options,
                                       'description'  => $myts->displayTarea($myts->undoHtmlSpecialChars($this->pollObj->getVar('description')), 1))
                );
        */
        $tpl->assign(array(
                         'poll'         => array(
                             'question'    => $myts->htmlSpecialChars($this->pollObj->getVar('question')),
                             'pollId'      => $this->pollObj->getVar('poll_id'),
                             'viewresults' => $GLOBALS['xoops']->url('modules/xoopspoll/pollresults.php') . '?poll_id=' . $this->pollObj->getVar('poll_id'),
                             'options'     => isset($options) ? $options : '',
                             'description' => $myts->displayTarea($myts->undoHtmlSpecialChars($this->pollObj->getVar('description')), 1)
                         ),
                         'can_vote'     => $can_vote,
                         'action'       => $GLOBALS['xoops']->url('modules/xoopspoll/index.php'),
                         'lang_vote'    => _MD_XOOPSPOLL_VOTE,
                         'lang_results' => _MD_XOOPSPOLL_RESULTS
                     ));
    }

    /**
     *
     * display html results to screen (echo)
     * @access public
     * @return null
     */
    public function renderResults()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $myTpl = new XoopsTpl();
        $this->assignResults($myTpl);  // get the poll information

        return $myTpl->fetch($GLOBALS['xoops']->path('modules/xoopspoll/templates/xoopspoll_results_renderer.tpl'));
    }

    /**
     *
     * assigns form results to template
     * @access public
     * @var    XoopsTpl tpl
     * @return null
     */
    public function assignResults(XoopsTpl $tpl)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $myts             = MyTextSanitizer::getInstance();
        $xuEndTimestamp   = xoops_getUserTimestamp($this->pollObj->getVar('end_time'));
        $xuEndFormatted   = ucfirst(date(_MEDIUMDATESTRING, $xuEndTimestamp));
        $xuStartTimestamp = xoops_getUserTimestamp($this->pollObj->getVar('start_time'));
        $xuStartFormatted = ucfirst(date(_MEDIUMDATESTRING, $xuStartTimestamp));

        //        $lHandler = xoops_getModuleHandler('log', 'xoopspoll');

        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('poll_id', $this->pollObj->getVar('poll_id'), '='));
        $criteria->setSort('option_id');
        $optObjsArray = $this->oHandler->getAll($criteria);
        $total        = $this->pollObj->getVar('votes');
        $i            = 0;
        foreach ($optObjsArray as $optObj) {
            $optionVars = $optObj->getValues();
            $percent    = ($total > 0) ? (100 * $optionVars['option_count'] / $total) : 0;
            if ($percent > 0) {
                $width                = (int)($percent * 2);
                $options[$i]['image'] = "<img src='" . $GLOBALS['xoops']->url("modules/xoopspoll/assets/images/colorbars/{$optionVars['option_color']}'") . " style='height: 14px; width: {$width}px; vertical-align: middle;' alt='" . (int)$percent
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                                        . "%' />";
            } else {
                $options[$i]['image'] = '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }

            /* setup module config handler - required since this is called by newbb too */
            /** @var XoopsModuleHandler $moduleHandler */
            $moduleHandler = xoops_getHandler('module');
            $configHandler = xoops_getHandler('config');
            $xp_module      = $moduleHandler->getByDirname('xoopspoll');
            $module_id      = $xp_module->getVar('mid');
            $xp_config      = $configHandler->getConfigsByCat(0, $module_id);

            if ($xp_config['disp_vote_nums']) {
                $options[$i]['percent'] = sprintf(' %01.1f%% (%d)', $percent, $optionVars['option_count']);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            } else {
                $options[$i]['percent'] = sprintf(' %01.1f%%', $percent);
            }
            $options[$i]['text']  = $optionVars['option_text'];
            $options[$i]['total'] = $optionVars['option_count'];
            $options[$i]['value'] = (int) $percent;
            ++$i;
            unset($optionVars);
        }
        $uid = (isset($GLOBALS['xoopsUser'])
                && is_object($GLOBALS['xoopsUser'])) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
        if (!$this->pollObj->hasExpired() && $this->pollObj->isAllowedToVote()
            && !$this->lHandler->hasVoted($this->pollObj->getVar('poll_id'), xoops_getenv('REMOTE_ADDR'), $uid)
        ) {
            $vote = "<a href='" . $GLOBALS['xoops']->url('modules/xoopspoll/index.php') . '?poll_id=' . $this->pollObj->getVar('poll_id') . "'>" . _MD_XOOPSPOLL_VOTE_NOW . '</a>';
        } else {
            $vote = null;
        }
        if ($xp_config['disp_vote_nums']) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $totalVotes  = sprintf(_MD_XOOPSPOLL_TOTALVOTES, $total);
            $totalVoters = sprintf(_MD_XOOPSPOLL_TOTALVOTERS, $this->pollObj->getVar('voters'));
        } else {
            $totalVotes = $totalVoters = '';
        }

        $tpl->assign('poll', array(
            'question'    => $myts->htmlSpecialChars($this->pollObj->getVar('question')),
            'end_text'    => $xuEndFormatted,
            'start_text'  => $xuStartFormatted,
            'totalVotes'  => $totalVotes,
            'totalVoters' => $totalVoters,
            'vote'        => $vote,
            'options'     => $options,
            'description' => $this->pollObj->getVar('description') //allow html
        ));
    }
}

Push — master ( 8b9728...8dad3b )

XoopspollRenderer::assignForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

XoopsModules25x / xoopspoll

Push — master ( 8b9728...8dad3b )

XoopspollRenderer::assignForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
