blocks/singlepoll.php ➔ xoopspollBlockSinglepollShow()

Complexity

Conditions	26
Paths	1553

Size

Total Lines	151
Code Lines	102

Duplication

Lines	40
Ratio	26.49 %

Importance

Changes

0

<?php
 * @return array block keys and values to be used by block template
 * @global mixed $GLOBALS ['xoopsUser']
 * @uses   CriteriaCompo
 * @uses   Criteria
 * @uses   xoops_getUserTimestamp() function to convert time to user time
 * @uses   formatTimestamp() takes timestamp and converts to human readable format
 */
function xoopspollBlockSinglepollShow($options)
{
    $block = [];

    $configHandler      = xoops_getHandler('config');
    $pollHandler   = Helper::getInstance()->getHandler('Poll');
    /** @var \XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $thisModule         = $moduleHandler->getByDirname('xoopspoll');
    $this_module_config = $configHandler->getConfigsByCat(0, $thisModule->getVar('mid'));

The method getConfigsByCat() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

    /* if admin hasn't initialized block then we'll pick a poll for them
     * provided that one exists in the database
     */
    if (0 === $options[1]) {
        $criteria = null;
        /**
         * check to see if we want to include polls created with forum (newbb)
         */
        if ($this_module_config['hide_forum_polls']
            && ($thisModule instanceof \XoopsModule)
            && $thisModule->isactive()) {
            $newbbModule = $moduleHandler->getByDirname('newbb');
            if ($newbbModule instanceof \XoopsModule && $newbbModule->isactive()) {
                /** @var Newbb\TopicHandler $topicHandler */
                $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
                $tFields      = ['topic_id', 'poll_id'];
                $tArray       = $topicHandler->getAll(new \Criteria('topic_haspoll', 0, '>'), $tFields, false);
                if (!empty($tArray)) {
                    $tcriteria = [];
                    foreach ($tArray as $t) {
                        $tcriteria[] = $t['poll_id'];
                    }
                    if (!empty($tcriteria)) {
                        $tstring  = '(' . implode(',', $tcriteria) . ')';
                        $criteria = new \Criteria('poll_id', $tstring, 'NOT IN');
                    }
                }
                unset($topicHandler, $tFields, $tArray);
            }
            unset($newbbModule);
        }

        if ($pollHandler->getCount($criteria) > 0) {
            $pollIdArray = $pollHandler->getIds();
            $thisId      = array_shift($pollIdArray);
            $pollObj     = $pollHandler->get($thisId);
        } else {
            return $block;
        }
    } else {
        $pollObj = $pollHandler->get((int)$options[1]);
    }

    if ($pollObj instanceof Poll) {
        if ((1 === $options[0]) || !$pollObj->hasExpired()) {
            $block['langVote']        = _MD_XOOPSPOLL_VOTE;
            $block['langResults']     = _MD_XOOPSPOLL_RESULTS;
            $block['langExpires']     = _MB_XOOPSPOLL_WILLEXPIRE;
            $block['langExpired']     = _MB_XOOPSPOLL_HASEXPIRED;
            $block['langComments']    = _MB_XOOPSPOLL_COMMENTS;
            $block['langComment']     = _MB_XOOPSPOLL_COMMENT;
            $block['showResultsLink'] = $options[2];
            $block['asList']          = $options[3];
            $block['thisModuleDir']   = 'xoopspoll';
            $block['url']             = 'http' . (!empty($_SERVER['HTTPS']) ? 's' : '') . '://' . $_SERVER['SERVER_NAME'] . $_SERVER['REQUEST_URI'];
            $block['dispVotes']       = $this_module_config['disp_vote_nums'];

            $optionHandler = Helper::getInstance()->getHandler('Option');

            $pollVars = $pollObj->getValues();
            $criteria = new \CriteriaCompo();
            $criteria->add(new \Criteria('poll_id', $pollVars['poll_id'], '='));
            $criteria->setSort('option_id');
            $optionsObjArray = $optionHandler->getAll($criteria);
            //            $optionsObjArray = $optionHandler->getAll($criteria, null, false);

            if (Constants::MULTIPLE_SELECT_POLL === $pollVars['multiple']) {
                $pollOptionType = 'checkbox';
                $pollOptionName = 'option_id[]';
            } else {
                $pollOptionType = 'radio';
                $pollOptionName = 'option_id';
            }

                $uid = 0;
            if (isset($GLOBALS['xoopsUser']) && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
                $uid = $GLOBALS['xoopsUser']->getVar('uid');
            }

            $totalVotes       = $pollVars['votes'];
            $logHandler       = Helper::getInstance()->getHandler('Log');
            $hasVoted         = $logHandler->hasVoted($pollVars['poll_id'], xoops_getenv('REMOTE_ADDR'), $uid) ? true : false;
            $canVote          = (!$hasVoted) && $pollObj->isAllowedToVote();
            $pollOptionsArray = [];
            foreach ($optionsObjArray as $optionObj) {
                $percent = ($totalVotes > 0) ? (100 * $optionObj->getVar('option_count') / $totalVotes) : 0;
                //                $percent = ($totalVotes > 0) ? ceil(100 * $optionObj->getVar('option_count') / $totalVotes) . '%' : '0%';
                /*@TODO::  Change block templates to use Smarty html_options to support this... then comment
                           out old $pollOptionsArray assignment
                $pollOptionsArray[] = array('options' => array($optionObj['option_id'] => $optionObj['option_text']),
                                              'count' => $optionObj['option_count'],
                                            'percent' => $percent,
                                              'color' => $optionObj['option_color']
                ); */
                $pollOptionsArray[] = [
                    'id'      => $optionObj->getVar('option_id'),
                    'text'    => $optionObj->getVar('option_text'),
                    'count'   => $optionObj->getVar('option_count'),
                    'percent' => sprintf(' %01.1f%%', $percent),
                    'color'   => $optionObj->getVar('option_color'),
                ];
            }

            $xuEndTimestamp     = xoops_getUserTimestamp($pollObj->getVar('end_time'));
            $xuEndFormattedTime = ucfirst(date(_MEDIUMDATESTRING, $xuEndTimestamp));

            $isVisible = true === $pollObj->isResultVisible();

            $multiple   = $pollVars['multiple'] ? true : false;
            $multiLimit = (int)$pollVars['multilimit'];
            $lang_multi = '';
            if ($multiple && ($multiLimit > 0)) {
                $lang_multi = sprintf(_MB_XOOPSPOLL_MULTITEXT, $multiLimit);
            }

            $block['id']          = $pollVars['poll_id'];
            $block['visible']     = $isVisible;
            $block['question']    = $pollVars['question'];
            $block['multiple']    = $multiple;
            $block['lang_multi']  = $lang_multi;
            $block['optionType']  = $pollOptionType;
            $block['optionName']  = $pollOptionName;
            $block['options']     = $pollOptionsArray;
            $block['hasExpired']  = $pollObj->hasExpired();
            $block['votes']       = $pollVars['votes'];
            $block['hasVoted']    = $hasVoted;
            $block['canVote']     = $canVote;
            $block['totalVotes']  = sprintf(_MD_XOOPSPOLL_TOTALVOTES, $totalVotes);
            $block['endTime']     = $xuEndFormattedTime; // formatted output for current user
            $block['comments']    = $pollObj->getComments($pollVars['poll_id']);

The call to XoopsModules\Xoopspoll\Poll::getComments() has too many arguments starting with $pollVars['poll_id'].

            $block['commentMode'] = Utility::commentMode();

            unset($optionsObjArray, $pollOptionsArray, $pollObj, $pollVars, $timeArray);

The variable $timeArray seems to be never defined.

        }