BlockActionsHandler::handleActions() - Code Metrics - Inspection of "2.1.0 Beta 2" - XoopsModules25x/xoopspoll - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#23)

by Michael

created 2023-04-20 10:57 UTC

BlockActionsHandler::handleActions() B

↳ Parent: BlockActionsHandler

Complexity

Conditions	10
Paths	10

Size

Total Lines	50
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	35
c	1
b	0
f	0
nc	10
nop	1
dl	0
loc	50
rs	7.6666

How to fix Complexity

<?php declare(strict_types=1);

namespace XoopsModules\Xoopspoll\Common;

/**
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 *
 * @category        Module
 * @author          XOOPS Development Team
 * @copyright       XOOPS Project
 * @link            https://xoops.org
 * @license         GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 */

use Xmf\Module\Admin;
use Xmf\Request;
use XoopsModules\Xoopspoll\{
    Helper
};

/**
 * class BlockActionsHandler
 */
class BlockActionsHandler
{
    private $blocksadmin;
    private $helper;
    private $request;

    /**
     * @param $blocksadmin
     */
    public function __construct($blocksadmin)
    {
        $this->blocksadmin = $blocksadmin;
        $this->helper = Helper::getInstance();
    }

    public function processPostData(): BlockData
    {
        $blockData                 = new BlockData();
        $blockData->ok             = Request::getInt('ok', 0, 'POST');
        $blockData->confirm_submit = Request::getCmd('confirm_submit', '', 'POST');
        $blockData->submit         = Request::getString('submit', '', 'POST');
        $blockData->bside          = Request::getString('bside', '0', 'POST');
        $blockData->bweight        = Request::getString('bweight', '0', 'POST');
        $blockData->bvisible       = Request::getString('bvisible', '0', 'POST');
        $blockData->bmodule        = Request::getArray('bmodule', [], 'POST');
        $blockData->btitle         = Request::getString('btitle', '', 'POST');
        $blockData->bcachetime     = Request::getString('bcachetime', '0', 'POST');
        $blockData->groups         = Request::getArray('groups', [], 'POST');
        $blockData->options        = Request::getArray('options', [], 'POST');
        $blockData->submitblock    = Request::getString('submitblock', '', 'POST');
        $blockData->fct            = Request::getString('fct', '', 'POST');
        $blockData->title          = Request::getString('title', '', 'POST');
        $blockData->side           = Request::getString('side', '0', 'POST');
        $blockData->weight         = Request::getString('weight', '0', 'POST');
        $blockData->visible        = Request::getString('visible', '0', 'POST');

//        $blockData->oldTitle      = [];
//        $blockData->oldSide       = [];
//        $blockData->oldWeight     = [];
//        $blockData->oldVisible    = [];
//        $blockData->oldGroups     = [];
//        $blockData->oldBcachetime = [];
//        $blockData->oldBmodule    = [];

        return $blockData;
    }

    public function handleActions(BlockData $blockData)
    {
        $moduleDirNameUpper = \mb_strtoupper(Helper::getInstance()->getDirname());
        $bid = Request::getInt('bid', 0);

        switch ($blockData->op) {
            case 'order':
                $blockData->bid        = Request::getArray('bid', []);
                $blockData->titleArray = Request::getArray('title', [], 'POST');
                // Fill in other properties from the request
                $this->processOrderBlockAction($blockData);
                break;

            case 'clone':
                $this->blocksadmin->cloneBlock($bid);
                break;

            case 'delete':
                if (1 === $blockData->ok) {
                    $this->blocksadmin->deleteBlock($bid);
                } else {
                    xoops_confirm(['ok' => 1, 'op' => 'delete', 'bid' => $bid], 'blocksadmin.php', constant('CO_' . $moduleDirNameUpper . '_' . 'DELETE_BLOCK_CONFIRM'), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
                    xoops_cp_footer();
                }
                break;

            case 'edit':
                if ($bid > 0) {
                    $this->blocksadmin->editBlock($bid);
                } else {
                    $this->helper->redirect('admin/blocksadmin.php', 3, _AM_BLOCK_EDIT_ID_ERROR);
                }
                break;

            case 'edit_ok':
                $this->blocksadmin->updateBlock($bid, $blockData->btitle, $blockData->bside, $blockData->bweight, $blockData->bvisible, $blockData->bcachetime, $blockData->bmodule, $blockData->options, $blockData->groups);
                break;

            case 'clone_ok':
                $this->blocksadmin->isBlockCloned($bid, $blockData->bside, $blockData->bweight, $blockData->bvisible, $blockData->bcachetime, $blockData->bmodule, $blockData->options, $blockData->groups, true);
                break;

            case 'list':
                //        xoops_cp_header();
                $this->blocksadmin->listBlocks();
                break;

            default:
                // Add the code to handle the default operation here
                break;
        }
    }

    public function processOrderBlockAction(BlockData $blockData)
    {
        $blockData->bid           = Request::getArray('bid', []);
        $blockData->oldtitle      = Request::getArray('oldtitle', [], 'POST');
        $blockData->oldside       = Request::getArray('oldside', [], 'POST');
        $blockData->oldweight     = Request::getArray('oldweight', [], 'POST');
        $blockData->oldvisible    = Request::getArray('oldvisible', [], 'POST');
        $blockData->oldgroups     = Request::getArray('oldgroups', [], 'POST');
        $blockData->oldbcachetime = Request::getArray('oldcachetime', [], 'POST');
        $blockData->oldbmodule    = Request::getArray('oldbmodule', [], 'POST');
        $blockData->title         = Request::getArray('title', [], 'POST');
        $blockData->weight        = Request::getArray('weight', [], 'POST');
        $blockData->visible       = Request::getArray('visible', [], 'POST');
        $blockData->side          = Request::getArray('side', [], 'POST');
        $blockData->bcachetime    = Request::getArray('bcachetime', [], 'POST');
        $blockData->groups        = Request::getArray('groups', [], 'POST');
        $blockData->bmodule       = Request::getArray('bmodule', [], 'POST');


        $this->blocksadmin->orderBlock(
            $blockData->bid,
            $blockData->oldtitle,
            $blockData->oldside,
            $blockData->oldweight,
            $blockData->oldvisible,
            $blockData->oldgroups,
            $blockData->oldbcachetime,
            $blockData->oldbmodule,
            $blockData->title,
            $blockData->weight,
            $blockData->visible,
            $blockData->side,
            $blockData->bcachetime,
            $blockData->groups,
            $blockData->bmodule
        );
    }


    //for testing mocking

    /**
     * @param $request
     * @return void
     */
    public function setRequest($request): void
    {
        $this->request = $request;
    }

}


1			<?php declare(strict_types=1);
2
3			namespace XoopsModules\Xoopspoll\Common;
4
5			/**
6			* You may not change or alter any portion of this comment or credits
7			* of supporting developers from this source code or any supporting source code
8			* which is considered copyrighted (c) material of the original comment or credit authors.
9			*
10			*
11			* @category Module
12			* @author XOOPS Development Team
13			* @copyright XOOPS Project
14			* @link https://xoops.org
15			* @license GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
16			*/
17
18			use Xmf\Module\Admin;
19			use Xmf\Request;
20			use XoopsModules\Xoopspoll\{
21			Helper
22			};
23
24			/**
25			* class BlockActionsHandler
26			*/
27			class BlockActionsHandler
28			{
29			private $blocksadmin;
30			private $helper;
31			private $request;
32
33			/**
34			* @param $blocksadmin
35			*/
36			public function __construct($blocksadmin)
37			{
38			$this->blocksadmin = $blocksadmin;
39			$this->helper = Helper::getInstance();
40			}
41
42			public function processPostData(): BlockData
43			{
44			$blockData = new BlockData();
45			$blockData->ok = Request::getInt('ok', 0, 'POST');
46			$blockData->confirm_submit = Request::getCmd('confirm_submit', '', 'POST');
47			$blockData->submit = Request::getString('submit', '', 'POST');
48			$blockData->bside = Request::getString('bside', '0', 'POST');
49			$blockData->bweight = Request::getString('bweight', '0', 'POST');
50			$blockData->bvisible = Request::getString('bvisible', '0', 'POST');
51			$blockData->bmodule = Request::getArray('bmodule', [], 'POST');
52			$blockData->btitle = Request::getString('btitle', '', 'POST');
53			$blockData->bcachetime = Request::getString('bcachetime', '0', 'POST');
54			$blockData->groups = Request::getArray('groups', [], 'POST');
55			$blockData->options = Request::getArray('options', [], 'POST');
56			$blockData->submitblock = Request::getString('submitblock', '', 'POST');
57			$blockData->fct = Request::getString('fct', '', 'POST');
58			$blockData->title = Request::getString('title', '', 'POST');
59			$blockData->side = Request::getString('side', '0', 'POST');
60			$blockData->weight = Request::getString('weight', '0', 'POST');
61			$blockData->visible = Request::getString('visible', '0', 'POST');
62
63			// $blockData->oldTitle = [];
64			// $blockData->oldSide = [];
65			// $blockData->oldWeight = [];
66			// $blockData->oldVisible = [];
67			// $blockData->oldGroups = [];
68			// $blockData->oldBcachetime = [];
69			// $blockData->oldBmodule = [];
70
71			return $blockData;
72			}
73
74			public function handleActions(BlockData $blockData)
75			{
76			$moduleDirNameUpper = \mb_strtoupper(Helper::getInstance()->getDirname());
77			$bid = Request::getInt('bid', 0);
78
79			switch ($blockData->op) {
80			case 'order':
81			$blockData->bid = Request::getArray('bid', []);
82			$blockData->titleArray = Request::getArray('title', [], 'POST');
83			// Fill in other properties from the request
84			$this->processOrderBlockAction($blockData);
85			break;
86
87			case 'clone':
88			$this->blocksadmin->cloneBlock($bid);
89			break;
90
91			case 'delete':
92			if (1 === $blockData->ok) {
93			$this->blocksadmin->deleteBlock($bid);
94			} else {
95			xoops_confirm(['ok' => 1, 'op' => 'delete', 'bid' => $bid], 'blocksadmin.php', constant('CO_' . $moduleDirNameUpper . '_' . 'DELETE_BLOCK_CONFIRM'), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
96			xoops_cp_footer();
97			}
98			break;
99
100			case 'edit':
101			if ($bid > 0) {
102			$this->blocksadmin->editBlock($bid);
103			} else {
104			$this->helper->redirect('admin/blocksadmin.php', 3, _AM_BLOCK_EDIT_ID_ERROR);
105			}
106			break;
107
108			case 'edit_ok':
109			$this->blocksadmin->updateBlock($bid, $blockData->btitle, $blockData->bside, $blockData->bweight, $blockData->bvisible, $blockData->bcachetime, $blockData->bmodule, $blockData->options, $blockData->groups);
110			break;
111
112			case 'clone_ok':
113			$this->blocksadmin->isBlockCloned($bid, $blockData->bside, $blockData->bweight, $blockData->bvisible, $blockData->bcachetime, $blockData->bmodule, $blockData->options, $blockData->groups, true);
114			break;
115
116			case 'list':
117			// xoops_cp_header();
118			$this->blocksadmin->listBlocks();
119			break;
120
121			default:
122			// Add the code to handle the default operation here
123			break;
124			}
125			}
126
127			public function processOrderBlockAction(BlockData $blockData)
128			{
129			$blockData->bid = Request::getArray('bid', []);
130			$blockData->oldtitle = Request::getArray('oldtitle', [], 'POST');
131			$blockData->oldside = Request::getArray('oldside', [], 'POST');
132			$blockData->oldweight = Request::getArray('oldweight', [], 'POST');
133			$blockData->oldvisible = Request::getArray('oldvisible', [], 'POST');
134			$blockData->oldgroups = Request::getArray('oldgroups', [], 'POST');
135			$blockData->oldbcachetime = Request::getArray('oldcachetime', [], 'POST');
136			$blockData->oldbmodule = Request::getArray('oldbmodule', [], 'POST');
137			$blockData->title = Request::getArray('title', [], 'POST');
138			$blockData->weight = Request::getArray('weight', [], 'POST');
139			$blockData->visible = Request::getArray('visible', [], 'POST');
140			$blockData->side = Request::getArray('side', [], 'POST');
141			$blockData->bcachetime = Request::getArray('bcachetime', [], 'POST');
142			$blockData->groups = Request::getArray('groups', [], 'POST');
143			$blockData->bmodule = Request::getArray('bmodule', [], 'POST');
144
145
146			$this->blocksadmin->orderBlock(
147			$blockData->bid,
148			$blockData->oldtitle,
149			$blockData->oldside,
150			$blockData->oldweight,
151			$blockData->oldvisible,
152			$blockData->oldgroups,
153			$blockData->oldbcachetime,
154			$blockData->oldbmodule,
155			$blockData->title,
156			$blockData->weight,
157			$blockData->visible,
158			$blockData->side,
159			$blockData->bcachetime,
160			$blockData->groups,
161			$blockData->bmodule
162			);
163			}
164
165
166			//for testing mocking
167
168			/**
169			* @param $request
170			* @return void
171			*/
172			public function setRequest($request): void
173			{
174			$this->request = $request;
175			}
176
177			}
178

XoopsModules25x / xoopspoll

Pull Request — master (#23)

BlockActionsHandler::handleActions() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like