XoopsModules25x /
xoopspoll
| Conditions | 18 |
| Paths | 1301 |
| Total Lines | 69 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 60 | function xoops_module_update_xoopspoll(\XoopsModule $module, $prev_version) |
||
| 61 | { |
||
| 62 | // referer check |
||
| 63 | $success = false; |
||
| 64 | $ref = xoops_getenv('HTTP_REFERER'); |
||
| 65 | if (('' === $ref) || 0 === mb_strpos($ref, $GLOBALS['xoops']->url('modules/system/admin.php'))) { |
||
| 66 | /* module specific part */ |
||
| 67 | require_once $GLOBALS['xoops']->path('modules/xoopspoll/include/oninstall.php'); |
||
| 68 | |||
| 69 | $installedVersion = (int)$prev_version; |
||
| 70 | xoops_loadLanguage('admin', 'xoopspoll'); |
||
| 71 | $db = \XoopsDatabaseFactory::getDatabaseConnection(); |
||
| 72 | $success = true; |
||
| 73 | if ($installedVersion < 140) { |
||
| 74 | /* add column for poll anonymous which was created in versions prior |
||
| 75 | * to 1.40 of xoopspoll but not automatically created |
||
| 76 | */ |
||
| 77 | $result = $db->queryF('SHOW COLUMNS FROM ' . $db->prefix('xoopspoll_desc') . " LIKE 'anonymous'"); |
||
| 78 | $foundAnon = $db->getRowsNum($result); |
||
| 79 | if (empty($foundAnon)) { |
||
| 80 | // column doesn't exist, so try and add it |
||
| 81 | $success = $db->queryF('ALTER TABLE ' . $db->prefix('xoopspoll_desc') . ' ADD anonymous TINYINT( 1 ) DEFAULT 0 NOT NULL AFTER multiple'); |
||
| 82 | if (false === $success) { |
||
| 83 | $module->setErrors(_AM_XOOPSPOLL_ERROR_COLUMN . 'anonymous'); |
||
| 84 | } |
||
| 85 | } |
||
| 86 | /* change description to TINYTEXT */ |
||
| 87 | if ($success) { |
||
| 88 | $success = $db->queryF('ALTER TABLE ' . $db->prefix('xoopspoll_desc') . ' MODIFY description TINYTEXT NOT NULL'); |
||
| 89 | if (false === $success) { |
||
| 90 | $module->setErrors(_AM_XOOPSPOLL_ERROR_COLUMN . 'description'); |
||
| 91 | } |
||
| 92 | } |
||
| 93 | |||
| 94 | if ($success) { |
||
| 95 | $success = $db->queryF('ALTER TABLE ' . $db->prefix('xoopspoll_desc') . " ADD multilimit TINYINT( 63 ) UNSIGNED DEFAULT '0' NOT NULL AFTER multiple"); |
||
| 96 | if (false === $success) { |
||
| 97 | $module->setErrors(_AM_XOOPSPOLL_ERROR_COLUMN . 'multilimit'); |
||
| 98 | } |
||
| 99 | } |
||
| 100 | if ($success) { |
||
| 101 | $success = $db->queryF('ALTER TABLE ' . $db->prefix('xoopspoll_desc') . " ADD mail_voter TINYINT( 1 ) UNSIGNED DEFAULT '0' NOT NULL AFTER mail_status"); |
||
| 102 | if (false === $success) { |
||
| 103 | $module->setErrors(_AM_XOOPSPOLL_ERROR_COLUMN . 'mail_voter'); |
||
| 104 | } |
||
| 105 | } |
||
| 106 | if ($success) { |
||
| 107 | $result = $db->queryF('SHOW COLUMNS FROM ' . $db->prefix('xoopspoll_desc') . " LIKE 'visibility'"); |
||
| 108 | $foundCol = $db->getRowsNum($result); |
||
| 109 | if (empty($foundCol)) { |
||
| 110 | // column doesn't exist, so try and add it |
||
| 111 | $success = $db->queryF('ALTER TABLE ' . $db->prefix('xoopspoll_desc') . " ADD visibility INT( 3 ) DEFAULT '0' NOT NULL AFTER display"); |
||
| 112 | if (false === $success) { |
||
| 113 | $module->setErrors(_AM_XOOPSPOLL_ERROR_COLUMN . 'visibility'); |
||
| 114 | } |
||
| 115 | } |
||
| 116 | } |
||
| 117 | } |
||
| 118 | |||
| 119 | if ($success) { |
||
| 120 | /* now reverse table names changes from 1.40 Beta */ |
||
| 121 | $s1 = xoopspollChangeTableName($db, 'mod_xoopspoll_option', 'xoopspoll_option'); |
||
| 122 | $s2 = xoopspollChangeTableName($db, 'mod_xoopspoll_desc', 'xoopspoll_desc'); |
||
| 123 | $s3 = xoopspollChangeTableName($db, 'mod_xoopspoll_log', 'xoopspoll_log'); |
||
| 124 | $success = ($s1 && $s2 && $s3); |
||
| 125 | } |
||
| 126 | } |
||
| 127 | |||
| 128 | return $success; |
||
| 129 | } |
||
| 130 |
Loading history...