XoopsModules25x /
xoopspoll
| Conditions | 24 |
| Paths | 30 |
| Total Lines | 135 |
| Code Lines | 102 |
| Lines | 38 |
| Ratio | 28.15 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 59 | * @global mixed $GLOBALS ['xoopsUser'] |
||
| 60 | * @uses CriteriaCompo |
||
| 61 | */ |
||
| 62 | function xoopspollBlockMultiShow($options) |
||
| 63 | { |
||
| 64 | $block = []; |
||
| 65 | $pollOptionArray = []; |
||
| 66 | /** @var \XoopsModuleHandler $moduleHandler */ |
||
| 67 | $moduleHandler = xoops_getHandler('module'); |
||
| 68 | $thisModule = $moduleHandler->getByDirname('xoopspoll'); |
||
| 69 | $configHandler = xoops_getHandler('config'); |
||
| 70 | $this_module_config = $configHandler->getConfigsByCat(0, $thisModule->getVar('mid')); |
||
|
Bug
introduced
by
|
|||
| 71 | |||
| 72 | $pollHandler = \XoopsModules\Xoopspoll\Helper::getInstance()->getHandler('Poll'); |
||
| 73 | $criteria = new \CriteriaCompo(); |
||
| 74 | $criteria->add(new \Criteria('display', Constants::DISPLAY_POLL_IN_BLOCK, '=')); |
||
| 75 | $criteria->add(new \Criteria('start_time', time(), '<=')); |
||
| 76 | if (0 === $options[1]) { |
||
| 77 | $criteria->add(new \Criteria('end_time', time(), '>=')); |
||
| 78 | } |
||
| 79 | |||
| 80 | /** |
||
| 81 | * now check to see if we want to hide polls that were created using newbb |
||
| 82 | */ |
||
| 83 | if ($this_module_config['hide_forum_polls'] && ($thisModule instanceof \XoopsModule) && $thisModule->isactive()) { |
||
| 84 | $newbbModule = $moduleHandler->getByDirname('newbb'); |
||
| 85 | if ($newbbModule instanceof \XoopsModule && $newbbModule->isactive()) { |
||
| 86 | /** @var Newbb\TopicHandler $topicHandler */ |
||
| 87 | $topicHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Topic'); |
||
| 88 | $tFields = array('topic_id', 'poll_id'); |
||
| 89 | $tArray = $topicHandler->getAll(new Criteria('topic_haspoll', 0, '>'), $tFields, false); |
||
| 90 | if (!empty($tArray)) { |
||
| 91 | $tcriteria = []; |
||
| 92 | foreach ($tArray as $t) { |
||
| 93 | $tcriteria[] = $t['poll_id']; |
||
| 94 | } |
||
| 95 | if (!empty($tcriteria)) { |
||
| 96 | $tstring = '(' . implode(',', $tcriteria) . ')'; |
||
| 97 | $criteria->add(new \Criteria('poll_id', $tstring, 'NOT IN')); |
||
| 98 | } |
||
| 99 | } |
||
| 100 | unset($topicHandler, $tFields, $tArray); |
||
| 101 | } |
||
| 102 | unset($newbbModule); |
||
| 103 | } |
||
| 104 | |||
| 105 | $criteria->setSort('weight ASC, end_time'); // trick criteria to allow 2 sort criteria |
||
| 106 | $criteria->setOrder('DESC'); |
||
| 107 | $pollObjs = $pollHandler->getAll($criteria); |
||
| 108 | $count = count($pollObjs); |
||
| 109 | if ($count) { |
||
| 110 | $block['langVote'] = _MD_XOOPSPOLL_VOTE; |
||
| 111 | $block['langResults'] = _MD_XOOPSPOLL_RESULTS; |
||
| 112 | $block['langExpires'] = _MB_XOOPSPOLL_WILLEXPIRE; |
||
| 113 | $block['langExpired'] = _MB_XOOPSPOLL_HASEXPIRED; |
||
| 114 | $block['langComments'] = _MB_XOOPSPOLL_COMMENTS; |
||
| 115 | $block['langComment'] = _MB_XOOPSPOLL_COMMENT; |
||
| 116 | $block['url'] = 'http' . (!empty($_SERVER['HTTPS']) ? 's' : '') . '://' . $_SERVER['SERVER_NAME'] . $_SERVER['REQUEST_URI']; |
||
| 117 | $block['dispVotes'] = $this_module_config['disp_vote_nums']; |
||
| 118 | $block['thisModuleDir'] = 'xoopspoll'; |
||
| 119 | $block['asList'] = $options[0]; |
||
| 120 | |||
| 121 | $optionHandler = Xoopspoll\Helper::getInstance()->getHandler('Option'); |
||
| 122 | $logHandler = Xoopspoll\Helper::getInstance()->getHandler('Log'); |
||
| 123 | |||
| 124 | foreach ($pollObjs as $pollObj) { |
||
| 125 | $criteria = new \CriteriaCompo(); |
||
| 126 | $pollVars = $pollObj->getValues(); |
||
| 127 | $criteria->add(new \Criteria('poll_id', $pollVars['poll_id'], '=')); |
||
| 128 | $criteria->setSort('option_id'); |
||
| 129 | $pollOptionObjs = $optionHandler->getAll($criteria); |
||
| 130 | if (Constants::MULTIPLE_SELECT_POLL === $pollVars['multiple']) { |
||
| 131 | $pollOptionType = 'checkbox'; |
||
| 132 | $pollOptionName = 'option_id[]'; |
||
| 133 | } else { |
||
| 134 | $pollOptionType = 'radio'; |
||
| 135 | $pollOptionName = 'option_id'; |
||
| 136 | } |
||
| 137 | |||
| 138 | $uid = 0; |
||
| 139 | if (isset($GLOBALS['xoopsUser']) && ($GLOBALS['xoopsUser'] instanceof \XoopsUser)) { |
||
| 140 | $uid = $GLOBALS['xoopsUser']->getVar('uid'); |
||
| 141 | } |
||
| 142 | |||
| 143 | $totalVotes = $pollVars['votes']; |
||
| 144 | $hasVoted = $logHandler->hasVoted($pollVars['poll_id'], xoops_getenv('REMOTE_ADDR'), $uid) ? true : false; |
||
| 145 | $canVote = (!$hasVoted) && $pollObj->isAllowedToVote(); |
||
| 146 | foreach ($pollOptionObjs as $pollOptionObj) { |
||
| 147 | $optionObjVars = $pollOptionObj->getValues(); |
||
| 148 | $percent = ($totalVotes > 0) ? (100 * $optionObjVars['option_count'] / $totalVotes) : 0; |
||
| 149 | // $percent = ($totalVotes > 0) ? (int)(100 * $optionObjVars['option_count'] / $totalVotes) . '%' : '0%'; |
||
| 150 | $pollOptionArray[] = [ |
||
| 151 | 'id' => $optionObjVars['option_id'], |
||
| 152 | 'text' => $optionObjVars['option_text'], |
||
| 153 | 'count' => $optionObjVars['option_count'], |
||
| 154 | 'percent' => sprintf(' %01.1f%%', $percent), |
||
| 155 | 'color' => $optionObjVars['option_color'], |
||
| 156 | ]; |
||
| 157 | } |
||
| 158 | unset($pollOptionObjs, $optionObjVars); |
||
| 159 | $xuEndTimestamp = xoops_getUserTimestamp($pollObj->getVar('end_time')); |
||
| 160 | $xuEndFormattedTime = ucfirst(date(_MEDIUMDATESTRING, $xuEndTimestamp)); |
||
| 161 | |||
| 162 | $isVisible = true === $pollObj->isResultVisible(); |
||
| 163 | $multiple = $pollVars['multiple'] ? true : false; |
||
| 164 | $multiLimit = (int)$pollVars['multilimit']; |
||
| 165 | $lang_multi = ''; |
||
| 166 | if ($multiple && ($multiLimit > 0)) { |
||
| 167 | $lang_multi = sprintf(_MB_XOOPSPOLL_MULTITEXT, $multiLimit); |
||
| 168 | } |
||
| 169 | |||
| 170 | $poll = [ |
||
| 171 | 'id' => $pollVars['poll_id'], |
||
| 172 | 'visible' => $isVisible, |
||
| 173 | 'question' => $pollVars['question'], |
||
| 174 | 'multiple' => $multiple, |
||
| 175 | 'lang_multi' => $lang_multi, |
||
| 176 | 'optionType' => $pollOptionType, |
||
| 177 | 'optionName' => $pollOptionName, |
||
| 178 | 'options' => $pollOptionArray, |
||
| 179 | 'hasExpired' => $pollObj->hasExpired(), |
||
| 180 | 'canVote' => $canVote, |
||
| 181 | 'votes' => $pollVars['votes'], |
||
| 182 | 'hasVoted' => $hasVoted, |
||
| 183 | 'totalVotes' => sprintf(_MD_XOOPSPOLL_TOTALVOTES, $totalVotes), |
||
| 184 | 'comments' => $pollObj->getComments($pollVars['poll_id']), |
||
| 185 | 'endTime' => $xuEndFormattedTime, |
||
| 186 | 'commentMode' => Xoopspoll\Utility::commentMode(), |
||
| 187 | ]; |
||
| 188 | $block['polls'][] = $poll; |
||
| 189 | unset($pollOptionArray, $poll, $pollVars); |
||
| 190 | } |
||
| 191 | } |
||
| 192 | |||
| 193 | return $block; |
||
| 194 | } |
||
| 270 |
Loading history...