User_language::getUserbar() - Code Metrics - Inspection of "updates for 2.0" - XoopsModules25x/xoopspoll - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#18)

by Michael

created 2020-07-24 11:09 UTC

User_language::getUserbar() B

↳ Parent: User_language

Complexity

Conditions	10
Paths	129

Size

Total Lines	56
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	38
c	1
b	0
f	0
nc	129
nop	0
dl	0
loc	56
rs	7.425

How to fix Long Method Complexity

<?php
/**
 * User Language Class (moved from 'main' language file)
 * @package   ::    newbb
 * @subpackage:: class
 */

require_once $GLOBALS['xoops']->path('modules/newbb/class/user.php');

/**
 *
 * Allows setting for user information
 * If you have a customized userbar, define it here.
 *
 */
class User_language extends User
{

    /**
     * User_language constructor.
     * @param $user
     */
    public function __construct($user)
    {
        parent::__construct($user);
    }
    /**
     * @param $user
     */
    public function User_language(&$user)
    {
        $this->__construct($user);
    }

    /**
     * @return array|null
     */
    public function &getUserbar()
    {
        global $xoopsModuleConfig, $xoopsUser, $isadmin;
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return null;
        }
        $user      = $this->user;
        $userbar   = array();
        $userbar[] = array(
            'link' => $GLOBALS['xoops']->url('userinfo.php?uid=' . $user->getVar('uid')),
            'name' => PROFILE

        );
        if (is_object($xoopsUser)) {
            $userbar[] = array(
                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "','pmlite', 450, 380);",
                'name' => _MD_PM
            );
        }
        if ($user->getVar('user_viewemail') || $isadmin) {
            $userbar[] = array(
                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "','new');",
                'name' => _MD_EMAIL
            );
        }
        if ($user->getVar('url')) {
            $userbar[] = array(
                'link' => "javascript:void window.open('" . $user->getVar('url') . "','new');",
                'name' => _MD_WWW
            );
        }
        if ($user->getVar('user_icq')) {
            $userbar[] = array(
                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $user->getVar('user_icq') . "','new');",
                'name' => _MD_ICQ
            );
        }
        if ($user->getVar('user_aim')) {
            $userbar[] = array(
                'link' => "javascript:void window.open('aim:goim?screenname=" . $user->getVar('user_aim') . '&amp;message=Hi+' . $user->getVar('user_aim') . '+Are+you+there?' . "','new');",
                'name' => _MD_AIM
            );
        }
        if ($user->getVar('user_yim')) {
            $userbar[] = array(
                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $user->getVar('user_yim') . '&.src=pg' . "','new');",
                'name' => _MD_YIM
            );
        }
        if ($user->getVar('user_msnm')) {
            $userbar[] = array(
                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $user->getVar('user_msnm') . "','new');",
                'name' => _MD_MSNM
            );
        }

        return $userbar;
    }
}


1			<?php
2			/**
3			* User Language Class (moved from 'main' language file)
4			* @package :: newbb
5			* @subpackage:: class
6			*/
7
8			require_once $GLOBALS['xoops']->path('modules/newbb/class/user.php');
9
10			/**
11			*
12			* Allows setting for user information
13			* If you have a customized userbar, define it here.
14			*
15			*/
16			class User_language extends User
17			{
18
19			/**
20			* User_language constructor.
21			* @param $user
22			*/
23			public function __construct($user)
24			{
25			parent::__construct($user);
26			}
27			/**
28			* @param $user
29			*/
30			public function User_language(&$user)
31			{
32			$this->__construct($user);
33			}
34
35			/**
36			* @return array\|null
37			*/
38			public function &getUserbar()
39			{
40			global $xoopsModuleConfig, $xoopsUser, $isadmin;
41			if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
42			return null;
43			}
44			$user = $this->user;
45			$userbar = array();
46			$userbar[] = array(
47			'link' => $GLOBALS['xoops']->url('userinfo.php?uid=' . $user->getVar('uid')),
48			'name' => PROFILE
			0 ignored issues – show Bug introduced 2020-07-24 11:13 UTC by Report Bug Copy Issue Report The constant `PROFILE` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
49			);
50			if (is_object($xoopsUser)) {
51			$userbar[] = array(
52			'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&to_userid=' . $user->getVar('uid') . "','pmlite', 450, 380);",
53			'name' => _MD_PM
54			);
55			}
56			if ($user->getVar('user_viewemail') \|\| $isadmin) {
57			$userbar[] = array(
58			'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "','new');",
59			'name' => _MD_EMAIL
60			);
61			}
62			if ($user->getVar('url')) {
63			$userbar[] = array(
64			'link' => "javascript:void window.open('" . $user->getVar('url') . "','new');",
65			'name' => _MD_WWW
66			);
67			}
68			if ($user->getVar('user_icq')) {
69			$userbar[] = array(
70			'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $user->getVar('user_icq') . "','new');",
71			'name' => _MD_ICQ
72			);
73			}
74			if ($user->getVar('user_aim')) {
75			$userbar[] = array(
76			'link' => "javascript:void window.open('aim:goim?screenname=" . $user->getVar('user_aim') . '&message=Hi+' . $user->getVar('user_aim') . '+Are+you+there?' . "','new');",
77			'name' => _MD_AIM
78			);
79			}
80			if ($user->getVar('user_yim')) {
81			$userbar[] = array(
82			'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $user->getVar('user_yim') . '&.src=pg' . "','new');",
83			'name' => _MD_YIM
84			);
85			}
86			if ($user->getVar('user_msnm')) {
87			$userbar[] = array(
88			'link' => "javascript:void window.open('http://members.msn.com?mem=" . $user->getVar('user_msnm') . "','new');",
89			'name' => _MD_MSNM
90			);
91			}
92
93			return $userbar;
94			}
95			}
96

XoopsModules25x / xoopspoll

Pull Request — master (#18)

User_language::getUserbar() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like