NewbbPostHandler::_delete()

Complexity

Conditions	30
Paths	1653

Size

Total Lines	119
Code Lines	73

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

        /* Set active post as deleted */
        if (($post->getVar('approved') > 0) && empty($force)) {
            $sql = 'UPDATE ' . $this->db->prefix('bb_posts') . ' SET approved = -1 WHERE post_id = ' . $post->getVar('post_id');
            if (!$result = $this->db->queryF($sql)) {

The assignment to $result is dead and can be removed.

                //@TODO: add error check here
            }
        } else { /* delete pending post directly */
            $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('bb_posts'), $post->getVar('post_id'));

It seems like $post->getVar('post_id') can also be of type array and array; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            if (!$result = $this->db->queryF($sql)) {
                $post->setErrors('delte post error: ' . $sql);

                return false;
            }
            $post->deleteAttachment();

            $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('bb_posts_text'), $post->getVar('post_id'));
            if (!$result = $this->db->queryF($sql)) {
                $post->setErrors('Could not remove post text: ' . $sql);

                return false;
            }
        }

        if ($post->isTopic()) {
            /** @var NewbbTopicHandler $topicHandler */
            $topicHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Topic');
            $topic_obj     = $topicHandler->get($post->getVar('topic_id'));
            if (is_object($topic_obj) && $topic_obj->getVar('approved') > 0 && empty($force)) {
                $topiccount_toupdate = 1;

The assignment to $topiccount_toupdate is dead and can be removed.

                $topic_obj->setVar('approved', -1);
                $topicHandler->insert($topic_obj);
                xoops_notification_deletebyitem($GLOBALS['xoopsModule']->getVar('mid'), 'thread', $post->getVar('topic_id'));
            } else {
                if (is_object($topic_obj)) {
                    if ($topic_obj->getVar('approved') > 0) {
                        xoops_notification_deletebyitem($GLOBALS['xoopsModule']->getVar('mid'), 'thread', $post->getVar('topic_id'));
                    }

                    $poll_id       = $topic_obj->getVar('poll_id');
                    /** @var XoopsModuleHandler $moduleHandler */
                    $moduleHandler = xoops_getHandler('module');
                    if ($poll_id > 0) {
                        $poll_moduleHandler = $moduleHandler->getByDirname('xoopspoll');
                        if (($poll_moduleHandler instanceof XoopsModuleHandler) && $poll_moduleHandler->isactive()) {

The method isactive() does not exist on XoopsModuleHandler.

$poll_moduleHandler is never a sub-type of XoopsModuleHandler.

                            $pollHandler = xoops_getModuleHandler('poll', 'xoopspoll');
                            if (false !== $pollHandler->deleteAll(new Criteria('poll_id', $poll_id, '='))) {
                                $optionHandler = xoops_getModuleHandler('option', 'xoopspoll');
                                $optionHandler->deleteAll(new Criteria('poll_id', $poll_id, '='));
                                $logHandler = xoops_getModuleHandler('log', 'xoopspoll');
                                $logHandler->deleteAll(new Criteria('poll_id', $poll_id, '='));
                                xoops_comment_delete($GLOBALS['xoopsModule']->getVar('mid'), $poll_id);
                            }
                        } else {
                            $poll_moduleHandler = $moduleHandler->getByDirname('umfrage');
                            if (($poll_moduleHandler instanceof XoopsModuleHandler)

$poll_moduleHandler is never a sub-type of XoopsModuleHandler.

                                && $poll_moduleHandler->isactive()
                            ) {
                                include_once $GLOBALS['xoops']->path('modules/umfrage/class/umfrage.php');
                                include_once $GLOBALS['xoops']->path('modules/umfrage/class/umfrageoption.php');
                                include_once $GLOBALS['xoops']->path('modules/umfrage/class/umfragelog.php');
                                include_once $GLOBALS['xoops']->path('modules/umfrage/class/umfragerenderer.php');

                                $poll = new Umfrage($poll_id);

The type Umfrage was not found. Maybe you did not declare it correctly or list all dependencies?

                                if (false !== $poll->delete()) {
                                    UmfrageOption::deleteByPollId($poll_id);

The type UmfrageOption was not found. Maybe you did not declare it correctly or list all dependencies?

                                    UmfrageLog::deleteByPollId($poll_id);

The type UmfrageLog was not found. Maybe you did not declare it correctly or list all dependencies?

                                    xoops_comment_delete($GLOBALS['xoopsModule']->getVar('mid'), $poll_id);
                                }
                            }
                        }
                    }
                }

                $sql = sprintf('DELETE FROM %s WHERE topic_id = %u', $this->db->prefix('bb_topics'), $post->getVar('topic_id'));
                if (!$result = $this->db->queryF($sql)) {
                    //                  xoops_error($this->db->error());
                }
                $sql = sprintf('DELETE FROM %s WHERE topic_id = %u', $this->db->prefix('bb_votedata'), $post->getVar('topic_id'));
                if (!$result = $this->db->queryF($sql)) {
                    //                  xoops_error($this->db->error());
                }
            }
        } else {
            $sql = 'UPDATE ' . $this->db->prefix('bb_topics') . ' t ' . 'LEFT JOIN ' . $this->db->prefix('bb_posts') . ' p ON p.topic_id = t.topic_id ' . 'SET t.topic_last_post_id = p.post_id ' . 'WHERE t.topic_last_post_id = '
                   . $post->getVar('post_id') . ' ' . 'AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('bb_posts') . ' ' . 'WHERE topic_id=t.topic_id)';
            if (!$result = $this->db->queryF($sql)) {
                //@TODO: add error checking here
            }
        }

        $postcount_toupdate = $post->getVar('approved');

        if ($postcount_toupdate > 0) {
            // Update user stats
            if ($post->getVar('uid') > 0) {
                $memberHandler = xoops_getHandler('member');
                $poster         = $memberHandler->getUser($post->getVar('uid'));
                if (is_object($poster) && $post->getVar('uid') === $poster->getVar('uid')) {
                    $poster->setVar('posts', $poster->getVar('posts') - 1);
                    $res = $memberHandler->insertUser($poster, true);

The assignment to $res is dead and can be removed.

                    unset($poster);
                }
            }
            // irmtfan - just update the pid for approved posts when the post is not topic (pid=0)
            if (!$post->isTopic()) {
                $sql = 'UPDATE ' . $this->db->prefix('bb_posts') . ' SET pid = ' . $post->getVar('pid') . ' WHERE approved=1 AND pid=' . $post->getVar('post_id');
                if (!$result = $this->db->queryF($sql)) {
                    //                  xoops_error($this->db->error());
                }
            }
        }

        return true;
    }