XoopsModules\Xoopspartners\Partners

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	3
A	__toString()	0	3	1

<?php

namespace XoopsModules\Xoopspartners;

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 *------------------------------------
 * Author: Raul Recio (AKA UNFOR)
 * Project: The XOOPS Project
 *------------------------------------
 */
/**
 * XoopsPartners - a partner affiliation links module
 *
 * @package      module\Xoopspartners\class
 * @author       Raul Recio (aka UNFOR)
 * @author       XOOPS Module Development Team
 * @copyright    {@link https://xoops.org 2001-2016 XOOPS Project}
 * @license      {@link https://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
 * @link         https://xoops.org XOOPS
 */
/**
 * Class Partners
 *
 * {@inheritDoc}
 * @see \XoopsObject
 */
class Partners extends \XoopsObject
{
    protected $db;

    /**
     * constructor
     *
     * @param null $id

Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?

     * @todo change 'url' to XOBJ_DTYPE_URL
     */
    public function __construct($id = null)
    {
        $this->db = \XoopsDatabaseFactory::getDatabaseConnection();

        $this->initVar('id', \XOBJ_DTYPE_INT, null, false);
        $this->initVar('weight', \XOBJ_DTYPE_INT, null, false, 10);
        $this->initVar('hits', \XOBJ_DTYPE_INT, null, true, 10);
        $this->initVar('url', \XOBJ_DTYPE_TXTBOX, null, true);
        $this->initVar('image', \XOBJ_DTYPE_TXTBOX, null, true);
        $this->initVar('title', \XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('description', \XOBJ_DTYPE_TXTBOX, null, true);
        $this->initVar('status', \XOBJ_DTYPE_INT, null, false, 0);
        if (!empty($id)) {
            if (\is_array($id)) {
                $this->assignVars($id);
            } else {
                $this->load((int)$id);

The method load() does not exist on XoopsModules\Xoopspartners\Partners.

            }
        }
    }

    /**
     * Returns category title
     *
     * @return string
     */
    public function __toString()
    {
        return $this->getVar('title', 's');

The expression return $this->getVar('title', 's') also could return the type array|boolean which is incompatible with the documented return type string.

    }
}