XoopsModules25x / xoopsmembers

blocks/membersstats_block.php

<?php
//  Author: SMD & Trabis
//  URL: http://www.xoopsmalaysia.org  & http://www.xuups.com
//  E-Mail: webmaster@xoopsmalaysia.org  & lusopoemas@gmail.com

use Xmf\IPAddress;

if (!defined('XOOPS_ROOT_PATH')) {
    exit;
}

/**
 * @param $options
 * @return array|bool
 */
function show_membersstats_block($options)
{
    global $xoopsConfig, $xoopsUser, $xoopsModule, $xoopsDB, $_SERVER;
    /* @var XoopsOnlineHandler $onlineHandler */
    $onlineHandler = xoops_getHandler('online');
    // set gc probabillity to 10% for now..
    if (mt_rand(1, 100) < 11) {
        $onlineHandler->gc(300);
    }
    if (is_object($xoopsUser)) {
        $uid   = $xoopsUser->getVar('uid');
        $uname = $xoopsUser->getVar('uname');
    } else {
        $uid   = 0;
        $uname = '';
    }
    $requestIp = IPAddress::fromRequest()->asReadable();
    $requestIp = (false === $requestIp) ? '0.0.0.0' : $requestIp;

The condition false === $requestIp is always false.

    if (is_object($xoopsModule)) {
        $onlineHandler->write($uid, $uname, time(), $xoopsModule->getVar('mid'), $requestIp);
    } else {
        $onlineHandler->write($uid, $uname, time(), 0, $requestIp);
    }
    $onlines = $onlineHandler->getAll();
    if (!empty($onlines)) {
        $total   = count($onlines);
        $block   = [];
        $guests  = 0;
        $members = '';
        for ($i = 0; $i < $total; ++$i) {
            if ($onlines[$i]['online_uid'] > 0) {
                $members .= ' <a href="' . XOOPS_URL . '/userinfo.php?uid=' . $onlines[$i]['online_uid'] . '" title="' . $onlines[$i]['online_uname'] . '">' . $onlines[$i]['online_uname'] . '</a>,';
            } else {
                ++$guests;
            }
        }
        $block['online_total'] = sprintf(_ONLINEPHRASE, $total);
        if (is_object($xoopsModule)) {
            $mytotal               = $onlineHandler->getCount(new \Criteria('online_module', $xoopsModule->getVar('mid')));
            $block['online_total'] .= ' (' . sprintf(_ONLINEPHRASEX, $mytotal, $xoopsModule->getVar('name')) . ')';
        }
        // Membership Statistic
        /** @var \XoopsMemberHandler $memberHandler */
        $memberHandler      = xoops_getHandler('member');
        $today              = formatTimestamp(time());

The assignment to $today is dead and can be removed.

        $level_criteria     = new \Criteria('level', 0, '>');
        $criteria           = new \CriteriaCompo($level_criteria);
        $criteria24         = new \CriteriaCompo($level_criteria);
        $criteria48         = new \CriteriaCompo($level_criteria);
        $total_active_users = $memberHandler->getUserCount($level_criteria);
        //Fixing stats for last 24 and 48 hours
        $users_reg_24 = $memberHandler->getUserCount($criteria24->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (24 * 3600)), '>=')), 'AND');

The call to XoopsMemberHandler::getUserCount() has too many arguments starting with 'AND'.

        $users_reg_48 = $memberHandler->getUserCount($criteria48->add(new \Criteria('user_regdate', (mktime(0, 0, 0) - (48 * 3600)), '>=')), 'AND');
        $limit        = 1;
        $criteria->setOrder('DESC');
        $criteria->setSort('user_regdate');
        $criteria->setLimit($limit);
        $lastmembers  = $memberHandler->getUsers($criteria);
        $lastusername = $lastmembers[0]->getVar('uname');
        $lastrealname = $lastmembers[0]->getVar('name');
        $lastid       = $lastmembers[0]->getVar('uid');

        //Total Post Count
        $sql                 = 'SELECT SUM(posts) AS totalposts FROM ' . $GLOBALS['xoopsDB']->prefix('users') . ' WHERE level > 0';
        $result              = $GLOBALS['xoopsDB']->query($sql);
        $myrow               = $GLOBALS['xoopsDB']->fetchArray($result);
        $block['totalposts'] = $myrow['totalposts']. ' ' . _MB_XOOPSMEMBERS_TOTALPOSTS;
		 

        // data
        $block['activeusers']    = $total_active_users. ' ' . _MB_XOOPSMEMBERS_REGISTEREDMEMBERS;
        $block['todayreg']       = $users_reg_24   . ' ' . _MB_XOOPSMEMBERS_REGISTEREDTODAY . ' ' . _MB_XOOPSMEMBERS_AND;
        $block['yesterdayreg']   = $users_reg_48 - $users_reg_24    . ' ' . _MB_XOOPSMEMBERS_REGISTEREDYESTERDAY;
        $block['online_names']   = $members;
        $block['online_members'] = $total - $guests  . ' ' . _MB_XOOPSMEMBERS_MEMBERS . ' ' . _MB_XOOPSMEMBERS_CURRENTONLINE;
        $block['online_guests']  = $guests . ' ' . _MB_XOOPSMEMBERS_GUESTS . ' ' . _MB_XOOPSMEMBERS_AND;
        $block['lang_more']      = _MB_XOOPSMEMBERS_MORE;

        $block['total_online'] = $total;

        if ('1' == $options[4] && '' != $lastrealname) {
            $block['latestmember'] = $lastrealname;
        } else {
            $block['latestmember'] = $lastusername;
        }
        $block['latest_id'] = $lastid;

        // Language Definition
        $block['membership_lang']          = _MB_XOOPSMEMBERS_MEMBERSHIP;
        $block['newestmember_lang']        = _MB_XOOPSMEMBERS_NEWESTMEMBER;
        $block['showtotalpost']            = $options[0];
        $block['showtotalonline']          = $options[1];
        $block['showreghistory']           = $options[2];
        $block['shownewmember']            = $options[3];
        $block['userealname']              = $options[4];

        return $block;
    } else {
        return false;
    }
}

/**
 * @param $options
 * @return string
 */
function membersstats_edit($options)
{
    $form = _MB_XOOPSMEMBERS_SHOWTOTALPOST . ' ';
    if (1 == $options[0]) {
        $chk = " checked";
    }
    $form .= "<input type='radio' name='options[0]' value='1'" . $chk . ' >&nbsp;' . _YES . '';

The variable $chk does not seem to be defined for all execution paths leading up to this point.

    $chk  = '';
    if (0 == $options[0]) {
        $chk = " checked";
    }
    $form .= "&nbsp;<input type='radio' name='options[0]' value='0'" . $chk . ' >' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWTOTALONLINE . '&nbsp;';
    if (1 == $options[1]) {
        $chk = " checked";
    }
    $form .= "<input type='radio' name='options[1]' value='1'" . $chk . ' >&nbsp;' . _YES . '';
    $chk  = '';
    if (0 == $options[1]) {
        $chk = " checked";
    }
    $form .= "&nbsp;<input type='radio' name='options[1]' value='0'" . $chk . ' >' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWREGHISTORY . '&nbsp;';
    if (1 == $options[2]) {
        $chk = " checked";
    }
    $form .= "<input type='radio' name='options[2]' value='1'" . $chk . ' >&nbsp;' . _YES . '';
    $chk  = '';
    if (0 == $options[2]) {
        $chk = " checked";
    }
    $form .= "&nbsp;<input type='radio' name='options[2]' value='0'" . $chk . ' >' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWNEWMEMBER . '&nbsp;';
    if (1 == $options[3]) {
        $chk = " checked";
    }
    $form .= "<input type='radio' name='options[3]' value='1'" . $chk . ' >&nbsp;' . _YES . '';
    $chk  = '';
    if (0 == $options[3]) {
        $chk = " checked";
    }
    $form .= "&nbsp;<input type='radio' name='options[3]' value='0'" . $chk . ' >' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_USEREALNAME . '&nbsp;';
    if (1 == $options[4]) {
        $chk = " checked";
    }
    $form .= "<input type='radio' name='options[4]' value='1'" . $chk . ' >&nbsp;' . _YES . '';
    $chk  = '';
    if (0 == $options[4]) {
        $chk = " checked";
    }
    $form .= "&nbsp;<input type='radio' name='options[4]' value='0'" . $chk . ' >' . _NO . '<br>';

    return $form;
}