memberswelcome_edit() - Code Metrics - Inspection of "updates" - XoopsModules25x/xoopsmembers - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#15)

unknown

created 2020-04-12 13:44 UTC

memberswelcome_edit() A

↳ Parent: Project

Complexity

Conditions	5
Paths	16

Size

Total Lines	25
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	17
c	1
b	0
f	0
nc	16
nop	1
dl	0
loc	25
rs	9.3888

<?php
// Author: Lio MJ
// Website: https://www.github.com/liomj/

if( ! defined( 'XOOPS_ROOT_PATH' ) ) exit ;
   
    function show_memberswelcome_block($options) {
	    global $xoopsConfig, $xoopsUser, $xoopsModule, $xoopsDB, $_SERVER;

		if (is_object($xoopsUser)) {
        $block['uid']=$xoopsUser->getVar('uid');

		$realname=$xoopsUser->getVar('name');
		
		if ($options[1]=='1' && $realname!='')
		{
        $block['membername']=$xoopsUser->getVar('name');
        }
		else
		{	
		$block['membername']=$xoopsUser->getVar('uname');
		}
		$block['user_avatar']=$xoopsUser->getVar('user_avatar');

		$ranking=$xoopsUser->rank();        
		$block['rankimage']=$ranking['image'];
		$block['ranktitle']=$ranking['title'];
		$block['showrank'] = $options[0];
		}
	 
    return $block; 

}


function memberswelcome_edit($options) {
	
$form = _MB_XOOPSMEMBERS_SHOWMEMBERSRANK."&nbsp;";
	if ( $options[0] == 1 ) {
		$chk = " checked='checked'";
	}
	$form .= "<input type='radio' name='options[0]' value='1'".$chk." />&nbsp;"._YES."";

	$chk = "";
	if ( $options[0] == 0 ) {
		$chk = " checked='checked'";
	}
	$form .= "&nbsp;<input type='radio' name='options[0]' value='0'".$chk." />"._NO."<br />";

	$form .= _MB_XOOPSMEMBERS_USEREALNAME."&nbsp;";
	if ( $options[1] == 1 ) {
		$chk = " checked='checked'";
	}
	$form .= "<input type='radio' name='options[1]' value='1'".$chk." />&nbsp;"._YES."";
	$chk = "";
	if ( $options[1] == 0 ) {
		$chk = " checked='checked'";
	}
	$form .= "&nbsp;<input type='radio' name='options[1]' value='0'".$chk." />"._NO."<br />";

	return $form;
}

?>



1			<?php
2			// Author: Lio MJ
3			// Website: https://www.github.com/liomj/
4
5			if( ! defined( 'XOOPS_ROOT_PATH' ) ) exit ;
6
7			function show_memberswelcome_block($options) {
8			global $xoopsConfig, $xoopsUser, $xoopsModule, $xoopsDB, $_SERVER;
9
10			if (is_object($xoopsUser)) {
11			$block['uid']=$xoopsUser->getVar('uid');
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-12 13:46 UTC by Report Bug Copy Issue Report `$block` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$block = array();` before regardless. Loading history...
12			$realname=$xoopsUser->getVar('name');
13
14			if ($options[1]=='1' && $realname!='')
15			{
16			$block['membername']=$xoopsUser->getVar('name');
17			}
18			else
19			{
20			$block['membername']=$xoopsUser->getVar('uname');
21			}
22			$block['user_avatar']=$xoopsUser->getVar('user_avatar');
23
24			$ranking=$xoopsUser->rank();
25			$block['rankimage']=$ranking['image'];
26			$block['ranktitle']=$ranking['title'];
27			$block['showrank'] = $options[0];
28			}
29
30			return $block;
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-12 13:46 UTC by Report Bug Copy Issue Report The variable `$block` does not seem to be defined for all execution paths leading up to this point. Loading history...
31			}
32
33
34			function memberswelcome_edit($options) {
35
36			$form = _MB_XOOPSMEMBERS_SHOWMEMBERSRANK." ";
37			if ( $options[0] == 1 ) {
38			$chk = " checked='checked'";
39			}
40			$form .= "<input type='radio' name='options[0]' value='1'".$chk." /> "._YES."";
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-12 13:46 UTC by Report Bug Copy Issue Report The variable `$chk` does not seem to be defined for all execution paths leading up to this point. Loading history...
41			$chk = "";
42			if ( $options[0] == 0 ) {
43			$chk = " checked='checked'";
44			}
45			$form .= " <input type='radio' name='options[0]' value='0'".$chk." />"._NO."<br />";
46
47			$form .= _MB_XOOPSMEMBERS_USEREALNAME." ";
48			if ( $options[1] == 1 ) {
49			$chk = " checked='checked'";
50			}
51			$form .= "<input type='radio' name='options[1]' value='1'".$chk." /> "._YES."";
52			$chk = "";
53			if ( $options[1] == 0 ) {
54			$chk = " checked='checked'";
55			}
56			$form .= " <input type='radio' name='options[1]' value='0'".$chk." />"._NO."<br />";
57
58			return $form;
59			}
60
61			?>
			0 ignored issues – show Best Practice introduced 2020-04-12 13:46 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
62

XoopsModules25x / xoopsmembers

Pull Request — master (#15)

memberswelcome_edit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like