Issues in class.updatenotifier.inc.php (master) - Issues in master - XoopsModules25x/xoopsinfo - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1626)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

updatenotifier/class.updatenotifier.inc.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * UpdateNotifier Plugin
 *
 * PHP version 5
 *
 * @category  PHP
 * @package   PSI_Plugin_UpdateNotifier
 * @author    Damien ROTH <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   SVN: $Id: class.updatenotifier.inc.php 661 2012-08-27 11:26:39Z namiltd $
 * @link      http://phpsysinfo.sourceforge.net
 */
/**
 * UpdateNotifier Plugin, which displays update notification from Ubuntu Landscape system
 *
 * @category  PHP
 * @package   PSI_Plugin_UpdateNotifier
 * @author    Damien ROTH <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   $Id: class.updatenotifier.inc.php 661 2012-08-27 11:26:39Z namiltd $
 * @link      http://phpsysinfo.sourceforge.net
 */
class UpdateNotifier extends PSI_Plugin
namespace YourVendor;

class YourClass { }
{
    /**
     * variable, which holds the content of the command
     * @var array
     */
    private $_filecontent = array();

    /**
     * variable, which holds the result before the xml is generated out of this array
     * @var array
     */
    private $_result = array();

    /**
     * read the data into an internal array and also call the parent constructor
     *
     * @param String $enc encoding
     */
    public function __construct($enc)
    {
        parent::__construct(__CLASS__, $enc);

        CommonFunctions::rfts(PSI_PLUGIN_UPDATENOTIFIER_FILE, $buffer_info);
        // Remove blank lines
        $this->_filecontent = preg_split("/\n/", $buffer_info, -1, PREG_SPLIT_NO_EMPTY);
    }

    /**
     * doing all tasks to get the required informations that the plugin needs
     * result is stored in an internal array
     *
     * @return void
     */
    public function execute()
    {
        if (empty($this->_filecontent)) {
            return;
        }

        if (PSI_PLUGIN_UPDATENOTIFIER_UBUNTU_LANDSCAPE_FORMAT === true) {
            /*
             Ubuntu Landscape format:
             - line 1: packages to update
             - line 2: security packages to update
             */
            if (count($this->_filecontent) == 2) {
                foreach ($this->_filecontent as $line) {
                    list($num, $text) = explode(" ", $line, 2);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                    $this->_result[] = $num;
                }
            } else {
                $this->global_error->addWarning("Unable to parse UpdateNotifier file");
            }
        } else {
            /*
             Universal format: A;B
             - A: packages to update
             - B: security packages to update
             */
            if (count($this->_filecontent) == 1 && strpos($this->_filecontent[0], ";") !== false) {
                $this->_result = explode(";", $this->_filecontent[0]);
            } else {
                $this->global_error->addWarning("Unable to parse UpdateNotifier file");
            }
        }
    }

    /**
     * generates the XML content for the plugin
     *
     * @return SimpleXMLElement entire XML content for the plugin
     */
    public function xml()
    {
        if (!empty($this->_result)) {
            $xmluu = $this->xml->addChild("UpdateNotifier");
            $xmluu->addChild("packages", $this->_result[0]);
            $xmluu->addChild("security", $this->_result[1]);
        }

        return $this->xml->getSimpleXmlElement();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2			/**
3			* UpdateNotifier Plugin
4			*
5			* PHP version 5
6			*
7			* @category PHP
8			* @package PSI_Plugin_UpdateNotifier
9			* @author Damien ROTH <[email protected]>
10			* @copyright 2009 phpSysInfo
11			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
12			* @version SVN: $Id: class.updatenotifier.inc.php 661 2012-08-27 11:26:39Z namiltd $
13			* @link http://phpsysinfo.sourceforge.net
14			*/
15			/**
16			* UpdateNotifier Plugin, which displays update notification from Ubuntu Landscape system
17			*
18			* @category PHP
19			* @package PSI_Plugin_UpdateNotifier
20			* @author Damien ROTH <[email protected]>
21			* @copyright 2009 phpSysInfo
22			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
23			* @version $Id: class.updatenotifier.inc.php 661 2012-08-27 11:26:39Z namiltd $
24			* @link http://phpsysinfo.sourceforge.net
25			*/
26			class UpdateNotifier extends PSI_Plugin
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
27			{
28			/**
29			* variable, which holds the content of the command
30			* @var array
31			*/
32			private $_filecontent = array();
33
34			/**
35			* variable, which holds the result before the xml is generated out of this array
36			* @var array
37			*/
38			private $_result = array();
39
40			/**
41			* read the data into an internal array and also call the parent constructor
42			*
43			* @param String $enc encoding
44			*/
45			public function __construct($enc)
46			{
47			parent::__construct(__CLASS__, $enc);
48
49			CommonFunctions::rfts(PSI_PLUGIN_UPDATENOTIFIER_FILE, $buffer_info);
50			// Remove blank lines
51			$this->_filecontent = preg_split("/\n/", $buffer_info, -1, PREG_SPLIT_NO_EMPTY);
52			}
53
54			/**
55			* doing all tasks to get the required informations that the plugin needs
56			* result is stored in an internal array
57			*
58			* @return void
59			*/
60			public function execute()
61			{
62			if (empty($this->_filecontent)) {
63			return;
64			}
65
66			if (PSI_PLUGIN_UPDATENOTIFIER_UBUNTU_LANDSCAPE_FORMAT === true) {
67			/*
68			Ubuntu Landscape format:
69			- line 1: packages to update
70			- line 2: security packages to update
71			*/
72			if (count($this->_filecontent) == 2) {
73			foreach ($this->_filecontent as $line) {
74			list($num, $text) = explode(" ", $line, 2);
			0 ignored issues – show Unused Code introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$text` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
75			$this->_result[] = $num;
76			}
77			} else {
78			$this->global_error->addWarning("Unable to parse UpdateNotifier file");
79			}
80			} else {
81			/*
82			Universal format: A;B
83			- A: packages to update
84			- B: security packages to update
85			*/
86			if (count($this->_filecontent) == 1 && strpos($this->_filecontent[0], ";") !== false) {
87			$this->_result = explode(";", $this->_filecontent[0]);
88			} else {
89			$this->global_error->addWarning("Unable to parse UpdateNotifier file");
90			}
91			}
92			}
93
94			/**
95			* generates the XML content for the plugin
96			*
97			* @return SimpleXMLElement entire XML content for the plugin
98			*/
99			public function xml()
100			{
101			if (!empty($this->_result)) {
102			$xmluu = $this->xml->addChild("UpdateNotifier");
103			$xmluu->addChild("packages", $this->_result[0]);
104			$xmluu->addChild("security", $this->_result[1]);
105			}
106
107			return $this->xml->getSimpleXmlElement();
			0 ignored issues – show Bug Best Practice introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->xml->getSimpleXmlElement();` (`SimpleXMLElement`) is incompatible with the return type declared by the interface `PSI_Interface_Plugin::xml` of type `SimpleXMLObject`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
108			}
109			}
110

XoopsModules25x / xoopsinfo

Issues (1626)

Security Analysis not enabled

updatenotifier/class.updatenotifier.inc.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like