Issues in class.Template.inc.php (master) - Issues in master - XoopsModules25x/xoopsinfo - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1626)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

phpsysinfo/includes/output/class.Template.inc.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * basic output functions
 *
 * PHP version 5
 *
 * @category  PHP
 * @package   PSI_Output
 * @author    Damien Roth <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   SVN: $Id: class.Output.inc.php 315 2009-09-02 15:48:31Z bigmichi1 $
 * @link      http://phpsysinfo.sourceforge.net
 */
/**
 * basic output functions for all output formats
 *
 * @category  PHP
 * @package   PSI_Output
 * @author    Damien Roth <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   Release: 3.0
 * @link      http://phpsysinfo.sourceforge.net
 */
class Template
namespace YourVendor;

class YourClass { }
{
    /**
     * Vars used in the template
     *
     * @Array
     */
    private $_vars;

    /**
     * Template file
     *
     * @String
     */
    private $_file;

    /**
     * Constructor
     *
     * @param String $file the template file name

     */
    public function __construct($file=null)
    {
        $this->_file = $file;
        $this->_vars = array();
    }

    /**
     * Set a template variable.
     *
     * @param string variable name
     * @param string variable value
     */
    public function set($name, $value)
    {
        $this->_vars[$name] = is_object($value) ? $value->fetch() : $value;
    }

    /**
     * Open, parse, and return the template file.
     *
     * @param string $file

     *
     * @return string
     */
    public function fetch($file=null)
    {
        if (!$file) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $file = $this->_file;
        }

        // Extract the vars to local namespace
        extract($this->_vars);

        // Start output buffering
        ob_start();

        include(APP_ROOT.$file);

        // Get the contents of the buffer
        $contents = ob_get_contents();

        // End buffering and discard
        ob_end_clean();

        return $contents;
    }
}


1			<?php
2			/**
3			* basic output functions
4			*
5			* PHP version 5
6			*
7			* @category PHP
8			* @package PSI_Output
9			* @author Damien Roth <[email protected]>
10			* @copyright 2009 phpSysInfo
11			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
12			* @version SVN: $Id: class.Output.inc.php 315 2009-09-02 15:48:31Z bigmichi1 $
13			* @link http://phpsysinfo.sourceforge.net
14			*/
15			/**
16			* basic output functions for all output formats
17			*
18			* @category PHP
19			* @package PSI_Output
20			* @author Damien Roth <[email protected]>
21			* @copyright 2009 phpSysInfo
22			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
23			* @version Release: 3.0
24			* @link http://phpsysinfo.sourceforge.net
25			*/
26			class Template
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
27			{
28			/**
29			* Vars used in the template
30			*
31			* @Array
32			*/
33			private $_vars;
34
35			/**
36			* Template file
37			*
38			* @String
39			*/
40			private $_file;
41
42			/**
43			* Constructor
44			*
45			* @param String $file the template file name
			0 ignored issues – show Documentation introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$file` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
46			*/
47			public function __construct($file=null)
48			{
49			$this->_file = $file;
50			$this->_vars = array();
51			}
52
53			/**
54			* Set a template variable.
55			*
56			* @param string variable name
57			* @param string variable value
58			*/
59			public function set($name, $value)
60			{
61			$this->_vars[$name] = is_object($value) ? $value->fetch() : $value;
62			}
63
64			/**
65			* Open, parse, and return the template file.
66			*
67			* @param string $file
			0 ignored issues – show Documentation introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$file` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
68			*
69			* @return string
70			*/
71			public function fetch($file=null)
72			{
73			if (!$file) {
			0 ignored issues – show Bug Best Practice introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$file` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
74			$file = $this->_file;
75			}
76
77			// Extract the vars to local namespace
78			extract($this->_vars);
79
80			// Start output buffering
81			ob_start();
82
83			include(APP_ROOT.$file);
84
85			// Get the contents of the buffer
86			$contents = ob_get_contents();
87
88			// End buffering and discard
89			ob_end_clean();
90
91			return $contents;
92			}
93			}
94

XoopsModules25x / xoopsinfo

Issues (1626)

Security Analysis not enabled

phpsysinfo/includes/output/class.Template.inc.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like