DragonFly::build() - Code Metrics - XoopsModules25x/xoopsinfo - Measure and Improve Code Quality continuously with Scrutinizer

DragonFly::build() A
last analyzed 2017-05-24 06:12 UTC

↳ Parent: DragonFly

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	0
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * DragonFly System Class
 *
 * PHP version 5
 *
 * @category  PHP
 * @package   PSI DragonFly OS class
 * @author    Michael Cramer <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   SVN: $Id: class.DragonFly.inc.php 287 2009-06-26 12:11:59Z bigmichi1 $
 * @link      http://phpsysinfo.sourceforge.net
 */
 /**
 * DragonFly sysinfo class
 * get all the required information from DragonFly system
 *
 * @category  PHP
 * @package   PSI DragonFly OS class
 * @author    Michael Cramer <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   Release: 3.0
 * @link      http://phpsysinfo.sourceforge.net
 */
class DragonFly extends BSDCommon
namespace YourVendor;

class YourClass { }
{
    /**
     * define the regexp for log parser
     */
    public function __construct()

    {
        parent::__construct();
        $this->setCPURegExp1("/^cpu(.*)\, (.*) MHz/");
        $this->setCPURegExp2("/^(.*) at scsibus.*: <(.*)> .*/");
        $this->setSCSIRegExp2("/^(da[0-9]+): (.*)MB /");
        $this->setPCIRegExp1("/(.*): <(.*)>(.*) (pci|legacypci)[0-9]+$/");
        $this->setPCIRegExp2("/(.*): <(.*)>.* at [0-9\.]+$/");
    }

    /**
     * UpTime
     * time the system is running
     *
     * @return void
     */
    private function _uptime()
    {
        $a = $this->grab_key('kern.boottime');

        preg_match("/sec = ([0-9]+)/", $a, $buf);
        $this->sys->setUptime(time() - $buf[1]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * get network information
     *
     * @return array

     */
    private function _network()
    {
        CommonFunctions::executeProgram('netstat', '-nbdi | cut -c1-25,44- | grep "^[a-z]*[0-9][ \t].*Link"', $netstat_b);
        CommonFunctions::executeProgram('netstat', '-ndi | cut -c1-25,44- | grep "^[a-z]*[0-9][ \t].*Link"', $netstat_n);
        $lines_b = preg_split("/\n/", $netstat_b, -1, PREG_SPLIT_NO_EMPTY);
        $lines_n = preg_split("/\n/", $netstat_n, -1, PREG_SPLIT_NO_EMPTY);
        for ($i = 0, $max = sizeof($lines_b); $i < $max; $i++) {
            $ar_buf_b = preg_split("/\s+/", $lines_b[$i]);
            $ar_buf_n = preg_split("/\s+/", $lines_n[$i]);
            if (!empty($ar_buf_b[0]) && (!empty($ar_buf_n[5]) || ($ar_buf_n[5] === "0"))) {
                $dev = new NetDevice();
                $dev->setName($ar_buf_b[0]);
                $dev->setTxBytes($ar_buf_b[8]);
                $dev->setRxBytes($ar_buf_b[5]);
                $dev->setErrors($ar_buf_n[4] + $ar_buf_n[6]);
                $dev->setDrops($ar_buf_n[8]);
                $this->sys->setNetDevices($dev);
            }
        }
    }

    /**
     * get the ide information
     *
     * @return array

     */
    protected function ide()
    {
        foreach ($this->readdmesg() as $line) {
            if (preg_match('/^(.*): (.*) <(.*)> at (ata[0-9]+\-(.*)) (.*)/', $line, $ar_buf)) {
                $dev = new HWDevice();
                $dev->setName($ar_buf[1]);
                if (!preg_match("/^acd[0-9]+(.*)/", $ar_buf[1])) {
                    $dev->setCapacity($ar_buf[2] * 1024);
                }
                $this->sys->setIdeDevices($dev);
            }
        }
    }

    /**
     * get icon name
     *
     * @return void
     */
    private function _distroicon()
    {
        $this->sys->setDistributionIcon('DragonFly.png');
    }

    /**
     * Processes
     *
     * @return void
     */
    protected function _processes()

    {
        if (CommonFunctions::executeProgram('ps', 'aux', $bufr, PSI_DEBUG)) {
            $lines = preg_split("/\n/", $bufr, -1, PREG_SPLIT_NO_EMPTY);
            $processes['*'] = 0;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            foreach ($lines as $line) {
                if (preg_match("/^\S+\s+\d+\s+\S+\s+\S+\s+\d+\s+\d+\s+\S+\s+(\w)/", $line, $ar_buf)) {
                    $processes['*']++;
                    $state = $ar_buf[1];
                    if ($state == 'I') $state = 'S'; //linux format
                    if (isset($processes[$state])) {
                        $processes[$state]++;
                    } else {
                        $processes[$state] = 1;
                    }
                }
            }
            if ($processes['*'] > 0) {
                $this->sys->setProcesses($processes);
            }
        }
    }

    /**
     * get the information
     *
     * @see BSDCommon::build()
     *
     * @return Void
     */
    public function build()
    {
        parent::build();
        $this->_distroicon();
        $this->_network();
        $this->_uptime();
        $this->_processes();
    }
}


1		<?php
2		/**
3		* DragonFly System Class
4		*
5		* PHP version 5
6		*
7		* @category PHP
8		* @package PSI DragonFly OS class
9		* @author Michael Cramer <[email protected]>
10		* @copyright 2009 phpSysInfo
11		* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
12		* @version SVN: $Id: class.DragonFly.inc.php 287 2009-06-26 12:11:59Z bigmichi1 $
13		* @link http://phpsysinfo.sourceforge.net
14		*/
15		/**
16		* DragonFly sysinfo class
17		* get all the required information from DragonFly system
18		*
19		* @category PHP
20		* @package PSI DragonFly OS class
21		* @author Michael Cramer <[email protected]>
22		* @copyright 2009 phpSysInfo
23		* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
24		* @version Release: 3.0
25		* @link http://phpsysinfo.sourceforge.net
26		*/
27		class DragonFly extends BSDCommon
		0 ignored issues – show Coding Style Compatibility introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
28		{
29		/**
30		* define the regexp for log parser
31		*/
32	View Code Duplication	public function __construct()
		0 ignored issues – show Duplication introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		parent::__construct();
35		$this->setCPURegExp1("/^cpu(.)\, (.) MHz/");
36		$this->setCPURegExp2("/^(.) at scsibus.: <(.)> ./");
37		$this->setSCSIRegExp2("/^(da[0-9]+): (.*)MB /");
38		$this->setPCIRegExp1("/(.): <(.)>(.*) (pci\|legacypci)[0-9]+$/");
39		$this->setPCIRegExp2("/(.): <(.)>.* at [0-9\.]+$/");
40		}
41
42		/**
43		* UpTime
44		* time the system is running
45		*
46		* @return void
47		*/
48		private function _uptime()
49		{
50		$a = $this->grab_key('kern.boottime');
		0 ignored issues – show Bug introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report The method `grab_key()` does not exist on `DragonFly`. Did you maybe mean `grabkey()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
51		preg_match("/sec = ([0-9]+)/", $a, $buf);
52		$this->sys->setUptime(time() - $buf[1]);
		0 ignored issues – show Documentation introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report `time() - $buf[1]` is of type `integer\|double`, but the function expects a `object<Interger>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53		}
54
55		/**
56		* get network information
57		*
58		* @return array
		0 ignored issues – show Documentation introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Should the return type not be `array\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
59		*/
60		private function _network()
61		{
62		CommonFunctions::executeProgram('netstat', '-nbdi \| cut -c1-25,44- \| grep "^[a-z][0-9][ \t].Link"', $netstat_b);
63		CommonFunctions::executeProgram('netstat', '-ndi \| cut -c1-25,44- \| grep "^[a-z][0-9][ \t].Link"', $netstat_n);
64		$lines_b = preg_split("/\n/", $netstat_b, -1, PREG_SPLIT_NO_EMPTY);
65		$lines_n = preg_split("/\n/", $netstat_n, -1, PREG_SPLIT_NO_EMPTY);
66		for ($i = 0, $max = sizeof($lines_b); $i < $max; $i++) {
67		$ar_buf_b = preg_split("/\s+/", $lines_b[$i]);
68		$ar_buf_n = preg_split("/\s+/", $lines_n[$i]);
69		if (!empty($ar_buf_b[0]) && (!empty($ar_buf_n[5]) \|\| ($ar_buf_n[5] === "0"))) {
70		$dev = new NetDevice();
71		$dev->setName($ar_buf_b[0]);
72		$dev->setTxBytes($ar_buf_b[8]);
73		$dev->setRxBytes($ar_buf_b[5]);
74		$dev->setErrors($ar_buf_n[4] + $ar_buf_n[6]);
75		$dev->setDrops($ar_buf_n[8]);
76		$this->sys->setNetDevices($dev);
77		}
78		}
79		}
80
81		/**
82		* get the ide information
83		*
84		* @return array
		0 ignored issues – show Documentation introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Should the return type not be `array\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
85		*/
86		protected function ide()
87		{
88		foreach ($this->readdmesg() as $line) {
89		if (preg_match('/^(.): (.) <(.)> at (ata[0-9]+\-(.)) (.*)/', $line, $ar_buf)) {
90		$dev = new HWDevice();
91		$dev->setName($ar_buf[1]);
92		if (!preg_match("/^acd[0-9]+(.*)/", $ar_buf[1])) {
93		$dev->setCapacity($ar_buf[2] * 1024);
94		}
95		$this->sys->setIdeDevices($dev);
96		}
97		}
98		}
99
100		/**
101		* get icon name
102		*
103		* @return void
104		*/
105		private function _distroicon()
106		{
107		$this->sys->setDistributionIcon('DragonFly.png');
108		}
109
110		/**
111		* Processes
112		*
113		* @return void
114		*/
115	View Code Duplication	protected function _processes()
		0 ignored issues – show Duplication introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		if (CommonFunctions::executeProgram('ps', 'aux', $bufr, PSI_DEBUG)) {
118		$lines = preg_split("/\n/", $bufr, -1, PREG_SPLIT_NO_EMPTY);
119		$processes['*'] = 0;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report `$processes` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$processes = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
120		foreach ($lines as $line) {
121		if (preg_match("/^\S+\s+\d+\s+\S+\s+\S+\s+\d+\s+\d+\s+\S+\s+(\w)/", $line, $ar_buf)) {
122		$processes['*']++;
123		$state = $ar_buf[1];
124		if ($state == 'I') $state = 'S'; //linux format
125		if (isset($processes[$state])) {
126		$processes[$state]++;
127		} else {
128		$processes[$state] = 1;
129		}
130		}
131		}
132		if ($processes['*'] > 0) {
133		$this->sys->setProcesses($processes);
134		}
135		}
136		}
137
138		/**
139		* get the information
140		*
141		* @see BSDCommon::build()
142		*
143		* @return Void
144		*/
145		public function build()
146		{
147		parent::build();
148		$this->_distroicon();
149		$this->_network();
150		$this->_uptime();
151		$this->_processes();
152		}
153		}
154

XoopsModules25x / xoopsinfo

DragonFly::build() A last analyzed 2017-05-24 06:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DragonFly::build() A
last analyzed 2017-05-24 06:12 UTC