UPS - Code Metrics - XoopsModules25x/xoopsinfo - Measure and Improve Code Quality continuously with Scrutinizer

UPS A
last analyzed 2017-05-24 06:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	39
rs	10
c	0
b	0
f	0
wmc	2
lcom	1
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getUPSInfo()	0	6	1

<?php
/**
 * Basic UPS Class
 *
 * PHP version 5
 *
 * @category  PHP
 * @package   PSI_UPS
 * @author    Michael Cramer <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   SVN: $Id: class.ups.inc.php 661 2012-08-27 11:26:39Z namiltd $
 * @link      http://phpsysinfo.sourceforge.net
 */
 /**
 * Basic UPS functions for all UPS classes
 *
 * @category  PHP
 * @package   PSI_UPS
 * @author    Michael Cramer <[email protected]>
 * @copyright 2009 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   Release: 3.0
 * @link      http://phpsysinfo.sourceforge.net
 */
abstract class UPS implements PSI_Interface_UPS
namespace YourVendor;

class YourClass { }
{
    /**
     * object for error handling
     *
     * @var Error
     */
    public $error;

    /**
     * main object for ups information
     *
     * @var UPSInfo
     */
    protected $upsinfo;

    /**
     * build the global Error object
     */
    public function __construct()
    {
        $this->error = PSI_Error::singleton();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->upsinfo = new UPSInfo();
    }

    /**
     * build and return the ups information
     *
     * @see PSI_Interface_UPS::getUPSInfo()
     *
     * @return UPSInfo
     */
    final public function getUPSInfo()
    {
        $this->build();

        return $this->upsinfo;
    }
}


1			<?php
2			/**
3			* Basic UPS Class
4			*
5			* PHP version 5
6			*
7			* @category PHP
8			* @package PSI_UPS
9			* @author Michael Cramer <[email protected]>
10			* @copyright 2009 phpSysInfo
11			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
12			* @version SVN: $Id: class.ups.inc.php 661 2012-08-27 11:26:39Z namiltd $
13			* @link http://phpsysinfo.sourceforge.net
14			*/
15			/**
16			* Basic UPS functions for all UPS classes
17			*
18			* @category PHP
19			* @package PSI_UPS
20			* @author Michael Cramer <[email protected]>
21			* @copyright 2009 phpSysInfo
22			* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
23			* @version Release: 3.0
24			* @link http://phpsysinfo.sourceforge.net
25			*/
26			abstract class UPS implements PSI_Interface_UPS
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
27			{
28			/**
29			* object for error handling
30			*
31			* @var Error
32			*/
33			public $error;
34
35			/**
36			* main object for ups information
37			*
38			* @var UPSInfo
39			*/
40			protected $upsinfo;
41
42			/**
43			* build the global Error object
44			*/
45			public function __construct()
46			{
47			$this->error = PSI_Error::singleton();
			0 ignored issues – show Bug introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->error` is correct as `\PSI_Error::singleton()` (which targets `PSI_Error::singleton()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
48			$this->upsinfo = new UPSInfo();
49			}
50
51			/**
52			* build and return the ups information
53			*
54			* @see PSI_Interface_UPS::getUPSInfo()
55			*
56			* @return UPSInfo
57			*/
58			final public function getUPSInfo()
59			{
60			$this->build();
61
62			return $this->upsinfo;
63			}
64			}
65

XoopsModules25x / xoopsinfo

UPS A last analyzed 2017-05-24 06:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

UPS A
last analyzed 2017-05-24 06:12 UTC