Pmset - Code Metrics - XoopsModules25x/xoopsinfo - Measure and Improve Code Quality continuously with Scrutinizer

Pmset A
last analyzed 2017-05-24 06:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	12.31 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	8
loc	65
rs	10
c	0
b	0
f	0
wmc	8
lcom	1
cbo	4

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	8	8	2
B	_info()	0	26	5
A	build()	0	4	1

How to fix Duplicated Code

<?php
/**
 * Pmset class
 *
 * PHP version 5
 *
 * @category  PHP
 * @package   PSI_UPS
 * @author    Robert Pelletier <[email protected]>
 * @copyright 2014 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   SVN: $Id: class.nut.inc.php 661 2012-08-27 11:26:39Z namiltd $
 * @link      http://phpsysinfo.sourceforge.net
 */
 /**
 * getting ups information from pmset program
 *
 * @category  PHP
 * @package   PSI_UPS
 * @author    Robert Pelletier <[email protected]>
 * @copyright 2014 phpSysInfo
 * @license   http://opensource.org/licenses/gpl-2.0.php GNU General Public License
 * @version   Release: 3.0
 * @link      http://phpsysinfo.sourceforge.net
 */
class Pmset extends UPS
namespace YourVendor;

class YourClass { }
{
    /**
     * internal storage for all gathered data
     *
     * @var array
     */
    private $_output = array();

    /**
     * get all information from all configured ups and store output in internal array
     */
    public function __construct()

    {
        parent::__construct();
        CommonFunctions::executeProgram('pmset', '-g batt', $temp);
        if (! empty($temp)) {
            $this->_output[] = $temp;
        }
    }

    /**
     * parse the input and store data in resultset for xml generation
     *
     * @return array

     */
   private function _info()
    {
        $model = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $percCharge = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $lines = explode(PHP_EOL, implode($this->_output));
        $dev = new UPSDevice();
        $model = explode('FW:',  $lines[1]);
        if (strpos($model[0], 'InternalBattery') === false) {
            $percCharge = explode(';',  $lines[1]);
            $dev->setName('UPS');
            if ($model !== false) {
                $dev->setModel(substr(trim($model[0]), 1));
            }
            if ($percCharge !== false) {
                $dev->setBatterCharge(trim(substr($percCharge[0], -4, 3)));
                $dev->setStatus(trim($percCharge[1]));
                if (isset($percCharge[2])) {
                    $time = explode(':', $percCharge[2]);
                    $hours = $time[0];
                    $minutes = $hours*60+substr($time[1], 0, 2);
                    $dev->setTimeLeft($minutes);
                }
            }
            $this->upsinfo->setUpsDevices($dev);
        }
    }

    /**
     * get the information
     *
     * @see PSI_Interface_UPS::build()
     *
     * @return Void
     */
    public function build()
    {
        $this->_info();
    }
}


1		<?php
2		/**
3		* Pmset class
4		*
5		* PHP version 5
6		*
7		* @category PHP
8		* @package PSI_UPS
9		* @author Robert Pelletier <[email protected]>
10		* @copyright 2014 phpSysInfo
11		* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
12		* @version SVN: $Id: class.nut.inc.php 661 2012-08-27 11:26:39Z namiltd $
13		* @link http://phpsysinfo.sourceforge.net
14		*/
15		/**
16		* getting ups information from pmset program
17		*
18		* @category PHP
19		* @package PSI_UPS
20		* @author Robert Pelletier <[email protected]>
21		* @copyright 2014 phpSysInfo
22		* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
23		* @version Release: 3.0
24		* @link http://phpsysinfo.sourceforge.net
25		*/
26		class Pmset extends UPS
		0 ignored issues – show Coding Style Compatibility introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
27		{
28		/**
29		* internal storage for all gathered data
30		*
31		* @var array
32		*/
33		private $_output = array();
34
35		/**
36		* get all information from all configured ups and store output in internal array
37		*/
38	View Code Duplication	public function __construct()
		0 ignored issues – show Duplication introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		parent::__construct();
41		CommonFunctions::executeProgram('pmset', '-g batt', $temp);
42		if (! empty($temp)) {
43		$this->_output[] = $temp;
44		}
45		}
46
47		/**
48		* parse the input and store data in resultset for xml generation
49		*
50		* @return array
		0 ignored issues – show Documentation introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report Should the return type not be `array\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
51		*/
52		private function _info()
53		{
54		$model = array();
		0 ignored issues – show Unused Code introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report `$model` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55		$percCharge = array();
		0 ignored issues – show Unused Code introduced 2016-07-02 12:09 UTC by Report Bug Copy Issue Report `$percCharge` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
56		$lines = explode(PHP_EOL, implode($this->_output));
57		$dev = new UPSDevice();
58		$model = explode('FW:', $lines[1]);
59		if (strpos($model[0], 'InternalBattery') === false) {
60		$percCharge = explode(';', $lines[1]);
61		$dev->setName('UPS');
62		if ($model !== false) {
63		$dev->setModel(substr(trim($model[0]), 1));
64		}
65		if ($percCharge !== false) {
66		$dev->setBatterCharge(trim(substr($percCharge[0], -4, 3)));
67		$dev->setStatus(trim($percCharge[1]));
68		if (isset($percCharge[2])) {
69		$time = explode(':', $percCharge[2]);
70		$hours = $time[0];
71		$minutes = $hours*60+substr($time[1], 0, 2);
72		$dev->setTimeLeft($minutes);
73		}
74		}
75		$this->upsinfo->setUpsDevices($dev);
76		}
77		}
78
79		/**
80		* get the information
81		*
82		* @see PSI_Interface_UPS::build()
83		*
84		* @return Void
85		*/
86		public function build()
87		{
88		$this->_info();
89		}
90		}
91

XoopsModules25x / xoopsinfo

Pmset A last analyzed 2017-05-24 06:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Pmset A
last analyzed 2017-05-24 06:12 UTC