Issues in process_form.php (master) - Issues in master - XoopsModules25x/xoopshp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (102)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

process_form.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

//  ------------------------------------------------------------------------ //
//             --  XoopsHP Module --       Xoops e-Learning System           //
//                     Copyright (c) 2005 SUDOW-SOKEN                        //
//                      <http://www.mailpark.co.jp/>                         //
//  ------------------------------------------------------------------------ //
//               Based on XoopsHP1.01 by Yoshi, aka HowardGee.               //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //

// HTTP_REFERER ACTION CHECK -> DBQuery -> function.php error $_SERVER[$key]

// If can't use command "$_SERVER["HTTP_REFERER"]" , don't save portfolio DB.
// analyze by kazuo sudow.
//
// TEST-TEST-TEST-TEST
// global $referer;
// $referer = $_SERVER["HTTP_REFERER"];
// if (!empty($referer)) {
//	$_SERVER["HTTP_REFERER"] = "dummy";
//	$referer = $_SERVER["HTTP_REFERER"];
//}

include_once dirname(dirname(__DIR__)) . '/mainfile.php';
include_once(XOOPS_ROOT_PATH . '/include/cp_functions.php');
global $db, $xoopsConfig, $xoopsUser, $xoopsModule, $xoopsObject, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

if ($_SERVER['HTTP_HOST'] != $_SERVER['SERVER_NAME']) {
    exit('Access Denied');
} elseif (!isset($_COOKIE['xoopsHP_file_id'])) {
    exit('Oops, a problem in the cookie!');
}

// Get the file number
$quiz_id = (int)$_COOKIE['xoopsHP_file_id'];

// Delete cookie -> $quiz_id
setcookie('xoopsHP_file_id', '', time() - 3600);

// kazuo sudow
// - non pair Open-Close Table.. More Header Written BUG.
// OpenTable();

$myts       = MyTextSanitizer::getInstance();
$uid        = $xoopsUser ? $xoopsUser->getVar('uid') : 0;
$user_email = $xoopsUser ? $xoopsUser->getVar('email') : '';
$uname      = $xoopsUser ? $xoopsUser->getVar('uname') : '';
$username   = $xoopsUser ? $xoopsUser->getVar('name') : '';

// Get the instructor's email addy etc
$teacher_email = '';
include __DIR__ . '/module_prefix.php';
$result = $xoopsDB->query('SELECT secid, title, results_to FROM ' . $xoopsDB->prefix($module_prefix . '_quiz') . " WHERE artid=$quiz_id");
list($secid, $quiz_title, $teacher_email) = $xoopsDB->fetchRow($result);
$secid = (int)$secid;
include __DIR__ . '/module_prefix.php';
$result = $xoopsDB->query('SELECT secname FROM ' . $xoopsDB->prefix($module_prefix . '_sections') . " WHERE secid=$secid");
list($secname) = $xoopsDB->fetchRow($result);

// Get the form data
// kazuo sudow --> EUC-JP (1.04) Sanitizer & mb_convert_encoding
$userid = $myts->stripSlashesGPC($_POST['realname']);
// Check if mbstring is supported --Yoshi
if (XOOPS_USE_MULTIBYTES && function_exists('mb_convert_encoding') && $xoopsConfig['language'] === 'japanese') {
    $userid = mb_convert_encoding($userid, 'EUC-JP', 'auto');
}

// Get Score --> %
// kazuo sudow --> EUC-JP (1.04) Sanitizer
$score = $myts->stripSlashesGPC($_POST['Score']);

// kazuo sudow --> EUC-JP (1.04) Sanitizer
$start_time = $myts->stripSlashesGPC($_POST['Start_Time']);
$start_time = date('Y/m/d H:i:s', strtotime($start_time));

// kazuo sudow --> EUC-JP (1.04) Sanitizer
$end_time = $myts->stripSlashesGPC($_POST['End_Time']);
$end_time = date('Y/m/d H:i:s', strtotime($end_time));

$timestamp = date('Y/m/d H:i:s');
$comment   = '';

// Write in the db
if ($xoopsUser) {
    include __DIR__ . '/module_prefix.php';
    $query = 'INSERT INTO ' . $xoopsDB->prefix($module_prefix . '_results') . " (quiz_id, uid, score, start_time, end_time, timestamp, host, ip, comment) VALUES ('";
    $query .= $quiz_id . "','";
    $query .= $uid . "','";
    $query .= $score . "','";
    $query .= $start_time . "','";
    $query .= $end_time . "','";
    $query .= $timestamp . "','";
    $query .= gethostbyaddr($_SERVER['REMOTE_ADDR']) . "','";
    $query .= $_SERVER['REMOTE_ADDR'] . "','";
    $query .= $comment . "')";
    $result = $xoopsDB->query($query);
    // Count up the counter for the completion
    $quiz_id = (int)$quiz_id;
    include __DIR__ . '/module_prefix.php';
    $xoopsDB->query('UPDATE ' . $xoopsDB->prefix($module_prefix . '_quiz') . " SET counter=counter+1 WHERE artid=$quiz_id");
}

// E-MAIL SEND
// send mail only if user or teacher email option is checked
if ($xoopsModuleConfig['mail_teacher'] || $xoopsModuleConfig['mail_user']) {
    //generate message
    // kazuo sudow 1.04 (add ID)
    // original
    // $subject = "XoopsHP Feedback: $uname, $quiz_title";

    // $subject = mb_encode_mimeheader(mb_convert_kana($subject,"KV"),"ISO-2022-JP","B");

    $subject = htmlspecialchars($xoopsConfig['sitename']) . ' ' . $xoopsModule->getVar('name') . ':' . $quiz_title . ' ' . $uname;
    if (!empty($username)) {
        $subject .= '(' . $username . ')';
    }
    if (!empty($userid)) {
        $subject .= ' (ID:' . $userid . ')';
    }

    // message
    $msg = _XD_FB_ID . "\t$userid\n";
    $msg .= _XD_FB_USERNAME . "\t$uname";
    if (!empty($username)) {
        $msg .= '(' . $username . ")\n";
    } else {
        $msg .= "\n";
    }
    // ks	$msg .= _XD_FB_UNAME . "\t$uname\n";
    // ks	$msg .= _MD_SECNAMEC . "\t$secname\n";
    $msg .= _MD_LT_COURSE . "\t$secname\n";
    $msg .= _XD_FB_QTITLE . "\t$quiz_title\n";
    $msg .= _XD_FB_SCORE . "\t$score\n";
    $msg .= _XD_FB_START . "\t$start_time\n";
    $msg .= _XD_FB_END . "\t$end_time\n";
    $msg .= _XD_FB_TIMESTAMP . "\t$timestamp\n";
    //	$msg .= _XD_FB_CMT . "\t$comment";
    $msg = multibyte($msg); // clean up for multybyte lang esp JP

    $xoopsMailer =& getMailer();
    $xoopsMailer->useMail();
    $xoopsMailer->setFromEmail($myts->oopsStripSlashesGPC($xoopsConfig['adminmail']));
    $xoopsMailer->setFromName($myts->oopsStripSlashesGPC($xoopsConfig['sitename']));
    $xoopsMailer->setSubject($myts->oopsStripSlashesGPC($subject));
    $xoopsMailer->setBody($myts->oopsStripSlashesGPC($msg));

    if ($xoopsModuleConfig['mail_teacher']) {
        $xoopsMailer->setToEmails($teacher_email);
    }
    if ($xoopsModuleConfig['mail_user']) {
        $xoopsMailer->setToEmails($user_email);
    }
}

// WWW
if (!$xoopsUser) {
    $msg = '<H3>' . _XD_FB_GUEST . "</H3>\n";
} elseif ($xoopsMailer->send() != false) {
    $msg = '<H3>' . _XD_FB_OK . "</H3>\n";
} else {
    $msg = '<H3>' . _XD_FB_NG . "</H3>\n";
}

// kazuo sudow 1.04
// TD CLASS=EVEN
// ks	$msg .= "<TABLE BORDER=1>\n";
$msg .= "<TABLE cellspacing='0' cellpadding='0' BORDER='1'>\n";
$msg .= "<TR><TD class='even'>" . _XD_FB_ID . "</TD><TD class='even'>$userid</TD></TR>\n";

if ($xoopsUser) {
    $msg .= "<TR><TD class='even'>" . _XD_FB_USERNAME . "</TD><TD class='even'>$uname";
    if (!empty($username)) {
        $msg .= '(' . $username . ")</TD></TR>\n";
    } else {
        $msg .= "</TD></TR>\n";
    }
} else {
    $msg .= "<TR><TD class='even'>" . _XD_FB_USERNAME . "</TD><TD class='even'>" . _MD_LT_GUEST . "</TD></TR>\n";
}

// ks	$msg .= "<TR><TD class='even'>" . _XD_FB_UNAME . "</TD><TD class='even'>$uname</TD></TR>\n";
// ks	$msg .= "<TR><TD class='even'>" . _MD_SECNAMEC . "</TD><TD class='even'>$secname</TD></TR>\n";
$msg .= "<TR><TD class='even'>" . _MD_LT_COURSE . "</TD><TD class='even'>$secname</TD></TR>\n";
$msg .= "<TR><TD class='even'>" . _XD_FB_QTITLE . "</TD><TD class='even'>$quiz_title</TD></TR>\n";
$msg .= "<TR><TD class='even'>" . _XD_FB_SCORE . "</TD><TD class='even'>$score</TD></TR>\n";
$msg .= "<TR><TD class='even'>" . _XD_FB_START . "</TD><TD class='even'>$start_time</TD></TR>\n";
$msg .= "<TR><TD class='even'>" . _XD_FB_END . "</TD><TD class='even'>$end_time</TD></TR>\n";
$msg .= "<TR><TD class='even'>" . _XD_FB_TIMESTAMP . "</TD><TD class='even'>$timestamp</TD></TR>\n";
//	$msg .= "<TR><TD class='even'>" . _XD_FB_CMT . "</TD><TD class='even'>$comment</TD></TR>\n";
$msg .= "</TABLE>\n";
$msg .= "<br>\n";
$msg .= "<center>\n";
$msg .= "<INPUT type='button' name='close' value='" . _XD_FB_CLSBTN . "' onClick='window.opener.close();window.close()'>\n";
$msg .= "</center>\n";

// TEST-TEST-TEST-TEST
// test	$msg .= $quiz_id; // -> get cookie xoopsHP_file_id
// test	$msg .= $referer; // -> check browser has referer

// WWW-PAGE written
my_wrapper($msg);
exit();

/**
 * @param $s
 * @return mixed|string
 */
function multibyte($s)
{
    // kazuo sudow global app
    global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}

    if (XOOPS_USE_MULTIBYTES && function_exists('mb_convert_encoding') && $xoopsConfig['language'] == 'japanese') {
        if (get_magic_quotes_gpc()) {
            // kazuo sudow - encode auto & EUC-JP
            // return mb_convert_encoding(stripslashes($s), _CHARSET, "EUC-JP,UTF-8,Shift_JIS,JIS");

            return mb_convert_encoding(stripslashes($s), 'EUC-JP', 'auto');
        } else {
            // kazuo sudow - encode auto
            // return mb_convert_encoding($s, _CHARSET, "EUC-JP,UTF-8,Shift_JIS,JIS");

            return mb_convert_encoding($s, 'EUC-JP', 'auto');
        }
    } else {
        if (get_magic_quotes_gpc()) {
            return stripslashes($s);
        } else {
            return $s;
        }
    }
}

/**
 * @param $msg
 */
function my_wrapper($msg)
{
    global $xoopsConfig, $xoopsTheme, $xoopsConfigMetaFooter;
function myFunction($a, $b) {
    // Do something
}

    $myts = MyTextSanitizer::getInstance();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    if ($xoopsConfig['gzip_compression'] == 1) {
        ob_start('ob_gzhandler');
    } else {
        ob_start();
    }
    if (!headers_sent()) {
        header('Content-Type:text/html; charset=' . _CHARSET);
        header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
        header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
        header('Cache-Control: no-store, no-cache, max-age=1, s-maxage=1, must-revalidate, post-check=0, pre-check=0');
        header('Pragma: no-cache');
    }

    echo "<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>";

    echo '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="' . _LANGCODE . '" lang="' . _LANGCODE . '">
    <head>
    <meta http-equiv="content-type" content="text/html; charset=' . _CHARSET . '" />
    <meta http-equiv="content-language" content="' . _LANGCODE . '" />
    <meta name="robots" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_robots']) . '" />
    <meta name="keywords" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_keywords']) . '" />
    <meta name="description" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_desc']) . '" />
    <meta name="rating" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_rating']) . '" />
    <meta name="author" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_author']) . '" />
    <meta name="copyright" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_copyright']) . '" />
    <meta name="generator" content="XOOPS" />
    <title>' . _MD_LT_RESULTS . '</title>';
    $themecss = getcss($xoopsConfig['theme_set']);
    echo '<link rel="stylesheet" type="text/css" media="all" href="' . XOOPS_URL . '/xoops.css" />';
    if ($themecss) {
        echo '<link rel="stylesheet" type="text/css" media="all" href="' . $themecss . '" />';
        //echo '<style type="text/css" media="all"><!-- @import url('.$themecss.'); --></style>';

    }
    echo '</head><body>';
    echo '<br>'; // kazuo sudow <BR> code app
    echo $msg;
    echo '</body></html>';
}


Issues (102)

Security Analysis not enabled

process_form.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 223 and the first side effect is on line 41. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			// ------------------------------------------------------------------------ //
3			// -- XoopsHP Module -- Xoops e-Learning System //
4			// Copyright (c) 2005 SUDOW-SOKEN //
5			// <http://www.mailpark.co.jp/> //
6			// ------------------------------------------------------------------------ //
7			// Based on XoopsHP1.01 by Yoshi, aka HowardGee. //
8			// ------------------------------------------------------------------------ //
9			// This program is free software; you can redistribute it and/or modify //
10			// it under the terms of the GNU General Public License as published by //
11			// the Free Software Foundation; either version 2 of the License, or //
12			// (at your option) any later version. //
13			// //
14			// You may not change or alter any portion of this comment or credits //
15			// of supporting developers from this source code or any supporting //
16			// source code which is considered copyrighted (c) material of the //
17			// original comment or credit authors. //
18			// //
19			// This program is distributed in the hope that it will be useful, //
20			// but WITHOUT ANY WARRANTY; without even the implied warranty of //
21			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
22			// GNU General Public License for more details. //
23			// //
24			// You should have received a copy of the GNU General Public License //
25			// along with this program; if not, write to the Free Software //
26			// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
27			// ------------------------------------------------------------------------ //
28
29			// HTTP_REFERER ACTION CHECK -> DBQuery -> function.php error $_SERVER[$key]
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `36%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30			// If can't use command "$_SERVER["HTTP_REFERER"]" , don't save portfolio DB.
31			// analyze by kazuo sudow.
32			//
33			// TEST-TEST-TEST-TEST
34			// global $referer;
35			// $referer = $_SERVER["HTTP_REFERER"];
36			// if (!empty($referer)) {
37			// $_SERVER["HTTP_REFERER"] = "dummy";
38			// $referer = $_SERVER["HTTP_REFERER"];
39			//}
40
41			include_once dirname(dirname(__DIR__)) . '/mainfile.php';
42			include_once(XOOPS_ROOT_PATH . '/include/cp_functions.php');
43			global $db, $xoopsConfig, $xoopsUser, $xoopsModule, $xoopsObject, $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
44
45			if ($_SERVER['HTTP_HOST'] != $_SERVER['SERVER_NAME']) {
46			exit('Access Denied');
47			} elseif (!isset($_COOKIE['xoopsHP_file_id'])) {
48			exit('Oops, a problem in the cookie!');
49			}
50
51			// Get the file number
52			$quiz_id = (int)$_COOKIE['xoopsHP_file_id'];
53
54			// Delete cookie -> $quiz_id
55			setcookie('xoopsHP_file_id', '', time() - 3600);
56
57			// kazuo sudow
58			// - non pair Open-Close Table.. More Header Written BUG.
59			// OpenTable();
60
61			$myts = MyTextSanitizer::getInstance();
62			$uid = $xoopsUser ? $xoopsUser->getVar('uid') : 0;
63			$user_email = $xoopsUser ? $xoopsUser->getVar('email') : '';
64			$uname = $xoopsUser ? $xoopsUser->getVar('uname') : '';
65			$username = $xoopsUser ? $xoopsUser->getVar('name') : '';
66
67			// Get the instructor's email addy etc
68			$teacher_email = '';
69			include __DIR__ . '/module_prefix.php';
70			$result = $xoopsDB->query('SELECT secid, title, results_to FROM ' . $xoopsDB->prefix($module_prefix . '_quiz') . " WHERE artid=$quiz_id");
71			list($secid, $quiz_title, $teacher_email) = $xoopsDB->fetchRow($result);
72			$secid = (int)$secid;
73			include __DIR__ . '/module_prefix.php';
74			$result = $xoopsDB->query('SELECT secname FROM ' . $xoopsDB->prefix($module_prefix . '_sections') . " WHERE secid=$secid");
75			list($secname) = $xoopsDB->fetchRow($result);
76
77			// Get the form data
78			// kazuo sudow --> EUC-JP (1.04) Sanitizer & mb_convert_encoding
79			$userid = $myts->stripSlashesGPC($_POST['realname']);
80			// Check if mbstring is supported --Yoshi
81			if (XOOPS_USE_MULTIBYTES && function_exists('mb_convert_encoding') && $xoopsConfig['language'] === 'japanese') {
82			$userid = mb_convert_encoding($userid, 'EUC-JP', 'auto');
83			}
84
85			// Get Score --> %
86			// kazuo sudow --> EUC-JP (1.04) Sanitizer
87			$score = $myts->stripSlashesGPC($_POST['Score']);
88
89			// kazuo sudow --> EUC-JP (1.04) Sanitizer
90			$start_time = $myts->stripSlashesGPC($_POST['Start_Time']);
91			$start_time = date('Y/m/d H:i:s', strtotime($start_time));
92
93			// kazuo sudow --> EUC-JP (1.04) Sanitizer
94			$end_time = $myts->stripSlashesGPC($_POST['End_Time']);
95			$end_time = date('Y/m/d H:i:s', strtotime($end_time));
96
97			$timestamp = date('Y/m/d H:i:s');
98			$comment = '';
99
100			// Write in the db
101			if ($xoopsUser) {
102			include __DIR__ . '/module_prefix.php';
103			$query = 'INSERT INTO ' . $xoopsDB->prefix($module_prefix . '_results') . " (quiz_id, uid, score, start_time, end_time, timestamp, host, ip, comment) VALUES ('";
104			$query .= $quiz_id . "','";
105			$query .= $uid . "','";
106			$query .= $score . "','";
107			$query .= $start_time . "','";
108			$query .= $end_time . "','";
109			$query .= $timestamp . "','";
110			$query .= gethostbyaddr($_SERVER['REMOTE_ADDR']) . "','";
111			$query .= $_SERVER['REMOTE_ADDR'] . "','";
112			$query .= $comment . "')";
113			$result = $xoopsDB->query($query);
114			// Count up the counter for the completion
115			$quiz_id = (int)$quiz_id;
116			include __DIR__ . '/module_prefix.php';
117			$xoopsDB->query('UPDATE ' . $xoopsDB->prefix($module_prefix . '_quiz') . " SET counter=counter+1 WHERE artid=$quiz_id");
118			}
119
120			// E-MAIL SEND
121			// send mail only if user or teacher email option is checked
122			if ($xoopsModuleConfig['mail_teacher'] \|\| $xoopsModuleConfig['mail_user']) {
123			//generate message
124			// kazuo sudow 1.04 (add ID)
125			// original
126			// $subject = "XoopsHP Feedback: $uname, $quiz_title";
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
127			// $subject = mb_encode_mimeheader(mb_convert_kana($subject,"KV"),"ISO-2022-JP","B");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
128			$subject = htmlspecialchars($xoopsConfig['sitename']) . ' ' . $xoopsModule->getVar('name') . ':' . $quiz_title . ' ' . $uname;
129			if (!empty($username)) {
130			$subject .= '(' . $username . ')';
131			}
132			if (!empty($userid)) {
133			$subject .= ' (ID:' . $userid . ')';
134			}
135
136			// message
137			$msg = _XD_FB_ID . "\t$userid\n";
138			$msg .= _XD_FB_USERNAME . "\t$uname";
139			if (!empty($username)) {
140			$msg .= '(' . $username . ")\n";
141			} else {
142			$msg .= "\n";
143			}
144			// ks $msg .= _XD_FB_UNAME . "\t$uname\n";
145			// ks $msg .= _MD_SECNAMEC . "\t$secname\n";
146			$msg .= _MD_LT_COURSE . "\t$secname\n";
147			$msg .= _XD_FB_QTITLE . "\t$quiz_title\n";
148			$msg .= _XD_FB_SCORE . "\t$score\n";
149			$msg .= _XD_FB_START . "\t$start_time\n";
150			$msg .= _XD_FB_END . "\t$end_time\n";
151			$msg .= _XD_FB_TIMESTAMP . "\t$timestamp\n";
152			// $msg .= _XD_FB_CMT . "\t$comment";
153			$msg = multibyte($msg); // clean up for multybyte lang esp JP
154
155			$xoopsMailer =& getMailer();
156			$xoopsMailer->useMail();
157			$xoopsMailer->setFromEmail($myts->oopsStripSlashesGPC($xoopsConfig['adminmail']));
158			$xoopsMailer->setFromName($myts->oopsStripSlashesGPC($xoopsConfig['sitename']));
159			$xoopsMailer->setSubject($myts->oopsStripSlashesGPC($subject));
160			$xoopsMailer->setBody($myts->oopsStripSlashesGPC($msg));
161
162			if ($xoopsModuleConfig['mail_teacher']) {
163			$xoopsMailer->setToEmails($teacher_email);
164			}
165			if ($xoopsModuleConfig['mail_user']) {
166			$xoopsMailer->setToEmails($user_email);
167			}
168			}
169
170			// WWW
171			if (!$xoopsUser) {
172			$msg = '<H3>' . _XD_FB_GUEST . "</H3>\n";
173			} elseif ($xoopsMailer->send() != false) {
174			$msg = '<H3>' . _XD_FB_OK . "</H3>\n";
175			} else {
176			$msg = '<H3>' . _XD_FB_NG . "</H3>\n";
177			}
178
179			// kazuo sudow 1.04
180			// TD CLASS=EVEN
181			// ks $msg .= "<TABLE BORDER=1>\n";
182			$msg .= "<TABLE cellspacing='0' cellpadding='0' BORDER='1'>\n";
183			$msg .= "<TR><TD class='even'>" . _XD_FB_ID . "</TD><TD class='even'>$userid</TD></TR>\n";
184
185			if ($xoopsUser) {
186			$msg .= "<TR><TD class='even'>" . _XD_FB_USERNAME . "</TD><TD class='even'>$uname";
187			if (!empty($username)) {
188			$msg .= '(' . $username . ")</TD></TR>\n";
189			} else {
190			$msg .= "</TD></TR>\n";
191			}
192			} else {
193			$msg .= "<TR><TD class='even'>" . _XD_FB_USERNAME . "</TD><TD class='even'>" . _MD_LT_GUEST . "</TD></TR>\n";
194			}
195
196			// ks $msg .= "<TR><TD class='even'>" . _XD_FB_UNAME . "</TD><TD class='even'>$uname</TD></TR>\n";
197			// ks $msg .= "<TR><TD class='even'>" . _MD_SECNAMEC . "</TD><TD class='even'>$secname</TD></TR>\n";
198			$msg .= "<TR><TD class='even'>" . _MD_LT_COURSE . "</TD><TD class='even'>$secname</TD></TR>\n";
199			$msg .= "<TR><TD class='even'>" . _XD_FB_QTITLE . "</TD><TD class='even'>$quiz_title</TD></TR>\n";
200			$msg .= "<TR><TD class='even'>" . _XD_FB_SCORE . "</TD><TD class='even'>$score</TD></TR>\n";
201			$msg .= "<TR><TD class='even'>" . _XD_FB_START . "</TD><TD class='even'>$start_time</TD></TR>\n";
202			$msg .= "<TR><TD class='even'>" . _XD_FB_END . "</TD><TD class='even'>$end_time</TD></TR>\n";
203			$msg .= "<TR><TD class='even'>" . _XD_FB_TIMESTAMP . "</TD><TD class='even'>$timestamp</TD></TR>\n";
204			// $msg .= "<TR><TD class='even'>" . _XD_FB_CMT . "</TD><TD class='even'>$comment</TD></TR>\n";
205			$msg .= "</TABLE>\n";
206			$msg .= "<br>\n";
207			$msg .= "<center>\n";
208			$msg .= "<INPUT type='button' name='close' value='" . _XD_FB_CLSBTN . "' onClick='window.opener.close();window.close()'>\n";
209			$msg .= "</center>\n";
210
211			// TEST-TEST-TEST-TEST
212			// test $msg .= $quiz_id; // -> get cookie xoopsHP_file_id
213			// test $msg .= $referer; // -> check browser has referer
214
215			// WWW-PAGE written
216			my_wrapper($msg);
217			exit();
218
219			/**
220			* @param $s
221			* @return mixed\|string
222			*/
223			function multibyte($s)
224			{
225			// kazuo sudow global app
226			global $xoopsConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
227
228			if (XOOPS_USE_MULTIBYTES && function_exists('mb_convert_encoding') && $xoopsConfig['language'] == 'japanese') {
229			if (get_magic_quotes_gpc()) {
230			// kazuo sudow - encode auto & EUC-JP
231			// return mb_convert_encoding(stripslashes($s), _CHARSET, "EUC-JP,UTF-8,Shift_JIS,JIS");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
232			return mb_convert_encoding(stripslashes($s), 'EUC-JP', 'auto');
233			} else {
234			// kazuo sudow - encode auto
235			// return mb_convert_encoding($s, _CHARSET, "EUC-JP,UTF-8,Shift_JIS,JIS");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
236			return mb_convert_encoding($s, 'EUC-JP', 'auto');
237			}
238			} else {
239			if (get_magic_quotes_gpc()) {
240			return stripslashes($s);
241			} else {
242			return $s;
243			}
244			}
245			}
246
247			/**
248			* @param $msg
249			*/
250			function my_wrapper($msg)
251			{
252			global $xoopsConfig, $xoopsTheme, $xoopsConfigMetaFooter;
			0 ignored issues – show Compatibility Best Practice introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
253
254			$myts = MyTextSanitizer::getInstance();
			0 ignored issues – show Unused Code introduced 2016-06-18 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$myts` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
255			if ($xoopsConfig['gzip_compression'] == 1) {
256			ob_start('ob_gzhandler');
257			} else {
258			ob_start();
259			}
260			if (!headers_sent()) {
261			header('Content-Type:text/html; charset=' . _CHARSET);
262			header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
263			header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
264			header('Cache-Control: no-store, no-cache, max-age=1, s-maxage=1, must-revalidate, post-check=0, pre-check=0');
265			header('Pragma: no-cache');
266			}
267
268			echo "<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>";
269
270			echo '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="' . _LANGCODE . '" lang="' . _LANGCODE . '">
271			<head>
272			<meta http-equiv="content-type" content="text/html; charset=' . _CHARSET . '" />
273			<meta http-equiv="content-language" content="' . _LANGCODE . '" />
274			<meta name="robots" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_robots']) . '" />
275			<meta name="keywords" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_keywords']) . '" />
276			<meta name="description" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_desc']) . '" />
277			<meta name="rating" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_rating']) . '" />
278			<meta name="author" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_author']) . '" />
279			<meta name="copyright" content="' . htmlspecialchars($xoopsConfigMetaFooter['meta_copyright']) . '" />
280			<meta name="generator" content="XOOPS" />
281			<title>' . _MD_LT_RESULTS . '</title>';
282			$themecss = getcss($xoopsConfig['theme_set']);
283			echo '<link rel="stylesheet" type="text/css" media="all" href="' . XOOPS_URL . '/xoops.css" />';
284			if ($themecss) {
285			echo '<link rel="stylesheet" type="text/css" media="all" href="' . $themecss . '" />';
286			//echo '<style type="text/css" media="all"><!-- @import url('.$themecss.'); --></style>';
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-18 08:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
287			}
288			echo '</head><body>';
289			echo '<br>'; // kazuo sudow <BR> code app
290			echo $msg;
291			echo '</body></html>';
292			}
293

XoopsModules25x / xoopshp

Issues (102)

Security Analysis not enabled

process_form.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like