Issues in onupdate.inc.php - New Issues - Inspection of "Merge pull request #7 from mambax7/master" - XoopsModules25x/xoopshp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d327be...a5915e )

by Michael

created 2016-06-18 08:51 UTC

include/onupdate.inc.php (4 issues)

Labels

Unused Code 4

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

if (!defined('XOOPS_ROOT_PATH')) {
    exit;
}

// referer check
$ref = xoops_getenv('HTTP_REFERER');
if ($ref === '' || strpos($ref, XOOPS_URL . '/modules/system/admin.php') === 0) {
    /* XoopsHP specific part */

    global $xoopsDB, $xoopsUser, $xoopsModule;
    include XOOPS_ROOT_PATH . '/modules/' . $modversion['dirname'] . '/module_prefix.php';

    // Perms check
    if (!is_object($xoopsUser) || !is_object($xoopsModule) || !$xoopsUser->isAdmin($xoopsModule->mid())) {
        exit('Access Denied');
    }

    // DB Maintenance

    if ($xoopsDB->query('SELECT display FROM ' . $xoopsDB->prefix($module_prefix . '_quiz')) === false) {

        // quiz database
        $result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_quiz') . " ADD   display TINYINT NOT NULL DEFAULT  '1'");
        if ($result) {
            //	    	echo '<br>' .  _AM_MSG_UPDATE_FAILED." (".$xoopsDB->prefix($module_prefix."_quiz").".display) <br>";
            $errors++;
        } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            //			echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_quiz").".display) <br>";
        }

        $result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_quiz') . " ADD  expire DATETIME NOT NULL DEFAULT  '0000-00-00 00:00:00'");
        if ($result) {
            //	    	echo '<br>' .  _AM_MSG_UPDATE_FAILED." (".$xoopsDB->prefix($module_prefix."_quiz").".expire) <br>";
            $errors++;
        } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            //			echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_quiz").".expire) <br>";
        }

        // sections database
        $result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_sections') . " ADD   display TINYINT NOT NULL DEFAULT  '1'");
        if ($result) {
            echo '<br>' . _AM_MSG_UPDATE_FAILED . ' (' . $xoopsDB->prefix($module_prefix . '_sections') . '.display) <br>';
            $errors++;
        } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            //			echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_sections").".display) <br>";
        }

        $result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_sections') . " ADD  expire DATETIME NOT NULL DEFAULT  '0000-00-00 00:00:00'");
        if ($result) {
            //	    	echo '<br>' .  _AM_MSG_UPDATE_FAILED." (".$xoopsDB->prefix($module_prefix."_sections").".expire) <br>";
            $errors++;
        } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            //			echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_sections").".expire) <br>";
        }

        //	echo "Database update ended with ".$errors."error(s)";
    }

    /* Misc */

    // Add other stuff below
}


1			<?php
2
3			if (!defined('XOOPS_ROOT_PATH')) {
4			exit;
5			}
6
7			// referer check
8			$ref = xoops_getenv('HTTP_REFERER');
9			if ($ref === '' \|\| strpos($ref, XOOPS_URL . '/modules/system/admin.php') === 0) {
10			/* XoopsHP specific part */
11
12			global $xoopsDB, $xoopsUser, $xoopsModule;
13			include XOOPS_ROOT_PATH . '/modules/' . $modversion['dirname'] . '/module_prefix.php';
14
15			// Perms check
16			if (!is_object($xoopsUser) \|\| !is_object($xoopsModule) \|\| !$xoopsUser->isAdmin($xoopsModule->mid())) {
17			exit('Access Denied');
18			}
19
20			// DB Maintenance
21
22			if ($xoopsDB->query('SELECT display FROM ' . $xoopsDB->prefix($module_prefix . '_quiz')) === false) {
23
24			// quiz database
25			$result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_quiz') . " ADD display TINYINT NOT NULL DEFAULT '1'");
26			if ($result) {
27			// echo '<br>' . _AM_MSG_UPDATE_FAILED." (".$xoopsDB->prefix($module_prefix."_quiz").".display) <br>";
28			$errors++;
29			} else {
			0 ignored issues – show Unused Code introduced 2016-06-18 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
30			// echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_quiz").".display) <br>";
31			}
32
33			$result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_quiz') . " ADD expire DATETIME NOT NULL DEFAULT '0000-00-00 00:00:00'");
34			if ($result) {
35			// echo '<br>' . _AM_MSG_UPDATE_FAILED." (".$xoopsDB->prefix($module_prefix."_quiz").".expire) <br>";
36			$errors++;
37			} else {
			0 ignored issues – show Unused Code introduced 2016-06-18 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
38			// echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_quiz").".expire) <br>";
39			}
40
41			// sections database
42			$result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_sections') . " ADD display TINYINT NOT NULL DEFAULT '1'");
43			if ($result) {
44			echo '<br>' . _AM_MSG_UPDATE_FAILED . ' (' . $xoopsDB->prefix($module_prefix . '_sections') . '.display) <br>';
45			$errors++;
46			} else {
			0 ignored issues – show Unused Code introduced 2016-06-18 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
47			// echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_sections").".display) <br>";
48			}
49
50			$result = $xoopsDB->queryF('ALTER TABLE ' . $xoopsDB->prefix($module_prefix . '_sections') . " ADD expire DATETIME NOT NULL DEFAULT '0000-00-00 00:00:00'");
51			if ($result) {
52			// echo '<br>' . _AM_MSG_UPDATE_FAILED." (".$xoopsDB->prefix($module_prefix."_sections").".expire) <br>";
53			$errors++;
54			} else {
			0 ignored issues – show Unused Code introduced 2016-06-18 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
55			// echo _AM_MSG_UPDATE_SUCCEEDED." (".$xoopsDB->prefix($module_prefix."_sections").".expire) <br>";
56			}
57
58			// echo "Database update ended with ".$errors."error(s)";
59			}
60
61			/* Misc */
62
63			// Add other stuff below
64			}
65

XoopsModules25x / xoopshp

Push — master ( d327be...a5915e )

include/onupdate.inc.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like