Issues in index.php (master) - Issues in master - XoopsModules25x/xoopsfaq - Measure and Improve Code Quality continuously with Scrutinizer

Issues (76)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

testdata/index.php (2 issues)

Labels

Severity

<?php declare(strict_types=1);

/**
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 (https://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @since           2.5.9
 * @author          Michael Beck (aka Mamba)
 */

use Xmf\Database\TableLoad;
use Xmf\Request;
use Xmf\Yaml;
use XoopsModules\Xoopsfaq\{
    Common\Configurator,
    Helper,
    Utility
};

/** @var Helper $helper */
/** @var Utility $utility */
/** @var Configurator $configurator */
require \dirname(__DIR__, 3) . '/include/cp_header.php';
require \dirname(__DIR__) . '/preloads/autoloader.php';

$op = Request::getCmd('op', '');

$moduleDirName      = \basename(\dirname(__DIR__));
$moduleDirNameUpper = \mb_strtoupper($moduleDirName);

$helper = Helper::getInstance();
// Load language files
$helper->loadLanguage('common');

switch ($op) {
    case 'load':
        if (Request::hasVar('ok', 'REQUEST') && 1 === Request::getInt('ok', 0)) {
            if (!$GLOBALS['xoopsSecurity']->check()) {
                redirect_header($helper->url('admin/index.php'), 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
            }
            loadSampleData();
        } else {
            xoops_cp_header();
            xoops_confirm(['ok' => 1, 'op' => 'load'], 'index.php', constant('CO_' . $moduleDirNameUpper . '_' . 'LOAD_SAMPLEDATA_CONFIRM'), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
            xoops_cp_footer();
        }
        break;
    case 'save':
        saveSampleData();
        break;
    case 'clear':
        if (Request::hasVar('ok', 'REQUEST') && 1 === Request::getInt('ok', 0)) {
            if (!$GLOBALS['xoopsSecurity']->check()) {
                redirect_header($helper->url('admin/index.php'), 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
            }
            clearSampleData();
        } else {
            xoops_cp_header();
            xoops_confirm(['ok' => 1, 'op' => 'clear'], 'index.php', sprintf(constant('CO_' . $moduleDirNameUpper . '_' . 'CLEAR_SAMPLEDATA')), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
            xoops_cp_footer();
        }
        break;
}

// XMF TableLoad for SAMPLE data

function loadSampleData(): void
{
    global $xoopsConfig;
    $moduleDirName      = \basename(\dirname(__DIR__));
    $moduleDirNameUpper = \mb_strtoupper($moduleDirName);

    $utility      = new Utility();
    $configurator = new Configurator();

    $tables = \Xmf\Module\Helper::getHelper($moduleDirName)->getModule()->getInfo('tables');

    $language = 'english/';
    if (is_dir(__DIR__ . '/' . $xoopsConfig['language'])) {
        $language = $xoopsConfig['language'] . '/';
    }

    // load module tables
    foreach ($tables as $table) {
        $tabledata = Yaml::readWrapped($language . $table . '.yml');
        TableLoad::truncateTable($table);
        TableLoad::loadTableFromArray($table, $tabledata);
    }

    // load permissions
    $table     = 'group_permission';
    $tabledata = Yaml::readWrapped($language . $table . '.yml');
    $mid       = \Xmf\Module\Helper::getHelper($moduleDirName)->getModule()->getVar('mid');
    loadTableFromArrayWithReplace($table, $tabledata, 'gperm_modid', $mid);

    //  ---  COPY test folder files ---------------
    if (is_array($configurator->copyTestFolders) && count($configurator->copyTestFolders) > 0) {
        //        $file =  \dirname(__DIR__) . '/testdata/images/';
        foreach (array_keys($configurator->copyTestFolders) as $i) {
            $src  = $configurator->copyTestFolders[$i][0];
            $dest = $configurator->copyTestFolders[$i][1];
            $utility->rcopy($src, $dest);
        }
    }
    \redirect_header('../admin/index.php', 1, \constant('CO_' . $moduleDirNameUpper . '_' . 'LOAD_SAMPLEDATA_SUCCESS'));
}

function saveSampleData(): void
{
    global $xoopsConfig;
    $moduleDirName      = \basename(\dirname(__DIR__));
    $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
    $helper             = Helper::getInstance();
    $tables             = $helper->getModule()->getInfo('tables');

    $languageFolder = __DIR__ . '/' . $xoopsConfig['language'];
    if (!file_exists($languageFolder . '/')) {
        Utility::createFolder($languageFolder . '/');
    }
    $exportFolder = $languageFolder . '/Exports-' . date('Y-m-d-H-i-s') . '/';
    Utility::createFolder($exportFolder);

    // save module tables
    foreach ($tables as $table) {
        TableLoad::saveTableToYamlFile($table, $exportFolder . $table . '.yml');
    }

    // save permissions
    $criteria = new \CriteriaCompo();
    $criteria->add(new \Criteria('gperm_modid', $helper->getModule()->getVar('mid')));
    $skipColumns[] = 'gperm_id';
    TableLoad::saveTableToYamlFile('group_permission', $exportFolder . 'group_permission.yml', $criteria, $skipColumns);
    unset($criteria);

    \redirect_header('../admin/index.php', 1, \constant('CO_' . $moduleDirNameUpper . '_' . 'SAVE_SAMPLEDATA_SUCCESS'));
}

function exportSchema(): void
{
    $moduleDirName      = \basename(\dirname(__DIR__));
    $moduleDirNameUpper = \mb_strtoupper($moduleDirName);

    try {
        // TODO set exportSchema
        //        $migrate = new Migrate($moduleDirName);
        //        $migrate->saveCurrentSchema();
        //
        //        redirect_header('../admin/index.php', 1, constant('CO_' . $moduleDirNameUpper . '_' . 'EXPORT_SCHEMA_SUCCESS'));
    } catch (\Throwable $e) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        exit(constant('CO_' . $moduleDirNameUpper . '_' . 'EXPORT_SCHEMA_ERROR'));

    }
}

/**
 * loadTableFromArrayWithReplace
 *
 * @param string $table  value which should be used instead of original value of $search
 *
 * @param array  $data   array of rows to insert
 *                       Each element of the outer array represents a single table row.
 *                       Each row is an associative array in 'column' => 'value' format.
 * @param string $search name of column for which the value should be replaced
 * @param int    $replace
 * @return int number of rows inserted
 */
function loadTableFromArrayWithReplace(string $table, array $data, string $search, int $replace): int
{
    /** @var \XoopsMySQLDatabase $db */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();

    $prefixedTable = $db->prefix($table);
    $count         = 0;

    $sql = 'DELETE FROM ' . $prefixedTable . ' WHERE `' . $search . '`=' . $db->quote((string)$replace);

    $result = $db->queryF($sql);

    foreach ($data as $row) {
        $insertInto  = 'INSERT INTO ' . $prefixedTable . ' (';
        $valueClause = ' VALUES (';
        $first       = true;
        foreach ($row as $column => $value) {
            if ($first) {
                $first = false;
            } else {
                $insertInto  .= ', ';
                $valueClause .= ', ';
            }

            $insertInto .= $column;
            if ($search === $column) {
                $valueClause .= $db->quote((string)$replace);
            } else {
                $valueClause .= $db->quote((string)$value);
            }
        }

        $sql = $insertInto . ') ' . $valueClause . ')';

        $result = $db->queryF($sql);
        if (false !== $result) {
            ++$count;
        }
    }

    return $count;
}

function clearSampleData(): void
{
    $moduleDirName      = \basename(\dirname(__DIR__));
    $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
    $helper             = Helper::getInstance();
    // Load language files
    $helper->loadLanguage('common');
    $tables = $helper->getModule()->getInfo('tables');
    // truncate module tables
    foreach ($tables as $table) {
        \Xmf\Database\TableLoad::truncateTable($table);
    }
    redirect_header($helper->url('admin/index.php'), 1, constant('CO_' . $moduleDirNameUpper . '_' . 'CLEAR_SAMPLEDATA_OK'));
}


1			<?php declare(strict_types=1);
2
3			/**
4			* You may not change or alter any portion of this comment or credits
5			* of supporting developers from this source code or any supporting source code
6			* which is considered copyrighted (c) material of the original comment or credit authors.
7			* This program is distributed in the hope that it will be useful,
8			* but WITHOUT ANY WARRANTY; without even the implied warranty of
9			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*
11			* @copyright XOOPS Project (https://xoops.org)
12			* @license GNU GPL 2 (https://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
13			* @since 2.5.9
14			* @author Michael Beck (aka Mamba)
15			*/
16
17			use Xmf\Database\TableLoad;
18			use Xmf\Request;
19			use Xmf\Yaml;
20			use XoopsModules\Xoopsfaq\{
21			Common\Configurator,
22			Helper,
23			Utility
24			};
25
26			/** @var Helper $helper */
27			/** @var Utility $utility */
28			/** @var Configurator $configurator */
29			require \dirname(__DIR__, 3) . '/include/cp_header.php';
30			require \dirname(__DIR__) . '/preloads/autoloader.php';
31
32			$op = Request::getCmd('op', '');
33
34			$moduleDirName = \basename(\dirname(__DIR__));
35			$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
36
37			$helper = Helper::getInstance();
38			// Load language files
39			$helper->loadLanguage('common');
40
41			switch ($op) {
42			case 'load':
43			if (Request::hasVar('ok', 'REQUEST') && 1 === Request::getInt('ok', 0)) {
44			if (!$GLOBALS['xoopsSecurity']->check()) {
45			redirect_header($helper->url('admin/index.php'), 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
46			}
47			loadSampleData();
48			} else {
49			xoops_cp_header();
50			xoops_confirm(['ok' => 1, 'op' => 'load'], 'index.php', constant('CO_' . $moduleDirNameUpper . '_' . 'LOAD_SAMPLEDATA_CONFIRM'), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
51			xoops_cp_footer();
52			}
53			break;
54			case 'save':
55			saveSampleData();
56			break;
57			case 'clear':
58			if (Request::hasVar('ok', 'REQUEST') && 1 === Request::getInt('ok', 0)) {
59			if (!$GLOBALS['xoopsSecurity']->check()) {
60			redirect_header($helper->url('admin/index.php'), 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
61			}
62			clearSampleData();
63			} else {
64			xoops_cp_header();
65			xoops_confirm(['ok' => 1, 'op' => 'clear'], 'index.php', sprintf(constant('CO_' . $moduleDirNameUpper . '_' . 'CLEAR_SAMPLEDATA')), constant('CO_' . $moduleDirNameUpper . '_' . 'CONFIRM'), true);
66			xoops_cp_footer();
67			}
68			break;
69			}
70
71			// XMF TableLoad for SAMPLE data
72
73			function loadSampleData(): void
74			{
75			global $xoopsConfig;
76			$moduleDirName = \basename(\dirname(__DIR__));
77			$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
78
79			$utility = new Utility();
80			$configurator = new Configurator();
81
82			$tables = \Xmf\Module\Helper::getHelper($moduleDirName)->getModule()->getInfo('tables');
83
84			$language = 'english/';
85			if (is_dir(__DIR__ . '/' . $xoopsConfig['language'])) {
86			$language = $xoopsConfig['language'] . '/';
87			}
88
89			// load module tables
90			foreach ($tables as $table) {
91			$tabledata = Yaml::readWrapped($language . $table . '.yml');
92			TableLoad::truncateTable($table);
93			TableLoad::loadTableFromArray($table, $tabledata);
94			}
95
96			// load permissions
97			$table = 'group_permission';
98			$tabledata = Yaml::readWrapped($language . $table . '.yml');
99			$mid = \Xmf\Module\Helper::getHelper($moduleDirName)->getModule()->getVar('mid');
100			loadTableFromArrayWithReplace($table, $tabledata, 'gperm_modid', $mid);
101
102			// --- COPY test folder files ---------------
103			if (is_array($configurator->copyTestFolders) && count($configurator->copyTestFolders) > 0) {
104			// $file = \dirname(__DIR__) . '/testdata/images/';
105			foreach (array_keys($configurator->copyTestFolders) as $i) {
106			$src = $configurator->copyTestFolders[$i][0];
107			$dest = $configurator->copyTestFolders[$i][1];
108			$utility->rcopy($src, $dest);
109			}
110			}
111			\redirect_header('../admin/index.php', 1, \constant('CO_' . $moduleDirNameUpper . '_' . 'LOAD_SAMPLEDATA_SUCCESS'));
112			}
113
114			function saveSampleData(): void
115			{
116			global $xoopsConfig;
117			$moduleDirName = \basename(\dirname(__DIR__));
118			$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
119			$helper = Helper::getInstance();
120			$tables = $helper->getModule()->getInfo('tables');
121
122			$languageFolder = __DIR__ . '/' . $xoopsConfig['language'];
123			if (!file_exists($languageFolder . '/')) {
124			Utility::createFolder($languageFolder . '/');
125			}
126			$exportFolder = $languageFolder . '/Exports-' . date('Y-m-d-H-i-s') . '/';
127			Utility::createFolder($exportFolder);
128
129			// save module tables
130			foreach ($tables as $table) {
131			TableLoad::saveTableToYamlFile($table, $exportFolder . $table . '.yml');
132			}
133
134			// save permissions
135			$criteria = new \CriteriaCompo();
136			$criteria->add(new \Criteria('gperm_modid', $helper->getModule()->getVar('mid')));
137			$skipColumns[] = 'gperm_id';
138			TableLoad::saveTableToYamlFile('group_permission', $exportFolder . 'group_permission.yml', $criteria, $skipColumns);
139			unset($criteria);
140
141			\redirect_header('../admin/index.php', 1, \constant('CO_' . $moduleDirNameUpper . '_' . 'SAVE_SAMPLEDATA_SUCCESS'));
142			}
143
144			function exportSchema(): void
145			{
146			$moduleDirName = \basename(\dirname(__DIR__));
147			$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
148
149			try {
150			// TODO set exportSchema
151			// $migrate = new Migrate($moduleDirName);
152			// $migrate->saveCurrentSchema();
153			//
154			// redirect_header('../admin/index.php', 1, constant('CO_' . $moduleDirNameUpper . '_' . 'EXPORT_SCHEMA_SUCCESS'));
155			} catch (\Throwable $e) {
			0 ignored issues – show Unused Code introduced 2021-10-29 20:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `catch (\Throwable $e)` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
156			exit(constant('CO_' . $moduleDirNameUpper . '_' . 'EXPORT_SCHEMA_ERROR'));
			0 ignored issues – show Best Practice introduced 2020-01-08 13:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
157			}
158			}
159
160			/**
161			* loadTableFromArrayWithReplace
162			*
163			* @param string $table value which should be used instead of original value of $search
164			*
165			* @param array $data array of rows to insert
166			* Each element of the outer array represents a single table row.
167			* Each row is an associative array in 'column' => 'value' format.
168			* @param string $search name of column for which the value should be replaced
169			* @param int $replace
170			* @return int number of rows inserted
171			*/
172			function loadTableFromArrayWithReplace(string $table, array $data, string $search, int $replace): int
173			{
174			/** @var \XoopsMySQLDatabase $db */
175			$db = \XoopsDatabaseFactory::getDatabaseConnection();
176
177			$prefixedTable = $db->prefix($table);
178			$count = 0;
179
180			$sql = 'DELETE FROM ' . $prefixedTable . ' WHERE `' . $search . '`=' . $db->quote((string)$replace);
181
182			$result = $db->queryF($sql);
183
184			foreach ($data as $row) {
185			$insertInto = 'INSERT INTO ' . $prefixedTable . ' (';
186			$valueClause = ' VALUES (';
187			$first = true;
188			foreach ($row as $column => $value) {
189			if ($first) {
190			$first = false;
191			} else {
192			$insertInto .= ', ';
193			$valueClause .= ', ';
194			}
195
196			$insertInto .= $column;
197			if ($search === $column) {
198			$valueClause .= $db->quote((string)$replace);
199			} else {
200			$valueClause .= $db->quote((string)$value);
201			}
202			}
203
204			$sql = $insertInto . ') ' . $valueClause . ')';
205
206			$result = $db->queryF($sql);
207			if (false !== $result) {
208			++$count;
209			}
210			}
211
212			return $count;
213			}
214
215			function clearSampleData(): void
216			{
217			$moduleDirName = \basename(\dirname(__DIR__));
218			$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
219			$helper = Helper::getInstance();
220			// Load language files
221			$helper->loadLanguage('common');
222			$tables = $helper->getModule()->getInfo('tables');
223			// truncate module tables
224			foreach ($tables as $table) {
225			\Xmf\Database\TableLoad::truncateTable($table);
226			}
227			redirect_header($helper->url('admin/index.php'), 1, constant('CO_' . $moduleDirNameUpper . '_' . 'CLEAR_SAMPLEDATA_OK'));
228			}
229

XoopsModules25x / xoopsfaq

Issues (76)

Security Analysis not enabled

testdata/index.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like