Inspection of "Merge pull request #9 from geekwright/recentlink" - XoopsModules25x/xoopsfaq - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (18a203)

by Michael

created 2023-05-26 03:44 UTC

Status

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -106,16 +106,16 @@
 block discarded – undo
     $ychck = (isset($options[0]) && ($options[0] > 0)) ? ' checked' : '';
     $nchck = !empty($ychck) ? '' : ' checked';
     $form  = '<div class="line140">'
-             . _MB_XOOPSFAQ_SHOW_EMPTY
-             . '&nbsp;<label for="r0">'
-             . _NO
-             . '</label><input type="radio" name="options[0]" id="r0" value="0"'
-             . $nchck
-             . '>&nbsp;<label for="r1">'
-             . _YES
-             . '</label><input type="radio" name="options[0]" id="r1" value="1"'
-             . $ychck
-             . '></div>'
-             . "\n";
+                . _MB_XOOPSFAQ_SHOW_EMPTY
+                . '&nbsp;<label for="r0">'
+                . _NO
+                . '</label><input type="radio" name="options[0]" id="r0" value="0"'
+                . $nchck
+                . '>&nbsp;<label for="r1">'
+                . _YES
+                . '</label><input type="radio" name="options[0]" id="r1" value="1"'
+                . $ychck
+                . '></div>'
+                . "\n";
     return $form;
 }

Please login to merge, or discard this patch.

class/CategoryHandler.php 1 patch

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -103,23 +103,23 @@
 block discarded – undo
         $buttons = ['edit', 'delete'];
 
         $ret = '<table class="outer width100 bnone pad3 marg5">'
-               . '  <thead>'
-               . '  <tr class="xoopsCenter">'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CATEGORY_ORDER
-               . '</th>'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CATEGORY_ID
-               . '</th>'
-               . '    <th class="txtleft">'
-               . _AM_XOOPSFAQ_CATEGORY_TITLE
-               . '</th>'
-               . '    <th class="width20">'
-               . _AM_XOOPSFAQ_ACTIONS
-               . '</th>'
-               . '  </tr>'
-               . '  </thead>'
-               . '  <tbody>';
+                . '  <thead>'
+                . '  <tr class="xoopsCenter">'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CATEGORY_ORDER
+                . '</th>'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CATEGORY_ID
+                . '</th>'
+                . '    <th class="txtleft">'
+                . _AM_XOOPSFAQ_CATEGORY_TITLE
+                . '</th>'
+                . '    <th class="width20">'
+                . _AM_XOOPSFAQ_ACTIONS
+                . '</th>'
+                . '  </tr>'
+                . '  </thead>'
+                . '  <tbody>';
         if ($objects['count'] > 0) {
             /** @var XoopsObject $object */
             foreach ($objects['list'] as $object) {

Please login to merge, or discard this patch.

class/ContentsHandler.php 1 patch

Indentation +59 added lines, -59 removed lines patch added patch discarded remove patch

@@ -159,32 +159,32 @@  discard block
 block discarded – undo
         $buttons = ['edit', 'delete'];
 
         $ret = '<table class="outer width100 bnone pad3 marg5">'
-               . '  <thead>'
-               . '  <tr class="center">'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CONTENTS_ID
-               . '</th>'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CONTENTS_ACTIVE
-               . '</th>'
-               . '    <th class="width5">'
-               . _AM_XOOPSFAQ_CONTENTS_WEIGHT
-               . '</th>'
-               . '    <th class="left">'
-               . _AM_XOOPSFAQ_CONTENTS_TITLE
-               . '</th>'
-               . '    <th class="left">'
-               . _AM_XOOPSFAQ_CATEGORY_TITLE
-               . '</th>'
-               . '    <th>'
-               . _AM_XOOPSFAQ_CONTENTS_PUBLISH
-               . '</th>'
-               . '    <th class="width20">'
-               . _AM_XOOPSFAQ_ACTIONS
-               . '</th>'
-               . '  </tr>'
-               . '  </thead>'
-               . '  <tbody>';
+                . '  <thead>'
+                . '  <tr class="center">'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CONTENTS_ID
+                . '</th>'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CONTENTS_ACTIVE
+                . '</th>'
+                . '    <th class="width5">'
+                . _AM_XOOPSFAQ_CONTENTS_WEIGHT
+                . '</th>'
+                . '    <th class="left">'
+                . _AM_XOOPSFAQ_CONTENTS_TITLE
+                . '</th>'
+                . '    <th class="left">'
+                . _AM_XOOPSFAQ_CATEGORY_TITLE
+                . '</th>'
+                . '    <th>'
+                . _AM_XOOPSFAQ_CONTENTS_PUBLISH
+                . '</th>'
+                . '    <th class="width20">'
+                . _AM_XOOPSFAQ_ACTIONS
+                . '</th>'
+                . '  </tr>'
+                . '  </thead>'
+                . '  <tbody>';
         if ($objects['count'] > 0) {
             $tdClass = 0;
             /** @var \Contents $object */
@@ -195,39 +195,39 @@  discard block
 block discarded – undo
                 ++$tdClass;
                 $dispClass = ($tdClass % 1) ? 'even' : 'odd';
                 $ret       .= '  <tr class="center middle">'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getVar('contents_id')
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getActiveIcon()
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getVar('contents_weight')
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . ' left">'
-                              . $thisContentTitle
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . ' left">'
-                              . $thisCatTitle
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">'
-                              . $object->getPublished(_SHORTDATESTRING)
-                              . '</td>'
-                              . '    <td class="'
-                              . $dispClass
-                              . '">';
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getVar('contents_id')
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getActiveIcon()
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getVar('contents_weight')
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . ' left">'
+                                . $thisContentTitle
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . ' left">'
+                                . $thisCatTitle
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">'
+                                . $object->getPublished(_SHORTDATESTRING)
+                                . '</td>'
+                                . '    <td class="'
+                                . $dispClass
+                                . '">';
                 $ret       .= Xoopsfaq\Utility::renderIconLinks($buttons, 'contents_id', $object->getVar('contents_id')) . '</td>' . '  </tr>';
             }
         } else {

Please login to merge, or discard this patch.

		@@ -106,16 +106,16 @@
		block discarded – undo
106	106	$ychck = (isset($options[0]) && ($options[0] > 0)) ? ' checked' : '';
107	107	$nchck = !empty($ychck) ? '' : ' checked';
108	108	$form = '<div class="line140">'
109		- . _MB_XOOPSFAQ_SHOW_EMPTY
110		- . ' <label for="r0">'
111		- . _NO
112		- . '</label><input type="radio" name="options[0]" id="r0" value="0"'
113		- . $nchck
114		- . '> <label for="r1">'
115		- . _YES
116		- . '</label><input type="radio" name="options[0]" id="r1" value="1"'
117		- . $ychck
118		- . '></div>'
119		- . "\n";
	109	+ . _MB_XOOPSFAQ_SHOW_EMPTY
	110	+ . ' <label for="r0">'
	111	+ . _NO
	112	+ . '</label><input type="radio" name="options[0]" id="r0" value="0"'
	113	+ . $nchck
	114	+ . '> <label for="r1">'
	115	+ . _YES
	116	+ . '</label><input type="radio" name="options[0]" id="r1" value="1"'
	117	+ . $ychck
	118	+ . '></div>'
	119	+ . "\n";
120	120	return $form;
121	121	}

		@@ -103,23 +103,23 @@
		block discarded – undo
103	103	$buttons = ['edit', 'delete'];
104	104
105	105	$ret = '<table class="outer width100 bnone pad3 marg5">'
106		- . ' <thead>'
107		- . ' <tr class="xoopsCenter">'
108		- . ' <th class="width5">'
109		- . _AM_XOOPSFAQ_CATEGORY_ORDER
110		- . '</th>'
111		- . ' <th class="width5">'
112		- . _AM_XOOPSFAQ_CATEGORY_ID
113		- . '</th>'
114		- . ' <th class="txtleft">'
115		- . _AM_XOOPSFAQ_CATEGORY_TITLE
116		- . '</th>'
117		- . ' <th class="width20">'
118		- . _AM_XOOPSFAQ_ACTIONS
119		- . '</th>'
120		- . ' </tr>'
121		- . ' </thead>'
122		- . ' <tbody>';
	106	+ . ' <thead>'
	107	+ . ' <tr class="xoopsCenter">'
	108	+ . ' <th class="width5">'
	109	+ . _AM_XOOPSFAQ_CATEGORY_ORDER
	110	+ . '</th>'
	111	+ . ' <th class="width5">'
	112	+ . _AM_XOOPSFAQ_CATEGORY_ID
	113	+ . '</th>'
	114	+ . ' <th class="txtleft">'
	115	+ . _AM_XOOPSFAQ_CATEGORY_TITLE
	116	+ . '</th>'
	117	+ . ' <th class="width20">'
	118	+ . _AM_XOOPSFAQ_ACTIONS
	119	+ . '</th>'
	120	+ . ' </tr>'
	121	+ . ' </thead>'
	122	+ . ' <tbody>';
123	123	if ($objects['count'] > 0) {
124	124	/** @var XoopsObject $object */
125	125	foreach ($objects['list'] as $object) {

		@@ -159,32 +159,32 @@ discard block
		block discarded – undo
159	159	$buttons = ['edit', 'delete'];
160	160
161	161	$ret = '<table class="outer width100 bnone pad3 marg5">'
162		- . ' <thead>'
163		- . ' <tr class="center">'
164		- . ' <th class="width5">'
165		- . _AM_XOOPSFAQ_CONTENTS_ID
166		- . '</th>'
167		- . ' <th class="width5">'
168		- . _AM_XOOPSFAQ_CONTENTS_ACTIVE
169		- . '</th>'
170		- . ' <th class="width5">'
171		- . _AM_XOOPSFAQ_CONTENTS_WEIGHT
172		- . '</th>'
173		- . ' <th class="left">'
174		- . _AM_XOOPSFAQ_CONTENTS_TITLE
175		- . '</th>'
176		- . ' <th class="left">'
177		- . _AM_XOOPSFAQ_CATEGORY_TITLE
178		- . '</th>'
179		- . ' <th>'
180		- . _AM_XOOPSFAQ_CONTENTS_PUBLISH
181		- . '</th>'
182		- . ' <th class="width20">'
183		- . _AM_XOOPSFAQ_ACTIONS
184		- . '</th>'
185		- . ' </tr>'
186		- . ' </thead>'
187		- . ' <tbody>';
	162	+ . ' <thead>'
	163	+ . ' <tr class="center">'
	164	+ . ' <th class="width5">'
	165	+ . _AM_XOOPSFAQ_CONTENTS_ID
	166	+ . '</th>'
	167	+ . ' <th class="width5">'
	168	+ . _AM_XOOPSFAQ_CONTENTS_ACTIVE
	169	+ . '</th>'
	170	+ . ' <th class="width5">'
	171	+ . _AM_XOOPSFAQ_CONTENTS_WEIGHT
	172	+ . '</th>'
	173	+ . ' <th class="left">'
	174	+ . _AM_XOOPSFAQ_CONTENTS_TITLE
	175	+ . '</th>'
	176	+ . ' <th class="left">'
	177	+ . _AM_XOOPSFAQ_CATEGORY_TITLE
	178	+ . '</th>'
	179	+ . ' <th>'
	180	+ . _AM_XOOPSFAQ_CONTENTS_PUBLISH
	181	+ . '</th>'
	182	+ . ' <th class="width20">'
	183	+ . _AM_XOOPSFAQ_ACTIONS
	184	+ . '</th>'
	185	+ . ' </tr>'
	186	+ . ' </thead>'
	187	+ . ' <tbody>';
188	188	if ($objects['count'] > 0) {
189	189	$tdClass = 0;
190	190	/** @var \Contents $object */
		@@ -195,39 +195,39 @@ discard block
		block discarded – undo
195	195	++$tdClass;
196	196	$dispClass = ($tdClass % 1) ? 'even' : 'odd';
197	197	$ret .= ' <tr class="center middle">'
198		- . ' <td class="'
199		- . $dispClass
200		- . '">'
201		- . $object->getVar('contents_id')
202		- . '</td>'
203		- . ' <td class="'
204		- . $dispClass
205		- . '">'
206		- . $object->getActiveIcon()
207		- . '</td>'
208		- . ' <td class="'
209		- . $dispClass
210		- . '">'
211		- . $object->getVar('contents_weight')
212		- . '</td>'
213		- . ' <td class="'
214		- . $dispClass
215		- . ' left">'
216		- . $thisContentTitle
217		- . '</td>'
218		- . ' <td class="'
219		- . $dispClass
220		- . ' left">'
221		- . $thisCatTitle
222		- . '</td>'
223		- . ' <td class="'
224		- . $dispClass
225		- . '">'
226		- . $object->getPublished(_SHORTDATESTRING)
227		- . '</td>'
228		- . ' <td class="'
229		- . $dispClass
230		- . '">';
	198	+ . ' <td class="'
	199	+ . $dispClass
	200	+ . '">'
	201	+ . $object->getVar('contents_id')
	202	+ . '</td>'
	203	+ . ' <td class="'
	204	+ . $dispClass
	205	+ . '">'
	206	+ . $object->getActiveIcon()
	207	+ . '</td>'
	208	+ . ' <td class="'
	209	+ . $dispClass
	210	+ . '">'
	211	+ . $object->getVar('contents_weight')
	212	+ . '</td>'
	213	+ . ' <td class="'
	214	+ . $dispClass
	215	+ . ' left">'
	216	+ . $thisContentTitle
	217	+ . '</td>'
	218	+ . ' <td class="'
	219	+ . $dispClass
	220	+ . ' left">'
	221	+ . $thisCatTitle
	222	+ . '</td>'
	223	+ . ' <td class="'
	224	+ . $dispClass
	225	+ . '">'
	226	+ . $object->getPublished(_SHORTDATESTRING)
	227	+ . '</td>'
	228	+ . ' <td class="'
	229	+ . $dispClass
	230	+ . '">';
231	231	$ret .= Xoopsfaq\Utility::renderIconLinks($buttons, 'contents_id', $object->getVar('contents_id')) . '</td>' . ' </tr>';
232	232	}
233	233	} else {

XoopsModules25x / xoopsfaq

Branch — master (18a203)

Status

Category

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

Indentation +59 added lines, -59 removed lines patch added patch discarded remove patch