XoopsModules25x / xoopsfaq

class/category.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
      *
      * @param string sort order ('id', order', or 'title') - default: id
      *
-     * @return mixed XoopsfaqCategory | false on failure
+     * @return boolean XoopsfaqCategory | false on failure
      */
     public function getObj($sort = 'id')
     {

class/contents.php

Spacing +4 added lines, -4 removed lines

@@ -95,14 +95,14 @@ 
 
         include_once $GLOBALS['xoops']->path('/class/xoopsformloader.php');
 
-        $caption = ($this->isNew()) ? _AM_XOOPSFAQ_CREATE_NEW: sprintf(_AM_XOOPSFAQ_MODIFY_ITEM, $this->getVar('contents_title'));
+        $caption = ($this->isNew()) ? _AM_XOOPSFAQ_CREATE_NEW : sprintf(_AM_XOOPSFAQ_MODIFY_ITEM, $this->getVar('contents_title'));
         $form = new XoopsThemeForm($caption, 'content', $_SERVER['REQUEST_URI'], 'post', true);
 //        $form->addElement(new XoopsFormHiddenToken());
         $form->addElement(new xoopsFormHidden('op', 'save'));
         $form->addElement(new xoopsFormHidden('contents_id', $this->getVar('contents_id', 'e')));
 
         // Active
-        $contents_active = new XoopsFormRadioYN(_AM_XOOPSFAQ_E_CONTENTS_ACTIVE, 'contents_active', $this->getVar('contents_active', 'e'),   ' ' . _YES . '', ' ' . _NO . '' );
+        $contents_active = new XoopsFormRadioYN(_AM_XOOPSFAQ_E_CONTENTS_ACTIVE, 'contents_active', $this->getVar('contents_active', 'e'), ' ' . _YES . '', ' ' . _NO . '');
         $contents_active->setDescription(_AM_XOOPSFAQ_E_CONTENTS_ACTIVE_DESC);
         $form->addElement($contents_active, false);
 
@@ -127,7 +127,7 @@ 
         $form->addElement($contents_weight, false);
 
         // Editor
-        $options_tray  = new XoopsFormElementTray(_AM_XOOPSFAQ_E_CONTENTS_CONTENT, '<br>');
+        $options_tray = new XoopsFormElementTray(_AM_XOOPSFAQ_E_CONTENTS_CONTENT, '<br>');
         if (class_exists('XoopsFormEditor')) {
 //            $editorConfigs = array('editor' => $GLOBALS['xoopsConfig']['general_editor'],
             $editorConfigs = array('editor' => $xfHelper->getConfig('use_wysiwyg', 'dhtmltextarea'),
@@ -254,7 +254,7 @@ 
             $criteria->setStart(0);
             $criteria->setLimit(0);
         } else {
-            $obj['list']  = $this->getObjects($sort, false);
+            $obj['list'] = $this->getObjects($sort, false);
         }
         $obj['list'] = $this->getObjects($criteria, false);
         $obj['count'] = (false !== $obj['list']) ? count($obj['list']) : 0;

Doc Comments +2 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
      *
      * @param CriteriaElement|string sort order ('id', 'cid', 'title', 'publish', or 'weight') default: 'id'
      *
-     * @return mixed XoopsfaqContents object | false on failure
+     * @return boolean XoopsfaqContents object | false on failure
      */
     public function getObj($sort = 'id')
     {
@@ -265,7 +265,7 @@ 
      * XoopsfaqContentsHandler::getPublished()
      *
      * @param string $id
-     * @return mixed array of XoopsfaqContent objects | false on failure
+     * @return boolean array of XoopsfaqContent objects | false on failure
      */
     public function getPublished($id = '')
     {

class/utility.php

Spacing +9 added lines, -9 removed lines

@@ -182,7 +182,7 @@ 
                 self::rrmdir($fObj->getPathname());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -221,7 +221,7 @@ 
                 self::rmove($fObj->getPathname(), $dest . '/' . $fObj->getFilename());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -255,11 +255,11 @@ 
 
         // Open the source directory to read in files
         $iterator = new DirectoryIterator($src);
-        foreach($iterator as $fObj) {
-            if($fObj->isFile()) {
+        foreach ($iterator as $fObj) {
+            if ($fObj->isFile()) {
                 copy($fObj->getPathname(), $dest . '/' . $fObj->getFilename());
-            } else if(!$fObj->isDot() && $fObj->isDir()) {
-                self::rcopy($fObj->getPathname(), $dest . '/' . $fObj-getFilename());
+            } else if (!$fObj->isDot() && $fObj->isDir()) {
+                self::rcopy($fObj->getPathname(), $dest . '/' . $fObj - getFilename());
             }
         }
         return true;
@@ -281,19 +281,19 @@ 
         xoops_loadLanguage('admin', $moduleDirName);
         $ret = '';
         if (null !== $value) {
-            foreach($icon_array as $_op => $icon) {
+            foreach ($icon_array as $_op => $icon) {
                 if (false === strpos($icon, '.')) {
                     $iconName = $icon;
                     $iconExt = 'png';
                 } else {
-                    $iconName = substr($icon, 0, strlen($icon)-strrchr($icon, '.'));
+                    $iconName = substr($icon, 0, strlen($icon) - strrchr($icon, '.'));
                     $iconExt  = substr(strrchr($icon, '.'), 1);
                 }
                 $url = (!is_numeric($_op)) ? $_op . '?' . $param . '=' . $value : xoops_getenv('PHP_SELF') . '?op=' . $iconName . '&' . $param . '=' . $value;
                 if (null !== $extra) {
                     $url .= ' ' . $extra;
                 }
-                $title = constant (htmlspecialchars(mb_strtoupper('_XO_LA_' . $iconName)));
+                $title = constant(htmlspecialchars(mb_strtoupper('_XO_LA_' . $iconName)));
                 $img = '<img src="' . Xmf\Module\Admin::iconUrl($iconName . '.' . $iconExt, '16') . '"'
                      . ' title ="' . $title . '"'
                      . ' alt = "' . $title . '"'

Doc Comments +2 added lines, -2 removed lines

@@ -268,8 +268,8 @@
     /**
      * Render the icon links
      *
-     * @param array $icon_array contains operation=>icon_name as key=>value
-     * @param mixed $param      HTML parameter
+     * @param string[] $icon_array contains operation=>icon_name as key=>value
+     * @param string $param      HTML parameter
      * @param mixed $value      HTML parameter value to set
      * @param mixed $extra      are any additional HTML attributes desired for the <a> tag
      * @return string

blocks/xoopsfaq_rand.php

Spacing +3 added lines, -3 removed lines

@@ -74,12 +74,12 @@ 
         $xpFaqObj = $xpFaqObjArray[$faqNum];
         $faq      = $myts->displayTarea($xpFaqObj->getVar('contents_title'));
         $txtAns   = strip_tags($xpFaqObj->getVar('contents_contents')); // get rid of html for block
-        $faqAns   = $myts->displayTarea(xoops_substr($txtAns, 0, $options[0]), 0, 0 ,0 ,0 ,0);
+        $faqAns   = $myts->displayTarea(xoops_substr($txtAns, 0, $options[0]), 0, 0, 0, 0, 0);
 
         $xfCatHandler = $xfHelper->getHandler('category');
         $catObj       = $xfCatHandler->get($xpFaqObj->getVar('contents_cid'));
         $cid          = $catObj->getVar('category_id');
-        $block = array( 'title' => _MB_XOOPSFAQ_RANDOM_TITLE,
+        $block = array('title' => _MB_XOOPSFAQ_RANDOM_TITLE,
                           'faq' => $faq,
                        'faqans' => $faqAns,
                      'morelink' => $xfHelper->url('index.php?cat_id=' . $cid . '#q' . $xpFaqObj->getVar('contents_id')),
@@ -114,7 +114,7 @@ 
     $formSelect->addOptionArray($optionArray);
     $selOptions = (false === strpos($options[1], ',')) ? $options[1] : explode(',', $options[1]);
     $formSelect->setValue($selOptions);
-    $selectCat   = $formSelect->render();
+    $selectCat = $formSelect->render();
 
     $form = '<div class="line140">'
           . _MB_XOOPSFAQ_CHARS . '&nbsp;'

blocks/xoopsfaq_recent.php

Spacing +2 added lines, -2 removed lines

@@ -81,7 +81,7 @@ 
             $faqTitle = $myts->displayTarea($faqObj->getVar('contents_title'));
             if (!empty($options[1])) {
                 $txtAns   = strip_tags($faqObj->getVar('contents_contents')); // get rid of html for block
-                $faqAns   = $myts->displayTarea(xoops_substr($txtAns, 0, $options[1]), 0, 0 ,0 ,0 ,0);
+                $faqAns   = $myts->displayTarea(xoops_substr($txtAns, 0, $options[1]), 0, 0, 0, 0, 0);
             } else {
                 $faqAns   = $myts->displayTarea($faqObj->getVar('contents_contents'),
                             (int)$faqObj->getVar('dohtml'),
@@ -125,7 +125,7 @@ 
     $formSelect->addOptionArray($optionArray);
     $selOptions = (false === strpos($options[3], ',')) ? $options[3] : explode(',', $options[3]);
     $formSelect->setValue($selOptions);
-    $selectCat   = $formSelect->render();
+    $selectCat = $formSelect->render();
 
     $ychck = (isset($options[2]) && ($options[2] > 0)) ? ' checked' : '';
     $nchck = !empty($ychck) ? '' : ' checked';

include/onupdate.inc.php

Spacing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
         $oldFiles = array($xfHelper->path('include/functions.php'),
                             $xsHelper->path('class/utilities.php')
         );
-        foreach($oldFiles as $file) {
+        foreach ($oldFiles as $file) {
             if (is_file($file)) {
                 if (false === ($delOk = unlink($file))) {
                     $module->setErrors(sprintf(_AM_XOOPSFAQ_ERROR_BAD_REMOVE, $file));

include/search.inc.php

Spacing +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
         return $ret;
     }
 
-    $moduleDirName = basename(dirname(__DIR__)) ;
+    $moduleDirName = basename(dirname(__DIR__));
     xoops_load('constants', $moduleDirName);
 
     $xfHelper = Xmf\Module\Helper::getHelper($moduleDirName);
@@ -69,7 +69,7 @@ 
     $catCount   = !empty($catArray) ? count($catArray) : 0;
     $totalLimit = (int)$limit - $catCount;
     foreach ($catArray as $cId => $cat) {
-        $ret[] = array ('image' => 'assets/images/folder.png',
+        $ret[] = array('image' => 'assets/images/folder.png',
                          'link' => $xfHelper->url('index.php?cat_id=' . $cId),
                         'title' => $cat['category_title'],
         );
@@ -99,7 +99,7 @@ 
     }
     $contentArray = $xfFaqHandler->getAll($criteria, $contentFields, false);
     foreach ($contentArray as $content) {
-        $ret[] = array ('image' => 'assets/images/question2.gif',
+        $ret[] = array('image' => 'assets/images/question2.gif',
                          'link' => $xfHelper->url('index.php?cat_id=' . $content['contents_cid'] . '#q' . $content['contents_id']),
                         'title' => $content['contents_title'],
                          'time' => $content['contents_publish'],

include/rss.inc.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     $retVal = array();
 
     foreach ($contentObjs as $contentObj) {
-        $retVal[] = array ('image' => '',
+        $retVal[] = array('image' => '',
                            'title' => $contentObj->getVar('contents_title'),
                             'link' => $contentObj->getVar('contents_contents'),
                             'time' => $contentObj->getVar('contents_publish'),

admin/category.php

Spacing +3 added lines, -3 removed lines

@@ -80,8 +80,8 @@ 
         break;
 
     case 'save':
-        if ( ($GLOBALS['xoopsSecurity'] instanceof XoopsSecurity) ) {
-            if ( !$GLOBALS['xoopsSecurity']->check() ) {
+        if (($GLOBALS['xoopsSecurity'] instanceof XoopsSecurity)) {
+            if (!$GLOBALS['xoopsSecurity']->check()) {
                 // failed xoops security check
                 $xfHelper->redirect('admin/index.php', 3, $GLOBALS['xoopsSecurity']->getErrors(true));
             }
@@ -109,7 +109,7 @@ 
     case 'default':
     default:
         $adminObject->displayNavigation('category.php');
-        $adminObject->addItemButton(_XO_XOOPSFAQ_ADDCAT, 'category.php?op=edit', 'add' , '');
+        $adminObject->addItemButton(_XO_XOOPSFAQ_ADDCAT, 'category.php?op=edit', 'add', '');
         $adminObject->displayButton('left');
         $xfCatHandler->displayAdminListing('order');
         break;