XoopsModules25x / xoopsfaq

blocks/xoopsfaq_rand.php

Spacing +3 added lines, -3 removed lines

@@ -74,12 +74,12 @@ 
         $xpFaqObj = $xpFaqObjArray[$faqNum];
         $faq      = $myts->displayTarea($xpFaqObj->getVar('contents_title'));
         $txtAns   = strip_tags($xpFaqObj->getVar('contents_contents')); // get rid of html for block
-        $faqAns   = $myts->displayTarea(xoops_substr($txtAns, 0, $options[0]), 0, 0 ,0 ,0 ,0);
+        $faqAns   = $myts->displayTarea(xoops_substr($txtAns, 0, $options[0]), 0, 0, 0, 0, 0);
 
         $xfCatHandler = $xfHelper->getHandler('category');
         $catObj       = $xfCatHandler->get($xpFaqObj->getVar('contents_cid'));
         $cid          = $catObj->getVar('category_id');
-        $block = array( 'title' => _MB_XOOPSFAQ_RANDOM_TITLE,
+        $block = array('title' => _MB_XOOPSFAQ_RANDOM_TITLE,
                           'faq' => $faq,
                        'faqans' => $faqAns,
                      'morelink' => $xfHelper->url('index.php?cat_id=' . $cid . '#q' . $xpFaqObj->getVar('contents_id')),
@@ -114,7 +114,7 @@ 
     $formSelect->addOptionArray($optionArray);
     $selOptions = (false === strpos($options[1], ',')) ? $options[1] : explode(',', $options[1]);
     $formSelect->setValue($selOptions);
-    $selectCat   = $formSelect->render();
+    $selectCat = $formSelect->render();
 
     $form = '<div class="line140">'
           . _MB_XOOPSFAQ_CHARS . '&nbsp;'

admin/category.php

Spacing +3 added lines, -3 removed lines

@@ -80,8 +80,8 @@ 
         break;
 
     case 'save':
-        if ( ($GLOBALS['xoopsSecurity'] instanceof XoopsSecurity) ) {
-            if ( !$GLOBALS['xoopsSecurity']->check() ) {
+        if (($GLOBALS['xoopsSecurity'] instanceof XoopsSecurity)) {
+            if (!$GLOBALS['xoopsSecurity']->check()) {
                 // failed xoops security check
                 $xfHelper->redirect('admin/index.php', 3, $GLOBALS['xoopsSecurity']->getErrors(true));
             }
@@ -109,7 +109,7 @@ 
     case 'default':
     default:
         $adminObject->displayNavigation('category.php');
-        $adminObject->addItemButton(_XO_XOOPSFAQ_ADDCAT, 'category.php?op=edit', 'add' , '');
+        $adminObject->addItemButton(_XO_XOOPSFAQ_ADDCAT, 'category.php?op=edit', 'add', '');
         $adminObject->displayButton('left');
         $xfCatHandler->displayAdminListing('order');
         break;

admin/main.php

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
         $catCount = $xfCatHandler->getCount();
         $adminObject->displayNavigation(basename(__FILE__));
         if (!empty($catCount)) {
-            $adminObject->addItemButton(_AM_XOOPSFAQ_CREATE_NEW, basename(__FILE__) . '?op=edit', 'add' , '');
+            $adminObject->addItemButton(_AM_XOOPSFAQ_CREATE_NEW, basename(__FILE__) . '?op=edit', 'add', '');
             $adminObject->displayButton('left');
         }
         $xfFaqHandler->displayAdminListing('weight');

xoops_version.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
 // Module SQL Tables
 $modversion['tables']              = array('xoopsfaq_contents',
                                          'xoopsfaq_categories'
-) ;
+);
 
 // Scripts to run upon installation or update
 $modversion['onInstall']           = "include/oninstall.inc.php";
@@ -136,7 +136,7 @@ 
 $editor_handler = XoopsEditorHandler::getInstance();
 $editorList     = array_flip($editor_handler->getList());
 
-$modversion['config']              = array(array('name' => 'use_wysiwyg',
+$modversion['config'] = array(array('name' => 'use_wysiwyg',
                                                 'title' => '_MI_XOOPSFAQ_EDITORS',
                                           'description' => '_MI_XOOPSFAQ_EDITORS_DESC',
                                              'formtype' => 'select',

class/contents.php

Doc Comments +2 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
      *
      * @param CriteriaElement|string sort order ('id', 'cid', 'title', 'publish', or 'weight') default: 'id'
      *
-     * @return mixed XoopsfaqContents object | false on failure
+     * @return boolean XoopsfaqContents object | false on failure
      */
     public function getObj($sort = 'id')
     {
@@ -265,7 +265,7 @@ 
      * XoopsfaqContentsHandler::getPublished()
      *
      * @param string $id
-     * @return mixed array of XoopsfaqContent objects | false on failure
+     * @return boolean array of XoopsfaqContent objects | false on failure
      */
     public function getPublished($id = '')
     {

Spacing +3 added lines, -3 removed lines

@@ -102,7 +102,7 @@ 
         $form->addElement(new xoopsFormHidden('contents_id', $this->getVar('contents_id', 'e')));
 
         // Active
-        $contents_active = new XoopsFormRadioYN(_AM_XOOPSFAQ_E_CONTENTS_ACTIVE, 'contents_active', $this->getVar('contents_active', 'e'),   ' ' . _YES . '', ' ' . _NO . '' );
+        $contents_active = new XoopsFormRadioYN(_AM_XOOPSFAQ_E_CONTENTS_ACTIVE, 'contents_active', $this->getVar('contents_active', 'e'), ' ' . _YES . '', ' ' . _NO . '');
         $contents_active->setDescription(_AM_XOOPSFAQ_E_CONTENTS_ACTIVE_DESC);
         $form->addElement($contents_active, false);
 
@@ -127,7 +127,7 @@ 
         $form->addElement($contents_weight, false);
 
         // Editor
-        $options_tray  = new XoopsFormElementTray(_AM_XOOPSFAQ_E_CONTENTS_CONTENT, '<br>');
+        $options_tray = new XoopsFormElementTray(_AM_XOOPSFAQ_E_CONTENTS_CONTENT, '<br>');
         if (class_exists('XoopsFormEditor')) {
             // $editorConfigs = array('editor' => $GLOBALS['xoopsConfig']['general_editor'],
             $editorConfigs = array('editor' => $xfHelper->getConfig('use_wysiwyg', 'dhtmltextarea'),
@@ -299,7 +299,7 @@ 
         $ret = array();
         $sql  = 'SELECT contents_cid ';
         $sql .= 'FROM `' . $this->table . '` ';
-        $sql .= 'WHERE (contents_active =\''. XoopsfaqConstants::ACTIVE . '\') ';
+        $sql .= 'WHERE (contents_active =\'' . XoopsfaqConstants::ACTIVE . '\') ';
         $sql .= 'GROUP BY contents_cid';
         if (!$result = $this->db->query($sql)) {
             return $ret;

class/utility.php

Doc Comments +2 added lines, -2 removed lines

@@ -268,8 +268,8 @@
     /**
      * Render the icon links
      *
-     * @param array $icon_array contains operation=>icon_name as key=>value
-     * @param mixed $param      HTML parameter
+     * @param string[] $icon_array contains operation=>icon_name as key=>value
+     * @param string $param      HTML parameter
      * @param mixed $value      HTML parameter value to set
      * @param mixed $extra      are any additional HTML attributes desired for the <a> tag
      * @return string

Spacing +11 added lines, -11 removed lines

@@ -42,8 +42,8 @@ 
     {
         $currentVersion = strtolower(str_replace('XOOPS ', '', XOOPS_VERSION));
         $requiredVersion = strtolower($module->getInfo('min_xoops'));
-        $vc = version_compare ($currentVersion , $requiredVersion);
-        $success = ($vc>=0);
+        $vc = version_compare($currentVersion, $requiredVersion);
+        $success = ($vc >= 0);
         if (false === $success) {
             xoops_loadLanguage('admin', $module->dirname());
             $module->setErrors(sprintf(_AM_XOOPSFAQ_ERROR_BAD_XOOPS, $requiredVersion, $currentVersion));
@@ -159,7 +159,7 @@ 
                 static::rrmdir($fObj->getPathname());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -198,7 +198,7 @@ 
                 static::rmove($fObj->getPathname(), $dest . '/' . $fObj->getFilename());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -232,11 +232,11 @@ 
 
         // Open the source directory to read in files
         $iterator = new DirectoryIterator($src);
-        foreach($iterator as $fObj) {
-            if($fObj->isFile()) {
+        foreach ($iterator as $fObj) {
+            if ($fObj->isFile()) {
                 copy($fObj->getPathname(), $dest . '/' . $fObj->getFilename());
-            } else if(!$fObj->isDot() && $fObj->isDir()) {
-                static::rcopy($fObj->getPathname(), $dest . '/' . $fObj-getFilename());
+            } else if (!$fObj->isDot() && $fObj->isDir()) {
+                static::rcopy($fObj->getPathname(), $dest . '/' . $fObj - getFilename());
             }
         }
         return true;
@@ -257,19 +257,19 @@ 
         xoops_loadLanguage('admin', $moduleDirName);
         $ret = '';
         if (null !== $value) {
-            foreach($icon_array as $_op => $icon) {
+            foreach ($icon_array as $_op => $icon) {
                 if (false === strpos($icon, '.')) {
                     $iconName = $icon;
                     $iconExt = 'png';
                 } else {
-                    $iconName = substr($icon, 0, strlen($icon)-strrchr($icon, '.'));
+                    $iconName = substr($icon, 0, strlen($icon) - strrchr($icon, '.'));
                     $iconExt  = substr(strrchr($icon, '.'), 1);
                 }
                 $url = (!is_numeric($_op)) ? $_op . '?' . $param . '=' . $value : xoops_getenv('PHP_SELF') . '?op=' . $iconName . '&' . $param . '=' . $value;
                 if (null !== $extra) {
                     $url .= ' ' . $extra;
                 }
-                $title = constant (htmlspecialchars(mb_strtoupper('_XO_LA_' . $iconName)));
+                $title = constant(htmlspecialchars(mb_strtoupper('_XO_LA_' . $iconName)));
                 $img = '<img src="' . Xmf\Module\Admin::iconUrl($iconName . '.' . $iconExt, '16') . '"'
                      . ' title ="' . $title . '"'
                      . ' alt = "' . $title . '"'

class/category.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
      *
      * @param string $sort order ('id', order', or 'title') - default: id
      *
-     * @return mixed XoopsfaqCategory | false on failure
+     * @return boolean XoopsfaqCategory | false on failure
      */
     public function getObj($sort = 'id')
     {

include/onupdate.inc.php

Spacing +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
         $oldFiles = array($xfHelper->path('include/functions.php'),
                             $xfHelper->path('class/utilities.php')
         );
-        foreach($oldFiles as $file) {
+        foreach ($oldFiles as $file) {
             if (is_file($file)) {
                 if (false === ($delOk = unlink($file))) {
                     $module->setErrors(sprintf(_AM_XOOPSFAQ_ERROR_BAD_REMOVE, $file));

include/sitemap.plugin.php

Spacing +3 added lines, -3 removed lines

@@ -27,13 +27,13 @@
     /** @var Xmf\Module\Helper\GenericHelper $xfHelper */
     $myts = MyTextSanitizer::getInstance();
 
-    $moduleDirName = basename(dirname(__DIR__)) ;
+    $moduleDirName = basename(dirname(__DIR__));
     $xfHelper      = Xmf\Module\Helper::getHelper($moduleDirName);
     $xfCatHandler  = $xfHelper->getHandler('category');
     $catList       = $xfCatHandler->getList();
 
-    $retVal = array() ;
-    foreach ($catList as $id=>$title){
+    $retVal = array();
+    foreach ($catList as $id=>$title) {
         $retVal['parent'][] = array('id' => $id,
                                  'title' => $myts->htmlSpecialChars($title),
                                    'url' => $xfHelper->url('index.php?cat_id=' . $id)