Issues (381)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

include/mailinglist.php (1 issue)

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * ****************************************************************************
4
 *  - A Project by Developers TEAM For Xoops - ( https://xoops.org )
5
 * ****************************************************************************
6
 *  XNEWSLETTER - MODULE FOR XOOPS
7
 *  Copyright (c) 2007 - 2012
8
 *  Goffy ( wedega.com )
9
 *
10
 *  You may not change or alter any portion of this comment or credits
11
 *  of supporting developers from this source code or any supporting
12
 *  source code which is considered copyrighted (c) material of the
13
 *  original comment or credit authors.
14
 *
15
 *  This program is distributed in the hope that it will be useful,
16
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
17
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
18
 *  GNU General Public License for more details.
19
 *  ---------------------------------------------------------------------------
20
 * @copyright  Goffy ( wedega.com )
21
 * @license    GNU General Public License 2.0
22
 * @package    xnewsletter
23
 * @author     Goffy ( [email protected] )
24
 *
25
 *  Version : 1 Thu 2012/12/06 12:57:01 :  Exp $
26
 * ****************************************************************************
27
 */
28
29
use XoopsModules\Xnewsletter;
30
31
// defined("XOOPS_ROOT_PATH") || die("XOOPS root path not defined");
32
require_once __DIR__ . '/common.php';
33
34
/**
35
 * @param int $type
36
 * @param int $subscr_id
37
 * @param $mailinglist_id
38
 *
39
 * @return bool|null
40
 */
41
function subscribingMLHandler($type, $subscr_id, $mailinglist_id)
42
{
43
    global $xoopsUser, $xoopsConfig;
44
    $helper = XoopsModules\Xnewsletter\Helper::getInstance();
45
46
    // get subscriber
47
    $subscrObj    = $helper->getHandler('Subscr')->get($subscr_id);
48
    $subscr_email = $subscrObj->getVar('subscr_email');
49
50
    // get mailinglist
51
    $mailinglistObj          = $helper->getHandler('Mailinglist')->get($mailinglist_id);
52
    $mailinglist_listname    = $mailinglistObj->getVar('mailinglist_listname');
53
    $mailinglist_email       = $mailinglistObj->getVar('mailinglist_email');
54
    $mailinglist_subscribe   = $mailinglistObj->getVar('mailinglist_subscribe');
55
    $mailinglist_unsubscribe = $mailinglistObj->getVar('mailinglist_unsubscribe');
56
    $mailinglist_system      = (int)$mailinglistObj->getVar('mailinglist_system');
57
    $mailinglist_target      = $mailinglistObj->getVar('mailinglist_target');
58
    $mailinglist_pwd         = $mailinglistObj->getVar('mailinglist_pwd');
59
    $mailinglist_notifyowner = $mailinglistObj->getVar('mailinglist_notifyowner');
60
61
    $senderUid = (is_object($xoopsUser) && isset($xoopsUser)) ? $xoopsUser->uid() : 0;
62
63
    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_DEFAULT_VAL) {
64
        // this should not happen
65
        $protocolObj = $helper->getHandler('Protocol')->create();
66
        $protocolObj->setVar('protocol_letter_id', 0);
67
        $protocolObj->setVar('protocol_subscriber_id', $subscr_id);
68
        $protocolObj->setVar('protocol_status', 'Error adding mailing list: invalid mailing list type');
69
        $protocolObj->setVar('protocol_success', false);
70
        $protocolObj->setVar('protocol_submitter', $senderUid);
71
        $protocolObj->setVar('protocol_created', time());
72
73
        if ($helper->getHandler('Protocol')->insert($protocolObj)) {
74
            return true;
75
        }
76
        return $protocolObj->getHtmlErrors();
77
    }
78
    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL) {
79
80
        if (_XNEWSLETTER_MAILINGLIST_SUBSCRIBE == $type) {
81
            $action_code = $mailinglist_subscribe;
82
        } else {
83
            $action_code = $mailinglist_unsubscribe;
84
        }
85
        $action_code = str_replace('{email}', $subscr_email, $action_code);
86
        $action_code = str_replace('{nameofmylist}', $mailinglist_listname, $action_code);
87
88
        require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.phpmailer.php';
89
        require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.pop3.php';
90
        require_once XOOPS_ROOT_PATH . '/class/mail/phpmailer/class.smtp.php';
91
92
        try {
93
            $xoopsMailer = xoops_getMailer();
94
            $xoopsMailer->reset();
95
            //$xoopsMailer->setTemplateDir();
96
            $xoopsMailer->useMail();
97
            $xoopsMailer->setHTML(false);
98
            //$xoopsMailer->setTemplate('activate.tpl');
99
            $xoopsMailer->setToEmails($mailinglist_email);
100
            if (isset($xoopsConfig['adminmail'])) {
101
                $xoopsMailer->setFromEmail($xoopsConfig['adminmail']);
102
            }
103
            if (isset($xoopsConfig['sitename'])) {
104
                $xoopsMailer->setFromName($xoopsConfig['sitename']);
105
            }
106
            //$xoopsMailer->setSubject($subject);
107
            $xoopsMailer->setBody($action_code);
108
            $xoopsMailer->send();
109
110
            $protocol_status = str_replace('%a', $action_code, _AM_XNEWSLETTER_SEND_SUCCESS_ML_DETAIL);
111
            $xoopsMailer->reset();
112
            $protocol_success = true;
113
        } catch (\Exception $e) {
114
            $protocol_status = _AM_XNEWSLETTER_SEND_ERROR_PHPMAILER . $xoopsMailer->getErrors(); //error messages
115
            $protocol_success = false;
116
            $helper->addLog($e);
117
        }
118
119
        //create item in protocol for this email
120
        $text_clean = ['<strong>', '</strong>', '<br/>', '<br>'];
121
        $protocol_status = str_replace($text_clean, '', $protocol_status);
122
123
        $protocolObj = $helper->getHandler('Protocol')->create();
124
        $protocolObj->setVar('protocol_letter_id', 0);
125
        $protocolObj->setVar('protocol_subscriber_id', $subscr_id);
126
        $protocolObj->setVar('protocol_status', $protocol_status);
127
        $protocolObj->setVar('protocol_success', $protocol_success);
128
        $protocolObj->setVar('protocol_submitter', $senderUid);
129
        $protocolObj->setVar('protocol_created', time());
130
131
        if ($helper->getHandler('Protocol')->insert($protocolObj)) {
132
            return true;
133
        }
134
        return $protocolObj->getHtmlErrors();
135
    }
136
137
    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL) {
138
139
        $action_code = $mailinglist_target;
140
        if (substr($action_code, -1) !== '/') {
141
            $action_code .= '/';
142
        }
143
        $action_code .= 'mailman/admin/';
144
        $action_code .= $mailinglist_listname;
145
        $action_code .= '/members/';
146
147
        if (_XNEWSLETTER_MAILINGLIST_SUBSCRIBE == $type) {
148
            $action_code .= 'add?subscribe_or_invite=0&send_welcome_msg_to_this_batch=0&notification_to_list_owner=' . $mailinglist_notifyowner;
149
            $action_code .= '&subscribees_upload=';
150
        } else {
151
            $action_code .= 'remove?send_unsub_ack_to_this_batch=0&send_unsub_notifications_to_list_owner=' . $mailinglist_notifyowner;
152
            $action_code .= '&unsubscribees_upload=';
153
        }
154
        $action_code .= $subscr_email;
155
        $action_code .= '&adminpw=' .  $mailinglist_pwd;
156
        //echo "action_code:".$action_code;
157
158
        try {
159
            $req = curl_init();
160
            curl_setopt($req, CURLOPT_URL, $action_code);
161
            curl_setopt($req, CURLOPT_RETURNTRANSFER, true);
162
163
            $res_curl = curl_exec($req);
0 ignored issues
show
$res_curl is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
164
165
            if(!curl_errno($req)){
166
                $status = (int)curl_getinfo($req, CURLINFO_HTTP_CODE);
167
                if ($status === 200) {
168
                    $protocol_status = str_replace('%a', $subscr_email, _AM_XNEWSLETTER_SEND_SUCCESS_ML_DETAIL);
169
                    $protocol_status = str_replace('%m', $mailinglist_listname, $protocol_status);
170
                    $protocol_success = true;
171
                } else {
172
                    $protocol_success = false;
173
                    $protocol_status = 'Curl error: ' . curl_error($req);
174
                }
175
            } else {
176
                $protocol_success = false;
177
                $protocol_status = 'Curl error: ' . curl_error($req);
178
            }
179
        } catch (\Exception $e) {
180
            $protocol_status = _AM_XNEWSLETTER_SEND_ERROR_PHPMAILER; //error messages
181
            $protocol_success = false;
182
            $helper->addLog($e);
183
        }
184
        curl_close($req);
185
        //create item in protocol for this email
186
        $text_clean = ['<strong>', '</strong>', '<br/>', '<br>'];
187
        $protocol_status = str_replace($text_clean, '', $protocol_status);
188
189
        $protocolObj = $helper->getHandler('Protocol')->create();
190
        $protocolObj->setVar('protocol_letter_id', 0);
191
        $protocolObj->setVar('protocol_subscriber_id', $subscr_id);
192
        $protocolObj->setVar('protocol_status', $protocol_status);
193
        $protocolObj->setVar('protocol_success', $protocol_success);
194
        $protocolObj->setVar('protocol_submitter', $senderUid);
195
        $protocolObj->setVar('protocol_created', time());
196
197
        if ($helper->getHandler('Protocol')->insert($protocolObj)) {
198
            return true;
199
        }
200
        return $protocolObj->getHtmlErrors();
201
    }
202
    return null;
203
}
204
205
/**
206
 * @param int $mailinglist_id
207
 * @return string|null
208
 */
209
function getActioncode ($mailinglist_id = 0) {
210
    $helper = XoopsModules\Xnewsletter\Helper::getInstance();
211
212
    // get mailinglist
213
    $mailinglistObj          = $helper->getHandler('Mailinglist')->get($mailinglist_id);
214
    $mailinglist_listname    = $mailinglistObj->getVar('mailinglist_listname');
215
    $mailinglist_system      = (int)$mailinglistObj->getVar('mailinglist_system');
216
    $mailinglist_target      = $mailinglistObj->getVar('mailinglist_target');
217
    $mailinglist_pwd         = $mailinglistObj->getVar('mailinglist_pwd');
218
219
    if ($mailinglist_system === _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL) {
220
221
        $action_code = $mailinglist_target;
222
        if (substr($action_code, -1) !== '/') {
223
            $action_code .= '/';
224
        }
225
        $action_code .= 'mailman/admin/';
226
        $action_code .= $mailinglist_listname;
227
        $action_code .= '/members/list?adminpw=' .  $mailinglist_pwd;
228
229
        return $action_code;
230
    }
231
    return null;
232
}
233