Issues in Letter.php (master) - Issues in master - XoopsModules25x/xnewsletter - Measure and Improve Code Quality continuously with Scrutinizer

Issues (381)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Letter.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace XoopsModules\Xnewsletter;

/**
 * ****************************************************************************
 *  - A Project by Developers TEAM For Xoops - ( https://xoops.org )
 * ****************************************************************************
 *  XNEWSLETTER - MODULE FOR XOOPS
 *  Copyright (c) 2007 - 2012
 *  Goffy ( wedega.com )
 *
 *  You may not change or alter any portion of this comment or credits
 *  of supporting developers from this source code or any supporting
 *  source code which is considered copyrighted (c) material of the
 *  original comment or credit authors.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *  ---------------------------------------------------------------------------
 * @copyright  Goffy ( wedega.com )
 * @license    GPL 2.0
 * @package    xnewsletter
 * @author     Goffy ( [email protected] )
 *
 * ****************************************************************************
 */

//use XoopsModules\Xnewsletter;

require_once dirname(__DIR__) . '/include/common.php';

/**
 * Class Letter
 */
class Letter extends \XoopsObject
{
    public $helper = null;
    public $db;

    //Constructor

    public function __construct()
    {
        $this->helper = Helper::getInstance();
        $this->db     = \XoopsDatabaseFactory::getDatabaseConnection();
        $this->initVar('letter_id',        XOBJ_DTYPE_INT,    null, false);
        $this->initVar('letter_title',     XOBJ_DTYPE_TXTBOX, null, true, 100);
        $this->initVar('letter_content',   XOBJ_DTYPE_TXTAREA,null, true);
        $this->initVar('letter_templateid',XOBJ_DTYPE_INT,    null, false);
        $this->initVar('letter_cats',      XOBJ_DTYPE_TXTBOX, null, false, 100); // IN PROGRESS: AN ARRAY SHOULD BE BETTER
        $this->initVar('letter_attachment',XOBJ_DTYPE_TXTBOX, null, false, 200);
        $this->initVar('letter_account',   XOBJ_DTYPE_INT,    null, false);
        $this->initVar('letter_email_test',XOBJ_DTYPE_TXTBOX, null, false, 100);
        $this->initVar('letter_submitter', XOBJ_DTYPE_INT,    null, false);
        $this->initVar('letter_created',   XOBJ_DTYPE_INT,     time(), false); // timestamp
        $this->initVar('letter_sender',    XOBJ_DTYPE_INT,    null, false);
        $this->initVar('letter_sent',      XOBJ_DTYPE_INT,    false, false); // timestamp or false
    }

    /**
     * @param bool $action
     * @param bool $admin_aerea
     *
     * @return null|\XoopsThemeForm
     */
    public function getForm($action = false, $admin_aerea = false)
    {
        global $xoopsDB, $xoopsUser, $pathImageIcon;

        if (false === $action) {
            $action = $_SERVER['REQUEST_URI'];
        }

        $title = $this->isNew() ? sprintf(_AM_XNEWSLETTER_LETTER_ADD) : sprintf(_AM_XNEWSLETTER_LETTER_EDIT);

        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
        $form = new \XoopsThemeForm($title, 'form', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');

        // letter_title
        $form->addElement(new \XoopsFormText(_AM_XNEWSLETTER_LETTER_TITLE, 'letter_title', 50, 255, $this->getVar('letter_title', 'e')), true);

        // letter_content
        $editor_configs           = [];
        $editor_configs['name']   = 'letter_content';
        $editor_configs['value']  = $this->getVar('letter_content', 'e');
        $editor_configs['rows']   = 40;
        $editor_configs['cols']   = 80;
        $editor_configs['width']  = '100%';
        $editor_configs['height'] = '800px';
        $editor_configs['editor'] = $this->helper->getConfig('xnewsletter_editor');
        $letter_content_editor    = new \XoopsFormEditor(_AM_XNEWSLETTER_LETTER_CONTENT, 'letter_content', $editor_configs);
        $letter_content_editor->setDescription(_AM_XNEWSLETTER_LETTER_CONTENT_DESC);
        $form->addElement($letter_content_editor, true);

        // letter_template
        $letterTemplateid = $this->isNew() ? 1 : $this->getVar('letter_templateid');
        $template_select = new \XoopsFormSelect(_AM_XNEWSLETTER_LETTER_TEMPLATE, 'letter_templateid', $letterTemplateid);
        // get template objects from database
        $templateCriteria = new \CriteriaCompo();
        $templateCriteria->add(new \Criteria('template_online', 1));
        $templateCriteria->setSort('template_title ASC, template_id');
        $templateCriteria->setOrder('DESC');
        $templateCount = $this->helper->getHandler('Template')->getCount($templateCriteria);
        if ($templateCount > 0) {
            $template_select->addOptionArray($this->helper->getHandler('Template')->getList($templateCriteria));
        } else {
            redirect_header('letter.php?op=list', 3, _MA_XNEWSLETTER_NOTEMPLATE_ONLINE);
        }
        $form->addElement($template_select, false);

        // letter_cats
        /** @var \XoopsGroupPermHandler $grouppermHandler */
        $grouppermHandler = xoops_getHandler('groupperm');
        /** @var \XoopsMemberHandler $memberHandler */
        $memberHandler    = xoops_getHandler('member');
        $groups           = $memberHandler->getGroupsByUser($xoopsUser->uid());
        $catCriteria      = new \CriteriaCompo();
        $catCriteria->setSort('cat_id');
        $catCriteria->setOrder('ASC');
        $letter_cats = explode('|', $this->getVar('letter_cats'));
        $cat_select  = new \XoopsFormCheckBox(_AM_XNEWSLETTER_LETTER_CATS, 'letter_cats', $letter_cats);
        $catObjs     = $this->helper->getHandler('Cat')->getAll($catCriteria);
        foreach ($catObjs as $cat_id => $catObj) {
            $cat_name = $catObj->getVar('cat_name');
            $show     = $grouppermHandler->checkRight('newsletter_create_cat', $cat_id, $groups, $this->helper->getModule()->mid());
            if (1 == $show) {
                $cat_select->addOption($cat_id, $cat_name);
            }
        }
        $form->addElement($cat_select, true);

        // attachments
        $attachment_tray = new \XoopsFormElementTray(_AM_XNEWSLETTER_LETTER_ATTACHMENT, '<br>');
        $attachment_tray->addElement(new \XoopsFormHidden('deleted_attachment_id', ''));
        // existing_attachments
        if ($this->isNew()) {
            $attachmentObjs = [];
        } else {
            $attachmentCriteria = new \CriteriaCompo();
            $attachmentCriteria->add(new \Criteria('attachment_letter_id', $this->getVar('letter_id')));
            $attachmentCriteria->setSort('attachment_id');
            $attachmentCriteria->setOrder('ASC');
            $attachmentObjs = $this->helper->getHandler('Attachment')->getAll($attachmentCriteria);
        }
        $i                      = 1;
        $remove_attachment_tray = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        foreach ($attachmentObjs as $attachment_id => $attachmentObj) {
            $delete_attachment_tray = new \XoopsFormElementTray('', '&nbsp;&nbsp;');
            $mode_select            = new \XoopsFormRadio(_AM_XNEWSLETTER_ATTACHMENT_MODE, "existing_attachments_mode[{$attachment_id}]", $attachmentObj->getVar('attachment_mode'), '&nbsp;');
            $mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASATTACHMENT, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASATTACHMENT);
            $mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASLINK, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASLINK);
            //$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_AUTO, _AM_XNEWSLETTER_ATTACHMENT_MODE_AUTO); // for future features
            $delete_attachment_tray->addElement($mode_select);
            $delete_attachment_tray->addElement(new \XoopsFormLabel('', $attachmentObj->getVar('attachment_name')));
            $delete_button = new \XoopsFormButton('', "delete_attachment_{$i}", _DELETE, 'submit');
            $delete_button->setExtra("onclick='this.form.elements.op.value=\"delete_attachment\";this.form.elements.deleted_attachment_id.value=\"{$attachment_id}\";'");
            $delete_attachment_tray->addElement($delete_button);
            $attachment_tray->addElement($delete_attachment_tray);
            ++$i;
            unset($mode_select);
            unset($delete_attachment_tray);
        }
        // new_attachments
        for ($j = $i; $j < ($this->helper->getConfig('xn_maxattachments') + 1); ++$j) {
            $add_attachment_tray = new \XoopsFormElementTray('', '&nbsp;&nbsp;');
            $mode_select         = new \XoopsFormRadio(_AM_XNEWSLETTER_ATTACHMENT_MODE, "new_attachments_mode[{$j}]", _XNEWSLETTER_ATTACHMENTS_MODE_ASATTACHMENT, '&nbsp;');
            $mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASATTACHMENT, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASATTACHMENT);
            $mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASLINK, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASLINK);
            //$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_AUTO, _AM_XNEWSLETTER_ATTACHMENT_MODE_AUTO); // for future features
            $add_attachment_tray->addElement($mode_select);
            $add_attachment_tray->addElement(new \XoopsFormFile('', "new_attachment_index={$j}", $this->helper->getConfig('xn_maxsize')));
            $attachment_tray->addElement($add_attachment_tray);
            unset($mode_select);
            unset($add_attachment_tray);
        }
        $form->addElement($attachment_tray);

        // letter_action
        $opt_nextaction = new \XoopsFormRadio('', 'letter_action', _AM_XNEWSLETTER_LETTER_ACTION_NO, '<br>');
        $opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_NO, _AM_XNEWSLETTER_LETTER_ACTION_NO);
        $opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_PREVIEW, _AM_XNEWSLETTER_LETTER_ACTION_PREVIEW);
        $opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_SEND, _AM_XNEWSLETTER_LETTER_ACTION_SEND);
        $opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_SENDTEST, _AM_XNEWSLETTER_LETTER_ACTION_SENDTEST);
        $opt_tray = new \XoopsFormElementTray(_AM_XNEWSLETTER_LETTER_ACTION, '<br>');
        $opt_tray->addElement($opt_nextaction);

        // letter_email_test
        $letter_email_test = $this->isNew() ? $xoopsUser->email() : $this->getVar('letter_email_test');
        if ('' == $letter_email_test) {
            $letter_email_test = $xoopsUser->email();
        }
        $opt_tray->addElement(new \XoopsFormText(_AM_XNEWSLETTER_LETTER_EMAIL_TEST . ':&nbsp;', 'letter_email_test', 50, 255, $letter_email_test), false);
        $form->addElement($opt_tray);

        // letter_account
        $accountsCriteria = new \CriteriaCompo();
        $accountsCriteria->setSort('accounts_id');
        $accountsCriteria->setOrder('ASC');
        $accountsCount   = $this->helper->getHandler('Accounts')->getCount($accountsCriteria);
        $account_default = 0;
        if ($this->isNew()) {
            $accountsObjs = $this->helper->getHandler('Accounts')->getAll($accountsCriteria);
            foreach ($accountsObjs as $accountsObj) {
                if (1 == $accountsObj->getVar('accounts_default')) {
                    $account_default = $accountsObj->getVar('accounts_id');
                }
            }
        } else {
            $account_default = $this->getVar('letter_account');
        }
        if (1 == $accountsCount) {
            $form->addElement(new \XoopsFormHidden('letter_account', $account_default));
        } else {
            $accounts_list = $this->helper->getHandler('Accounts')->getList($accountsCriteria);

            if (true === $admin_aerea) {
                $opt_accounts = new \XoopsFormRadio(_AM_XNEWSLETTER_LETTER_ACCOUNTS_AVAIL, 'letter_account', $account_default);
                $opt_accounts->addOptionArray($accounts_list);
                $form->addElement($opt_accounts, false);
            } else {
                $form->addElement(new \XoopsFormLabel(_AM_XNEWSLETTER_LETTER_ACCOUNTS_AVAIL, $accounts_list[$account_default]));
                $form->addElement(new \XoopsFormHidden('letter_account', $account_default));
            }
        }

        if ($this->isNew()) {
            $time           = time();
            $submitter_uid  = $GLOBALS['xoopsUser']->uid();
            $submitter_name = $GLOBALS['xoopsUser']->uname();
        } else {
            $time          = $this->getVar('letter_created');
            $submitter_uid = $this->getVar('letter_submitter');
            xoops_load('xoopsuserutility');
            $submitter_name = \XoopsUserUtility::getUnameFromId($submitter_uid);
        }

        $form->addElement(new \XoopsFormHidden('letter_submitter', $submitter_uid));
        $form->addElement(new \XoopsFormHidden('letter_created', $time));

        $form->addElement(new \XoopsFormLabel(_AM_XNEWSLETTER_SUBMITTER, $submitter_name));
        $form->addElement(new \XoopsFormLabel(_AM_XNEWSLETTER_CREATED, formatTimestamp($time, 's')));

        $form->addElement(new \XoopsFormHidden('op', 'save_letter'));
        $form->addElement(new \XoopsFormButtonTray('', _SUBMIT, 'submit', '', false));

        return $form;
    }

    /**
     * Get Values
     * @param null $keys
     * @param string|null $format
     * @param int|null $maxDepth
     * @return array
     */
    public function getValuesLetter($keys = null, $format = null, $maxDepth = null)
    {
        $ret = $this->getValues($keys, $format, $maxDepth);
        $ret['id']             = $this->getVar('letter_id');
        $ret['title']          = $this->getVar('letter_title');
        $ret['content']        = $this->getVar('letter_content');
        $ret['templateid']     = $this->getVar('letter_templateid');
        $templateObj           = $this->helper->getHandler('Template')->get($this->getVar('letter_templateid'));
        if (is_object($templateObj)) {
            $ret['template_title'] = $templateObj->getVar('template_title');
        }
        $ret['cats']           = $this->getVar('letter_cats');
        $ret['attachment']     = $this->getVar('letter_attachment');
        $ret['account']        = $this->getVar('letter_account');
        $ret['email_test']     = $this->getVar('letter_email_test');
        $ret['sender']         = $this->getVar('letter_sender') > 0 ? \XoopsUser::getUnameFromId($this->getVar('letter_sender')) : '-';
        $ret['sent']           = $this->getVar('letter_sent') > 1 ? formatTimestamp($this->getVar('letter_sent'), 's') : '-';
        $ret['created']        = formatTimestamp($this->getVar('letter_created'), 's');
        $ret['submitter']      = \XoopsUser::getUnameFromId($this->getVar('letter_submitter'));
        return $ret;
    }

}


1			<?php
2
3			namespace XoopsModules\Xnewsletter;
4
5			/**
6			* ****************************************************************************
7			* - A Project by Developers TEAM For Xoops - ( https://xoops.org )
8			* ****************************************************************************
9			* XNEWSLETTER - MODULE FOR XOOPS
10			* Copyright (c) 2007 - 2012
11			* Goffy ( wedega.com )
12			*
13			* You may not change or alter any portion of this comment or credits
14			* of supporting developers from this source code or any supporting
15			* source code which is considered copyrighted (c) material of the
16			* original comment or credit authors.
17			*
18			* This program is distributed in the hope that it will be useful,
19			* but WITHOUT ANY WARRANTY; without even the implied warranty of
20			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21			* GNU General Public License for more details.
22			* ---------------------------------------------------------------------------
23			* @copyright Goffy ( wedega.com )
24			* @license GPL 2.0
25			* @package xnewsletter
26			* @author Goffy ( [email protected] )
27			*
28			* ****************************************************************************
29			*/
30
31			//use XoopsModules\Xnewsletter;
32
33			require_once dirname(__DIR__) . '/include/common.php';
34
35			/**
36			* Class Letter
37			*/
38			class Letter extends \XoopsObject
39			{
40			public $helper = null;
41			public $db;
42
43			//Constructor
44
45			public function __construct()
46			{
47			$this->helper = Helper::getInstance();
48			$this->db = \XoopsDatabaseFactory::getDatabaseConnection();
49			$this->initVar('letter_id', XOBJ_DTYPE_INT, null, false);
50			$this->initVar('letter_title', XOBJ_DTYPE_TXTBOX, null, true, 100);
51			$this->initVar('letter_content', XOBJ_DTYPE_TXTAREA,null, true);
52			$this->initVar('letter_templateid',XOBJ_DTYPE_INT, null, false);
53			$this->initVar('letter_cats', XOBJ_DTYPE_TXTBOX, null, false, 100); // IN PROGRESS: AN ARRAY SHOULD BE BETTER
54			$this->initVar('letter_attachment',XOBJ_DTYPE_TXTBOX, null, false, 200);
55			$this->initVar('letter_account', XOBJ_DTYPE_INT, null, false);
56			$this->initVar('letter_email_test',XOBJ_DTYPE_TXTBOX, null, false, 100);
57			$this->initVar('letter_submitter', XOBJ_DTYPE_INT, null, false);
58			$this->initVar('letter_created', XOBJ_DTYPE_INT, time(), false); // timestamp
59			$this->initVar('letter_sender', XOBJ_DTYPE_INT, null, false);
60			$this->initVar('letter_sent', XOBJ_DTYPE_INT, false, false); // timestamp or false
61			}
62
63			/**
64			* @param bool $action
65			* @param bool $admin_aerea
66			*
67			* @return null\|\XoopsThemeForm
68			*/
69			public function getForm($action = false, $admin_aerea = false)
70			{
71			global $xoopsDB, $xoopsUser, $pathImageIcon;
72
73			if (false === $action) {
74			$action = $_SERVER['REQUEST_URI'];
75			}
76
77			$title = $this->isNew() ? sprintf(_AM_XNEWSLETTER_LETTER_ADD) : sprintf(_AM_XNEWSLETTER_LETTER_EDIT);
78
79			require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
80			$form = new \XoopsThemeForm($title, 'form', $action, 'post', true);
81			$form->setExtra('enctype="multipart/form-data"');
82
83			// letter_title
84			$form->addElement(new \XoopsFormText(_AM_XNEWSLETTER_LETTER_TITLE, 'letter_title', 50, 255, $this->getVar('letter_title', 'e')), true);
85
86			// letter_content
87			$editor_configs = [];
88			$editor_configs['name'] = 'letter_content';
89			$editor_configs['value'] = $this->getVar('letter_content', 'e');
90			$editor_configs['rows'] = 40;
91			$editor_configs['cols'] = 80;
92			$editor_configs['width'] = '100%';
93			$editor_configs['height'] = '800px';
94			$editor_configs['editor'] = $this->helper->getConfig('xnewsletter_editor');
95			$letter_content_editor = new \XoopsFormEditor(_AM_XNEWSLETTER_LETTER_CONTENT, 'letter_content', $editor_configs);
96			$letter_content_editor->setDescription(_AM_XNEWSLETTER_LETTER_CONTENT_DESC);
97			$form->addElement($letter_content_editor, true);
98
99			// letter_template
100			$letterTemplateid = $this->isNew() ? 1 : $this->getVar('letter_templateid');
101			$template_select = new \XoopsFormSelect(_AM_XNEWSLETTER_LETTER_TEMPLATE, 'letter_templateid', $letterTemplateid);
102			// get template objects from database
103			$templateCriteria = new \CriteriaCompo();
104			$templateCriteria->add(new \Criteria('template_online', 1));
105			$templateCriteria->setSort('template_title ASC, template_id');
106			$templateCriteria->setOrder('DESC');
107			$templateCount = $this->helper->getHandler('Template')->getCount($templateCriteria);
108			if ($templateCount > 0) {
109			$template_select->addOptionArray($this->helper->getHandler('Template')->getList($templateCriteria));
110			} else {
111			redirect_header('letter.php?op=list', 3, _MA_XNEWSLETTER_NOTEMPLATE_ONLINE);
112			}
113			$form->addElement($template_select, false);
114
115			// letter_cats
116			/** @var \XoopsGroupPermHandler $grouppermHandler */
117			$grouppermHandler = xoops_getHandler('groupperm');
118			/** @var \XoopsMemberHandler $memberHandler */
119			$memberHandler = xoops_getHandler('member');
120			$groups = $memberHandler->getGroupsByUser($xoopsUser->uid());
121			$catCriteria = new \CriteriaCompo();
122			$catCriteria->setSort('cat_id');
123			$catCriteria->setOrder('ASC');
124			$letter_cats = explode('\|', $this->getVar('letter_cats'));
125			$cat_select = new \XoopsFormCheckBox(_AM_XNEWSLETTER_LETTER_CATS, 'letter_cats', $letter_cats);
126			$catObjs = $this->helper->getHandler('Cat')->getAll($catCriteria);
127			foreach ($catObjs as $cat_id => $catObj) {
128			$cat_name = $catObj->getVar('cat_name');
129			$show = $grouppermHandler->checkRight('newsletter_create_cat', $cat_id, $groups, $this->helper->getModule()->mid());
130			if (1 == $show) {
131			$cat_select->addOption($cat_id, $cat_name);
132			}
133			}
134			$form->addElement($cat_select, true);
135
136			// attachments
137			$attachment_tray = new \XoopsFormElementTray(_AM_XNEWSLETTER_LETTER_ATTACHMENT, '<br>');
138			$attachment_tray->addElement(new \XoopsFormHidden('deleted_attachment_id', ''));
139			// existing_attachments
140			if ($this->isNew()) {
141			$attachmentObjs = [];
142			} else {
143			$attachmentCriteria = new \CriteriaCompo();
144			$attachmentCriteria->add(new \Criteria('attachment_letter_id', $this->getVar('letter_id')));
145			$attachmentCriteria->setSort('attachment_id');
146			$attachmentCriteria->setOrder('ASC');
147			$attachmentObjs = $this->helper->getHandler('Attachment')->getAll($attachmentCriteria);
148			}
149			$i = 1;
150			$remove_attachment_tray = [];
			0 ignored issues – show Unused Code introduced 2019-10-05 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$remove_attachment_tray` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
151			foreach ($attachmentObjs as $attachment_id => $attachmentObj) {
152			$delete_attachment_tray = new \XoopsFormElementTray('', '  ');
153			$mode_select = new \XoopsFormRadio(_AM_XNEWSLETTER_ATTACHMENT_MODE, "existing_attachments_mode[{$attachment_id}]", $attachmentObj->getVar('attachment_mode'), ' ');
154			$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASATTACHMENT, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASATTACHMENT);
155			$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASLINK, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASLINK);
156			//$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_AUTO, _AM_XNEWSLETTER_ATTACHMENT_MODE_AUTO); // for future features
157			$delete_attachment_tray->addElement($mode_select);
158			$delete_attachment_tray->addElement(new \XoopsFormLabel('', $attachmentObj->getVar('attachment_name')));
159			$delete_button = new \XoopsFormButton('', "delete_attachment_{$i}", _DELETE, 'submit');
160			$delete_button->setExtra("onclick='this.form.elements.op.value=\"delete_attachment\";this.form.elements.deleted_attachment_id.value=\"{$attachment_id}\";'");
161			$delete_attachment_tray->addElement($delete_button);
162			$attachment_tray->addElement($delete_attachment_tray);
163			++$i;
164			unset($mode_select);
165			unset($delete_attachment_tray);
166			}
167			// new_attachments
168			for ($j = $i; $j < ($this->helper->getConfig('xn_maxattachments') + 1); ++$j) {
169			$add_attachment_tray = new \XoopsFormElementTray('', '  ');
170			$mode_select = new \XoopsFormRadio(_AM_XNEWSLETTER_ATTACHMENT_MODE, "new_attachments_mode[{$j}]", _XNEWSLETTER_ATTACHMENTS_MODE_ASATTACHMENT, ' ');
171			$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASATTACHMENT, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASATTACHMENT);
172			$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_ASLINK, _AM_XNEWSLETTER_ATTACHMENT_MODE_ASLINK);
173			//$mode_select->addOption(_XNEWSLETTER_ATTACHMENTS_MODE_AUTO, _AM_XNEWSLETTER_ATTACHMENT_MODE_AUTO); // for future features
174			$add_attachment_tray->addElement($mode_select);
175			$add_attachment_tray->addElement(new \XoopsFormFile('', "new_attachment_index={$j}", $this->helper->getConfig('xn_maxsize')));
176			$attachment_tray->addElement($add_attachment_tray);
177			unset($mode_select);
178			unset($add_attachment_tray);
179			}
180			$form->addElement($attachment_tray);
181
182			// letter_action
183			$opt_nextaction = new \XoopsFormRadio('', 'letter_action', _AM_XNEWSLETTER_LETTER_ACTION_NO, '<br>');
184			$opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_NO, _AM_XNEWSLETTER_LETTER_ACTION_NO);
185			$opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_PREVIEW, _AM_XNEWSLETTER_LETTER_ACTION_PREVIEW);
186			$opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_SEND, _AM_XNEWSLETTER_LETTER_ACTION_SEND);
187			$opt_nextaction->addOption(_XNEWSLETTER_LETTER_ACTION_VAL_SENDTEST, _AM_XNEWSLETTER_LETTER_ACTION_SENDTEST);
188			$opt_tray = new \XoopsFormElementTray(_AM_XNEWSLETTER_LETTER_ACTION, '<br>');
189			$opt_tray->addElement($opt_nextaction);
190
191			// letter_email_test
192			$letter_email_test = $this->isNew() ? $xoopsUser->email() : $this->getVar('letter_email_test');
193			if ('' == $letter_email_test) {
194			$letter_email_test = $xoopsUser->email();
195			}
196			$opt_tray->addElement(new \XoopsFormText(_AM_XNEWSLETTER_LETTER_EMAIL_TEST . ': ', 'letter_email_test', 50, 255, $letter_email_test), false);
197			$form->addElement($opt_tray);
198
199			// letter_account
200			$accountsCriteria = new \CriteriaCompo();
201			$accountsCriteria->setSort('accounts_id');
202			$accountsCriteria->setOrder('ASC');
203			$accountsCount = $this->helper->getHandler('Accounts')->getCount($accountsCriteria);
204			$account_default = 0;
205			if ($this->isNew()) {
206			$accountsObjs = $this->helper->getHandler('Accounts')->getAll($accountsCriteria);
207			foreach ($accountsObjs as $accountsObj) {
208			if (1 == $accountsObj->getVar('accounts_default')) {
209			$account_default = $accountsObj->getVar('accounts_id');
210			}
211			}
212			} else {
213			$account_default = $this->getVar('letter_account');
214			}
215			if (1 == $accountsCount) {
216			$form->addElement(new \XoopsFormHidden('letter_account', $account_default));
217			} else {
218			$accounts_list = $this->helper->getHandler('Accounts')->getList($accountsCriteria);
219
220			if (true === $admin_aerea) {
221			$opt_accounts = new \XoopsFormRadio(_AM_XNEWSLETTER_LETTER_ACCOUNTS_AVAIL, 'letter_account', $account_default);
222			$opt_accounts->addOptionArray($accounts_list);
223			$form->addElement($opt_accounts, false);
224			} else {
225			$form->addElement(new \XoopsFormLabel(_AM_XNEWSLETTER_LETTER_ACCOUNTS_AVAIL, $accounts_list[$account_default]));
226			$form->addElement(new \XoopsFormHidden('letter_account', $account_default));
227			}
228			}
229
230			if ($this->isNew()) {
231			$time = time();
232			$submitter_uid = $GLOBALS['xoopsUser']->uid();
233			$submitter_name = $GLOBALS['xoopsUser']->uname();
234			} else {
235			$time = $this->getVar('letter_created');
236			$submitter_uid = $this->getVar('letter_submitter');
237			xoops_load('xoopsuserutility');
238			$submitter_name = \XoopsUserUtility::getUnameFromId($submitter_uid);
239			}
240
241			$form->addElement(new \XoopsFormHidden('letter_submitter', $submitter_uid));
242			$form->addElement(new \XoopsFormHidden('letter_created', $time));
243
244			$form->addElement(new \XoopsFormLabel(_AM_XNEWSLETTER_SUBMITTER, $submitter_name));
245			$form->addElement(new \XoopsFormLabel(_AM_XNEWSLETTER_CREATED, formatTimestamp($time, 's')));
246
247			$form->addElement(new \XoopsFormHidden('op', 'save_letter'));
248			$form->addElement(new \XoopsFormButtonTray('', _SUBMIT, 'submit', '', false));
249
250			return $form;
251			}
252
253			/**
254			* Get Values
255			* @param null $keys
256			* @param string\|null $format
257			* @param int\|null $maxDepth
258			* @return array
259			*/
260			public function getValuesLetter($keys = null, $format = null, $maxDepth = null)
261			{
262			$ret = $this->getValues($keys, $format, $maxDepth);
263			$ret['id'] = $this->getVar('letter_id');
264			$ret['title'] = $this->getVar('letter_title');
265			$ret['content'] = $this->getVar('letter_content');
266			$ret['templateid'] = $this->getVar('letter_templateid');
267			$templateObj = $this->helper->getHandler('Template')->get($this->getVar('letter_templateid'));
268			if (is_object($templateObj)) {
269			$ret['template_title'] = $templateObj->getVar('template_title');
270			}
271			$ret['cats'] = $this->getVar('letter_cats');
272			$ret['attachment'] = $this->getVar('letter_attachment');
273			$ret['account'] = $this->getVar('letter_account');
274			$ret['email_test'] = $this->getVar('letter_email_test');
275			$ret['sender'] = $this->getVar('letter_sender') > 0 ? \XoopsUser::getUnameFromId($this->getVar('letter_sender')) : '-';
276			$ret['sent'] = $this->getVar('letter_sent') > 1 ? formatTimestamp($this->getVar('letter_sent'), 's') : '-';
277			$ret['created'] = formatTimestamp($this->getVar('letter_created'), 's');
278			$ret['submitter'] = \XoopsUser::getUnameFromId($this->getVar('letter_submitter'));
279			return $ret;
280			}
281
282			}
283

XoopsModules25x / xnewsletter

Issues (381)

Security Analysis not enabled

class/Letter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like