Issues in mailinglist.php - New Issues - Inspection of "various fixes" - XoopsModules25x/xnewsletter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#29)

by Goffy

created 2020-01-16 20:27 UTC

admin/mailinglist.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ****************************************************************************
 *  - A Project by Developers TEAM For Xoops - ( https://xoops.org )
 * ****************************************************************************
 *  XNEWSLETTER - MODULE FOR XOOPS
 *  Copyright (c) 2007 - 2012
 *  Goffy ( wedega.com )
 *
 *  You may not change or alter any portion of this comment or credits
 *  of supporting developers from this source code or any supporting
 *  source code which is considered copyrighted (c) material of the
 *  original comment or credit authors.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *  ---------------------------------------------------------------------------
 * @copyright  Goffy ( wedega.com )
 * @license    GNU General Public License 2.0
 * @package    xnewsletter
 * @author     Goffy ( [email protected] )
 *
 * ****************************************************************************
 */

use Xmf\Request;

$currentFile = basename(__FILE__);
require_once __DIR__ . '/admin_header.php';
xoops_cp_header();

// set template
$templateMain = 'xnewsletter_admin_mailinglists.tpl';

require_once XOOPS_ROOT_PATH . '/modules/xnewsletter/include/mailinglist.php';

// We recovered the value of the argument op in the URL$
$op                 = Request::getString('op', 'list');
$mailinglistId      = Request::getInt('mailinglist_id', 0);
$mailinglist_system = Request::getInt('mailinglist_system', _XNEWSLETTER_MAILINGLIST_TYPE_DEFAULT_VAL);

$GLOBALS['xoopsTpl']->assign('val_mailman',           _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL);
$GLOBALS['xoopsTpl']->assign('val_majordomo',         _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL);
$GLOBALS['xoopsTpl']->assign('xnewsletter_url',       XNEWSLETTER_URL);
$GLOBALS['xoopsTpl']->assign('xnewsletter_icons_url', XNEWSLETTER_ICONS_URL);

switch ($op) {
    case 'list':
    default:
        $adminObject->displayNavigation($currentFile);
        $adminObject->addItemButton(_AM_XNEWSLETTER_NEWMAILINGLIST . ': '. _AM_XNEWSLETTER_MAILINGLIST_SYSTEM_MAILMAN, '?op=new_mailinglist&amp;mailinglist_system=' . _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL, 'add');
        $adminObject->addItemButton(_AM_XNEWSLETTER_NEWMAILINGLIST . ': ' . _AM_XNEWSLETTER_MAILINGLIST_SYSTEM_MAJORDOMO, '?op=new_mailinglist&amp;mailinglist_system=' . _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL, 'add');
        $GLOBALS['xoopsTpl']->assign('buttons', $adminObject->renderButton('left'));
        $limit               = $helper->getConfig('adminperpage');
        $mailinglistCriteria = new \CriteriaCompo();
        $mailinglistCriteria->setSort('mailinglist_id ASC, mailinglist_email');
        $mailinglistCriteria->setOrder('ASC');
        $mailinglistCount = $helper->getHandler('Mailinglist')->getCount();
        $start            = Request::getInt('start', 0);
        $mailinglistCriteria->setStart($start);
        $mailinglistCriteria->setLimit($limit);
        $mailinglistsAll = $helper->getHandler('Mailinglist')->getAll($mailinglistCriteria);
        if ($mailinglistCount > $limit) {
            require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
            $pagenav = new \XoopsPageNav($mailinglistCount, $limit, $start, 'start', 'op=list');
            $GLOBALS['xoopsTpl']->assign('pagenav', $pagenav->renderNav(4));
        }

        if ($mailinglistCount > 0) {
            $GLOBALS['xoopsTpl']->assign('mailinglistCount', $mailinglistCount);

            foreach ($mailinglistsAll as $ml_id => $mailinglistObj) {
                $mailinglist = $mailinglistObj->getValuesMailinglist();
                if (_XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL === (int)$mailinglistObj->getVar('mailinglist_system')) {
                    $mailinglist['check_list']=true;
                }
                $GLOBALS['xoopsTpl']->append('mailinglists_list', $mailinglist);
                unset($mailinglist);
            }
        } else {
            $GLOBALS['xoopsTpl']->assign('error', _AM_XNEWSLETTER_THEREARENT_MAILINGLIST);
        }
        break;
    case 'new_mailinglist':

        $adminObject->displayNavigation($currentFile);
        $adminObject->addItemButton(_AM_XNEWSLETTER_MAILINGLISTLIST, '?op=list', 'list');
        $GLOBALS['xoopsTpl']->assign('buttons', $adminObject->renderButton('left'));

        $mailinglistObj = $helper->getHandler('Mailinglist')->create();
        $mailinglistObj->setVar('mailinglist_system', 0);
        $form           = $mailinglistObj->getForm(false, $mailinglist_system);
        $GLOBALS['xoopsTpl']->assign('form', $form->render());
        break;
    case 'save_mailinglist':
        if (!$GLOBALS['xoopsSecurity']->check()) {
            redirect_header($currentFile, 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
        }
        if (Request::hasVar('mailinglist_id', 'REQUEST')) {
            $mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
        } else {
            $mailinglistObj = $helper->getHandler('Mailinglist')->create();
        }
        $mailinglistObj->setVar('mailinglist_system',      Request::getString('mailinglist_system'));
        $mailinglistObj->setVar('mailinglist_name',        Request::getString('mailinglist_name'));
        $mailinglistObj->setVar('mailinglist_email',       Request::getString('mailinglist_email'));
        $mailinglistObj->setVar('mailinglist_listname',    Request::getString('mailinglist_listname'));
        $mailinglistObj->setVar('mailinglist_subscribe',   Request::getString('mailinglist_subscribe'));
        $mailinglistObj->setVar('mailinglist_unsubscribe', Request::getString('mailinglist_unsubscribe'));
        $mailinglistObj->setVar('mailinglist_target',      Request::getString('mailinglist_target'));
        $mailinglistObj->setVar('mailinglist_pwd',         Request::getString('mailinglist_pwd'));
        $mailinglistObj->setVar('mailinglist_notifyowner', Request::getInt('mailinglist_notifyowner'));
        $mailinglistObj->setVar('mailinglist_submitter',   Request::getString('mailinglist_submitter'));
        $mailinglistObj->setVar('mailinglist_created',     Request::getInt('mailinglist_created'));

        if ($helper->getHandler('Mailinglist')->insert($mailinglistObj)) {
            redirect_header('?op=list', 3, _AM_XNEWSLETTER_FORMOK);
        }

        $GLOBALS['xoopsTpl']->assign('error', $mailinglistObj->getHtmlErrors());
        $form = $mailinglistObj->getForm();
        $GLOBALS['xoopsTpl']->assign('form', $form->render());
        break;
    case 'edit_mailinglist':
        $adminObject->displayNavigation($currentFile);
        $adminObject->addItemButton(_AM_XNEWSLETTER_NEWMAILINGLIST, '?op=new_mailinglist', 'add');
        $adminObject->addItemButton(_AM_XNEWSLETTER_MAILINGLISTLIST, '?op=list', 'list');
        $GLOBALS['xoopsTpl']->assign('buttons', $adminObject->renderButton('left'));

        $mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
        $form           = $mailinglistObj->getForm(false, (int)$mailinglistObj->getVar('mailinglist_system'));
        $GLOBALS['xoopsTpl']->assign('form', $form->render());
        break;
    case 'check_list':
        $mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
        if (_XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL === (int)$mailinglistObj->getVar('mailinglist_system')) {
            $actioncode = getActioncode($mailinglistObj->getVar('mailinglist_id'));
            $c = curl_init($actioncode);
            curl_setopt($c, CURLOPT_RETURNTRANSFER, true);
            $html = curl_exec($c);
            if (curl_error($c)) {
                $GLOBALS['xoopsTpl']->assign('error', curl_error($c));
            }
            $status = (int)curl_getinfo($c, CURLINFO_HTTP_CODE);
            curl_close($c);

            if ($status === 200) {
                $GLOBALS['xoopsTpl']->assign('success', _AM_XNEWSLETTER_MAILINGLIST_CSUCCESS);
            } else {
                $GLOBALS['xoopsTpl']->assign('error', _AM_XNEWSLETTER_MAILINGLIST_CFAILED . $status);
            }
            $mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
            $form           = $mailinglistObj->getForm(false, (int)$mailinglistObj->getVar('mailinglist_system'));
            $GLOBALS['xoopsTpl']->assign('form', $form->render());
        }

        break;
    case 'delete_mailinglist':
        $mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
        if (true === Request::getBool('ok', false, 'POST')) {
            if (!$GLOBALS['xoopsSecurity']->check()) {
                redirect_header($currentFile, 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
            }
            if ($helper->getHandler('Mailinglist')->delete($mailinglistObj)) {
                redirect_header($currentFile, 3, _AM_XNEWSLETTER_FORMDELOK);
            } else {
                $GLOBALS['xoopsTpl']->assign('error', $mailinglistObj->getHtmlErrors());
            }
        } else {
            xoops_confirm([
                              'ok'             => true,
                              'mailinglist_id' => $mailinglistId,
                              'op'             => 'delete_mailinglist',
                          ], $_SERVER['REQUEST_URI'], sprintf(_AM_XNEWSLETTER_FORMSUREDEL, $mailinglistObj->getVar('mailinglist_name')));
        }
        break;
}
require_once __DIR__ . '/admin_footer.php';


1		<?php
2		/**
3		* ****************************************************************************
4		* - A Project by Developers TEAM For Xoops - ( https://xoops.org )
5		* ****************************************************************************
6		* XNEWSLETTER - MODULE FOR XOOPS
7		* Copyright (c) 2007 - 2012
8		* Goffy ( wedega.com )
9		*
10		* You may not change or alter any portion of this comment or credits
11		* of supporting developers from this source code or any supporting
12		* source code which is considered copyrighted (c) material of the
13		* original comment or credit authors.
14		*
15		* This program is distributed in the hope that it will be useful,
16		* but WITHOUT ANY WARRANTY; without even the implied warranty of
17		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18		* GNU General Public License for more details.
19		* ---------------------------------------------------------------------------
20		* @copyright Goffy ( wedega.com )
21		* @license GNU General Public License 2.0
22		* @package xnewsletter
23		* @author Goffy ( [email protected] )
24		*
25		* ****************************************************************************
26		*/
27
28		use Xmf\Request;
29
30		$currentFile = basename(__FILE__);
31		require_once __DIR__ . '/admin_header.php';
32		xoops_cp_header();
33
34		// set template
35		$templateMain = 'xnewsletter_admin_mailinglists.tpl';
36
37		require_once XOOPS_ROOT_PATH . '/modules/xnewsletter/include/mailinglist.php';
38
39		// We recovered the value of the argument op in the URL$
40		$op = Request::getString('op', 'list');
41		$mailinglistId = Request::getInt('mailinglist_id', 0);
42		$mailinglist_system = Request::getInt('mailinglist_system', _XNEWSLETTER_MAILINGLIST_TYPE_DEFAULT_VAL);
43
44		$GLOBALS['xoopsTpl']->assign('val_mailman', _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL);
45		$GLOBALS['xoopsTpl']->assign('val_majordomo', _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL);
46		$GLOBALS['xoopsTpl']->assign('xnewsletter_url', XNEWSLETTER_URL);
47		$GLOBALS['xoopsTpl']->assign('xnewsletter_icons_url', XNEWSLETTER_ICONS_URL);
48
49		switch ($op) {
50		case 'list':
51		default:
52		$adminObject->displayNavigation($currentFile);
53		$adminObject->addItemButton(_AM_XNEWSLETTER_NEWMAILINGLIST . ': '. _AM_XNEWSLETTER_MAILINGLIST_SYSTEM_MAILMAN, '?op=new_mailinglist&mailinglist_system=' . _XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL, 'add');
54		$adminObject->addItemButton(_AM_XNEWSLETTER_NEWMAILINGLIST . ': ' . _AM_XNEWSLETTER_MAILINGLIST_SYSTEM_MAJORDOMO, '?op=new_mailinglist&mailinglist_system=' . _XNEWSLETTER_MAILINGLIST_TYPE_MAJORDOMO_VAL, 'add');
55		$GLOBALS['xoopsTpl']->assign('buttons', $adminObject->renderButton('left'));
56		$limit = $helper->getConfig('adminperpage');
57		$mailinglistCriteria = new \CriteriaCompo();
58		$mailinglistCriteria->setSort('mailinglist_id ASC, mailinglist_email');
59		$mailinglistCriteria->setOrder('ASC');
60		$mailinglistCount = $helper->getHandler('Mailinglist')->getCount();
61		$start = Request::getInt('start', 0);
62		$mailinglistCriteria->setStart($start);
63		$mailinglistCriteria->setLimit($limit);
64		$mailinglistsAll = $helper->getHandler('Mailinglist')->getAll($mailinglistCriteria);
65	View Code Duplication	if ($mailinglistCount > $limit) {
66		require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
67		$pagenav = new \XoopsPageNav($mailinglistCount, $limit, $start, 'start', 'op=list');
68		$GLOBALS['xoopsTpl']->assign('pagenav', $pagenav->renderNav(4));
69		}
70
71		if ($mailinglistCount > 0) {
72		$GLOBALS['xoopsTpl']->assign('mailinglistCount', $mailinglistCount);
73
74		foreach ($mailinglistsAll as $ml_id => $mailinglistObj) {
75		$mailinglist = $mailinglistObj->getValuesMailinglist();
76		if (_XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL === (int)$mailinglistObj->getVar('mailinglist_system')) {
77		$mailinglist['check_list']=true;
78		}
79		$GLOBALS['xoopsTpl']->append('mailinglists_list', $mailinglist);
80		unset($mailinglist);
81		}
82		} else {
83		$GLOBALS['xoopsTpl']->assign('error', _AM_XNEWSLETTER_THEREARENT_MAILINGLIST);
84		}
85		break;
86	View Code Duplication	case 'new_mailinglist':
		0 ignored issues – show Duplication introduced 2016-06-01 02:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		$adminObject->displayNavigation($currentFile);
88		$adminObject->addItemButton(_AM_XNEWSLETTER_MAILINGLISTLIST, '?op=list', 'list');
89		$GLOBALS['xoopsTpl']->assign('buttons', $adminObject->renderButton('left'));
90
91		$mailinglistObj = $helper->getHandler('Mailinglist')->create();
92		$mailinglistObj->setVar('mailinglist_system', 0);
93		$form = $mailinglistObj->getForm(false, $mailinglist_system);
94		$GLOBALS['xoopsTpl']->assign('form', $form->render());
95		break;
96		case 'save_mailinglist':
97		if (!$GLOBALS['xoopsSecurity']->check()) {
98		redirect_header($currentFile, 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
99		}
100		if (Request::hasVar('mailinglist_id', 'REQUEST')) {
101		$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
102		} else {
103		$mailinglistObj = $helper->getHandler('Mailinglist')->create();
104		}
105		$mailinglistObj->setVar('mailinglist_system', Request::getString('mailinglist_system'));
106		$mailinglistObj->setVar('mailinglist_name', Request::getString('mailinglist_name'));
107		$mailinglistObj->setVar('mailinglist_email', Request::getString('mailinglist_email'));
108		$mailinglistObj->setVar('mailinglist_listname', Request::getString('mailinglist_listname'));
109		$mailinglistObj->setVar('mailinglist_subscribe', Request::getString('mailinglist_subscribe'));
110		$mailinglistObj->setVar('mailinglist_unsubscribe', Request::getString('mailinglist_unsubscribe'));
111		$mailinglistObj->setVar('mailinglist_target', Request::getString('mailinglist_target'));
112		$mailinglistObj->setVar('mailinglist_pwd', Request::getString('mailinglist_pwd'));
113		$mailinglistObj->setVar('mailinglist_notifyowner', Request::getInt('mailinglist_notifyowner'));
114		$mailinglistObj->setVar('mailinglist_submitter', Request::getString('mailinglist_submitter'));
115		$mailinglistObj->setVar('mailinglist_created', Request::getInt('mailinglist_created'));
116
117		if ($helper->getHandler('Mailinglist')->insert($mailinglistObj)) {
118		redirect_header('?op=list', 3, _AM_XNEWSLETTER_FORMOK);
119		}
120
121		$GLOBALS['xoopsTpl']->assign('error', $mailinglistObj->getHtmlErrors());
122		$form = $mailinglistObj->getForm();
123		$GLOBALS['xoopsTpl']->assign('form', $form->render());
124		break;
125	View Code Duplication	case 'edit_mailinglist':
126		$adminObject->displayNavigation($currentFile);
127		$adminObject->addItemButton(_AM_XNEWSLETTER_NEWMAILINGLIST, '?op=new_mailinglist', 'add');
128		$adminObject->addItemButton(_AM_XNEWSLETTER_MAILINGLISTLIST, '?op=list', 'list');
129		$GLOBALS['xoopsTpl']->assign('buttons', $adminObject->renderButton('left'));
130
131		$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
132		$form = $mailinglistObj->getForm(false, (int)$mailinglistObj->getVar('mailinglist_system'));
133		$GLOBALS['xoopsTpl']->assign('form', $form->render());
134		break;
135		case 'check_list':
136		$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
137		if (_XNEWSLETTER_MAILINGLIST_TYPE_MAILMAN_VAL === (int)$mailinglistObj->getVar('mailinglist_system')) {
138		$actioncode = getActioncode($mailinglistObj->getVar('mailinglist_id'));
139		$c = curl_init($actioncode);
140		curl_setopt($c, CURLOPT_RETURNTRANSFER, true);
141		$html = curl_exec($c);
142		if (curl_error($c)) {
143		$GLOBALS['xoopsTpl']->assign('error', curl_error($c));
144		}
145		$status = (int)curl_getinfo($c, CURLINFO_HTTP_CODE);
146		curl_close($c);
147
148		if ($status === 200) {
149		$GLOBALS['xoopsTpl']->assign('success', _AM_XNEWSLETTER_MAILINGLIST_CSUCCESS);
150		} else {
151		$GLOBALS['xoopsTpl']->assign('error', _AM_XNEWSLETTER_MAILINGLIST_CFAILED . $status);
152		}
153		$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
154		$form = $mailinglistObj->getForm(false, (int)$mailinglistObj->getVar('mailinglist_system'));
155		$GLOBALS['xoopsTpl']->assign('form', $form->render());
156		}
157
158		break;
159	View Code Duplication	case 'delete_mailinglist':
160		$mailinglistObj = $helper->getHandler('Mailinglist')->get($mailinglistId);
161		if (true === Request::getBool('ok', false, 'POST')) {
162		if (!$GLOBALS['xoopsSecurity']->check()) {
163		redirect_header($currentFile, 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
164		}
165		if ($helper->getHandler('Mailinglist')->delete($mailinglistObj)) {
166		redirect_header($currentFile, 3, _AM_XNEWSLETTER_FORMDELOK);
167		} else {
168		$GLOBALS['xoopsTpl']->assign('error', $mailinglistObj->getHtmlErrors());
169		}
170		} else {
171		xoops_confirm([
172		'ok' => true,
173		'mailinglist_id' => $mailinglistId,
174		'op' => 'delete_mailinglist',
175		], $_SERVER['REQUEST_URI'], sprintf(_AM_XNEWSLETTER_FORMSUREDEL, $mailinglistObj->getVar('mailinglist_name')));
176		}
177		break;
178		}
179		require_once __DIR__ . '/admin_footer.php';
180

XoopsModules25x / xnewsletter

Pull Request — master (#29)

admin/mailinglist.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like